From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.4425.1675996327482735617 for ; Thu, 09 Feb 2023 18:32:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NUU7Bs3e; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675996327; x=1707532327; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LVz7Lzeemo4UkbLTolgj6Sp5Qs1CY6ZpfXkRw3SFG7Y=; b=NUU7Bs3eU4ZFnH9tQweeISede5Q1q7DmQew1Ypg3dkoskvXV7xZ4pkjH 7egY+NLVclLyHHQCF5PXgxCsexECSiyxpMKDM4fObsVxU8stqEPioxxpv vuQxSl9JV1/rFXdLZzNx+oB0knsirTMRMd6EWu0MEt97LSxyd2OkvL9hg /+WFlqBZVGovJyoIc+yscv67jP8fkIofQrr/91vZqjmYMzTvLPCaFAAkQ opRW7v9tjPejBa5sDRPTxGZQlZ50r7QTmhYiNlxEck6dQqYsH5y17t5M9 pIJaSjPFc714ZBSVTj5kLwcX4UObi49K0iZTltq+WdOGKKNFL5pLsiR3M Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="416543412" X-IronPort-AV: E=Sophos;i="5.97,285,1669104000"; d="scan'208";a="416543412" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2023 18:32:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="700304257" X-IronPort-AV: E=Sophos;i="5.97,285,1669104000"; d="scan'208";a="700304257" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 09 Feb 2023 18:32:06 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 9 Feb 2023 18:32:05 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 9 Feb 2023 18:32:05 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 9 Feb 2023 18:32:05 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 9 Feb 2023 18:32:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5eNZzm3N+5nN0teXS2xDpFZ1saqoSBRIDIc3Y1V/U6ZkPaIrRC7kqNh68x+FYAd8X/SXRMxqmJ0dNPlQbcolrL6QcdoPS5gHZWAKHPg1bN1B9aQYnPHNdTUVmfnNAO4TvBVCxglzcr/EEENa2vaJO2gcGAB+QaiBljCVW/bEBM11wQFbTPfUYMoiZxy3AqDODXjt3Uxv5QlMpOvqNI/laD8O72sHlG/9JzwBTA+tyTuOh/NujzEl921DE3mhEvLUlYEx8Ru8Vhp0BBiflmx6QmZGEggKGBzXzgP5uhnPO/ZC4yNM60ip8GZeW1LvpVwwQPC1UEkoU7Q7DlyPfG+Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=clcu+uUBpnf0um97Frhbm6R15tsTh2aTxWTUs2PaISE=; b=Kc+U+PIhpiv4gWL8N43p2KPz3b/XNpiu6O9zBQcefBfOxrhZk3xS7xuGhYRiBnhqK+RdMAxYFxMSYD0ItzXJtXwbs3Rf1cQ9Dw4yeDDTNX8gd665CecUxyTR2xL078TJ9X8I3ejbupDm3lMMENXgJU58iwiNbIf4pu5kDRplV0MpGmXddNLfCQzDvxpbPIP+A6h6EfKr5BYPx/bHsY9lX2UOJMhNO96r7yqX+sUTZS5Zj0lKk6E7Q3BXNPyDWPC9ynKzq2J4cRuP0ilaQZe06/mT36S+vC+2d+oHMuN7DXXj2JM7Wa7n/JBhF15WBEZ37FzVdcXQFcKdBJUkKQzjqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SJ0PR11MB4798.namprd11.prod.outlook.com (2603:10b6:a03:2d5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 02:32:02 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5%6]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 02:32:02 +0000 From: "Isaac Oram" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "S, Ashraf Ali" , "Chaganty, Rangasai V" , "Ni, Ray" , "Chiu, Chasel" Subject: Re: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add changes for rewrite varstore header Thread-Topic: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add changes for rewrite varstore header Thread-Index: AQHZPOnlxtomSBnu2kK8+nKUYd4Dd67Hdcvg Date: Fri, 10 Feb 2023 02:32:02 +0000 Message-ID: References: <20230210005130.1021-1-mikuback@linux.microsoft.com> In-Reply-To: <20230210005130.1021-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SJ0PR11MB4798:EE_ x-ms-office365-filtering-correlation-id: 275a60a6-2599-490e-831d-08db0b0efe2e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UvjLS8I0I42EMOnTtR8T1AQHFGw1NlqL9pumDXOAyPteef+hOd2AbMl8VfxZHuqT8ck0D5dwhLGVuWQoKwXqsgYTqMTg/zJ7JeM61XqotjZFfXzrIxvQhv3TF9FETtfo0fE10bnhmeueJrytx4+deWa2MQKXROMsqswIzIcUhDVQC2l/nuZ4E5ondj3B/WGt7qJT0nDkhIrargfpHCYkWpCAl6l1Mzk9CxGdm80yV0QTJJq6lNTJHV9YD2ENjQTpqPIB/iy7BMtTzxL1w5AwzEGPqtR9rmV0hx47Y+ojud5Sya/abKCPv0fs1/e0/z16bX37MeMyjk/LpwZyyAeqTkIey3Y5+nQnd6pZsNnC68g5iQkrxGJRQ2wMl1YLnLuzLlaYschW5nMez77ucX0xKtNokGtyGfbuSWmltey47zSB59HlvfbDyZWhZQBIAQ1HtY4vGeAHFG9t7/ZBStw678K/ScM+1MpL+tOuFTAUKNmWApMAQVx1OCzWBuo3DQbjY8CgT5tGBn5KTL12CJ2VuriEk3MU+8bdsznrTKNhNMi6XsjZ7EGwJfHhY4Hls0DdYsV9mv5ZUYkzJU5yRFREmR/mvnk/I3h5XLTkAzCYoUdoGgHytWtuCVqOE2/7qvNnVTvNbwVbVrLF8tiE/ChlfbZkNcodJK0UXiuapMSETzS2wr92mTLEx/JTouVI2VqDl7/vNOQh92akboR/ABmXyWqlBJOCJ4V3rh5eTg0n44E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(136003)(376002)(39860400002)(366004)(451199018)(2906002)(86362001)(38100700002)(82960400001)(122000001)(110136005)(53546011)(6506007)(186003)(7696005)(9686003)(26005)(38070700005)(55016003)(33656002)(83380400001)(66476007)(8676002)(66446008)(66556008)(54906003)(316002)(19627235002)(66946007)(41300700001)(4326008)(478600001)(107886003)(64756008)(76116006)(71200400001)(52536014)(8936002)(5660300002)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5yeDRjZB50JD009TWNlk8fagOCFQz0Yh3Z67YHOL/1PHm0dTtRz1hSo/HB11?= =?us-ascii?Q?F1hptaJBfElIBehK9GtT1K2H9mPWBPuYAzYgYc2RMbWght2B5pslJa452K6/?= =?us-ascii?Q?n+H1DKhk+hppUVclHWBX4Sbpki1DQUOctjsR87umibTEKxXxaGxV3lereThU?= =?us-ascii?Q?Lx9EoWh8SfLWXq2nyAuO3vVviwTC5n8N3N0tSmHUS72aVTivIFOqe/CtbBkx?= =?us-ascii?Q?f4OMYPAOqzSPJkW4SiglI1HgfNWKUSdTbzOYAW2UH6OXzbHF8PQ/lT99JPJb?= =?us-ascii?Q?E67FnzW0BxkjQSX7F3h3crK8jKYwGUjTykPTWoc2gyi38xxhxeGsdq4aXLEC?= =?us-ascii?Q?Hqz4Oo94rrnzuAcaj62MmOCWVNlaP+zbxkr5Rslm2DdnnVrmhuEofdzbSxoa?= =?us-ascii?Q?AupsAiO6URHWpkzZf2/JegzCACFkCgwFfhuTDakiZip7UYme8ZCVTaONIz15?= =?us-ascii?Q?DdsL/aa9CBXd7Clw83Ak8Aay3o/eSchDCR6sHnHo1G4XHKyX+NBuJUU/nmIs?= =?us-ascii?Q?UQwhHORYqCxHv/sEXdEOWhOCj4We5ZZ5zfnYU/7HpAsrWfcoQNgZLYOca3CE?= =?us-ascii?Q?h9PD3ojUVTZV+lRPS5U9ByK07C5C+NHGYyB32O/0/oohQGyYWewJ5wYo6oJB?= =?us-ascii?Q?ii09yTkM337UcWd1y6OjfkhDOkr/cB/arT1a8ctUqHKA4cIYp0tDG7ZsV64k?= =?us-ascii?Q?QMNsFR+AOZxyPQOH/K64AZ/9/pQLYh/MNTDjOFsvhycoFvs3mPAMTnI/Rdnr?= =?us-ascii?Q?gz7nUfOrCYt3il/Gr1Zo2So9I2tfBYAN0LSx+MUIbH6Qk/IOfUUDnnXFJrBQ?= =?us-ascii?Q?YLxwN/oy8HQlmCN9dsuw+JORGEvwDciUA6qKYESSVhXVJ9BbuOSHc1pxJj3W?= =?us-ascii?Q?V8liusivQQ1GZ9zj8zk83OIJHgaWF1iyaFTsqoCINyCYmOW3b69pCphPrSEU?= =?us-ascii?Q?spBpM1VtDvWixKzd9vqA90DnQr3yZXha4kq4mE7SFIGYxs3+7b8kSwcfv22V?= =?us-ascii?Q?8ONVpMPI5a6I3PYXZTiPUAnfzsCv6idOpB3yl5RiLhSNT79lLp8OhkEymqPO?= =?us-ascii?Q?l1FOSXOOJtI1i9NGVBkiuNxLrxS1BH5bi6z6Yro8BdyvZHVJrqzrmHKFaaoE?= =?us-ascii?Q?j2BwpimwkQOfQ4j0h6Hb15SaEcG8gxdiL0Tk5UwhiOZiRyco2LAGJma+oj3q?= =?us-ascii?Q?ec01TMf9u5bl4WKF58pdwqwsYOtDN6LGhpx0a05R4yQOWUrBAy6pCJQtnfMN?= =?us-ascii?Q?atoN735ZzVquhOBfVWOlKhxk9TBUe53L2S6RkLzigrqg3fIShNG5dFATzR4/?= =?us-ascii?Q?zk9iuG0TZPZaZsoj8pDk8IPpMus3mDUzFGCz1Nqmd+r+xT+cAleYlzxZeKoc?= =?us-ascii?Q?aFHdnqxVQttrtM1AE7Fv5nnYzOe4Ufitm6ENQtrrSbfBMsTUfIkIH/g6qET5?= =?us-ascii?Q?ezENFiYI6gMXjwwy+p6ltncwMh+BanpXmEYEKfJzfJQ3yBkX8UFQVpDFVQ/6?= =?us-ascii?Q?W8TdWw7WqdqMZzmUCqKXu3gSGMDspc11L1+AidYMaur5LWAJB2e8sgCdt8pF?= =?us-ascii?Q?Tv6qCyeMDoLZsuQ/BQmhGMi4zIz0AZVj5B2vT3V0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 275a60a6-2599-490e-831d-08db0b0efe2e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 02:32:02.4497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XXXLo4DAEyNXTvZg3MV7AUy09zeNdMw3gtHbLxKKNxvOXjEomlQNBUHOmm3SA83FcCktWVDWNmxDsFbue15HbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4798 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Thursday, February 9, 2023 4:52 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray ; Chiu, Chasel Subject: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add chan= ges for rewrite varstore header From: Michael Kubacki Updates the Standalone MM module to have the necessary INF changes to build= with the following two recent commits made to rewrite the the variable sto= re header in the MM SPI FVB service. - e95c798 - 88d44c5 Cc: Ashraf Ali S Cc: Isaac Oram Cc: Rangasai V Chaganty Cc: Ray Ni Cc: Chasel Chiu Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSta= ndaloneMm.inf | 4 ++++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiF= vbServiceStandaloneMm.inf b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/Spi= FvbService/SpiFvbServiceStandaloneMm.inf index 152cf0036fdb..717b6fc00cc6 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServi= ceStandaloneMm.inf +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbSe +++ rviceStandaloneMm.inf @@ -44,6 +44,8 @@ [Packages] [Pcd] gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase ## CONSUM= ES gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize ## CONSUM= ES + gIntelSiliconPkgTokenSpaceGuid.PcdFlashVariableStoreType ## SOMETI= MES_CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdFlashNvStorageAdditionalSize ##=20 + CONSUMES =20 [Sources] FvbInfo.c @@ -60,6 +62,8 @@ [Protocols] [Guids] gEfiFirmwareFileSystem2Guid ## CONSUMES gEfiSystemNvDataFvGuid ## CONSUMES + gEfiVariableGuid ## SOMETIMES_CONSUMES + gEfiAuthenticatedVariableGuid ## SOMETIMES_CONSUMES =20 [Depex] TRUE diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index d73a51ca5235..cad22acda496 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -188,7 +188,8 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, = PcdsDynamicEx] =20 ## Define Flash Variable Store type.

# When Flash Variable Store corruption happened, the SpiFvbService will= recreate Variable Store - # with valid header information provided by this PCD value.
+ # with valid header information provided by this PCD value. + # Note: This PCD must be FixedAtBuild when using Standalone MM. # 0: Variable Store is gEfiVariableGuid type.
# 1: Variable Store is gEfiAuthenticatedVariableGuid type.
# Other value: reserved for future use.
@@ -199,6 +200,7 @@ [PcdsFi= xedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] # Platform may implement a Regular variable region and an additional re= gion, which will require this PCD # to tell SpiFvbService to include both regions. # Note: This PCD is for compatible with legacy usages that should be de= precated. + # Note: This PCD must be FixedAtBuild when using Standalone MM. # The new usage model should define separate regions without implicit c= onnections to UEFI Variable or FTW regions.
# Example legacy usage is to set this PCD equal to platform PcdFlashFvN= vStorageEventLogSize. # 0: No additional NVS region.
-- 2.28.0.windows.1