Re: [edk2-devel] [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82

["Isaac Oram" <isaac.w.oram@intel.com>]

Pushed as 857a342e50..07f5955bad

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Monday, April 3, 2023 8:56 AM
To: Ramkumar Krishnamoorthi <ramkumark@ami.com>; devel@edk2.groups.io
Cc: Venkatesan, Selvaraj <selvarajv@ami.com>; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>; Ponnusamy, Suresh <sureshkumarp@ami.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

I amended the author to match "Ramkumar K <ramkumark@ami.com>".  Please correct.  I am not sure if it is git config or groups.io that is mismatching.  You can do git log and see the delta between author and your signoff.

Thanks for fixing the enum.

Regards,
Isaac

-----Original Message-----
From: Ramkumar Krishnamoorthi <ramkumark@ami.com> 
Sent: Monday, March 27, 2023 4:04 AM
To: devel@edk2.groups.io
Cc: Venkatesan, Selvaraj <selvarajv@ami.com>; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>; Ponnusamy, Suresh <sureshkumarp@ami.com>; Ramkumar Krishnamoorthi <ramkumark@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82

Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID  of JunctionCity and Aowanda platform to 0x81 and 0x82

Fix to resolve the boot error - Change the enum constants values TypeBoardPortTemplate, TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h.
Changed PcdBoardId as 0x81 and 0x82 for Junction and Aowanda on respective PlatformPkg.dsc.

Cc: Harikrishna Doppalapudi <harikrishnad@ami.com>
Cc: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Cc: Selvaraj V <selvarajv@ami.com>
Cc: Ramkumar K <ramkumark@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Ramkumar K <ramkumark@ami.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc      | 2 +-
 Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc | 2 +-
 Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
index 8761f8b56a..fa4cfc09db 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
@@ -49,7 +49,7 @@
   gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047      # Built in messages:  Error, MTRR, info, load, warn, init
   gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2     # This is set to INT3 (0x2) for Simics source level debugging
 !endif
-  gPlatformTokenSpaceGuid.PcdBoardId|0x26
+  gPlatformTokenSpaceGuid.PcdBoardId|0x82

 [PcdsFixedAtBuild.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
index 8e226c1552..f934a456dd 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
@@ -49,7 +49,7 @@
   gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047      # Built in messages:  Error, MTRR, info, load, warn, init
   gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2     # This is set to INT3 (0x2) for Simics source level debugging
 !endif
-  gPlatformTokenSpaceGuid.PcdBoardId|0x25
+  gPlatformTokenSpaceGuid.PcdBoardId|0x81

 [PcdsFixedAtBuild.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900
diff --git a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
index 0c14a2409f..ca96ab3304 100644
--- a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
+++ b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
@@ -69,7 +69,7 @@ typedef enum {
   //
   // Vendor board range currently starts at 0x80
   //
-  TypeBoardPortTemplate,               // 0x80
+  TypeBoardPortTemplate = 0x80,               // 0x80
   TypeJunctionCity,
   TypeAowanda,
   EndOfVendorPlatformTypeEnum
--
2.37.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.