From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.2915.1659986792294363078 for ; Mon, 08 Aug 2022 12:26:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YTo7rdJP; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659986792; x=1691522792; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xnxP1MRBn6yo/xj8dy4WmcxDau2rOWP0P89FVfkqZMw=; b=YTo7rdJPqyocOD4BHvK1oeNr8A+bMNP3cA6oJsVk4tOKbd67UkCn9ETD KVmFZXDLPhQRlhsooULMQa8lC+xRE0izYX82k5d5eAazTUXqjfQYZM7gi gVdS7tmk5y+wXW/BhbNL+LDPquu9eJ0PDUt+A5TiiINImZnG0edwtwcMq g0BcVdVa6OK2pMh99pF7j0QxbUBOUnb2dqHwV5LMXz6kdZqNBU1TTjcfr ewoOKaRiHZBY1nJrknOvxYFLs+B0HMozHGy9H5WVpnC+2/uOIBw3LqRP2 C/5pAk5SLOgh/b27d1AJWwrh9b0VtdA/BTfqIv6eoH/TtpQgeP1y7ybjE g==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="277609730" X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="277609730" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 12:26:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="555053741" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Aug 2022 12:26:30 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:26:29 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 12:26:29 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 12:26:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 12:26:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L013P1J4vDqpMsrHEVnZP9PecdcnCjVkVwBIHjRycY4shT3B63VUjUPn6E9Bffy74z+I3IhIR1/INe4HrQ7AxS4U9iF92dsJoPf6JpJeiTYLDzfiNEC5I4PwjUOmhCRivkqKy9vt3LFeQ9Q6Cw6Hwad2qE3F+uVFU2Ve2BflWzz52JUXnZdvnoGrCsQn705JqlP7XvphyojcLdsLYf3su403LrSrMUgBu2SaJyNlePkjLVlfW08ALX+oAKfsomKCmhrbpfy3uZghJ6HV4DgfQKvscFjc8+pM/BkeuZQv52x0QqCUKaxJ9p8SmP0lE0N+ZKsNx/3gkdHAEg7BdVrv/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlDS/iEUBioGl/ElDVeeVYi7DVnal4H+eRwxQfQJPIo=; b=nEOr156VQh4fySRnvLDZVRECXVGFfO2HIWwOs80lvg16EVLTJs1q+RucCoQu+p6TYatklo7IcT1QINny2TPIA4X6ZiM99wbOwxUJH0dn3gO/x7gMyL683czFXUEzk21/09Ll8Pse+8Eo+Vbh9dGv4NSzCmSMIkrGPSNGbnYnXQx4iIOvZaw4uxDGpe+yEzjDBQCxO3l/7WL6BQ6OYYnK5DVX7cC7cU9ACMZcsrPQR3Rq8wA1Vth4yrWB1ASvjEf5SP1gVFvZFvObSdMvWs60HwEcfVFPbSi2m+Scpzm9EO1WiFO8AbbuQfwHXYBEgPTGKOO48cjTdzrX3mfU0qPG6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SJ0PR11MB4894.namprd11.prod.outlook.com (2603:10b6:a03:2d4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Mon, 8 Aug 2022 19:26:25 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%9]) with mapi id 15.20.5504.016; Mon, 8 Aug 2022 19:26:25 +0000 From: "Oram, Isaac W" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "benjamin.doron00@gmail.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Sinha, Ankit" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules are mutually exclusive Thread-Topic: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules are mutually exclusive Thread-Index: AQHYoEnAkLky6TdA70Kt+XOgwFGKga2ld3zQgAABXTA= Date: Mon, 8 Aug 2022 19:26:25 +0000 Message-ID: References: <20220725171207.3154408-1-benjamin.doron00@gmail.com> <170974F020AA914C.7247@groups.io> In-Reply-To: <170974F020AA914C.7247@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5ca1282-8c33-4008-8d50-08da7973e250 x-ms-traffictypediagnostic: SJ0PR11MB4894:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ht0fB+oUMX4dQUKn8qOKovt50JouVP9x/6H4EA/QQTlBQ9q+Zus/DFkTaj70IrwjZ6+hTor9Fr5o6ePBkHo2TsfaSo9rRlPV69VnhkQcwxLm+9zHNbI+n7+RrEoOTXCFIS//eu8OdjqLIkQ2p4OGxMC/oSfV0LkfFsjHzOodjLwgiJR78sTnCmvfG7PI7gxfzb+mLtOFFPrK7SRjs07UYZAgcGV6EGpWcfF3xhECGwyqCny/L+HmqgM0SWwjnIxZ40O4bJUwoky3FjBm8SyurgtrtVQBqz41GBuVHcD8WHCkoCgxG33noWjSttJX2FXSB0JMKUMZoeywPhnsmIF0c/OuTaXbfm5U6LtECjI0va35C7k3SXeqHXBsgiG4zRKjszZiYS/kYmFbsrMMPB0S8HrD8IPjOuTEhNgIVEshMTMug7fxNqqnaivRL3a4J3XCb2/BoyySm9ApEqRy82X1LsbmxfRzbX83w13skoOvQz1zPFBiRE0HpDri2vLeQhAdU9mC/jAKZADAQllKchR04qGyRBdVsVns6x/FgZ69GnLrix9DxlPScONlKtVTaJYX1/75xpygMqCoxSrBseg58Hm47LvY1pMRUDKNgwxvLJ3XToCckFtujC4nsE7lbf7pXOcbljNzQ0kUTQJTdIdGXoz8dqDHUItBzHhLmVRCiJ1EMxY4EJ7QNLsJp/Gl22NecXpUOn6oLHWkRycrSzDWdWNsDSLRABedG5rqhIVRK0nyhNYrcqAT3utihUhNUX3bECmjnS201zS3FeKdeUlwpYQ8n9/wD5eHxuVklZsQEzo3Bn0sQPWQ7ULHtpDvjFmwDJNj3yn4Njn+ygFnm1Ghkknoyil3Us9UmdTzaTfiQeIpI9dXp10eZfv6r37+ln/V x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(346002)(136003)(396003)(376002)(478600001)(71200400001)(966005)(33656002)(41300700001)(38070700005)(52536014)(53546011)(6506007)(83380400001)(7696005)(186003)(86362001)(54906003)(26005)(110136005)(107886003)(82960400001)(55016003)(76116006)(66556008)(66946007)(66476007)(5660300002)(64756008)(9686003)(316002)(66446008)(4326008)(8676002)(38100700002)(2906002)(122000001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EkDaFZBFzcLYO2wKazLApKimXVlB/hGB7EDhZtAsFf3DEs3Ao18L2L4uZ9qF?= =?us-ascii?Q?B/Rfe3vY5NbHSnGK+kuLFxacUdtpvZx4Fpd6qNRZGePr/05qLRdDLy5Lr2Ej?= =?us-ascii?Q?x1K0VqWCOW7NYcXE2AmPTqk+GYyIeu0KUPKdYMpnVYpy8M/9eMBzVb9AbL8L?= =?us-ascii?Q?K/qEsg5Dlp7ozJ94my1++zmk4CFszZUnAs5hSsyzed/qDeXtKskeJTFkB77Y?= =?us-ascii?Q?z7pDmN2Ai8TApskexqjLQg3Q5fIDXvJ/D5GsDR6wUhrPW/KJVkIBol/M4LTq?= =?us-ascii?Q?BvSqq+aGMWEEow0ryX4Dm8gIxCs8dBXekzbNNzvbIqFFOG1elbnaKrACjavj?= =?us-ascii?Q?fCPbsr5Vlc825U9ONlV+wt24fuptyaew16WT/sYb/gZI04Ogvww1sj+5ZLz6?= =?us-ascii?Q?ZaEQwKaf+GF3EfmAwznTci5Q2HwUlUoOxKuNwFe9xzTEX2KQj4GTK7A8LhYq?= =?us-ascii?Q?EtalGze1MWjE0tcJhuBgQmHAF+Vbb+onlfoFTdReGvTm+4Oqag2sJjrtI99J?= =?us-ascii?Q?AYT0hXT/YU2JiLn9Evt9+oG8FxEqe/MONoZTY56uUnZ7s4fgHkUGzSk2fipv?= =?us-ascii?Q?QtQhpCc1MgwBencDpAc6BInYbhHbDMpSQcweLKfNqayuom9Zuyu/oe0voR6R?= =?us-ascii?Q?3aTr2r8zm26rypmGYeorIya30CuasT4p7/NaPgWFFHznJveFTcsTEoJjIK6m?= =?us-ascii?Q?V0nAIuCL0Yakyn8IIndB5LQ/IvAMYCauY1NHshFDg+t/7K9HB/jCFXo+XNSh?= =?us-ascii?Q?Ab0OB1Eo5xnZT2hxJShllMi2Sv4SPuK3d37VAwr0ZSs812MeFyKGI7UP1ljq?= =?us-ascii?Q?4wHlZqr28oW3aNNcCr44b28xklTtjGNsqnWM1qrSKOYFyDP6iK/8Pk/9/egK?= =?us-ascii?Q?AltEwe626dLAZJdc3SGeT10GuRtLYOGLXGfKkfKwORt3OjQGdFNX2Oan+sWQ?= =?us-ascii?Q?u8VtM3dcCjG/iROfklUNZUvxC5jMP2MCECzZ7cd2SnHeNL2Qdu9MX0g2cHK7?= =?us-ascii?Q?42m4fqkzY1/IoqzlAmzjwCpJg3ycJNpZKCveVEXizmgIq65Kp/5hbNrD6K8F?= =?us-ascii?Q?Lnw0ComGVZHbv0amijir2YNUHEk2Hlgu6f/WKy3kGliAxOA/nHB2AO5/KxWP?= =?us-ascii?Q?u+IuuCqReOH1Svxyb2fG9+3+RYTYYA51/2HIFmJKNZsU0Fmt+ax4mbbI1fxe?= =?us-ascii?Q?i/fLiBqgCAbR47TD8RDR/sAPdMzAwU9nhwVz2JP3MkNTxfwo+svhwpYlI7e4?= =?us-ascii?Q?nP9wMheV0pSPC+Gq+buQUfMHGEV0ezPDKmLk+G8iPacxhNqMTvai4ufQ7C9a?= =?us-ascii?Q?vkI5QJ6VCHJrFbuYWq2ORsKHzPiG+yZ8P3Bhtvy0bxAzWHZHXF/eCv/E9KF/?= =?us-ascii?Q?+SlWjPxYJMwzfRy7/yUcC+1NZLtvfVmlQLqopZ1tYrQxGaT8LZdaLDOYaolU?= =?us-ascii?Q?WmfzG/81L+Ul0f6F+RFGW95dAStB8aoPvY8wtyprP8mrwyUL2IIubYAZA4t0?= =?us-ascii?Q?CFBl3sKAagtnbs014aXNb76dWh4u7KPOZ1uNkq7Y9ewV4cGV9QKeYs7g5+xM?= =?us-ascii?Q?PMKsQVnfMhzAHNPQ6ycl82GwFinpyJu21SVyiq0b?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5ca1282-8c33-4008-8d50-08da7973e250 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 19:26:25.0851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sa7z+6VnsVd0v5i1mEKCYbf30gWuOo29qHhQxkUu56dwAQ+hd6GRUB3iDr7gZAbHRoNTNthFD7tDOTGQfTgajQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as edc718521e..d85e4251ce -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oram, Isaac = W Sent: Monday, August 8, 2022 12:22 PM To: devel@edk2.groups.io; benjamin.doron00@gmail.com Cc: Chaganty, Rangasai V ; Desimone, Nathani= el L ; Sinha, Ankit = ; Gao, Liming ; Dong, Eric Subject: Re: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modu= les are mutually exclusive Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Monday, July 25, 2022 10:12 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Sinha, Ankit ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules = are mutually exclusive The DXE and SMM versions of AcpiDebug perform the same task and are therefo= re mutually exclusive. Including both modules results in a duplicate ACPI t= able, resulting in the feature not working at all. Therefore, add a new PCD to determine which module will be included. Now, either version successfully write to the debug buffer. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Ankit Sinha Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 1 + Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 1 + Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c = | 4 ++++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 1 + Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 3 +++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 7 +++++-- 6 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 28530b8c674b..908fe4d1f7a9 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -48,6 +48,7 @@ # Debugging features # gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDeb= ugFeatureEnable |TRUE+ gAcpiDebugFeaturePkgTokenSpaceGuid.Pcd= UseSmmVersion |FALSE gBeepDebugFeaturePkgTokenSpace= Guid.PcdBeepDebugFeatureEnable |TRUE gPostCodeDebugFeaturePk= gTokenSpaceGuid.PcdPostCodeDebugFeatureEnable |TRUE gUsb3DebugFeatur= ePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable |TRUEdiff --git a= /Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc b/Featur= es/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc index e214175edaf7..d59e3e61b9b9 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc @@ -59,6 +59,7 @@ # [PcdsFeatureFlag] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatu= reEnable |FALSE+ gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUseSmm= Version |FALSE gBeepDebugFeaturePkgTokenSpaceGuid.P= cdBeepDebugFeatureEnable |FALSE gPostCodeDebugFeaturePkgToke= nSpaceGuid.PcdPostCodeDebugFeatureEnable |FALSE gUsb3DebugFeaturePkg= TokenSpaceGuid.PcdUsb3DebugFeatureEnable |FALSEdiff --git a/Fe= atures/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c b/Fe= atures/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebug.c index 4caeffc7dec9..0b28e2f7a6d5 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebu= g.c +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD +++ ebug.c @@ -483,6 +483,10 @@ InitializeAcpiDebugSmm ( EFI_SMM_BASE2_PROTOCOL *SmmBase2; BOOLEAN InSmm; = + if (!PcdGetBool (PcdAcpiDebugFeatureActive)) {+ return EFI_SUCCESS;+ = }+ Status =3D gBS->LocateProtocol (&gEfiSmmBase2ProtocolGuid, NULL, (VOI= D **) &SmmBase2); ASSERT_EFI_ERROR (Status); if (EFI_ERROR (Status)) {d= iff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePk= g.dec b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.de= c index 915923100731..1a290bab29d9 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d +++ ec @@ -28,6 +28,7 @@ [PcdsFeatureFlag] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatur= eEnable|FALSE|BOOLEAN|0xA0000001+ gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUs= eSmmVersion|FALSE|BOOLEAN|0xA0000002 [PcdsFixedAtBuild, PcdsPatchableInMod= ule, PcdsDynamic, PcdsDynamicEx] ## This PCD specifies the ACPI debug mes= sage buffer size.diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/= Include/AcpiDebugFeature.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg= /Include/AcpiDebugFeature.dsc index f5b8bacee039..684549bbdd78 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature= .dsc +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeat +++ ure.dsc @@ -54,5 +54,8 @@ # in the package build. # Add components here that should be included= in the package build.+!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUseSmmVers= ion =3D=3D FALSE AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+!el= se AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+!endifdiff --git = a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf b/Fea= tures/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf index 855826292cb5..e904a2f8fbf2 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd +++ f @@ -7,5 +7,8 @@ # ## -INF RuleOverride =3D DRIVER_ACPITABLE AcpiDebugFeaturePkg/AcpiDebugD= xeSmm/AcpiDebugDxe.inf-INF RuleOverride =3D DRIVER_ACPITABLE AcpiDebugFeatu= rePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+!if gAcpiDebugFeaturePkgTokenSpaceGu= id.PcdUseSmmVersion =3D=3D FALSE+ INF RuleOverride =3D DRIVER_ACPITABLE Ac= piDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+!else+ INF RuleOverride= =3D DRIVER_ACPITABLE AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+= !endif-- 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91815): https://edk2.groups.io/g/devel/message/91815 Mute This Topic: https://groups.io/mt/92609642/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] = -=3D-=3D-=3D-=3D-=3D-=3D