From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.1.1665435572277251951 for ; Mon, 10 Oct 2022 13:59:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Fctcbz3S; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665435572; x=1696971572; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z8ljFgCPutkpXzvC/4VihsJ5YQNlfamazXGEUNiDZOc=; b=Fctcbz3SWNoRPMzMmfgM2p0c102/xwMtE0HRoEoIWFTLRnBiyeGZcp5X wfTGDHELVYIxNblgv+iSSCiim4FvtbCyaC6LC8GGXhXDuPm4wG0nRCxM9 RSKCMKiGGskVynGx8tGI9QjTXuSp+UlOF2KKQdqrT/z8ya4QSz1WzEiE9 JBOzFYAt11Hph1Z+aqkZuVVS+PZml3RifBG0OZnsECiWlIuXzvQ/Yhx0N y12/JrMmuFPOwm/936NlhYsYWnOR95OsEAapyJshHr1hHXjI8CG+zcLvn VzB82OmpPrSsVDfqjMA5Rjgz2HVT23qcnU4KOf+EI7mLpIvrn8TQEQMnU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="284062504" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="284062504" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 13:59:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="715250501" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="715250501" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2022 13:59:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 13:59:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 13:59:31 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 10 Oct 2022 13:59:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZzJtd+tvhjUnEx1FPMfhpxK8+9cpS4rBAdYczioPTf5xb/AtrGI/kV6GzgEVCDLB4qXIsWV0uyOjHbzbSeSy/JX+mLe8cNGljlhgyiVDxOA5i5QoM4bylYRGZa3xTFsdAq863BY2Igna7z0pSVYBxd0zD2bxtlohfE7Xc2TqWLQ2okqKTZxbIAJp6N8br9tJpssFzwESS3zOIy28AwAwZKjFfLwy52FkFymMhkdkqhqbgLt94LFVnqK6ZH4zGeswy7JyK0vXNHs8luzJadVqlGn/S3JsBUEDyoa44swKkMxNcMuJt2JUvPLmGgXG/BuD5VD2xLJC5HSZ4n/eOoMWxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=psor15m5hw8GKZI6vzDkWKOvuiXQJe2hNw9uOPkVDOk=; b=eGh9uCVOH6enu4AY7M/M5KQewYp2nrCptIrHDPZS9d8fZTvvM2WPNe3n+x4hj2xoQ85XLyUMKaLm0XeBSFg+ZdzftJTUG5zdrO1NPXlPG5yeFnexvF4mBZmttHxNW5STfxNiDGVSZxzqmXn7rz7JjMm+yWycucm3Hok5ilj2g3xWAffXzhu4Oz1CklYCneFPo5SXlpSyl1d+iOOdwkKinpOBqqeLIqF0enjT//PYrVmnVDe9O8LT9y+/KgXcQuTRlp6DDFWSfsqqdJ7qSshlYjrzw9u3V/d+Bkf72xSMkpv+aLiSBGRBQ8eazfPMpTk7sFcYfBHY23/lvBm5/JDK7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM4PR11MB5358.namprd11.prod.outlook.com (2603:10b6:5:395::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 10 Oct 2022 20:59:29 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940%3]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 20:59:29 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "S, Ashraf Ali" , "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Index: AQHY2M5xkqAnxs02402u+RUJ5WwXxa4IJJkQ Date: Mon, 10 Oct 2022 20:59:29 +0000 Message-ID: References: <20221005152302.4445-1-mikuback@linux.microsoft.com> In-Reply-To: <20221005152302.4445-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|DM4PR11MB5358:EE_ x-ms-office365-filtering-correlation-id: 9fddc592-8ec3-4d23-7f2c-08daab0252dd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D0WwQ+EYcUGkItt31L7uo5n/mY3Ypph8JnC2+XixJck2QmHRWQP8ILrtfOE+W9pgGMtRJPcXfQ+me5UbXS5zqcIWXhEW1SOo1SZbAjiO0GiJ5DISTEv1k/59zn9AxLFaRuZ1CvTBTN9R4QqTE0MGUo7IqTQb3jzEBRqf/SWTjrOA6EdMWF/ZVJNfhxAvr41LHG7CHV1ZRYrM2g7bKkvt9WeFbQtRbUIVBMf+F4RMY8otP81BLtWcKhWuuS7bNisIOftnwvr4pXGe32Ws2ypDRIlxrHaPgyNJ9imqiNw2Vj6QtUOo5iVjF+jbWmPWdoDGwvmMtfz/k1H/mMlMN3dyVlq7hUQeojmb7wUaIiAxeM3WPwktJILsOKKVQAJUC6ROoCZvXKGQ+3a2BVyf1WZLlLtTOo4JF3xf56Zw1cNNSfRWAme+Pog9X4U3J/hLqy6uhn0yg8hxX2LqwRdHIBAOVsOyxOVyOafyPxYXCzeSY1BPm95aJm11UHIGORDoXRq8jLcsoJe0bzvUP4e8BfA0pX3quGXvrMnczqcLin11YLOIHr8KYbtPzwpLIBiqsC4N2gJt/661UHW3/gB8zn+M2XNY59bvAPHCoOvclO4/lCc5kg62vw/JMx91LyuIdM8JNzIrCUTYFGwIeXuZZ66+A6lZkwIpnJhaGVyjaBBgGa5SwW3navF2U+HdWxDcvz4dIncA6p13zVseLIR3BNZnvotK1WupxXnqCtJYjH3GgEF71suKIGJuwvbzFNwm4Gxi1a1kFRpJBk8ONc3qHL8C5ZS/Nu0tmWdO0Ib/RWCeLOW0662+Zcg3nKQ9xwpFt6Dxp52db/njs/AqfcOiFYlSXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(316002)(54906003)(66899015)(83380400001)(2906002)(966005)(38070700005)(66946007)(5660300002)(55016003)(64756008)(4326008)(66556008)(7696005)(122000001)(186003)(76116006)(82960400001)(66476007)(53546011)(6506007)(66446008)(41300700001)(107886003)(38100700002)(8936002)(33656002)(9686003)(26005)(52536014)(86362001)(110136005)(8676002)(71200400001)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DMSZQ/JOaPlmHuNpmDXiwfwh+wOuaR7KUa9CIbfBadJpz5sYE/GZGarvpeJU?= =?us-ascii?Q?3LNgCckFMSvgO1hyRIguWnIG4TY9f2YYVW7/Ks907N/EuZ2tSXLCJ8uviZyX?= =?us-ascii?Q?b0G7cETTc4Z2CZo58yTUO1+A065GI2KQUsLrOiUc+U5vU5Net3xo0ZQP4rGv?= =?us-ascii?Q?mgarOy+rfiIFwEy12Ds2oAKgJdE3fRlScBH5tYApjHxP8qERwJW4Jyz11Rw8?= =?us-ascii?Q?gXWHlUAWtkAGSEgENtGU/eMeVQqfarlouZkswv2LQAGFVg/6aS02pbI0SoRE?= =?us-ascii?Q?5K7K1H3zEIqwMMe1aeGfunx5yzp3MipnFHhy4UAT1CzsllghouF9lpZWV8Gj?= =?us-ascii?Q?glsXloT3zeuKRCyYk8+sJAwBtaF/YeRaoNN0CGs24rm9tk8LNO/tUoY/Mr0E?= =?us-ascii?Q?GnlHzNzYVpOZ+r5Go7khuIZlOtEhZ09VHXJ3nBiix5dJ4yhW09OBobsYoF+W?= =?us-ascii?Q?mHi+aT5IOP85mDDPhoBP7sS1jW43td49DqERzV3F4Ym50cnHVCUJP6We4fq1?= =?us-ascii?Q?ySF7ibITPtsrgGJwXgPOCkWPEaAdLv+qgZZOWuaAm1IssQGDVGX5J9DmK+sY?= =?us-ascii?Q?BSf2NxTqEbnN57KZUqA4R1G4Y/IapBuJmqCnaLwhRs5TpyXMACzEVYBDoPHn?= =?us-ascii?Q?E1Z9Q5EWaif9NcG4pdvODYdE/aj1y/admH3ahEhZ2gdqvjAxeJ0INV843RtX?= =?us-ascii?Q?WPQYfh++xF1MikUPNR6ieibqc8VNamGD+nNCT5tz0xpaFgEpjF34VxxiP5V+?= =?us-ascii?Q?kUJaD7w/bruSGYtYxTrKA9hYAdlqomVflSiba+Kt7IlMtdpJMApNXuP/Vb3K?= =?us-ascii?Q?kucTRBqDkhPsKHT/gao17lHwWi+nsj7GY7vLkzuH8DZZ7Qu7/sJoN5PZ9m10?= =?us-ascii?Q?Ms+7FOBUe/TXfIzn8yKuNrl9Bo6Uai37wBN3QFw/J1K+35pYiskaripVs8aU?= =?us-ascii?Q?Eqh6yLgVWx69zijrctMIbmaNp4t9W+C/f5aCR6PpBvcIa65jCbVS9xzq13CF?= =?us-ascii?Q?Jl5WD4nxEadMVdCqTl5J4qxFPhXWrFuimMB6GAM8lzWvFAJ/dqHnUoMuxUm8?= =?us-ascii?Q?mbWOAa18FBS3pIsXQEdahnsYCmFvvwwpep2WCawqhnPdFAH4wNoHNCPhkJGV?= =?us-ascii?Q?C3OJfcjwg1+sxnIO1RnJ6/6uGco5rPEnHr+k6mJsZqWE4UHrabpwh6HN4yJC?= =?us-ascii?Q?bG1LejEVyWQbmMj6TdJGOz0nRngKQ1kKlVUlgSmPcWshezUBnL2isXOcraxp?= =?us-ascii?Q?YUolua6W30DqTXvIoxDAZMBuR1s3cBdctTXUf1jquxmgx5z7ubJNN+Y/Ri2j?= =?us-ascii?Q?XQMcqmCdxvxHswbPqnpq8IgaxVkmj8xYfEKtJqyJxpASiHo/Brb+dvXIk+o3?= =?us-ascii?Q?J9hD9qObquEVi0YFjLuBvEHNeWMk50vKS5eKCgjXcpk2mzp4N7o9AmXNfXLp?= =?us-ascii?Q?i9RkzoNNRQW2xVQ0UaFB84anzeTFsPTxYqi4ojwc1fur7wKNBztXxCUtxDJz?= =?us-ascii?Q?dUw0PKGnMhy1x2IEnTqE8KBC8salFCXEzF5gmYaUQODtG5aPUy4UcITnzxzA?= =?us-ascii?Q?RqmL6E0rZQK+CWasPqciJ9kCJV6RK48S2LhpSgqe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fddc592-8ec3-4d23-7f2c-08daab0252dd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 20:59:29.4253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OtPElIeAOsnIFbVDuvkfJptMdn7gDHaOgddSfp4pYJhzJsZjjGuUBsrX+bvlKS34DuoU0/1BzxGyq0DUGBuF0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5358 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Wednesday, October 5, 2022 8:23 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvb= Service: Read FV header length from header From: Michael Kubacki Bug Fix: Read the FV header length from the Firmware Volume Block (FVB) information structure as opposed to EFI_FIRMWARE_VOLUME_HEADER to acc= ount for a variable number of block map entries. Cc: Ashraf Ali S Cc: Isaac Oram Cc: Rangasai V Chaganty Cc: Ray Ni Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbI= nfo.c b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c index 634a44218c7a..ab1cb2ef1622 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo. +++ c @@ -115,7 +115,7 @@ GetFvbInfo ( Status =3D mFvbMediaInfoGenerators[Index](&FvbMediaInfo); ASSERT_EFI_ERROR (Status); if (!EFI_ERROR (Status) && (FvbMediaInfo.BaseAddress =3D=3D FvBaseAddr= ess)) { - FvHeader =3D AllocateCopyPool (sizeof (EFI_FIRMWARE_VOLUME_HEADER), = &FvbMediaInfo.FvbInfo); + FvHeader =3D AllocateCopyPool (FvbMediaInfo.FvbInfo.HeaderLength,=20 + &FvbMediaInfo.FvbInfo); =20 // // Update the checksum value of FV header. -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94758): https://edk2.groups.io/g/devel/message/94758 Mute This Topic: https://groups.io/mt/94137814/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D