From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.57.1665435848952982526 for ; Mon, 10 Oct 2022 14:04:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZNF36o9h; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665435848; x=1696971848; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pB2AjlK3WsXJgi+peNk8C1n66iXbMjEjwe14eBdg1dc=; b=ZNF36o9hTnl0b/DoTEPX+Vq98wCd8sPisJsDPxjxSbc8nxa7F52XkCOH e8cHFFeqFHtkXzJoD6mnM9S0o/rTUfOq+G6GXFLG5a0ocSMOjW4Lcs0Kw wUBTFnApLDTw6xUv1eboED/drubmrN9AYDaFH/LHAQaHClqj4Ne84xLv1 vOins+m50Sc03ubGzUxLWhkaRaChiz/EtK5Coir+/K6KLb9TvHBNwxwDX jwGnALR0+LzBrMIVTMVj/JpE5BENN2VmXrUo6E7uw7TjPjpwpS2kTRSmR al3smbvRqDfuniPYZEyp1sSfvXgo0cTmFL4zM0xaG4J3aKgMq7LErRskN Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="303074154" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="303074154" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 14:04:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="955080757" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="955080757" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 14:04:07 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 14:04:07 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 14:04:07 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 14:04:07 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 10 Oct 2022 14:04:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgkY7As0h8XuVKA/d+TN2/P+Zi+/G//RIwpNGJ1u10YmBfsAym6CXLa6i61XqT/zL7wum1j+gZ+52Htd3JC0Tn/QccgVRSrVW4w0d0TvrXr9UWkzhl70y+0xHeuiY84eNwr8qr+4iXoH++VjQf7sPSSVbsZcEM3I6DNWCx4SkIPy41PmaqQYdwxm9MW6sIPE9dIQCoLDrWPxomliBOErG2JgbPh3Llr17rNQ32pjnW5t6nx/7RVe8D32/HIvl7Rgc3WPW9wXJqqwK/LSmQ/qmB6Z+Q/quhKn0yedFhZEVRcua+UUxwFr/ahWg79jtE/ziAEyJN5zF112SXC6KYNL3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/R/7u5BLmOFKZcBeW/TrYZ7VC9crTrDD1vbOGYfoao=; b=n+UEhRHSIlcx2jNS+n0WKerMdrWoOLUNGidLE+qmz/SFWW7lpwVo2PjB1JN0W0dbMq44tGZw0+NmO9zuDfAuKWlqBvhaCiBQT7qqTaMy2jt128ocXyqAP5SlNfMVJp4OxynIjJH6e+mT5F5dPkMIPXwvrVx3/sFr1+5wvHLbYzyoSmbo0wqs261YrW6uaf560j3hN2mgktsGIlLaqU/GOOSui7O5iqix9eOJAy5RXJWmYbvQnf8AcRUZNFuQMMwYjR080xP6ctxg5jLQDuwi57O1w/dKhxtyj/FnE/3p4EaTolyKNoWYOuAIonybVz27Gbb5GBuRZXJruRgLG0JPfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by CY5PR11MB6533.namprd11.prod.outlook.com (2603:10b6:930:43::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 21:04:05 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940%3]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 21:04:05 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "Oram, Isaac W" , "mikuback@linux.microsoft.com" CC: "S, Ashraf Ali" , "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Index: AQHY2M5xkqAnxs02402u+RUJ5WwXxa4IJJkQgAABXsA= Date: Mon, 10 Oct 2022 21:04:05 +0000 Message-ID: References: <20221005152302.4445-1-mikuback@linux.microsoft.com> <171CD0D455B8F804.950@groups.io> In-Reply-To: <171CD0D455B8F804.950@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|CY5PR11MB6533:EE_ x-ms-office365-filtering-correlation-id: 4e7e7fb2-5a98-4058-4b12-08daab02f74a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YkxqR2k6KjNMJAU1XdmHUrjMRUr+z7UrgJzwvxZty4d42niE7OqJyjzZhZ6nRViF+OAjCh4Ssy1YKZj1F5tXyTI2zeJgLt5bfiKQaCm/eloT6J+22HTgheYwKQIv4ks3mj0yb+1yfzWvSPq6cD1rYkltL6FT02Ihr0ngFpRNfzoiFMU7Mcy8/CPmOJbJHK6BHyS5WMYGh5XegK48BisnFTvFZE8rFz6rUS4v0tG0LtiPRvc2YAOb5QgNIUrCYyDJFzdkLBDm0pfeddaNW3Vt71LI4CsWU2IPeNr3kwatEJkaJ1bARrfHiIlZa2Vk5KtLEYMiIn4pQ/ZjuKlu47OyNjt7gclXWoVIrfYQDaf9ruf6uvHjFWDBwHbjp0W3HAWicKWgu3cf9TNPHfg9urIVOr3DrDdfx8YzZ5AlRf9JQvNrB98diuJKVfIUMOzqWa9fphf4wnyCrlEW4FTgaPcZShD8oTS8LI+9Xe4UTfjkV/rRxJ5fZGJpQHO1OLE3MWrBAPjA+9OVMWp2Qp4hieFe4BLtl4j11WCgXH6aH7+JXpfXFkEckJIhGu743Y5MHHXRq2v3rPe7kN7rgBQ8xfzO9EsHmgJefWJbOMq7wfrNnALX2f9BB3vVZSbXMh7aWGAqmN57tU15ljyu0zjSnhXn/y7y0uvbWl+NBAAFEhOfbazpzVOV3YRdEi27PFHnK4oqXPSkCyLbjOnpjaqrhQWHIu1ijj5onZZhrPHIODrVYI1ryHDn8Nt69LYUL2/JqeGsI/wydwM5vIxulptN1/bYQaJu8wIHeJMEQ3WZ/NUlsKn9zClPHg9ofczl4y4WubLsH59MhYg5Cmc0iVsWihp+Ig== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(66899015)(83380400001)(86362001)(82960400001)(33656002)(110136005)(38100700002)(5660300002)(38070700005)(41300700001)(52536014)(66476007)(66946007)(64756008)(9686003)(4326008)(107886003)(8676002)(122000001)(8936002)(66446008)(66556008)(186003)(2906002)(54906003)(55016003)(316002)(76116006)(26005)(6506007)(7696005)(478600001)(53546011)(71200400001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ARG0Oza5rtK9+BaEH35OfREod3uqHlf5kuUjmVWsx83lE3YI4r4B682Y9/XK?= =?us-ascii?Q?ImgaNmeM8cABWlpCgbUrgL0DrCdMohj1FsD8zn2kZhY8GvLpNCpEvZWA3yzW?= =?us-ascii?Q?eAj5cLAM50Rk0iNqu9atET26utigggjBeaCXbk+V+0Uaeg7Dh+C1CR5ZkyO4?= =?us-ascii?Q?gNwiyA3tqTnN8mU10bu6Da3qikTZdNoyf5FmS8Yerc0q8MjsRcOY9mgPJAn5?= =?us-ascii?Q?i6C+1uzvAZcyQuzxmRC8ru6TCa9YBiDE5G/cdhGGLk6wxA9YZPNH0TLKAqw0?= =?us-ascii?Q?HIG7Fv8WAncjAGUdUKmWTX7FVYi9RLXWnsx05LbiXTSXPEcRHMK6Le3zJjXb?= =?us-ascii?Q?dKq7F8ArVfJSL9mbfGYu/o0apnnrNJoCUctHYYpCXks2OMrviDyih6i8RcP1?= =?us-ascii?Q?FHik6V2au1H/9nsFtxwLF9AMcD2f2D2z1rxGAZ9hZXDchjxc27CkXb8R8hxa?= =?us-ascii?Q?D1JzVSZgFuSa2rcvYQLohu6B7YgEKsDgMVmsl2jzAZELFPMhLu6+GZ/ritSz?= =?us-ascii?Q?rwVbHgO2l/J6Mxn67o4OnJRYguyeiaaxtrDigPlw8X3P4ZOYZeA9M3WxCz63?= =?us-ascii?Q?cvFBj+XPnFoTsTJ2UtNMECr8ljKZKXX5wU61SPcnSCPwUzoVfimRPonPo38W?= =?us-ascii?Q?OOKq2+pdSdT57R7zLSjsihsPgxwxa188wxPOpkPQ3P2hC+ZtUpspQzi1Nygi?= =?us-ascii?Q?ZsXEbIy9XItwuoqarlVWFWuzLeQjwJ5zfyQdDVI+OKNgF5c7M9+YSprI283o?= =?us-ascii?Q?oBfb8icYjRdvvWcg4SbxvpeVQmAjzxY/9L0qrfXx33XoAyZdERMkZkMkit3L?= =?us-ascii?Q?yrOvOlqUQm25npc7Y2VkhuxxFX157jM5NLLrSRqN/PEgg078Wtg3cQfeZifN?= =?us-ascii?Q?oWN8zOsPtuLISvQkTfV6qL188t7ATITnRZyAl6kIvr2FHjMs7S3jRMipE0OV?= =?us-ascii?Q?L0XjAyuJv6jk6eeBkZv3VOQdw7mi0NwjhcVtT/rSbXlUThf/YZs4x+7/FqWB?= =?us-ascii?Q?rMELw4ptXRUztMipwmw9czkHPJGjlUjo59S+PnqpRKa+IZEMH05GVGYIMdwx?= =?us-ascii?Q?edruZAmNqPMPxBroKG8gXW8B/3QO32oGpc1yq/Lf5sa80HrS12UuDOpW2nWk?= =?us-ascii?Q?8PPthn9uQWab6N2d2LvUHXOB4nM7CAdNKs5f4tZH/4rT4rTSPcGdbpRrZzIq?= =?us-ascii?Q?VYiVESY6IC4zA9HcTNHOU/Ae8cq+5Goe8fA0GZYxC1ugIEBCbwObPbl4z7Xw?= =?us-ascii?Q?OL8Fu0A6kNYB5BW3qMZb0R8ht6GaRZD1aTcIKzW1JgCfQsaFe6UWB3z/SSwd?= =?us-ascii?Q?aT3uk2tP4jOAfEoMKN7o1TlHsrAdyUG5nRVRShwBeYUbQr5u6CNnjZpXdIZL?= =?us-ascii?Q?xM5zLRLJqyu2hOIdmC0cvHVbIfAqN8qvJQlqe+C2vplCTNBzq5lLxyXLazS2?= =?us-ascii?Q?RMPwSUFPTgubEGpjsva164PG44HZXt2Uq9u8KipBFHBN6t4GEOBfx42Ab43T?= =?us-ascii?Q?wMMzMlgmPXAfskM/R/N7cykfp1C/nEwYaoIU8+Bemt9z+1f2nyHEKa3OS5gs?= =?us-ascii?Q?zALnURpe2WgBpeoGI3PtnpaAJBcBvwEv2Ul8qL6I?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7e7fb2-5a98-4058-4b12-08daab02f74a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 21:04:05.2847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HrfM3xerZo5UE1pEOJga/UACZQv0awb6tzjiDfsYb5f5VLttA3H2E/9O31g/nSsNvWbBC9XUe1z4D6XonwwZqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6533 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as ad00518399..45c2015953 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, October 10, 2022 1:59 PM To: devel@edk2.groups.io; mikuback@linux.microsoft.com Cc: S, Ashraf Ali ; Chaganty, Rangasai V ; Ni, Ray Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/Sp= iFvbService: Read FV header length from header Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Wednesday, October 5, 2022 8:23 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvb= Service: Read FV header length from header From: Michael Kubacki Bug Fix: Read the FV header length from the Firmware Volume Block (FVB) information structure as opposed to EFI_FIRMWARE_VOLUME_HEADER to acc= ount for a variable number of block map entries. Cc: Ashraf Ali S Cc: Isaac Oram Cc: Rangasai V Chaganty Cc: Ray Ni Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbI= nfo.c b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c index 634a44218c7a..ab1cb2ef1622 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo. +++ c @@ -115,7 +115,7 @@ GetFvbInfo ( Status =3D mFvbMediaInfoGenerators[Index](&FvbMediaInfo); ASSERT_EFI_ERROR (Status); if (!EFI_ERROR (Status) && (FvbMediaInfo.BaseAddress =3D=3D FvBaseAddr= ess)) { - FvHeader =3D AllocateCopyPool (sizeof (EFI_FIRMWARE_VOLUME_HEADER), = &FvbMediaInfo.FvbInfo); + FvHeader =3D AllocateCopyPool (FvbMediaInfo.FvbInfo.HeaderLength, + &FvbMediaInfo.FvbInfo); =20 // // Update the checksum value of FV header. -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94758): https://edk2.groups.io/g/devel/message/94758 Mute This Topic: https://groups.io/mt/94137814/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] = -=3D-=3D-=3D-=3D-=3D-=3D