From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.90623.1673309378821444800 for ; Mon, 09 Jan 2023 16:09:39 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HfZLI8zY; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673309378; x=1704845378; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qEpjJ/lyblPhAjqhpxuB5u4pF8RZF9u2tYNpPPIe1FY=; b=HfZLI8zY+OMjsWirvNC3eBIEMhL2WIbV+Oya5iFv1dcMt4PrQvAKvqll UzDaSsd+FHmxdw4lhp9z0AYZjUhNJkKN8ypwHqzW5Mmkr12oQsNcMrJfA XVi1uWiny81vAVaRRYOgSK1/ivBwvupJDnTIgLWYHGE9TZcGuFHSWAEAx kIC2SQ8jx6fWEyA037I3dJbtL9UTsIimm7U8s0gxT53PyAEdKCTdi/U8L FbYIQUZf4AN1cZJaNIDAgUhCOxaNghr1TxOtaqZx7YqlINK264zmEViAB zH1REhKXs+XgVlyqUfNvcGFZJ7fSFCkYX0aI3f0xh8B+WI07Kndioav4b Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="323089426" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="323089426" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 16:09:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725351983" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="725351983" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 09 Jan 2023 16:09:38 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 9 Jan 2023 16:09:37 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 9 Jan 2023 16:09:37 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 9 Jan 2023 16:09:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iadw4UEFd3Afi/JqS/d/uIOUz+lejPToB6VSaVLk/6sBz63UC/yY9orViPaMOmD5D6pvIWNoFTpR25gMUQmeQwJBvDElNMowsm/ZkwYu04FkRIgyy4gwobtj+Ql0Rh4jK5sv8Vkkx66fA8yqjrHlPdS3NnL+KmcoipGGSFi64B/JhYfaqper5f1DNFWkn0Ed+DQ9eqG7fYRmCsm60oquA8aY6fOg6l0QqWl113CfwOP0PyIsXLFqTracUO2EIBfAkvgS4K0ZXtabkQ2N8j61FhPvGd9amrmIGgqQ8iBDSD3wtZPZNbBVROjaf6mn6w40nBBghGFPAlYTPlIFiwoeAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wOouu7HwKZ+mb2c2kH5K4C4vRhjL1S07dYgJLSACK+Q=; b=CAPkVfQxJeYBcDBjbGpEEcEbk6Ov1bB5G3DS8kmppMZkY9cr4EmIDOoqY3oO4UHj+EhyRQ+zwkf94eb7Md4+G86FnvTRCuTOckG0/5ranstA+bdTQGox0PIrZsNwE5b6m3jU1ke9Kisgoe6EnZ4sG8b2Qt/VwkRmPCdQqZ1ugRv13dUgpLDvO5drLTCXduOrbCuyk3DRsfXuvqXXKa84hRzU8bVNFFbKDjcowfmlnNSZ4An8jnL3HxrU+V6sJiTgLcKk7K/lVrBP4ARuySvDGxJEglWK763lWcJWma8FIKA/3QiEoS9HqLLsvAYUgKn8togc6bXpiMsA/36slov5VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by MN6PR11MB8171.namprd11.prod.outlook.com (2603:10b6:208:471::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 00:09:33 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9%3]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 00:09:33 +0000 From: "Isaac Oram" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , "Ponnusamy, Suresh" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation Thread-Index: AQHZIKXdgbWYfDjL3kuuLn2bm67pAq6PJOkAgAepW1A= Date: Tue, 10 Jan 2023 00:09:33 +0000 Message-ID: References: <154285e560df24b2cf6a0a7dd9b09577dd10ce37.1672882404.git.isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|MN6PR11MB8171:EE_ x-ms-office365-filtering-correlation-id: d768d86f-9e4a-455d-22d0-08daf29ef3e1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B6boofaYUbYZZh6OI6WspK7A1ANwyM8dmK/rEdpXz4LQgdWXXfUDcwxXyeApvF54NYZCseft1lf732JbMYUT0PqQP8eJLswbWxc85bPo0YYcFu7ReQAMTShqFzANDABicNCmDHQbfbfQPv2s7DvVJo+7zz6/Wsal73ER2/q7S35FwHpQ/McWryra4dL1L0NKmEz1h941+5pIvcNMe5byydV12i2OlnIdzPEZiByUH121Zc/FYTYC2vCD4A5+on4ZIaUL2yZgOcAV2UY74T9WywPR6nrvuMQVoE2BHG7RIGo158ug77u+Zb6KRu+mKgPTOc2aVvKEDveIOl80OsY7GR6eaT1mRoDjnm/nKHlp4fx2lMkYudIyUv4S1bROfQ1nN+q9XY1/WmttLkhVKU/F2Z7nlubtHfvv9dDG1Q0erwf4llWEDAHoxdJ2SbgRg4D/19SEsEgzOba4Gqjuwi8SeioI2OBHMydtgsfClnbfDH045qsMmGowIHVq3r8patYVDGcRQUgnFl7AX+HCHRKt3rOGrapKQwMr1FxO3pmfCcLsW4As8t10M/dWeJ8UEJF9MYmbjviBFLc+wapKmK1ZpGcl6T6quclFQuMZrp8aWIM5YZPgpin9s+n7FeM1cIac4YI/cEiazgEClpT46AJe6py14t6mdytsGRbDK19l9pDk437COOyQdSMwXPAPStj1Zj55M6xPyXbP+vguLzb6vg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(396003)(136003)(346002)(451199015)(53546011)(2906002)(71200400001)(6506007)(7696005)(478600001)(9686003)(26005)(186003)(55016003)(316002)(76116006)(19627235002)(110136005)(8676002)(66446008)(66476007)(66946007)(66556008)(64756008)(4326008)(41300700001)(54906003)(5660300002)(83380400001)(33656002)(82960400001)(122000001)(38100700002)(52536014)(38070700005)(86362001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C2LjoMxXoltBExXxiedrVV+ZOfzCqMzaFra1xhVFUXuH0DudaTfLDlcvFx5d?= =?us-ascii?Q?gXa102FyOTkyIIc1G4DBt7Sh7B5Zn980bKCGhD/7HbRpsEoIlLcfQ61IjKZr?= =?us-ascii?Q?zSCduH+VEHhCFLg+q1iUbrPJqCoNurrdsgw+YfERAn2GCQ9HXN3MHIQOGvqS?= =?us-ascii?Q?wNGafBv9AIB+zx7mFzWkOLA/hQW8Phb04MS4ipEPx7YgKZFxW8lFIqO4p6bZ?= =?us-ascii?Q?+nUNB3Ml/0TICIn5tdcB31NpNKzgxG5HLG2T2bIirpvjcpWJ8PrPe1ck2s9r?= =?us-ascii?Q?2GrcEJhhyrFOizniwqeuWyWC0Rar7pNX2ktSiiwhUCNsNJMoXWwVSJAS6qA+?= =?us-ascii?Q?dttDUJL9O+0yAIc5VYo0za89N5MuWEsup9XS3lo1ITllzXCJB1hkNtfyHxNp?= =?us-ascii?Q?wCuXcL+ihSf4W57VdhA84KR6pfyaDETJ9I31WHeMIrGu7gstG33gjRB4oe+r?= =?us-ascii?Q?htkme9Ls83WDEMA80zSl0grJpGlmI/CzilgtOv4BMPnhqcudkPeQbugTQlZS?= =?us-ascii?Q?5jMobxDmWeT0w8JqdONPjWb1qo5zk/wGXAZdbZ2Ah+BOX068D5N7bS7cg21l?= =?us-ascii?Q?WJosrjH+f723z800xzex+kCtGDwy2i09UCgXC3/tbgCpO86DISSn04AX0cBO?= =?us-ascii?Q?EyZhK8uaiJOdszOO0Ly7H+/NUhb3BaAqgHLfeL4IU7iVzRGShC3vtaFLibt/?= =?us-ascii?Q?f125Ak9aO0x+7PKQC7ChxcvsX1N4bxVfdjjFY5sZBUGQPTP28skkx92qU/MM?= =?us-ascii?Q?bTrsX9wBun0Hu8ZoTRbeVEDQXbJoZDj9Bgr6C99DmaoESB4QOj+LptOaweaT?= =?us-ascii?Q?XFA02Liyt8BFn0fTVCF2tiCu97nZteGHEcIkZTEL8j2k/z8rmLauA34L/wbI?= =?us-ascii?Q?N2X4wuj6tSYFcQ57H3j45DtTPKhpDwMaX6iGsNlkwyrscFyK6A6saPjDt9cQ?= =?us-ascii?Q?v3d8Y3v7Q2rXmn7wZ7g0VUg7lXdz0ojqgEwsbCUWsfUhZM8nNTmcQMuW/WmO?= =?us-ascii?Q?Ce0YTRZvWCcCzW2Wv63nojBCSziXdbzTglPE2G/5OJ1NtlRcXeRUrZIjJ80z?= =?us-ascii?Q?8InBG+te5PnEuShzjxQU2a8oK5A5ajcKMNcr4sKXNWzBJTJNslx51qC6+w+w?= =?us-ascii?Q?GSw+wnmxK5jZUaugiwe5VrBjOyKbSvnqYTJYxdWrU7Bbp2tYHOt91ADZaMSN?= =?us-ascii?Q?SPeSyhj4f+dGUNUXsl57iy0yVJGEJvp8ECFtJk/qUFHoOd/aRms2DgupTn0j?= =?us-ascii?Q?MXgx1e8ExTZJunwh7VewnEI55eX0nhpvQBTd9wuBn/KwRy2FDqzedvB5ibDo?= =?us-ascii?Q?HNto9PlJmk2Ud/GnCSSyQSSe0o2DXywiRogs5O12cCOMVdBOwEVtlXk7e15d?= =?us-ascii?Q?MZhUO3y+88Dl+Vt1aCKP7VXT721J23j+c3UrqSc61aL9FZXBXkGqi7qn31Hu?= =?us-ascii?Q?gylOg4u2Yr6n2ROZlEvUflN6orbmTNkVVtnSAzuy+4Ei3c37Lg01ho9D1Ewy?= =?us-ascii?Q?QptL6v0T+aXdYLdO5SG/lEAFlSkzDC0Pvv4nChy0fWOmHfAcX/WH0mCGwGTL?= =?us-ascii?Q?J/kTtKk2SBfZDBB4LWNFPGKhptA/XIJESUZd55gO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d768d86f-9e4a-455d-22d0-08daf29ef3e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 00:09:33.6562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qs3NsuTXX8VXkzHnuuVVzGvM+I1BDnRKgkBFMTjGhwEKjTtJXXFnA2CNV8ooGc7BM9Fedw9t/Vm5kisYQjyeEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8171 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as a57865b571..3e0f5b21c9 -----Original Message----- From: Chiu, Chasel =20 Sent: Wednesday, January 4, 2023 7:09 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Ponnusamy, Suresh Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg= /AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation Reviewed-by: Chasel Chiu > -----Original Message----- > From: Oram, Isaac W > Sent: Wednesday, January 4, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L=20 > ; Chiu, Chasel=20 > ; Sinha, Ankit ;=20 > Ponnusamy, Suresh > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation >=20 > Block length incorrectly calculated off of the block width. > Reverted EFI_ACPI_GPE0_BLK_WIDTH change and added #defines for > X_GPE0 and X_GPE1 contents. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu > Cc: Ankit Sinha > Cc: Suresh Ponnusamy > Signed-off-by: Isaac Oram > --- > .../Features/Acpi/AcpiTables/Fadt/Fadt62.aslc | 16 +++++++------- > .../WhitleyOpenBoardPkg/Include/Acpi/Fadt.h | 21 > ++++++++++++++++++- > 2 files changed, 28 insertions(+), 9 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > index f37cf0a508..b7f15ef716 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/F > +++ adt62.aslc > @@ -143,19 +143,19 @@ EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE > Fadt =3D { > // > // X_General Purpose Event 0 Register Block > // > - {EFI_ACPI_GPE0_BLK_ADDRESS_SPACE_ID, > - EFI_ACPI_GPE0_BLK_BIT_WIDTH, > - EFI_ACPI_GPE0_BLK_BIT_OFFSET, > + {EFI_ACPI_X_GPE0_BLK_ADDRESS_SPACE_ID, > + EFI_ACPI_X_GPE0_BLK_BIT_WIDTH, > + EFI_ACPI_X_GPE0_BLK_BIT_OFFSET, > EFI_ACPI_6_2_BYTE, > - EFI_ACPI_GPE0_BLK_ADDRESS}, > + EFI_ACPI_X_GPE0_BLK_ADDRESS}, > // > // X_General Purpose Event 1 Register Block > // > - {EFI_ACPI_GPE1_BLK_ADDRESS_SPACE_ID, > - EFI_ACPI_GPE1_BLK_BIT_WIDTH, > - EFI_ACPI_GPE1_BLK_BIT_OFFSET, > + {EFI_ACPI_X_GPE1_BLK_ADDRESS_SPACE_ID, > + EFI_ACPI_X_GPE1_BLK_BIT_WIDTH, > + EFI_ACPI_X_GPE1_BLK_BIT_OFFSET, > EFI_ACPI_6_2_UNDEFINED, > - EFI_ACPI_GPE1_BLK_ADDRESS} > + EFI_ACPI_X_GPE1_BLK_ADDRESS} > }; >=20 > VOID* > diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > b/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > index ebfd21b6cc..8857879370 100644 > --- a/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > +++ b/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > @@ -152,10 +152,19 @@ For Watson Creek we set this to 0 and then=20 > dynamically update this to 1 in the D // Information // #define=20 > EFI_ACPI_GPE0_BLK_ADDRESS_SPACE_ID EFI_ACPI_6_2_SYSTEM_IO > -#define EFI_ACPI_GPE0_BLK_BIT_WIDTH 0 // size of > R_PCH_ACPI_GPE0_STS_127_96 + R_PCH_ACPI_GPE0_EN_127_96 > +#define EFI_ACPI_GPE0_BLK_BIT_WIDTH 0x100 // size of > R_PCH_ACPI_GPE0_STS_127_96 + R_PCH_ACPI_GPE0_EN_127_96 > #define EFI_ACPI_GPE0_BLK_BIT_OFFSET 0x00 > #define EFI_ACPI_GPE0_BLK_ADDRESS > (EFI_ACPI_PM1A_EVT_BLK_ADDRESS + 0x80) >=20 > +// > +// X General Purpose Event 0 Register Block Generic Address //=20 > +Information // #define EFI_ACPI_X_GPE0_BLK_ADDRESS_SPACE_ID > +EFI_ACPI_6_2_SYSTEM_IO > +#define EFI_ACPI_X_GPE0_BLK_BIT_WIDTH 0x00 > +#define EFI_ACPI_X_GPE0_BLK_BIT_OFFSET 0x00 > +#define EFI_ACPI_X_GPE0_BLK_ADDRESS > EFI_ACPI_GPE0_BLK_ADDRESS > + > // > // General Purpose Event 1 Register Block Generic Address //=20 > Information @@ -164,6 +173,16 @@ For Watson Creek we set this to 0 and=20 > then dynamically update this to 1 in the D > #define EFI_ACPI_GPE1_BLK_BIT_WIDTH 0x0 > #define EFI_ACPI_GPE1_BLK_BIT_OFFSET 0x0 > #define EFI_ACPI_GPE1_BLK_ADDRESS 0x0 > + > +// > +// X General Purpose Event 1 Register Block Generic Address //=20 > +Information // #define EFI_ACPI_X_GPE1_BLK_ADDRESS_SPACE_ID > +EFI_ACPI_6_2_SYSTEM_IO > +#define EFI_ACPI_X_GPE1_BLK_BIT_WIDTH 0x00 > +#define EFI_ACPI_X_GPE1_BLK_BIT_OFFSET 0x00 > +#define EFI_ACPI_X_GPE1_BLK_ADDRESS 0x00 > + > // > // Reset Register Generic Address Information // > -- > 2.39.0.windows.1