From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.1986.1662734293807345218 for ; Fri, 09 Sep 2022 07:38:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=izgT343T; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662734293; x=1694270293; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ucGSeOb2fOOjcoGvD3b7b8KEnj2sdlqSBJ+xc6ILyCM=; b=izgT343TpzfrZ/tHDlF2/eVlMK1Cm0XkEjEBGFftIp9MZEt8ZGpKBms0 6AyYO7MPcm50swSSqaA7UeV/Hzkr+Xo3vlZvfYSZH2Iwf6RDw9YH44TxW xK3i6DJAD6OX4/AZWnCGkF2i7hBBPenp6Zkn+/kgqCz2P4wTMepxaWrQp MxTIVYvJbUalTygb6VStH3hRrVJnrx4yEvZ/1vRfq8Bx+5l0A26qI6RQX Re/R+SEGqc+6vmU4POFalxMdH0Q714scTaVUrllXzFjCp84Fa3rerwKZX iy1NgkrcorJwpWMxdbbBfKpEuOZAlrvc/Erq6s2VvKAEMnzd2i1QnhO+z A==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="359210153" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="359210153" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 07:38:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="611076634" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 09 Sep 2022 07:38:13 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 07:38:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 07:38:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 07:38:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyI5vhY6PiQH7dAdz3UkLx+QeTrvfwrnCj2C+zKOc9VXdfu/KsA824PGU3qGLvVNc6Ta+NzqccGriA9l/SUp/E0cTjW4+roichX1M6dPghuKnyma49V9p3vykK6HEheluq5NQ3QM2VdemuozVDP+ZeXq3/blu8M0Ro635Fupz0t93t7mSaMBxtyct1yAj1Lv8c0Yf3hq1OYDrPTCuDHuUB2D/Sgc06gpVKNsLeQO62YOu+O5vBK162MB+W2Sj8WtCblv3PnQV/cCfItCThBx7qUqIoJnwj9F6JnBKNcZjzUrl5QWS8tnRb6MMXSmy3Be6/BO6Dn1H18Xuvf2UCR64Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sdNwNSvU3X/CCNFYEp1iAjdqAMIjMF045QBLks/tCdk=; b=aEYYeqNLNh03+A+XG26PRLuw9nnOGxXdnwsiRix1yCKMnFvJsLpBSeOkLdwkJT9LE4kFnyEmkfXRbLRse55OzYuaKyU13DLCZ1CtIAdWY5fVbk0rMNvp5O9I/o0EitdEHBcZm7urq59MdXpjEqxax7c3ORc7eqGlA8KZVS7Dqr+aqtm06R/Q9JGmj/k4IEwGl3MxNdSKSAkgaT7OxYyMwlmNEw+GqjV68+mr/VYWfFYM0pl4o2H+DzhzqxLHU2lln+tW5ZOLqBXeksu9Poy1DNAhDPwV73/0GxapoeLXFl8lxD62lRugeTA7fYOJDaLJSc2GOVIm054BKR5zLF+F4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SA0PR11MB4655.namprd11.prod.outlook.com (2603:10b6:806:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 14:38:07 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::4149:e96e:480e:e1c3%5]) with mapi id 15.20.5588.010; Fri, 9 Sep 2022 14:38:07 +0000 From: "Isaac Oram" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Sinha, Ankit" , "Chiu, Chasel" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Thread-Topic: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Thread-Index: AQHYwhX1W1830jSjL0ikqfRDyGqxya3XLshg Date: Fri, 9 Sep 2022 14:38:07 +0000 Message-ID: References: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> In-Reply-To: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c8734df-591c-402e-7e62-08da9270e942 x-ms-traffictypediagnostic: SA0PR11MB4655:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZpZ/pp8IJnGQ48KlvxIyliXUDAYWd6pVv+dY9flrOMlZI1n3DFskPvbs/ErujYlTF3F+Iwi7XtSKSYXfVJ8OPnl1k+iSVQcf5hk+gr32ocIhwGTDm9eloWZ9tmqrinCMyacGZmXuswQqp2qpoCfKhmHZihVGJoLnG4abUQ5T2TbmHQP4Ou+NlL1KRPD4HFBTmw/APmFtyaVW1kNALlFpILcODnR9UVrgBl27W4JRdggs8L7slz0vJCwRUIKoxOn6MGgFH3IGOzOvJnrkmLvvyP42tg3swwz8R4OCedFlLuuPqBBkYMRPBKAUIjRCIm24rIeFxe33PFSDfQFXMdNn9IL2yKKIEGAw6mj4kRwGF9Dwo7Hb1K3KONoyOHsgqhqOzldIlEaEWcnEqp2rZwFtmccJIsRscHmpGtFlkwg/qSkSK1iUI7mPzmCvGQQOmtZHFQ9wWrnmHlLnpDvnynClP1MRIkObXqX0Ecua6/UfUOFmTgIQ2PF03pSsmUe/0Gxg1tTErURBQBFwOVhZODw7U5zLnmz/0XJ6GbwUyebVKAfSSaHiBDlpXgYN/ayUGumnZtWZlA43igVH1fO69yK0STGYQDK/ZGn0U/MyjthFyXStBMZQNtHlMm7dnyXEIn0Hf4UMIWZ5g4tYtjfLBNDL9A8mGl8taB+QYpyMYFBPdduYOhjG5n+dazY/L5CFk4l3WPvDeQdjAD/ulXoP8DiHY5tU1YmkhvDf2szmKYP6fgwxPznZ+2yA+dVmf29rYyrtt06bvb+87PEd5ZXcadUbwYURy+1bDR7JiS7Oaq38mP8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(366004)(396003)(376002)(136003)(38070700005)(122000001)(38100700002)(82960400001)(8676002)(76116006)(66946007)(66556008)(4326008)(66446008)(64756008)(19627235002)(54906003)(66476007)(316002)(110136005)(8936002)(2906002)(55016003)(5660300002)(52536014)(186003)(83380400001)(478600001)(71200400001)(53546011)(7696005)(6506007)(26005)(107886003)(9686003)(41300700001)(86362001)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?neiQa13kWUdW0lPPwelAqymWZGkZxvvvRiqkB2iwPKzk1ys21nQKiEs59V/R?= =?us-ascii?Q?IAhKBRtty64YjeNW+S6HLqcp4y1scKLLoX4kw7KV4CTNTAj+qMHf2r8pYWYz?= =?us-ascii?Q?2i84jiPODaoxnXXDJk5SyzRojClKg3GU8vaKcH8Rj/M1feStrcH+qHYQpf+o?= =?us-ascii?Q?LQZHPLq+LR6z2wHRWCwsUxY0iy0zCgLtDsF7RmXxroy+MGgZ64xHQB5u3v44?= =?us-ascii?Q?Nr1Dx/iYuEqPLRZxpipVO9JvXR10ZglnY2qCGUHoze93CVGV6JdkdOcpKtOF?= =?us-ascii?Q?BaZPFoyToxRxpT0xTgxjpIeS84qJ0iCpagVPPYjO1WN3wl6k7CUdr0UxuEbG?= =?us-ascii?Q?XTgGTg5FKruf1rXOo1kRxOjxQJxHL09UFFb6AaJ6fbKpZR15U4Jb0wSsmhay?= =?us-ascii?Q?ZaMPys6tF1e+zjx7tWShyPmjOjQhTzjRCiS6ei22HYVnpIa/zckVuH5m64Ra?= =?us-ascii?Q?tTG7uCzp7pyTug/76nL6pLFo+fGwXIcxkGBdO0LyL8bMalcgTuSIy8fRYuBj?= =?us-ascii?Q?1O/YfbH6j4Ph1u1v4MDQPpY+QEokLbFMLDlYPvSTngZxl1KVBIwQFec0fi0a?= =?us-ascii?Q?HLcvYBQug7NL/VNyx2ELwEi8F/EBMtTyfJjcnTDKQAPVdY6d5l3KWCEEk4n4?= =?us-ascii?Q?P0JdbWlspcSIljMksimUKgut+CSW1lmAuZpex6b20i0mn4Tf3ARiNqFJY47e?= =?us-ascii?Q?qY8nZQdICZCDDD3vbGmG8/eClR84a16TFFnFJgUVKpaNyUGPPK7LBci5qH+3?= =?us-ascii?Q?+qZduQ0dX55mxLp+7JL8egtKJA/yrZcBl4bT9NlsaCpkxV8Q8ke0GNPKL6I5?= =?us-ascii?Q?SZeKzJEkfQ3PywiBHYzQXU+Rr566ZM+l/S+SZ4F1xdUZCaLPATn2n/+GqOFE?= =?us-ascii?Q?Na/vP9m6ebrSV7/0nsI8eZo8e/5mQmCtUOobTgeK3PfDddM1H6pJyQX+xGpY?= =?us-ascii?Q?QSRedT+qnAduLCtovljwEY/xDgxscuC3/52OfaDSVTjcUs5KrNPr/CeBMHL6?= =?us-ascii?Q?cWDsOOEUrq0E2xRW/cwMo+I/LgzugNxH7cJwV6mOoPLCfqrj3o+RoPgv6/+N?= =?us-ascii?Q?bFDIGsrBxOGoeosiGFB46dTREADHzpMV6O89KX/jL6fQ6YkqQDaLf5TeiCl6?= =?us-ascii?Q?1SR6gjifamw9+RPDAsW1kct5Mv7EoGgn5mQrb+mfGgqnbtx8fOOoKI4Nvw8j?= =?us-ascii?Q?FqbVAmS5C93yqccEVxv9eCiCqVhHNVr8RcSFCpXwxmwldUAc36Yd3RMIiH8b?= =?us-ascii?Q?CrqKIIQTilb738R2SICNYChEa51OYZOlxqXNZMck2ix1xZhYN/CLFjJFRq8e?= =?us-ascii?Q?m5VYUytLpvm3dgY4oFlE6HChmyoaxzitXAGb7YS12rnh7l9J9nek3shTTaSl?= =?us-ascii?Q?wrQnffOHKwlQFnGNAHXAYvFzDzgWjopL3xJNkTyUTlGMyVjZdN7iIimMfufy?= =?us-ascii?Q?lKu6mb3YpXgg+OSepBMOCJjwD00e1pQSzFYfSmWc4NkJUSuh++yoU179owD2?= =?us-ascii?Q?y+kcMbSpmsP/ZEkZVx5BYMCNMPZr+TRByiGCny8jBq/6uGFFSrEQStWtZiWM?= =?us-ascii?Q?hwHMdHlUcV3owUxpEY2JM1+doSsuyG0A1spvSb1n?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8734df-591c-402e-7e62-08da9270e942 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 14:38:07.3475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G1T6VQfnvEaiWb/DiqSLjqbXSgWyRzpFsM+yI/7umV9qJo62TVwff1w4HEYKu04PP14QjUMxiEWNX5GWdmEtZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4655 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series should have a cover letter. Please rebase the series and send V2 no= w that Nate's I2CHdmiDebugSerialPortLib has been merged. Thanks, Isaac -----Original Message----- From: Benjamin Doron =20 Sent: Tuesday, September 6, 2022 10:27 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Sinha, Ankit ; Chiu, Chasel ; Gao, Liming ; Dong, Eric Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,Whiskeyl= akeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib SecBoardInitLib is called to enable serial port before SerialPortInitialize= and DEBUG(). This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in S= EC phase, which presently initialises this way. No testing was performed before, it's assumed too risky unless the GPIO hap= pens to have the desired default. Presently, DEBUG() works in SEC phase. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Ankit Sinha Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Li= brary/SecFspWrapperPlatformSecLib/PlatformInit.c index ef89e3f31018..d74b07bc062b 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/PlatformInit.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat +++ formSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange ) {+ //+ // Board/Silicon initia= lization+ // Prepare controllers before enabling serial port+ //+ BoardA= fterTempRamInit ();+ // // Platform initialization // Enable Serial p= ort here@@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); DEBUG ((D= EBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); - BoardAfterTempRamInit ()= ;- TestPointTempMemoryFunction (StartOfRange, EndOfRange); }diff --git a/= Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWr= apperPlatformSecLib/PlatformInit.c b/Platform/Intel/WhiskeylakeOpenBoardPkg= /UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c index 486c8c72616e..53f95c29bde5 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/Se= cFspWrapperPlatformSecLib/PlatformInit.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library +++ /SecFspWrapperPlatformSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange ) {+ //+ // Board/Silicon initia= lization+ // Prepare controllers before enabling serial port+ //+ BoardA= fterTempRamInit ();+ // // Platform initialization // Enable Serial p= ort here@@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); DEBUG ((D= EBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); - BoardAfterTempRamInit ()= ;- TestPointTempMemoryFunction (StartOfRange, EndOfRange); }--=20 2.37.2