public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pedro.falcato@gmail.com" <pedro.falcato@gmail.com>
Cc: Theo Jehl <theojehl76@gmail.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe
Date: Tue, 9 May 2023 22:13:47 +0000	[thread overview]
Message-ID: <SA1PR11MB5801BAB34DFD86EE63524B1ED0769@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230509161439.288422-2-pedro.falcato@gmail.com>

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato
Sent: Tuesday, May 9, 2023 9:15 AM
To: devel@edk2.groups.io
Cc: Pedro Falcato <pedro.falcato@gmail.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Theo Jehl <theojehl76@gmail.com>
Subject: [edk2-devel] [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the generic version in MdeModulePkg.

Tested-by: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Theo Jehl <theojehl76@gmail.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc       | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
index 283c235b44c0..5a63848f26cd 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
+++ b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
@@ -21,7 +21,7 @@
 [Components.$(DXE_ARCH)]
   OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
   MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
index f5c317c83e6a..b409a6164412 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
@@ -160,7 +160,7 @@
 [Components.$(DXE_ARCH)]
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
index 5af0f0f2faa2..b106828460a9 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
@@ -266,7 +266,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize             = 0x800000
   INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
-  INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
--
2.40.1







  reply	other threads:[~2023-05-09 22:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
2023-05-09 22:13   ` Isaac Oram [this message]
2023-05-09 16:14 ` [PATCH edk2-platforms 2/4] SbsaQemu: " Pedro Falcato
2023-05-09 16:14 ` [PATCH edk2-platforms 3/4] LoongArchQemuPkg: " Pedro Falcato
2023-05-10  3:16   ` [edk2-devel] " Chao Li
2023-05-09 16:14 ` [PATCH edk2-platforms 4/4] Silicon/Armada7k8k: " Pedro Falcato
2023-05-10  6:16 ` [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA1PR11MB5801BAB34DFD86EE63524B1ED0769@SA1PR11MB5801.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox