From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic
Date: Wed, 12 Oct 2022 00:10:18 +0000 [thread overview]
Message-ID: <SA1PR11MB5801BB679B808E9274DB2D72D0229@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB5821776A370E2179E5BAE0AECD229@MW4PR11MB5821.namprd11.prod.outlook.com>
Pushed as 66cef08cde..ee8d078e39
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Tuesday, October 11, 2022 5:05 PM
To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com>
Sent: Monday, October 10, 2022 2:41 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic
Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c
index 28117ad460..a884c9745f 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi
+++ Platform.c
@@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall (
// Install the table
//
AcpiStatus = AcpiTable->InstallAcpiTable (AcpiTable, CurrentTable, CurrentTable->Length, &TableHandle);
- if (!EFI_ERROR (AcpiStatus)) {
+ if (EFI_ERROR (AcpiStatus)) {
ASSERT_EFI_ERROR (AcpiStatus);
return AcpiStatus;
}
--
2.36.1.windows.1
prev parent reply other threads:[~2022-10-12 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1665437608.git.isaac.w.oram@intel.com>
2022-10-10 21:41 ` [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Isaac Oram
2022-10-12 0:04 ` Nate DeSimone
2022-10-12 0:10 ` Isaac Oram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5801BB679B808E9274DB2D72D0229@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox