From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.14947.1665533428164072431 for ; Tue, 11 Oct 2022 17:10:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HbPesPaL; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665533428; x=1697069428; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8y2UkC5Q0KWvWu9sP+JSkQ+xl6yLhq2tNdRCpFjsnss=; b=HbPesPaLFCEwheG70CTDzn0duao0/BtMqLrLmS3jP6jL1tmuy999HUgP 0XYghlum/GqHiiyGH71sWOuhvsoik8evNkyyzXjCg/CzT6UWFnzwzYyyH 0yKrebZJ10c50ushMRr+Yo0om1x/wSV8GB433P5Xnc62INoLdE3RYxjDW zSsLdNFJcAJtELuYuojTOJ75H8D5G/88cosW80Hm91X/s/XHY5mM/K51z f20s6cSseyFWtJmcGTYaUpe5y8ragzckojB6bx2f2+E3JFrrCEe2/3sRH weoESvCCE2CJwiTVdR9OGjp2wL457NPJfE6YoRQQxvy2BfTJFxwbbO9qZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="306284032" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="306284032" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 17:10:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="628899490" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="628899490" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 11 Oct 2022 17:10:26 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 17:10:26 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 17:10:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 17:10:25 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 17:10:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WITcIj0Kqse5QrOdT8sHBoyZfCb6yh1jZ9aawzl27EvH4DB9Wx0ZkXqujdv0gmTGUFQKuZa/wta0lgLJ8Z6fUDHiJ2Dnr5fL5ucusgOPQLwfPbpGbGoR0qd5Sgisyx3mXvK5UHbNyCcc+BqmvUnUJBPoA/KKOPUa3KuDLWvVFpax/ryO7D3YzHG+L2ruvhZ+QwmOxCi1vzaENXN36L6UjPhXm3bjKQegICW3eUjQdl/azqgeuDgEK7ERYqBzwk3ZTYoiSnl9h4rxY4Y1UpiVKpmrYKd9YowcuvngD5vubRbkTaO9W6oyVm7ORK/v8I3oqId+nUPN31+95izhDpdT9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJBN3RSrGqs+lwFSOUdiICfMTzFV1bAKjUPeYuIeCn8=; b=fly8yW866LjNnq3iyIl0l3Epj1VgMEBLwyL1cvvbHzmXbDFzivgALIk7cTg1EscUK8jQWsqTYAoMKHn13BLIuX7okCaqLxBsTq2V9PrwqZk3QThahZMIN1knjn7AKl2GlQEf1QIDDEghRIdhDJA99oeTsSpZ4FR1WShkZWZrkznkaoYmhjWcpU2Xc8+GBIdP3x9A7BqRgBHVqeLa3MW6T4MQx9rOz0pAzOonQfgvb5jRVjB8hOij+XFn89oksr+u1UJFQd3JDLnCyAMQg2PcfP1lP+OnwIKK+YzlmaoFZJaqTYStzee+egzXoDJwITh0x8MpYMmADvmjKLK7sxECfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by IA1PR11MB7385.namprd11.prod.outlook.com (2603:10b6:208:423::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 00:10:18 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::53f5:67e8:334d:a940%3]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 00:10:18 +0000 From: "Isaac Oram" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Thread-Index: AQHY3PES+yWdBDFuzkiekxQvB9eaZ64J4pqAgAABgBA= Date: Wed, 12 Oct 2022 00:10:18 +0000 Message-ID: References: <1b764cb06aeea4b029e2b2c4b3d14fbcf7dbdef3.1665437608.git.isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|IA1PR11MB7385:EE_ x-ms-office365-filtering-correlation-id: 731851f5-847d-4de6-bd3d-08daabe6255d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LrepDBn3LveS0383w/ITu8lwWiQJIp080hpqJ6mNj0uJnlGiaHw4ybpox9V0SPCx2W7BKl4H6rqqUn+6BX3tyBR3/rJYWdx2SlCtWm4x4RbHjwoJyifR292qYo/owvP+SCLIMfbZnnfCCPto5lScZY4+qXihPgN8nzE7xOYJlJg/FCStdOuckFCQyIDpr3NLM/Vcn9CJEp467JXd2ADpsvpvefaYbQAStdOlMIxqB66qGhkYEtYf5pxAlI7aovKa8buVSKPafobrvfOhqnFeTKu38wwhb8Mfut+IjFJ23Pehi78zO/ey1EBHQP0eUPeDzmRBZiU9FyyNKpaiwW6TbQ8Ni/TQzS30Ct9dvKjZjtR0CQyEk/KNyieAz6altae4OznrMUa72l5wyhuZb6jWknhbb/lE26wC1HFSSH8U8SunQMbQuDnFH/kLTaz3YxDn4I1bEU0rAWPCMLtNfbwQhY0dOmRFnQDwPq2WWW5kC5M9CaweveQUv9yn5VHHPTBqs1qxxjw5yA7CXK7WtSU32UXSYihVsNW9NN6c8sxCGZqlIF4Zi4HWhNX/qT7e3dkWG75mZF3gj4DegEbTMKdsmvXizhbEZtXb3BktUyciaIsA+KxDDxWZU9yBZjhzxBvvSSgubvJwnkPpi2zRawhuQ4aamNTLXFAEJbmo7LDmpRKWmtFJL/dkb42stftNPN4mTMLbMG9FiMogHqkNUIX2G0ssyemCQFWRnCudz2aBRnG0ACbY3UonmVZjhIheaUu8Jysp/CUY6CmtM6Lw4ODV5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(346002)(39860400002)(396003)(376002)(451199015)(2906002)(4326008)(8676002)(316002)(66446008)(66946007)(66476007)(64756008)(76116006)(107886003)(5660300002)(110136005)(52536014)(41300700001)(71200400001)(478600001)(86362001)(82960400001)(7696005)(6506007)(8936002)(33656002)(53546011)(83380400001)(122000001)(66556008)(186003)(38070700005)(55016003)(9686003)(38100700002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9Zh2w4CNvSgrrno7MUXd39x+hFnC50KuQQtKXMQgB5AjLcGOSS3WKjW2l/Fx?= =?us-ascii?Q?nd9q4Lt9xS7BIsoUjqprBAL8Exo9SeQdVHNtqgkF9a3WVBS87ZMmvQiG8FKT?= =?us-ascii?Q?eZrODcEl0Q5TzXBjQs5gJVsVyKyiMAvlvySCo9BRacMRlBhbkoph3ohWQ5fv?= =?us-ascii?Q?B/DOq+QiGFs288xcEHBeqIll9uPlOoPyr63yjN+0o+NKC5/Z/xwBkwnyvzgx?= =?us-ascii?Q?ld6N1h7ghSZsoDwmWSyrQfMATDJ8no2w9CjFpujaNcmUOBaZMWT+wq7TGT92?= =?us-ascii?Q?bSMLWFScETvgwQwvnK6ox2Sfg2LEjdNOP/nKdBxY/nhIBp30kdrstwRaeMSZ?= =?us-ascii?Q?3BYtpBtA3tfbb2D3nWX6ROITBEkYl64s4fU11fYgPoNMhcqzXqYcO8NA++ck?= =?us-ascii?Q?XtgEctUa6HdGeAAT47UqHYzu0bpQ9QdAStTFGQ5rQ1fG0pWRT0AH+Mx/X5Xa?= =?us-ascii?Q?mBZ6QWeO2MmRz5MKS/xN++rRKtLQcYBXhd8D+z29mONjaYmCJiqcIS6bGH6w?= =?us-ascii?Q?2KtrU9UeJUtcaLQfoFCtVhp4xF3KO8raIWJKggwS7j71sC6EEvTqEoGmhxqj?= =?us-ascii?Q?XWfZd7t2EdPFqEx7Sz/ezXLkz6+N1Bcx8LI+VbnMeRg9S7th5/Gbb5fpT9GH?= =?us-ascii?Q?EObMdd495M6uvUrHRvieUDmcQFUYYTpd8fgWUOis9d6Yk0vly7b6hnu4iZUv?= =?us-ascii?Q?n0r7SR3aRPwsxiiZ4ByAgdm88eArwPhI9BeQlMWKC5eH5uKSMUUIxdsb4YUF?= =?us-ascii?Q?tTK2IUydZTy1onXAlnZ7LHWaIATFPQxUJIFKbzZc6Hq4A6vv4SnrDDkfpB7Y?= =?us-ascii?Q?zLALgRiRmo9Z41IzATsY2VqIgfqMhbmo/nTMqJigJlomWuq0dl4e+p7h259A?= =?us-ascii?Q?LTAaPVkwqsHjm9y6wJjU4Zw+8h+SWCMsk1BBilhaDFqHYmDfk1EYDzq3OR2J?= =?us-ascii?Q?FXLChuGecsWDAHoV6mLMQqYq9WWDeEz4wEl89hhrmfEy2d/qksF+RFPyyNkt?= =?us-ascii?Q?a8auDVpJoD4E8ETZyZBfD9VlsggSK88lu27x3oQJefdQnIIkhxjSUGE6CJby?= =?us-ascii?Q?v1hoDPTtSHOkNvqw4j/4nujeI6bkuWvspDqpxJZhqzPNFzvDFHWXvOQP+DHM?= =?us-ascii?Q?uokkzn+2HShljICnW/HaYPjOAPd7C3Ge4CgcWTff3LSO90siTJTrzqJ/R67t?= =?us-ascii?Q?1xycOA26Hx0OXQ0UCiSDzoJnqt4/7gxCseURKDdMJWEL+62BMY6kD5MMN9G8?= =?us-ascii?Q?+yBBg4tveoAqKr66C8Pisc9DPx8h6VLBhsqtztsN7Pm1SZtTlnc9uf8b37Jb?= =?us-ascii?Q?+MEFtQn0W1w0WGf3GzmTmONcTlhrET+XdTmqrNj3ExkR9dnB2qF2D9G4Y2mH?= =?us-ascii?Q?WQHWfbbGMuti5cl1lP0GOxIF2SJX5RpiSsHFtQbZbVpaZurZzycrCgGffDtQ?= =?us-ascii?Q?uIiO6uXCQbeubcL4x7ETQD5LhowoxkyLRMsfX7FOOyOKDsa1h2OcOriDy2CP?= =?us-ascii?Q?zFmYHQ9mZcH9m2ioVU2ZFADBSYIXxTFNJ74l36680N3Nd4MXvTeNM22taUul?= =?us-ascii?Q?uKwncPBs3BRiC7e2olyDx9pa2DVsmS68PSHc7gf7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 731851f5-847d-4de6-bd3d-08daabe6255d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 00:10:18.3762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: otldVUteh8Pgp9rwDkksmcRU0KPYutwSmaBWqGM9hy6/m+3mijp59hjeBX4Rs3sb1HUSzimEwp0EgwIs6pUBQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7385 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 66cef08cde..ee8d078e39 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Tuesday, October 11, 2022 5:05 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg= /AcpiPlatform: Fix table install logic Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Monday, October 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Acp= iPlatform: Fix table install logic Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e59= 0cf81f2b9af9e17243a422798833b0e that prevents some tables from being instal= led. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/= AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatf= orm/AcpiPlatform.c index 28117ad460..a884c9745f 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPla= tform.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi +++ Platform.c @@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall ( // Install the table // AcpiStatus =3D AcpiTable->InstallAcpiTable (AcpiTable, Curre= ntTable, CurrentTable->Length, &TableHandle); - if (!EFI_ERROR (AcpiStatus)) { + if (EFI_ERROR (AcpiStatus)) { ASSERT_EFI_ERROR (AcpiStatus); return AcpiStatus; } -- 2.36.1.windows.1