From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.1906.1661281570826627653 for ; Tue, 23 Aug 2022 12:06:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AySsELee; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661281570; x=1692817570; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MqRSQk0/nDKyHHyLRHjpYQFFkeI8JHiP/oJ7/W92xt0=; b=AySsELeeD49uWOqUQRRrdQe39/gk6BFLVKe0Lx6/V8m33SAGBssvvTg7 w45KxSMF/tYOTUsvuOQXRLa1rvD9Avdt9uo9Sm/OQz/NJ8ZvMl5FcjIew Zsp9BfpiMBK0KnpjqgX08mN9arnnbOmlVtuOdAg5mpmVLYycqoC60BEWL cjU7H8krLW+UwoY206kbgzVXKFzhhZ7J0BZBnHV6AWHnLF7UwoA9jL5gQ AMUermKgo7yUIQkIMkspbOCKg0HUFeZOZnsgeAgloeqRNNzmwHIhGlYfE Qon1soiMffdly6wkSf7/IYm1tcn8SdliGmLBw1zU37kUjwVy9mb628uco w==; X-IronPort-AV: E=McAfee;i="6500,9779,10448"; a="274162529" X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="274162529" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 12:06:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,258,1654585200"; d="scan'208";a="642558233" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2022 12:06:10 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 12:05:18 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 23 Aug 2022 12:05:18 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 23 Aug 2022 12:05:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHeaSYHKfBcM4Y5MXsB7iBggGiHDtnELuD62ZJBLShgmuEcEVG69ts608KycYhk/Ew70La0ve5K6uKKDdNhq7aPedM4wtZK/8L0mVzKg2kl0Jk4su4PboiFBQTXRJz0Rbj8QNE3aS47t1zgITtxWouVgUTi2awp9czmgJ1g3oSy70ie593lhAeP6IIcYRkKhIl9JGgMxZYBJchOu1QtxGy6pJtEHC9HW2Jt0rNJjbUBNPC6IGc5wzGYjXCaJ7fBSV9N+hy3XY2IkRoafA1of4d8d3EJacJTUWtPdHk2r6TUmarUjZTQrYVQgLVMYX20K4wz9fUSW3CjbzDQjf5IXig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4xb5syAqdjzA3xTUhSZjYHqQW+0HSPYxyZqy4y8Jcgk=; b=NgS6Ft6DRTUBuc4iTU/BHmm60hByo5OUgjCO+wQtTr7utrffl1BmuI80kkzkN6F8NFPsyVmLXsZWQtVINsthkHkz+Tsw5rwYI8qntZm8dkJ2Los+4ef5zITsyhjN6mj3gDQ/+ip9Rt/aie3ftUTLC+TNlfwksbrmCVowUaAMKU8Ba5PZNLuJTBBM/aFZIF+8apamYic2S7yh4z7UG2a9aC73AxjH+iF9lbY32vPSBK/NrsgE5SKAMkjbgoXfe0PVA1hxN2Km1rj0IyArpgYwRF0txcBj1ypfm8Vm32SH5vYMZEgUsSTzd1edViFT+iyz2lc3eQ5BrN3ToyOcVadH+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Tue, 23 Aug 2022 19:05:17 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::d1ab:10f2:3d04:2b09]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::d1ab:10f2:3d04:2b09%4]) with mapi id 15.20.5566.014; Tue, 23 Aug 2022 19:05:17 +0000 From: "Oram, Isaac W" To: "Singh, DeepakX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "S, Ashraf Ali" , "Pir, Ovais F" Subject: Re: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Topic: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Index: AQHYtyDkyL/HG/lGEkiemVnNfuxHC62810Kg Date: Tue, 23 Aug 2022 19:05:16 +0000 Message-ID: References: <2ca9fbfafd8fa1df47f001d40d0b5f5c4135a0b9.1661241884.git.deepakx.singh@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d4939d5-5ea0-4e6f-70a5-08da853a6a90 x-ms-traffictypediagnostic: PH0PR11MB5030:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GESZiFeCcME++zqDuIWghRH3wQK1CEpDzUkdS6wMDrUvm0iFC5Si9jjKTs9UgV+/ToD7OKaJ7rlvWXpYS7AgPbn5gyhRAcEgz3pL1THe5nvJrerPgA6Z2ANJfCwnPgafEXHgxVwbsbzHkTcmcs6oPjEv4DRB3LHWAl8MyMMDH0+/GCFE9cti5fwVSLqyK0gJxWSzuzB1tOZHYq+MMaIAc/g5ORMGmMQxesgQQD2cMGDwful1cF+exywWlyHrRGKzXHpJ5WIElL/M5AE+re5rkr+h0TtMgZ0ZzvqbhyB0N/FTihNYjA3XFDsNi7h/W4QWXXNpLRkc7AbQ2rRf+NgyPlBrj+WxrO6PqJSGKFx2TI/P6dI2fb+Z3d+DZq3cw+4nhoaEyqdTrrpYG17WD2MEGq0XGUe5kUMQ1N/52D6RR1EX+eexFYOIcsyo0fA2koCqZPvx0VuRBLbd2gjzCCJ8314jlMENc4I8FXvQlOtW/65L80U2ieVudIBCbyGkrpVySmLgYqDT8RZB3Qlf0KU2HnrywU6QciyoAYwfoKkr45eqm61+Q83E1B1HnDf0s25f86317QiNeT3IN9A44DhBGHXCjH/AxvkP1QkIRSYKQVph/AayIqhuZ5NMrb28qay+6rpDp8idiACQGH7U2m7OcYljiIYhmPz0fHlVz76LXWm7Msfdu1jAZ1sOBg6RNGMYZBLt/Ofb20GzEOs2OZkpWbK0/1F9C+nC4e6JKfQKt1p2DMFA69b+0DUDW9ZkcLcdT3x4SJJX6eocuPA1NBV/kZV4d3r8AOb3EQgcYyM+qCI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39860400002)(346002)(396003)(376002)(83380400001)(71200400001)(2906002)(52536014)(8936002)(4326008)(66946007)(66476007)(8676002)(66556008)(64756008)(66446008)(76116006)(5660300002)(6506007)(2940100002)(7696005)(26005)(53546011)(9686003)(33656002)(41300700001)(107886003)(186003)(966005)(55016003)(478600001)(38070700005)(82960400001)(86362001)(110136005)(54906003)(122000001)(316002)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aMlC0Hps9NDOsX/cjqbq8Kx6uCbFLgON0lpK+oqBzLx44N5N2nN+taus5X8l?= =?us-ascii?Q?VrRviuo99/S3fMf5T1o57f5A7GbwJWKYeCFiRHKMueYPdlJBr5PiX8wBZp7Q?= =?us-ascii?Q?IIOgZFeAMa5X2Bapz3leASIjGFcAmMYByh5xWDpvfepgIXm4Wzl6KUUyqJhW?= =?us-ascii?Q?8z/svzQwBnRXBidNq9jTVwqwpavoF10yWO5GyGnqqO+T2jLGu/IxkYAVs3wm?= =?us-ascii?Q?X7OVNfYqXBcy5nB2/DnKWJtG+NHKEZJykI/aB7e9va6GoDtYg0wlTCbeGHqZ?= =?us-ascii?Q?4MItcve8IKZK9Rmpcl5QrZ7hBOFHvDxHc0WTqSNPW/n+cdywlkCZm/QwvyII?= =?us-ascii?Q?0B/4iFemqe3EB5xm0tjUvopdzwtUnLImpq/EQCN41OMZ84CUbSXHQ/67EAjf?= =?us-ascii?Q?r2a7uHsYwQXnpHwQ7yA0A3uHz9VX6JlJwDXTvtM3iGv+1967mMe35oXFo0Oj?= =?us-ascii?Q?fN8pebJ24ymGjl4r1a9UCRVL1/pJN/ZRr4obQs9UHLBVUNMFlIXC2z10zcFQ?= =?us-ascii?Q?CKNIx8xDjFwgPKlkZUFjvy2gcmhuHqZ1CsJl6NWGCOuoESZBshgmb4Gmry1f?= =?us-ascii?Q?rU38Z0JVTMzt5DbcAMwAfItttIlBKUXgGZ/ZeJhrS+YbqgHD9ayDQh1NMu34?= =?us-ascii?Q?NSEDoW+Up6MkUew3MhmSF3fkm3hSisO126szQ1P+zhcKgy1/FQKpd73EgRfj?= =?us-ascii?Q?FdHDqq+ljwd20faX92QX7+jY/4n/mTP4nqx0Q/R+ZtPxoGMtwdv/M/rJyNIC?= =?us-ascii?Q?zi/4mQ94ufPdD+jpKAj6jUKYmtDaWtE5rNd+PpKpe+0tea/KXWVzNTyVjG6a?= =?us-ascii?Q?STu44XhMLm/uESXuhlY4DMVN1fPRNLKZXLmCxngYdZ0E3oWD4bDqzNX+H2Fv?= =?us-ascii?Q?4kA1VF6nFK+T4XnGJpASlwnzhQ+3brDfCH/zF/FV/3onQcnVayGucOx59N+Q?= =?us-ascii?Q?QIqoejF98Vu/w5U+hUgkz70NorXJnjVzqvZIu9d6tg+R0dzQ/3r1YEAX8Not?= =?us-ascii?Q?/5T3NreaMuHDLPd/fHxiOsUJl7fRPfjNstHma5E02rCIWftmCfFJEnmwcIdc?= =?us-ascii?Q?mgLUU83VA0tt2jWATEfEcKWXI4yKrbh+GwLSQi1cfq8LJDWPWKSOWnif7QAb?= =?us-ascii?Q?JoFmdLFQ59NCk7Y+2LbWx+A9cj+ZKMxecbpnM0WGCy7Aj3bLbFIHBZZZexKJ?= =?us-ascii?Q?EjIrYY/LrHhknNRV+N8RKMLUa38VH+d6VZ8+oxglF57hipk0pBACM1dLv3xk?= =?us-ascii?Q?0qsudEXNi11U64kxJ+YH+V9LngYIPDYkVefE708Y4qYjteFPs+1EwDNGXZiF?= =?us-ascii?Q?0Zx/lVkDJbWTqhWrn9E7mJxYr68sEeO1XJxyBbyZ4SMmg6x7kCM6ztqH2oW+?= =?us-ascii?Q?B2tRY3HWUCEo9+n/RPKkI9Yl9qiVlm9A3Z5RWfNwAiq3tgC6b3Ur46J48bE3?= =?us-ascii?Q?5TbEnRPsdfDeqPy1F9XIQbwVr3sK0/VuYlXEKHqvKd3dCCX3EX58QM6S0TRq?= =?us-ascii?Q?hZFP3KJzRGmbbkZA3uNHsClGAQbh3hWmVDyUSIteR7aOcQRj+0ud39SP/Gvb?= =?us-ascii?Q?lYs9F7Ar9z0pCNadQqwZYT20mtPfOXJGgg9KOzIb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4939d5-5ea0-4e6f-70a5-08da853a6a90 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 19:05:16.8169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8CkH04LWLgVBdFVv5XnKYC3MyDF5BPQ3rPlHlmIqx4KZh+aE4yYwBonq+bIYO8KjYkgSKJ5KQmnXiSY/tmHc8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5030 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 9769bf28d1..e12240390f Note that I had to fixup your author and signed off messages. Author can be configured in groups.io settings I believe. Signed off indicates an issue with your git config settings for name and em= ail. Also, I now notice the patch email was missing "[edk2-devel]" and "[edk2-pl= atforms]" prefix to allow people to filter the emails effectively. Please correct these for future review emails. Regards, Isaac -----Original Message----- From: Oram, Isaac W=20 Sent: Tuesday, August 23, 2022 11:48 AM To: Singh, DeepakX ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali ; Pir, Ovais F Subject: RE: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect = number of arguments Reviewed-by: Isaac Oram Note that comparing the two patches shows no delta other than timestamp and= title. -----Original Message----- From: Singh, DeepakX =20 Sent: Tuesday, August 23, 2022 1:44 AM To: devel@edk2.groups.io Cc: Singh, DeepakX ; Ni, Ray ; C= haganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali ; Pir, Ovais F Subject: [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect numb= er of arguments REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4027 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Cc: Ovais F Pir Signed-off-by: Singh Deepak5x --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index aa2bf14fa8..7a70dc7aea 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -488,7 +488,7 @@ DoMeasurementsFromDigestRegister ( DEBUG((DEBUG_INFO, "\n")); } =20 - DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n", ExtendDigestRegister))= ; + DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n")); ExtendDigestRegister (PciIo, DeviceSecurityPolicy, TcgAlgId, DigestSel= , Digest, DeviceSecurityState); } } diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c= b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c index c7a56cf571..ef1737b1b6 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c @@ -642,7 +642,7 @@ DumpVtdVerRegs ( IN VTD_VER_REG *VerReg ) { - DEBUG ((DEBUG_INFO, " VerReg:\n", VerReg->Uint32)); + DEBUG ((DEBUG_INFO, " VerReg - 0x%x\n", VerReg->Uint32)); DEBUG ((DEBUG_INFO, " Major - 0x%x\n", VerReg->Bits.Major)); DEBUG ((DEBUG_INFO, " Minor - 0x%x\n", VerReg->Bits.Minor)); } @@ -657,7 +657,7 @@ DumpVtdCapRegs ( IN VTD_CAP_REG *CapReg ) { - DEBUG((DEBUG_INFO, " CapReg:\n", CapReg->Uint64)); + DEBUG((DEBUG_INFO, " CapReg - 0x%x\n", CapReg->Uint64)); DEBUG((DEBUG_INFO, " ND - 0x%x\n", CapReg->Bits.ND)); DEBUG((DEBUG_INFO, " AFL - 0x%x\n", CapReg->Bits.AFL)); DEBUG((DEBUG_INFO, " RWBF - 0x%x\n", CapReg->Bits.RWBF)); @@ -688,7 +688,7 @@ DumpVtdECapRegs ( IN VTD_ECAP_REG *ECapReg ) { - DEBUG((DEBUG_INFO, " ECapReg:\n", ECapReg->Uint64)); + DEBUG((DEBUG_INFO, " ECapReg - 0x%x\n", ECapReg->Uint64)); DEBUG((DEBUG_INFO, " C - 0x%x\n", ECapReg->Bits.C)); DEBUG((DEBUG_INFO, " QI - 0x%x\n", ECapReg->Bits.QI)); DEBUG((DEBUG_INFO, " DT - 0x%x\n", ECapReg->Bits.DT)); --=20 2.30.2.windows.1