* [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS
@ 2022-07-27 19:12 Sinha, Ankit
2022-08-03 23:07 ` Oram, Isaac W
[not found] ` <1707F85762E81048.17676@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Sinha, Ankit @ 2022-07-27 19:12 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Nate DeSimone, Eric Dong
1. Add the PCD for GPE 1 block register width control in FADT
2. Re-arrange PCD category for some PCDs
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Ankit Sinha <ankit.sinha@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 1 +
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 9 ++++++---
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index c7e87cbd7d9d..e68b6070607f 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1227,6 +1227,7 @@ PlatformUpdateTables (
FadtHeader->XPmTmrBlk.AccessSize = PcdGet8 (PcdAcpiXPmTmrBlkAccessSize);
FadtHeader->XGpe0Blk.AccessSize = PcdGet8 (PcdAcpiXGpe0BlkAccessSize);
FadtHeader->XGpe1Blk.AccessSize = PcdGet8 (PcdAcpiXGpe1BlkAccessSize);
+ FadtHeader->XGpe1Blk.RegisterBitWidth = PcdGet8 (PcdAcpiXGpe1BlkRegisterBitWidth);
FadtHeader->SleepControlReg.AddressSpaceId = PcdGet8 (PcdAcpiSleepControlRegisterAddressSpaceId);
FadtHeader->SleepControlReg.RegisterBitWidth = PcdGet8 (PcdAcpiSleepControlRegisterBitWidth);
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 31b6c3be3cc1..1dc0683da650 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -93,6 +93,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize
+ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index 098bb50075d1..3a735b0e1917 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -134,6 +134,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00010048
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x00010049
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x0001004A
+ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056
gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055
#
@@ -266,9 +267,6 @@
[PcdsDynamic, PcdsDynamicEx]
gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x90000019
- gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025
- gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026
- gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId|0x00|UINT8|0x0001004B
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth|0x00|UINT8|0x0001004C
gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset|0x00|UINT8|0x0001004D
@@ -337,6 +335,11 @@
# //Header<BR>
# 0x7F, 0xFF, 0x04, 0x00}<BR>
gMinPlatformPkgTokenSpaceGuid.PcdTrustedStorageDevicePath|{0x02, 0x01, 0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 0x00, 0x00, 0x17, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x3000010
+
+ ## ACPI
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027
[PcdsFixedAtBuild]
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS 2022-07-27 19:12 [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS Sinha, Ankit @ 2022-08-03 23:07 ` Oram, Isaac W [not found] ` <1707F85762E81048.17676@groups.io> 1 sibling, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-03 23:07 UTC (permalink / raw) To: devel@edk2.groups.io, Sinha, Ankit; +Cc: Desimone, Nathaniel L, Dong, Eric Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> Please run \edk2\BaseTools\Scripts\PatchCheck.py on commits to identify whitespace and other simple issues. There are also typically editor settings to clean these automatically. I will clean up trailing whitespace on push. Regards, Isaac -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sinha, Ankit Sent: Wednesday, July 27, 2022 12:12 PM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS 1. Add the PCD for GPE 1 block register width control in FADT 2. Re-arrange PCD category for some PCDs Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Ankit Sinha <ankit.sinha@intel.com> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 + Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 9 ++++++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index c7e87cbd7d9d..e68b6070607f 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -1227,6 +1227,7 @@ PlatformUpdateTables ( FadtHeader->XPmTmrBlk.AccessSize = PcdGet8 (PcdAcpiXPmTmrBlkAccessSize); FadtHeader->XGpe0Blk.AccessSize = PcdGet8 (PcdAcpiXGpe0BlkAccessSize); FadtHeader->XGpe1Blk.AccessSize = PcdGet8 (PcdAcpiXGpe1BlkAccessSize); + FadtHeader->XGpe1Blk.RegisterBitWidth = PcdGet8 (PcdAcpiXGpe1BlkRegisterBitWidth); FadtHeader->SleepControlReg.AddressSpaceId = PcdGet8 (PcdAcpiSleepControlRegisterAddressSpaceId); FadtHeader->SleepControlReg.RegisterBitWidth = PcdGet8 (PcdAcpiSleepControlRegisterBitWidth); diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf index 31b6c3be3cc1..1dc0683da650 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf @@ -93,6 +93,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec index 098bb50075d1..3a735b0e1917 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -134,6 +134,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00010048 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x00010049 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x0001004A + + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UIN + T8|0x00010056 gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 # @@ -266,9 +267,6 @@ [PcdsDynamic, PcdsDynamicEx] gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x90000019 - gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025 - gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026 - gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027 gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId|0x00|UINT8|0x0001004B gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth|0x00|UINT8|0x0001004C gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset|0x00|UINT8|0x0001004D @@ -337,6 +335,11 @@ # //Header<BR> # 0x7F, 0xFF, 0x04, 0x00}<BR> gMinPlatformPkgTokenSpaceGuid.PcdTrustedStorageDevicePath|{0x02, 0x01, 0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 0x00, 0x00, 0x17, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x3000010 + + ## ACPI + + gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 + 0000025 + + gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9000 + 0026 + + gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x9000002 + 7 [PcdsFixedAtBuild] -- 2.27.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1707F85762E81048.17676@groups.io>]
* Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS [not found] ` <1707F85762E81048.17676@groups.io> @ 2022-08-03 23:18 ` Oram, Isaac W 0 siblings, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-03 23:18 UTC (permalink / raw) To: devel@edk2.groups.io, Oram, Isaac W, Sinha, Ankit Cc: Desimone, Nathaniel L, Dong, Eric Pushed as d09dafd0b9..a6b7458972 (fixed author format and trailing whitespace) -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W Sent: Wednesday, August 3, 2022 4:07 PM To: devel@edk2.groups.io; Sinha, Ankit <ankit.sinha@intel.com> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com> Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> Please run \edk2\BaseTools\Scripts\PatchCheck.py on commits to identify whitespace and other simple issues. There are also typically editor settings to clean these automatically. I will clean up trailing whitespace on push. Regards, Isaac -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sinha, Ankit Sent: Wednesday, July 27, 2022 12:12 PM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS 1. Add the PCD for GPE 1 block register width control in FADT 2. Re-arrange PCD category for some PCDs Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Ankit Sinha <ankit.sinha@intel.com> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 + Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 9 ++++++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index c7e87cbd7d9d..e68b6070607f 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -1227,6 +1227,7 @@ PlatformUpdateTables ( FadtHeader->XPmTmrBlk.AccessSize = PcdGet8 (PcdAcpiXPmTmrBlkAccessSize); FadtHeader->XGpe0Blk.AccessSize = PcdGet8 (PcdAcpiXGpe0BlkAccessSize); FadtHeader->XGpe1Blk.AccessSize = PcdGet8 (PcdAcpiXGpe1BlkAccessSize); + FadtHeader->XGpe1Blk.RegisterBitWidth = PcdGet8 (PcdAcpiXGpe1BlkRegisterBitWidth); FadtHeader->SleepControlReg.AddressSpaceId = PcdGet8 (PcdAcpiSleepControlRegisterAddressSpaceId); FadtHeader->SleepControlReg.RegisterBitWidth = PcdGet8 (PcdAcpiSleepControlRegisterBitWidth); diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf index 31b6c3be3cc1..1dc0683da650 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf @@ -93,6 +93,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec index 098bb50075d1..3a735b0e1917 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -134,6 +134,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00010048 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x00010049 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x0001004A + + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UIN + T8|0x00010056 gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 # @@ -266,9 +267,6 @@ [PcdsDynamic, PcdsDynamicEx] gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x90000019 - gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025 - gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026 - gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027 gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterAddressSpaceId|0x00|UINT8|0x0001004B gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitWidth|0x00|UINT8|0x0001004C gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegisterBitOffset|0x00|UINT8|0x0001004D @@ -337,6 +335,11 @@ # //Header<BR> # 0x7F, 0xFF, 0x04, 0x00}<BR> gMinPlatformPkgTokenSpaceGuid.PcdTrustedStorageDevicePath|{0x02, 0x01, 0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 0x00, 0x00, 0x17, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x3000010 + + ## ACPI + + gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 + 0000025 + + gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9000 + 0026 + + gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x9000002 + 7 [PcdsFixedAtBuild] -- 2.27.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-03 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 19:12 [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS Sinha, Ankit
2022-08-03 23:07 ` Oram, Isaac W
[not found] ` <1707F85762E81048.17676@groups.io>
2022-08-03 23:18 ` Oram, Isaac W
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox