From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Nickle Wang <nicklew@nvidia.com>,
"Igor Kulchytskyy" <igork@ami.com>,
Abdul Lateef Attar <abdattar@amd.com>
Subject: Re: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function
Date: Thu, 16 Feb 2023 01:43:01 +0000 [thread overview]
Message-ID: <SA1PR11MB5801D8DA30544A08225C6680D0A09@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230207162236.1406-2-abner.chang@amd.com>
I see your point that it is confusing the sets of protocols and libraries that have the same function. I think that the solution should be to decouple them so that we can clearly say something like "use edk2 interfaces, IpmiLib, and ManageabilityPkg or IpmiFeaturePkg, do not mix the two solutions". And if at some point in the future both are consuming edk2 API and ManageabilityPkg shared content, we can remove that comment.
Specific feedback on this commit:
edk2-platforms/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c (212) has another instance of "IpmiSubmitCommand" that should be changed to "IpmiSendCommand" to match the rest of the patch.
We should not make this change. We should modify the series to not use IpmiBaseLib/IpmiTransportPpi/IpmiTransportProtocol.
Regards,
Isaac
-----Original Message-----
From: abner.chang@amd.com <abner.chang@amd.com>
Sent: Tuesday, February 7, 2023 8:23 AM
To: devel@edk2.groups.io
Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Abdul Lateef Attar <abdattar@amd.com>
Subject: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function
From: Abner Chang <abner.chang@amd.com>
Rename IpmiSubmitCommand to IpmiSendCommand because the naming of this function is confusing with IpmiSubmitCommand defined in IPMI Protocol.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
---
.../Include/Library/IpmiBaseLib.h | 2 +-
.../Include/Ppi/IpmiTransportPpi.h | 2 +-
.../Include/Protocol/IpmiTransportProtocol.h | 2 +- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 2 +-
.../GenericIpmi/Pei/PeiGenericIpmi.c | 2 +-
.../GenericIpmi/Smm/SmmGenericIpmi.c | 2 +-
.../Library/IpmiBaseLib/IpmiBaseLib.c | 4 +--
.../Library/IpmiBaseLibNull/IpmiBaseLibNull.c | 2 +-
.../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 26 +++++++++----------
.../IpmiCommandLibNetFnChassis.c | 12 ++++-----
.../IpmiCommandLibNetFnStorage.c | 24 ++++++++---------
.../IpmiCommandLibNetFnTransport.c | 8 +++---
.../Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c | 4 +--
.../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 4 +--
.../Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c | 12 ++++-----
15 files changed, 54 insertions(+), 54 deletions(-)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiBaseLib.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiBaseLib.h
index 8487ace5ba..9e77bdad8d 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/IpmiBaseLib.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/
+++ IpmiBaseLib.h
@@ -37,7 +37,7 @@ InitializeIpmiBase (
**/
EFI_STATUS
-IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *CommandData,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTransportPpi.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTransportPpi.h
index 9ecb20f9bf..4bdb5db00b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTransportPpi.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/Ipmi
+++ TransportPpi.h
@@ -59,7 +59,7 @@ EFI_STATUS
//
struct _PEI_IPMI_TRANSPORT_PPI {
UINT64 Revision;
- PEI_IPMI_SEND_COMMAND IpmiSubmitCommand;
+ PEI_IPMI_SEND_COMMAND IpmiSendCommand;
PEI_IPMI_GET_CHANNEL_STATUS GetBmcStatus; };
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/IpmiTransportProtocol.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/IpmiTransportProtocol.h
index 2ee6f98e07..bb17073f06 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/IpmiTransportProtocol.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol
+++ /IpmiTransportProtocol.h
@@ -63,7 +63,7 @@ EFI_STATUS
//
struct _IPMI_TRANSPORT {
UINT64 Revision;
- IPMI_SEND_COMMAND IpmiSubmitCommand;
+ IPMI_SEND_COMMAND IpmiSendCommand;
IPMI_GET_CHANNEL_STATUS GetBmcStatus;
EFI_HANDLE IpmiHandle;
UINT8 CompletionCode;
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index d788b48867..f1f089b575 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/
+++ IpmiInit.c
@@ -396,7 +396,7 @@ InitializeIpmiKcsPhysicalLayer (
mIpmiInstance->Signature = SM_IPMI_BMC_SIGNATURE;
mIpmiInstance->SlaveAddress = BMC_SLAVE_ADDRESS;
mIpmiInstance->BmcStatus = BMC_NOTREADY;
- mIpmiInstance->IpmiTransport.IpmiSubmitCommand = IpmiSendCommand;
+ mIpmiInstance->IpmiTransport.IpmiSendCommand = IpmiSendCommand;
mIpmiInstance->IpmiTransport.GetBmcStatus = IpmiGetBmcStatus;
//
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c
index 3efb772b68..e9018ca8df 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/
+++ PeiGenericIpmi.c
@@ -76,7 +76,7 @@ PeiInitializeIpmiKcsPhysicalLayer (
mIpmiInstance->Signature = SM_IPMI_BMC_SIGNATURE;
mIpmiInstance->SlaveAddress = BMC_SLAVE_ADDRESS;
mIpmiInstance->BmcStatus = BMC_NOTREADY;
- mIpmiInstance->IpmiTransportPpi.IpmiSubmitCommand = PeiIpmiSendCommand;
+ mIpmiInstance->IpmiTransportPpi.IpmiSendCommand = PeiIpmiSendCommand;
mIpmiInstance->IpmiTransportPpi.GetBmcStatus = PeiGetIpmiBmcStatus;
mIpmiInstance->PeiIpmiBmcDataDesc.Flags = EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST;
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
index fda215baaa..c1892f5ab8 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/
+++ SmmGenericIpmi.c
@@ -166,7 +166,7 @@ Returns:
mIpmiInstance->Signature = SM_IPMI_BMC_SIGNATURE;
mIpmiInstance->SlaveAddress = BMC_SLAVE_ADDRESS;
mIpmiInstance->BmcStatus = BMC_NOTREADY;
- mIpmiInstance->IpmiTransport.IpmiSubmitCommand = IpmiSendCommand;
+ mIpmiInstance->IpmiTransport.IpmiSendCommand = IpmiSendCommand;
mIpmiInstance->IpmiTransport.GetBmcStatus = IpmiGetBmcStatus;
DEBUG ((DEBUG_INFO,"IPMI: Waiting for Getting BMC DID in SMM \n")); diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.c
index 5df9d861c6..01ff322d27 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBase
+++ Lib/IpmiBaseLib.c
@@ -91,7 +91,7 @@ InitializeIpmiBase (
**/
EFI_STATUS
-IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *CommandData,
@@ -108,7 +108,7 @@ IpmiSubmitCommand (
return Status;
}
- Status = mIpmiTransport->IpmiSubmitCommand (
+ Status = mIpmiTransport->IpmiSendCommand (
mIpmiTransport,
NetFunction,
0,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/IpmiBaseLibNull.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/IpmiBaseLibNull.c
index 7c4c67f6ac..7af21bbaf1 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/IpmiBaseLibNull.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBase
+++ LibNull/IpmiBaseLibNull.c
@@ -43,7 +43,7 @@ InitializeIpmiBase (
**/
EFI_STATUS
-IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *CommandData,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
index 2e34909f3e..dbd154e2a6 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm
+++ andLib/IpmiCommandLibNetFnApp.c
@@ -24,7 +24,7 @@ IpmiGetDeviceId (
UINT32 DataSize;
DataSize = sizeof(*DeviceId);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_DEVICE_ID,
NULL,
@@ -45,7 +45,7 @@ IpmiGetSelfTestResult (
UINT32 DataSize;
DataSize = sizeof(*SelfTestResult);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_SELFTEST_RESULTS,
NULL,
@@ -66,7 +66,7 @@ IpmiResetWatchdogTimer (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_RESET_WATCHDOG_TIMER,
NULL,
@@ -88,7 +88,7 @@ IpmiSetWatchdogTimer (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_SET_WATCHDOG_TIMER,
(VOID *)SetWatchdogTimer,
@@ -109,7 +109,7 @@ IpmiGetWatchdogTimer (
UINT32 DataSize;
DataSize = sizeof(*GetWatchdogTimer);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_WATCHDOG_TIMER,
NULL,
@@ -131,7 +131,7 @@ IpmiSetBmcGlobalEnables (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_SET_BMC_GLOBAL_ENABLES,
(VOID *)SetBmcGlobalEnables, @@ -152,7 +152,7 @@ IpmiGetBmcGlobalEnables (
UINT32 DataSize;
DataSize = sizeof(*GetBmcGlobalEnables);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_BMC_GLOBAL_ENABLES,
NULL,
@@ -174,7 +174,7 @@ IpmiClearMessageFlags (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_CLEAR_MESSAGE_FLAGS,
(VOID *)ClearMessageFlagsRequest, @@ -195,7 +195,7 @@ IpmiGetMessageFlags (
UINT32 DataSize;
DataSize = sizeof(*GetMessageFlagsResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_MESSAGE_FLAGS,
NULL,
@@ -215,7 +215,7 @@ IpmiGetMessage (
{
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_MESSAGE,
NULL,
@@ -237,7 +237,7 @@ IpmiSendMessage (
{
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_SEND_MESSAGE,
(VOID *)SendMessageRequest, @@ -274,7 +274,7 @@ IpmiGetSystemUuid (
}
RequestSize = 0;
ResponseSize = sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_SYSTEM_GUID,
(VOID *)NULL,
@@ -323,7 +323,7 @@ IpmiGetChannelInfo (
}
*GetChannelInfoResponseSize = sizeof (IPMI_GET_CHANNEL_INFO_RESPONSE);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_APP,
IPMI_APP_GET_CHANNEL_INFO,
(UINT8 *)GetChannelInfoRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
index 9c19f52ce4..c8c0e90a79 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm
+++ andLib/IpmiCommandLibNetFnChassis.c
@@ -23,7 +23,7 @@ IpmiGetChassisCapabilities (
UINT32 DataSize;
DataSize = sizeof(*GetChassisCapabilitiesResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_GET_CAPABILITIES,
NULL,
@@ -44,7 +44,7 @@ IpmiGetChassisStatus (
UINT32 DataSize;
DataSize = sizeof(*GetChassisStatusResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_GET_STATUS,
NULL,
@@ -66,7 +66,7 @@ IpmiChassisControl (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_CONTROL,
(VOID *)ChassisControlRequest, @@ -88,7 +88,7 @@ IpmiSetPowerRestorePolicy (
UINT32 DataSize;
DataSize = sizeof(*ChassisControlResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_SET_POWER_RESTORE_POLICY,
(VOID *)ChassisControlRequest, @@ -110,7 +110,7 @@ IpmiSetSystemBootOptions (
UINT32 DataSize;
DataSize = sizeof(*BootOptionsResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS,
(VOID *)BootOptionsRequest, @@ -132,7 +132,7 @@ IpmiGetSystemBootOptions (
UINT32 DataSize;
DataSize = sizeof(*BootOptionsResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_CHASSIS,
IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS,
(VOID *)BootOptionsRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
index 2215028089..4e84084605 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm
+++ andLib/IpmiCommandLibNetFnStorage.c
@@ -24,7 +24,7 @@ IpmiGetFruInventoryAreaInfo (
UINT32 DataSize;
DataSize = sizeof(*GetFruInventoryAreaInfoResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO,
(VOID *)GetFruInventoryAreaInfoRequest, @@ -45,7 +45,7 @@ IpmiReadFruData ( {
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_READ_FRU_DATA,
(VOID *)ReadFruDataRequest, @@ -68,7 +68,7 @@ IpmiWriteFruData (
UINT32 DataSize;
DataSize = sizeof(*WriteFruDataResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_WRITE_FRU_DATA,
(VOID *)WriteFruDataRequest, @@ -89,7 +89,7 @@ IpmiGetSelInfo (
UINT32 DataSize;
DataSize = sizeof(*GetSelInfoResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_SEL_INFO,
NULL,
@@ -110,7 +110,7 @@ IpmiGetSelEntry (
{
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_SEL_ENTRY,
(VOID *)GetSelEntryRequest, @@ -132,7 +132,7 @@ IpmiAddSelEntry (
UINT32 DataSize;
DataSize = sizeof(*AddSelEntryResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_ADD_SEL_ENTRY,
(VOID *)AddSelEntryRequest, @@ -155,7 +155,7 @@ IpmiPartialAddSelEntry (
UINT32 DataSize;
DataSize = sizeof(*PartialAddSelEntryResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY,
(VOID *)PartialAddSelEntryRequest, @@ -177,7 +177,7 @@ IpmiClearSel (
UINT32 DataSize;
DataSize = sizeof(*ClearSelResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_CLEAR_SEL,
(VOID *)ClearSelRequest,
@@ -198,7 +198,7 @@ IpmiGetSelTime (
UINT32 DataSize;
DataSize = sizeof(*GetSelTimeResponse);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_SEL_TIME,
NULL,
@@ -220,7 +220,7 @@ IpmiSetSelTime (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_SET_SEL_TIME,
(VOID *)SetSelTimeRequest, @@ -241,7 +241,7 @@ IpmiGetSdrRepositoryInfo (
UINT32 DataSize;
DataSize = sizeof(*GetSdrRepositoryInfoResp);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_SDR_REPOSITORY_INFO,
NULL,
@@ -262,7 +262,7 @@ IpmiGetSdr (
{
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_STORAGE,
IPMI_STORAGE_GET_SDR,
(VOID *)GetSdrRequest,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
index 30ea84c04b..eec281c5bd 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm
+++ andLib/IpmiCommandLibNetFnTransport.c
@@ -26,7 +26,7 @@ IpmiSolActivating (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_TRANSPORT,
IPMI_TRANSPORT_SOL_ACTIVATING,
(VOID *)SolActivatingRequest, @@ -49,7 +49,7 @@ IpmiSetSolConfigurationParameters (
UINT32 DataSize;
DataSize = sizeof(*CompletionCode);
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_TRANSPORT,
IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM,
(VOID *)SetConfigurationParametersRequest,
@@ -70,7 +70,7 @@ IpmiGetSolConfigurationParameters ( {
EFI_STATUS Status;
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_TRANSPORT,
IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM,
(VOID *)GetConfigurationParametersRequest,
@@ -111,7 +111,7 @@ IpmiGetLanConfigurationParameters (
return EFI_INVALID_PARAMETER;
}
- Status = IpmiSubmitCommand (
+ Status = IpmiSendCommand (
IPMI_NETFN_TRANSPORT,
IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS,
(UINT8 *)GetLanConfigurationParametersRequest,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c
index 8679cd95db..b97152208a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiB
+++ aseLib/PeiIpmiBaseLib.c
@@ -48,7 +48,7 @@ InitializeIpmiBase (
**/
EFI_STATUS
-IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *CommandData,
@@ -65,7 +65,7 @@ IpmiSubmitCommand (
ASSERT_EFI_ERROR (Status);
return Status;
}
- Status = IpmiTransport->IpmiSubmitCommand (
+ Status = IpmiTransport->IpmiSendCommand (
IpmiTransport,
NetFunction,
0,
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c
index 6282adc269..ee1d3d5bed 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiB
+++ aseLib/SmmIpmiBaseLib.c
@@ -96,7 +96,7 @@ InitializeIpmiBase (
**/
EFI_STATUS
-IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *CommandData,
@@ -133,7 +133,7 @@ Returns:
return Status;
}
- Status = mIpmiTransport->IpmiSubmitCommand (
+ Status = mIpmiTransport->IpmiSendCommand (
mIpmiTransport,
NetFunction,
0,
diff --git a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c
index 700e413aa6..2b02ba6a20 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c
+++ b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs
+++ /IpmiLibKcs.c
@@ -193,7 +193,7 @@ UpdateBmcStatusOnResponse ( **/ EFI_STATUS EFIAPI -IpmiSubmitCommand (
+IpmiSendCommand (
IN UINT8 NetFunction,
IN UINT8 Command,
IN UINT8 *RequestData,
@@ -222,7 +222,7 @@ IpmiSubmitCommand (
}
IpmiInstance->Signature = SM_IPMI_BMC_SIGNATURE;
- IpmiInstance->KcsTimeoutPeriod = PcdGet64(PcdIpmiKcsTimeoutPeriod);
+ IpmiInstance->KcsTimeoutPeriod = PcdGet64(PcdIpmiKcsTimeoutPeriod);
IpmiInstance->SlaveAddress = PcdGet8(PcdIpmiBmcSlaveAddress);
IpmiInstance->IpmiIoBase = PcdGet16(PcdIpmiIoBaseAddress);
DEBUG((DEBUG_INFO,"IPMI KcsTimeoutPeriod=0x%x\n", IpmiInstance->KcsTimeoutPeriod)); @@ -269,7 +269,7 @@ IpmiSubmitCommand (
}
Status = SendDataToBmcPort (
- IpmiInstance->KcsTimeoutPeriod,
+ IpmiInstance->KcsTimeoutPeriod,
IpmiInstance->IpmiIoBase,
(UINT8 *)IpmiCommand,
(UINT8)(RequestDataSize + EFI_IPMI_COMMAND_HEADER_SIZE) @@ -287,7 +287,7 @@ IpmiSubmitCommand (
//
DataSize = MAX_TEMP_DATA;
Status = ReceiveBmcDataFromPort (
- IpmiInstance->KcsTimeoutPeriod,
+ IpmiInstance->KcsTimeoutPeriod,
IpmiInstance->IpmiIoBase,
(UINT8 *)IpmiResponse,
&DataSize
@@ -301,8 +301,8 @@ IpmiSubmitCommand (
}
//
- // If we got this far without any error codes, but the DataSize is 0 then the
- // command response failed, so do not continue.
+ // If we got this far without any error codes, but the DataSize is 0
+ then the // command response failed, so do not continue.
//
if (DataSize < 3) {
Status = EFI_DEVICE_ERROR;
--
2.37.1.windows.1
next prev parent reply other threads:[~2023-02-16 1:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 16:22 [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function Chang, Abner
2023-02-16 1:43 ` Isaac Oram [this message]
2023-02-17 7:28 ` Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 2/7] ManageabilityPkg: Add diagrams Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 3/7] ManageabilityPkg: Add Readme file Chang, Abner
2023-02-16 1:44 ` Isaac Oram
2023-02-17 7:28 ` Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package Chang, Abner
2023-02-16 1:49 ` Isaac Oram
2023-02-17 7:29 ` Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 5/7] ManageabilityPkg: Implement Ipmi Protocol/Ppi Chang, Abner
2023-02-16 1:47 ` Isaac Oram
2023-02-17 7:29 ` Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 6/7] IpmiProtocol: Add to Manageability Package Chang, Abner
2023-02-07 16:22 ` [edk2-platforms][PATCH 7/7] edk2-platforms: Maintainers.txt Chang, Abner
2023-02-08 7:34 ` Michael D Kinney
[not found] ` <174197631C900AFE.27199@groups.io>
2023-02-07 18:24 ` [edk2-devel] " Chang, Abner
2023-02-16 1:51 ` Isaac Oram
2023-02-17 7:30 ` Chang, Abner
2023-02-16 1:42 ` [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol Isaac Oram
2023-02-17 7:27 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5801D8DA30544A08225C6680D0A09@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox