From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.533.1676511792758372366 for ; Wed, 15 Feb 2023 17:43:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cCzu6Woo; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676511792; x=1708047792; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OXFCmA3wkR2oKii+z8AFBWYDBr0yor5PYTYBperD+eU=; b=cCzu6WoopldsFBHdbBaObtmEUmp+uN34EJJEDtofZ5E2ycDSNxo1LZbC TLeLL+ZCNTj1D7OKy4bgQXrGqUCoEuuRezaBTddNvJAmv1IS7rMdCuku3 hINCexAqmtvfyj6hIle1m/vHENQzr0G8TvSwcPLvTa+bfhsPVzUBoU7vO QhKInMXmsRBqOEXtliAPjgOZL1tUFDN5ZQGxBq1Lw6pUXQpv4s1lJeR8U sFG1kgXKsTY//OzUKiSW9wkgAabHJZycR6OVC2h0OD0dK5vs4hNaGz5DF 5YkR0Ic4Zze6I3R2iNkGjFiIT5l00j18QomeGSl0pegYE14hRxs9G2TCL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="359024332" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="359024332" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 17:43:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="702389602" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="702389602" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 15 Feb 2023 17:43:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 17:43:10 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Feb 2023 17:43:10 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 15 Feb 2023 17:43:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjyVuldx01Kd/TXZqvnjJ/NZBQtLYjyRNkko+ZLhgsz4xSvKrtO6l2cruDmQtfxS4yLu562lZC11LDCgr+GtD/45TK2xY/0s9yUJtLUNHoQNx5Eo9aLhUAL184zu7t9BeWMHKxz7BwmirQi1v10uPg6ZFabtZ5jeUE3lfgLEGMiI0bkePNUNpi+uCEz2N+R1irEh4BsfjaDsGhBv55uILhPfLzifY0rKkABnA0NrU2kMQDR1in1KpW68S3UbVdwH1fVH1zJ7CxmOvS08K+ni/FDnNhW/OLEMDHIyOaVnF3I7mjApAWo1kxDqxFEYKdEPL3aRn4eI25iirpH5n4I+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8h7oR+JMVeRD1rNvprtztRzWHrrDP/mjZmczGg+h7Q=; b=mkDDdKW8YG+VPvnnVuGYOskURMwbcuO6/YQFuMVYBGX1CPEOH7WAMZhVbbY7xfpFD3iVShHFyzeiPoewaSd2NG1nOuepppDi8J0V3OQfk+jmmKE8LDpJawGkhazQSnkzm46nMyUrzIc50NhCjlWGRaesveeQMNr/jHGdlHERU9md3THb9M2aMiRcV6pNjZJuMzjT88iaxWdCWtGfPWXyKx6qoE3oRB8D0j5QF+hH3Mr5sllgsQBO+H76dx4P44vDY9Zn6cVfjT23qyVqi9dUVc9E/co1Nf+wLWG0Oyr058zQ9oTBYd/dnQ58C1Lspt70330Y356j3Ttb1xbiSRVxYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DS7PR11MB7690.namprd11.prod.outlook.com (2603:10b6:8:e6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 01:43:02 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::7623:38f5:ab31:61a5%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 01:43:02 +0000 From: "Isaac Oram" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Desimone, Nathaniel L" , Nickle Wang , "Igor Kulchytskyy" , Abdul Lateef Attar Subject: Re: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function Thread-Topic: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function Thread-Index: AQHZOxB5Y5NMcxTNbkGp5KcrjjEmx67Qym+g Date: Thu, 16 Feb 2023 01:43:01 +0000 Message-ID: References: <20230207162236.1406-1-abner.chang@amd.com> <20230207162236.1406-2-abner.chang@amd.com> In-Reply-To: <20230207162236.1406-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|DS7PR11MB7690:EE_ x-ms-office365-filtering-correlation-id: 08cddffd-5dbb-4759-76e4-08db0fbf23e5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rp3Szw/qutxgoG32bPPsE0KOsJZfU+S+B9dK8G28IXZOvJPjwDDiKN2qIXYIr3OlLTCjGDjTfWUnXr+a/n/fJpUSereoPbW3fv7zij21nnUyDPdWrF7x4bZS04y7OR4z535dJiPc8g/pYmTSvxbK/H/yuOxDvY/MbeNetFYHYYXSTXXh7FIZ9PSb6MarVkeLWSm8/y2AYis3+H68mJd55K1Ss+QWbZ7iDHAJgdcAEVfxyyrmYk8q6Cb+f5XAfl+xDrY/333k7K48XcVqHViFhemKONssmCF/PBmQT9qlIfD+UXDOagyFRKeIXk+p4FWmzKwyyzjlQ6vQwkUOnBJicq0eTEbgQH/DdiiFM4HW+UekUdSqQpEeB9tUTn2OoU/MlZXy7iZufrHQiJnIa2kfwpl1P34mVwgUKmUWluADqIqoWrb9QPj93XmdXtfZwbyXM/PQyYAQ0LJRYjFWSvdnNwP6aEX49No7mW1iI6FViiFWcVfUMksG5EWnpEPjGGIkxSlQj0f1bln0FCNizuLDg5+Rthib8mXKFaEOtS2LlqWMgyKXWX26NK6oRIPbDSyoP8leSaTgidoojuMWjNVNfNMJVTD+dfODR/bbOuVTEGSfY+I2O7H2r/9rUOwve7qcmD2vIbshtA4RzAAmHEFALbhowKrQwBcy8bT2Wph5HFcHg9NibdEI+ZZE69+oz5w2cLomIQ7NSGk2lYgx/gkXQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(39860400002)(376002)(346002)(396003)(451199018)(66556008)(316002)(66476007)(66446008)(41300700001)(54906003)(52536014)(8936002)(5660300002)(110136005)(8676002)(30864003)(71200400001)(4326008)(2906002)(64756008)(76116006)(66946007)(7696005)(55016003)(478600001)(26005)(186003)(6506007)(9686003)(53546011)(83380400001)(33656002)(38100700002)(122000001)(38070700005)(82960400001)(86362001)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MWDn2TuKayeJvTcWXyk0P0Xk/3ehzCUzIOX7/CPYrrq67Yjvy21tGlf78NZv?= =?us-ascii?Q?9FRu7tuDP/grVDhmJ438ewfr/TVtgXM7wU+90tKQpcZhXi6muSx3puty6wN+?= =?us-ascii?Q?ML6E+Ubclja4/JZMlIbcxY/MmcZkNDo4pWuVX7Ky33vkRXYvgUyz1tdALVG8?= =?us-ascii?Q?GRUJRx1gWWz/c1NMoRoF9AG0t47g69a1eWr7pbUMYEWXmllNg4HaYDz80Myn?= =?us-ascii?Q?0Z9d3fqZL7q6aldWBTYvDioZ+6iVMkj0fLWKOZSPjNlkT85u5+tQX54682cq?= =?us-ascii?Q?Qw9zpn0y1mF8+Wsw2YkiyCwt96t2zblNYQaVEcCdHGAtm0rbOtO366we/7y7?= =?us-ascii?Q?hWjTzuLq/49v8cbpGCiWeTFqTs99SKayK0Qw+fcaiGJL6coQ3FRIFyqAmcAk?= =?us-ascii?Q?VBPpLG6QVejMP4Bc845ivawduSlNLuDjVlocO3vXjrKhFxAXYhElxPGSomy3?= =?us-ascii?Q?98kIFq6oDBQ87qI2jZ5BTP0kR99VXnU8hxwndM9rOrKKgZGAQ8TwJgEgbu4H?= =?us-ascii?Q?b+n96t1sroMTZQHWreSDUrMhGX7XFL+uTxSEfMVyuioTMR4BylDWXpSsgrt7?= =?us-ascii?Q?O8/4qrqBOYHRT57UVMeYtEEK+/MoQYnt9/ycvyWlH5eHET2W8uw3NIP1cfOZ?= =?us-ascii?Q?rURf522K2iShO6AA1NKS6cYAAeT+QCIUfRLrDmhCljpn9GmEhAYif6QPmjyk?= =?us-ascii?Q?bXVsE+8Ouv6qnHUCaBaglO+IIK1FRu3ku05olGfP1u45jvzq3FOE8X+JI/dI?= =?us-ascii?Q?h0rxa7w1wveBEA0ybD5i4WEx1gghf2uFl2zgJEYcNNYuOTLuUfWjGOQBCgBF?= =?us-ascii?Q?Ipq9U0sTaHtpfcXMX4pEgtmUK+0jw2vehNOD+ktCa6nFieOVOnZS8LDrkn1u?= =?us-ascii?Q?DduQ+IPqVyq9x0/rKHuaJj/bxHctf5MEU0DJDSHmEr6yhGtbiWhdEWZ6/Qo7?= =?us-ascii?Q?luBmgbyKvJaksCnKk0KORvwfN90xwlwAABORhyLKXBdITO7gk440sJXkftqq?= =?us-ascii?Q?OEuMFvp5dtGRIzP7Md4/HqDd2sjUjgzNaOfJVxXjOPKbl+caEq8XMRPfEgZy?= =?us-ascii?Q?0b27JRBL9EyX4WdwiMTS/20DCRvAgdnFQ41hR3ENzQRd+7BxOTgtBAgMtl9U?= =?us-ascii?Q?IHjC0fpq4xJGF56NVVOg1ZX/QfwpYxBf79s2xnYhPKtaAI1gwxLsTBmqYBuF?= =?us-ascii?Q?iZPGJQVlfNYMZjoAO/LHVLPKOvXuxcdSjKGwxtxo14EWtk1wye68m3VAttjk?= =?us-ascii?Q?12uqDUIQ+gMBZaHkBF26JrVyvRG4TRnRDf+Qp/oHPnd4jzbkEXFCsotef37J?= =?us-ascii?Q?xze2fwNErfF8FXQNmdduXGj9RShmvZnGbM3ljJ+HJiVWYsCiit5aN03ID5Zl?= =?us-ascii?Q?QhvaWAxUJKkclFwvBXkXWy29K8uECT2E+hjE7QkwL6bMifOc/5xcwEE0Unee?= =?us-ascii?Q?tDjI4C6F72DkKQ2vNleHXEcY4tlut1GNts6G4ONaxE4oRx1tINdx/KlCR7hL?= =?us-ascii?Q?DjU9brpqUkoIrPVrw0YQo2qsFwpWiYqUQM/L6ICHyCxE9NLABltSOAHTRku0?= =?us-ascii?Q?ieReI1NaiFldEB/JWm8QnCYaLlRAfm7/+tq4m7wC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08cddffd-5dbb-4759-76e4-08db0fbf23e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 01:43:01.7999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zy3Rw21Oqlt3l5q+mcuGjrHgCZpGo4nnZLQMzcXAjzD1I/XrKAmea1zuc0vU4MW3MiKBDK+Z7jEgdiyuct1mZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7690 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I see your point that it is confusing the sets of protocols and libraries t= hat have the same function. I think that the solution should be to decoupl= e them so that we can clearly say something like "use edk2 interfaces, Ipmi= Lib, and ManageabilityPkg or IpmiFeaturePkg, do not mix the two solutions".= And if at some point in the future both are consuming edk2 API and Manage= abilityPkg shared content, we can remove that comment. Specific feedback on this commit: edk2-platforms/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/Ipmi= LibKcs/IpmiLibKcs.c (212) has another instance of "IpmiSubmitCommand" that = should be changed to "IpmiSendCommand" to match the rest of the patch. We should not make this change. We should modify the series to not use Ipm= iBaseLib/IpmiTransportPpi/IpmiTransportProtocol. Regards, Isaac -----Original Message----- From: abner.chang@amd.com =20 Sent: Tuesday, February 7, 2023 8:23 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Oram, Isaac W ; Desimone, Nathaniel L ; Nickle Wan= g ; Igor Kulchytskyy ; Abdul Lateef Atta= r Subject: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitComma= nd function From: Abner Chang Rename IpmiSubmitCommand to IpmiSendCommand because the naming of this func= tion is confusing with IpmiSubmitCommand defined in IPMI Protocol. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../Include/Library/IpmiBaseLib.h | 2 +- .../Include/Ppi/IpmiTransportPpi.h | 2 +- .../Include/Protocol/IpmiTransportProtocol.h | 2 +- .../IpmiFeaturePkg/= GenericIpmi/Dxe/IpmiInit.c | 2 +- .../GenericIpmi/Pei/PeiGenericIpmi.c | 2 +- .../GenericIpmi/Smm/SmmGenericIpmi.c | 2 +- .../Library/IpmiBaseLib/IpmiBaseLib.c | 4 +-- .../Library/IpmiBaseLibNull/IpmiBaseLibNull.c | 2 +- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 26 +++++++++---------- .../IpmiCommandLibNetFnChassis.c | 12 ++++----- .../IpmiCommandLibNetFnStorage.c | 24 ++++++++--------- .../IpmiCommandLibNetFnTransport.c | 8 +++--- .../Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c | 4 +-- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 4 +-- .../Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c | 12 ++++----- 15 files changed, 54 insertions(+), 54 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Libr= ary/IpmiBaseLib.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/Library/IpmiBaseLib.h index 8487ace5ba..9e77bdad8d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/Ipm= iBaseLib.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ +++ IpmiBaseLib.h @@ -37,7 +37,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/= IpmiTransportPpi.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Incl= ude/Ppi/IpmiTransportPpi.h index 9ecb20f9bf..4bdb5db00b 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTra= nsportPpi.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/Ipmi +++ TransportPpi.h @@ -59,7 +59,7 @@ EFI_STATUS // struct _PEI_IPMI_TRANSPORT_PPI { UINT64 Revision; - PEI_IPMI_SEND_COMMAND IpmiSubmitCommand; + PEI_IPMI_SEND_COMMAND IpmiSendCommand; PEI_IPMI_GET_CHANNEL_STATUS GetBmcStatus; }; =20 diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Prot= ocol/IpmiTransportProtocol.h b/Features/Intel/OutOfBandManagement/IpmiFeatu= rePkg/Include/Protocol/IpmiTransportProtocol.h index 2ee6f98e07..bb17073f06 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/Ip= miTransportProtocol.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol +++ /IpmiTransportProtocol.h @@ -63,7 +63,7 @@ EFI_STATUS // struct _IPMI_TRANSPORT { UINT64 Revision; - IPMI_SEND_COMMAND IpmiSubmitCommand; + IPMI_SEND_COMMAND IpmiSendCommand; IPMI_GET_CHANNEL_STATUS GetBmcStatus; EFI_HANDLE IpmiHandle; UINT8 CompletionCode; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index d788b48867..f1f089b575 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -396,7 +396,7 @@ InitializeIpmiKcsPhysicalLayer ( mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D IpmiSendCommand; + mIpmiInstance->IpmiTransport.IpmiSendCommand =3D IpmiSendCommand; mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus; =20 // diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 3efb772b68..e9018ca8df 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ +++ PeiGenericIpmi.c @@ -76,7 +76,7 @@ PeiInitializeIpmiKcsPhysicalLayer ( mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransportPpi.IpmiSubmitCommand =3D PeiIpmiSendCommand= ; + mIpmiInstance->IpmiTransportPpi.IpmiSendCommand =3D PeiIpmiSendCommand= ; mIpmiInstance->IpmiTransportPpi.GetBmcStatus =3D PeiGetIpmiBmcStatu= s; =20 mIpmiInstance->PeiIpmiBmcDataDesc.Flags =3D EFI_PEI_PPI_DESCRIPT= OR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index fda215baaa..c1892f5ab8 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/ +++ SmmGenericIpmi.c @@ -166,7 +166,7 @@ Returns: mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D IpmiSendCommand; + mIpmiInstance->IpmiTransport.IpmiSendCommand =3D IpmiSendCommand; mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus; =20 DEBUG ((DEBUG_INFO,"IPMI: Waiting for Getting BMC DID in SMM \n")); di= ff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBa= seLib/IpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Lib= rary/IpmiBaseLib/IpmiBaseLib.c index 5df9d861c6..01ff322d27 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= /IpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBase +++ Lib/IpmiBaseLib.c @@ -91,7 +91,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -108,7 +108,7 @@ IpmiSubmitCommand ( return Status; } =20 - Status =3D mIpmiTransport->IpmiSubmitCommand ( + Status =3D mIpmiTransport->IpmiSendCommand ( mIpmiTransport, NetFunction, 0, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= BaseLibNull/IpmiBaseLibNull.c b/Features/Intel/OutOfBandManagement/IpmiFeat= urePkg/Library/IpmiBaseLibNull/IpmiBaseLibNull.c index 7c4c67f6ac..7af21bbaf1 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= Null/IpmiBaseLibNull.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBase +++ LibNull/IpmiBaseLibNull.c @@ -43,7 +43,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnApp.c b/Features/Intel/OutOfBandManagement/Ip= miFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c index 2e34909f3e..dbd154e2a6 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnApp.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm +++ andLib/IpmiCommandLibNetFnApp.c @@ -24,7 +24,7 @@ IpmiGetDeviceId ( UINT32 DataSize; =20 DataSize =3D sizeof(*DeviceId); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_DEVICE_ID, NULL, @@ -45,7 +45,7 @@ IpmiGetSelfTestResult ( UINT32 DataSize; =20 DataSize =3D sizeof(*SelfTestResult); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_SELFTEST_RESULTS, NULL, @@ -66,7 +66,7 @@ IpmiResetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_RESET_WATCHDOG_TIMER, NULL, @@ -88,7 +88,7 @@ IpmiSetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SET_WATCHDOG_TIMER, (VOID *)SetWatchdogTimer, @@ -109,7 +109,7 @@ IpmiGetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetWatchdogTimer); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_WATCHDOG_TIMER, NULL, @@ -131,7 +131,7 @@ IpmiSetBmcGlobalEnables ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SET_BMC_GLOBAL_ENABLES, (VOID *)SetBmcGlobalEnables, @@ -152,7 +152,7 @@ IpmiGetBmcGl= obalEnables ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetBmcGlobalEnables); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_BMC_GLOBAL_ENABLES, NULL, @@ -174,7 +174,7 @@ IpmiClearMessageFlags ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_CLEAR_MESSAGE_FLAGS, (VOID *)ClearMessageFlagsRequest, @@ -195,7 +195,7 @@ IpmiGet= MessageFlags ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetMessageFlagsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_MESSAGE_FLAGS, NULL, @@ -215,7 +215,7 @@ IpmiGetMessage ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_MESSAGE, NULL, @@ -237,7 +237,7 @@ IpmiSendMessage ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SEND_MESSAGE, (VOID *)SendMessageRequest, @@ -274,7 +274,7 @@ IpmiGetSystem= Uuid ( } RequestSize =3D 0; ResponseSize =3D sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_SYSTEM_GUID, (VOID *)NULL, @@ -323,7 +323,7 @@ IpmiGetChannelInfo ( } =20 *GetChannelInfoResponseSize =3D sizeof (IPMI_GET_CHANNEL_INFO_RESPONSE); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_CHANNEL_INFO, (UINT8 *)GetChannelInfoRequest, diff --git a/Features/Intel/O= utOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetF= nChassis.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnChassis.c index 9c19f52ce4..c8c0e90a79 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnChassis.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm +++ andLib/IpmiCommandLibNetFnChassis.c @@ -23,7 +23,7 @@ IpmiGetChassisCapabilities ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetChassisCapabilitiesResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_CAPABILITIES, NULL, @@ -44,7 +44,7 @@ IpmiGetChassisStatus ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetChassisStatusResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_STATUS, NULL, @@ -66,7 +66,7 @@ IpmiChassisControl ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_CONTROL, (VOID *)ChassisControlRequest, @@ -88,7 +88,7 @@ IpmiSetPower= RestorePolicy ( UINT32 DataSize; =20 DataSize =3D sizeof(*ChassisControlResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_SET_POWER_RESTORE_POLICY, (VOID *)ChassisControlRequest, @@ -110,7 +110,7 @@ IpmiSetSys= temBootOptions ( UINT32 DataSize; =20 DataSize =3D sizeof(*BootOptionsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, (VOID *)BootOptionsRequest, @@ -132,7 +132,7 @@ IpmiGetSystem= BootOptions ( UINT32 DataSize; =20 DataSize =3D sizeof(*BootOptionsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, (VOID *)BootOptionsRequest, diff --git a/Features/Intel/OutOf= BandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnSto= rage.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm= andLib/IpmiCommandLibNetFnStorage.c index 2215028089..4e84084605 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnStorage.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm +++ andLib/IpmiCommandLibNetFnStorage.c @@ -24,7 +24,7 @@ IpmiGetFruInventoryAreaInfo ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetFruInventoryAreaInfoResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO, (VOID *)GetFruInventoryAreaInfoRequest, @@ -45,7 +45,7 @@ Ipm= iReadFruData ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_READ_FRU_DATA, (VOID *)ReadFruDataRequest, @@ -68,7 +68,7 @@ IpmiWriteFruDat= a ( UINT32 DataSize; =20 DataSize =3D sizeof(*WriteFruDataResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_WRITE_FRU_DATA, (VOID *)WriteFruDataRequest, @@ -89,7 +89,7 @@ IpmiGetSelInfo= ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSelInfoResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_INFO, NULL, @@ -110,7 +110,7 @@ IpmiGetSelEntry ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_ENTRY, (VOID *)GetSelEntryRequest, @@ -132,7 +132,7 @@ IpmiAddSelEnt= ry ( UINT32 DataSize; =20 DataSize =3D sizeof(*AddSelEntryResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_ADD_SEL_ENTRY, (VOID *)AddSelEntryRequest, @@ -155,7 +155,7 @@ IpmiPartialAd= dSelEntry ( UINT32 DataSize; =20 DataSize =3D sizeof(*PartialAddSelEntryResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY, (VOID *)PartialAddSelEntryRequest, @@ -177,7 +177,7 @@ IpmiCl= earSel ( UINT32 DataSize; =20 DataSize =3D sizeof(*ClearSelResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_CLEAR_SEL, (VOID *)ClearSelRequest, @@ -198,7 +198,7 @@ IpmiGetSelTime ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSelTimeResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_TIME, NULL, @@ -220,7 +220,7 @@ IpmiSetSelTime ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_SET_SEL_TIME, (VOID *)SetSelTimeRequest, @@ -241,7 +241,7 @@ IpmiGetSdrRepo= sitoryInfo ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSdrRepositoryInfoResp); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SDR_REPOSITORY_INFO, NULL, @@ -262,7 +262,7 @@ IpmiGetSdr ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SDR, (VOID *)GetSdrRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnTransport.c b/Features/Intel/OutOfBandManagem= ent/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c index 30ea84c04b..eec281c5bd 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnTransport.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComm +++ andLib/IpmiCommandLibNetFnTransport.c @@ -26,7 +26,7 @@ IpmiSolActivating ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_SOL_ACTIVATING, (VOID *)SolActivatingRequest, @@ -49,7 +49,7 @@ IpmiSetSolCon= figurationParameters ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM, (VOID *)SetConfigurationParametersRequest, @@ -70,7 +70,7 @@ IpmiGetSolConfigurationParameters ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM, (VOID *)GetConfigurationParametersRequest, @@ -111,7 +111,7 @@ IpmiGetLanConfigurationParameters ( return EFI_INVALID_PARAMETER; } =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS, (UINT8 *)GetLanConfigurationParametersRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiI= pmiBaseLib/PeiIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c index 8679cd95db..b97152208a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBase= Lib/PeiIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiB +++ aseLib/PeiIpmiBaseLib.c @@ -48,7 +48,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -65,7 +65,7 @@ IpmiSubmitCommand ( ASSERT_EFI_ERROR (Status); return Status; } - Status =3D IpmiTransport->IpmiSubmitCommand ( + Status =3D IpmiTransport->IpmiSendCommand ( IpmiTransport, NetFunction, 0, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c index 6282adc269..ee1d3d5bed 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiB +++ aseLib/SmmIpmiBaseLib.c @@ -96,7 +96,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -133,7 +133,7 @@ Returns: return Status; } =20 - Status =3D mIpmiTransport->IpmiSubmitCommand ( + Status =3D mIpmiTransport->IpmiSendCommand ( mIpmiTransport, NetFunction, 0, diff --git a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLi= bKcs/IpmiLibKcs.c b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library= /IpmiLibKcs/IpmiLibKcs.c index 700e413aa6..2b02ba6a20 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/Ip= miLibKcs.c +++ b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs +++ /IpmiLibKcs.c @@ -193,7 +193,7 @@ UpdateBmcStatusOnResponse ( **/ EFI_STATUS EFIAPI -I= pmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *RequestData, @@ -222,7 +222,7 @@ IpmiSubmitCommand ( } =20 IpmiInstance->Signature =3D SM_IPMI_BMC_SIGNATURE= ; - IpmiInstance->KcsTimeoutPeriod =3D PcdGet64(PcdIpmiKcsTi= meoutPeriod);=20 + IpmiInstance->KcsTimeoutPeriod =3D PcdGet64(PcdIpmiKcsTi= meoutPeriod); IpmiInstance->SlaveAddress =3D PcdGet8(PcdIpmiBmcSla= veAddress); IpmiInstance->IpmiIoBase =3D PcdGet16(PcdIpmiIoBas= eAddress); DEBUG((DEBUG_INFO,"IPMI KcsTimeoutPeriod=3D0x%x\n", IpmiInstance->KcsT= imeoutPeriod)); @@ -269,7 +269,7 @@ IpmiSubmitCommand ( } =20 Status =3D SendDataToBmcPort ( - IpmiInstance->KcsTimeoutPeriod, + IpmiInstance->KcsTimeoutPeriod, IpmiInstance->IpmiIoBase, (UINT8 *)IpmiCommand, (UINT8)(RequestDataSize + EFI_IPMI_COMMAND_HEADER_SIZE) @@ -287,7 +287= ,7 @@ IpmiSubmitCommand ( // DataSize =3D MAX_TEMP_DATA; Status =3D ReceiveBmcDataFromPort ( - IpmiInstance->KcsTimeoutPeriod, + IpmiInstance->KcsTimeoutPeriod, IpmiInstance->IpmiIoBase, (UINT8 *)IpmiResponse, &DataSize @@ -301,8 +301,8 @@ IpmiSubmitCommand ( } =20 // - // If we got this far without any error codes, but the DataSize is 0 the= n the - // command response failed, so do not continue. =20 + // If we got this far without any error codes, but the DataSize is 0=20 + then the // command response failed, so do not continue. // if (DataSize < 3) { Status =3D EFI_DEVICE_ERROR; -- 2.37.1.windows.1