From: "Isaac Oram" <isaac.w.oram@intel.com>
To: "Rudolph, Patrick" <patrick.rudolph@9elements.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Dong, Guo" <guo.dong@intel.com>
Subject: Re: [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support
Date: Tue, 21 Mar 2023 19:33:18 +0000 [thread overview]
Message-ID: <SA1PR11MB5801E8770A149B19673F591CD0819@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230320085327.1387588-2-patrick.rudolph@9elements.com>
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
In the future, please CC maintainers from https://github.com/iworam/edk2-platforms/blob/master/Maintainers.txt in the commit messages.
-----Original Message-----
From: Patrick Rudolph <patrick.rudolph@9elements.com>
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support
- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv
Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4358
---
Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
index 2fbb8215..51aa8de5 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
@@ -38,7 +38,7 @@ def BuildUniversalPayload(Args, MacroList):
# Find universal UEFI payload build build script
#
Edk2PayloadBuildScript = os.path.normpath("UefiPayloadPkg/UniversalPayloadBuild.py")
- for package_path in os.environ['PACKAGES_PATH'].split(';'):
+ for package_path in os.environ['PACKAGES_PATH'].split(os.pathsep):
if os.path.exists (os.path.join (package_path, Edk2PayloadBuildScript)):
Edk2PayloadBuildScript = os.path.join (package_path, Edk2PayloadBuildScript)
break
@@ -49,7 +49,7 @@ def BuildUniversalPayload(Args, MacroList):
BuildDir = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/UefiPayloadPkgX64"))
PlatformFvReportPath = os.path.join(BuildDir, "PlatformPayloadReport.txt")
UniversalUefiPld = os.path.join(BuildDir, 'UniversalPayload.elf')
- PlatformFv = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PlatformPayload.Fv"))
+ PlatformFv = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PLATFORMPAYLOAD.Fv"))
if "CLANG_BIN" in os.environ:
LlvmObjcopyPath = os.path.join(os.environ["CLANG_BIN"], "llvm-objcopy")
--
2.39.1
next prev parent reply other threads:[~2023-03-21 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:53 [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages Patrick Rudolph
2023-03-20 8:53 ` [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support Patrick Rudolph
2023-03-20 14:23 ` [edk2-devel] " Sheng Lean Tan
[not found] ` <174E26B1017CD4BD.5245@groups.io>
2023-03-21 11:10 ` Sheng Lean Tan
2023-03-21 19:33 ` Isaac Oram [this message]
[not found] ` <174E86249B3DA0F4.22739@groups.io>
2023-03-21 20:35 ` Isaac Oram
2023-03-20 14:23 ` [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages Sheng Lean Tan
[not found] ` <174E26B3110214AC.8852@groups.io>
2023-03-21 11:10 ` Sheng Lean Tan
2023-03-21 20:09 ` Isaac Oram
[not found] ` <174E881872B7EE16.19937@groups.io>
2023-03-21 20:35 ` Isaac Oram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5801E8770A149B19673F591CD0819@SA1PR11MB5801.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox