From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.12421.1684465695616903032 for ; Thu, 18 May 2023 20:08:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IFRArLGl; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684465695; x=1716001695; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VPhsA93U0Gyz1EYM4bDXB0WQ1yp4UkolISsLobnc6cA=; b=IFRArLGlQNcioI42Ei1QKvmliCX4N5FGKTyXJeMGauZH70cmB+H+F8qt 0Zl9Bske8q70RuSHGu/XqBVPMwC65ZKqrWqKwBmFu8ium2GvPPMFfY493 hOOXHZxCTezeb94hvVZ2rgtsntIbeQUFN5Zm1pmrog+/iTjrz03tyNBPt d7+EhcaxxJWiSE/VzaN7vCqXW1SMrfkJyxWl2Mn161zkR9ikUkLw4mLlq SUpd90ZHCKm5GmbPUJghwPvirf+BxmMZMXIUQa1Sp4B25OhJpyhoXRDF5 7QjZrCYruW9kX1G24QuLtN/RrMCLpvTBT+IknaIwE2VskVhFB4P3sDRJG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="332623585" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="332623585" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 20:08:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="733123573" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="733123573" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 18 May 2023 20:08:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 20:08:03 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 20:08:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 20:08:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 18 May 2023 20:08:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jac8gRLtAURvWrieCMWy50CR/dRVT90x9UZxzzkVV1v4/Q3SUgnAoScctVLmC3DxtBbIaxyc5RBLvzkNCn42GD6UwUJFErkt8irT+3FTWU+Q5rLMjtZiWAYK7OmAD2WnI0zQVQZWrrpenOjg/N15O6b6os3iXampfGOgmEiVVWDRU4OgBquE5UwSZS+b+AQ+CEO3tGkDDl1CE1G7LPx5SD2eoh4O84Rg3Ag2d7n7ewnPN1tICvox+BihFf7BTVQy2GbULew/5OMfbAF+e6zhXhAyWd3oWIGWQKH3YK/viWsWsxms6w2qcUC2uC/2je02aM2AK9Sp3/OQ93jKUpmjig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MosZksk+o+SUY9f6vehjCQwp9WsOZ56m1sEGmvht9es=; b=e5Eh2IkKU/0umQgMGjK+84T/B85lWADzrHcSlXsM+tI+EKuOi/7AF26uHmOXbF0rl4aByCH3qJdhVRECSSvjzDpIG+qzewM7mRvKAWJm9NIS0MQ8J1Va4kM4/iK+LdNRe+JJ8IwI54KM5s/Ug55O4C4M0wvKQjkICe8nXVtALL9F1H9+e3/TbiB7bu6qJE1VG5uGPfON8Aq50E+MLRml5WDgyWNR0FhvYvVI2KlgGv5d/KQ59M9YuKY8LUC8wL62RrwhUyUOi+SgmNGHE+EMNZSml15vGtZogeT5qwboceE3+XJQfZh/pOjKbhnNp54Nj/JYHhxzepajSoELDbGnbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by DM4PR11MB5357.namprd11.prod.outlook.com (2603:10b6:5:394::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Fri, 19 May 2023 03:07:56 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::6979:a90f:e224:41c5%4]) with mapi id 15.20.6387.030; Fri, 19 May 2023 03:07:56 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: Abdul Lateef Attar , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiFru: IPMI FRU Driver Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiFru: IPMI FRU Driver Thread-Index: AQHZhIGtUmSltMosi0qEUw1qmgTIva9g9SBg Date: Fri, 19 May 2023 03:07:55 +0000 Message-ID: References: <20230512032633.1740-1-abner.chang@amd.com> In-Reply-To: <20230512032633.1740-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|DM4PR11MB5357:EE_ x-ms-office365-filtering-correlation-id: 142966b9-b249-4895-91c9-08db58163e27 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IFAvxj17RX1N8Jo8UQxyqhlArXVJP9A3CZv8GVeX/J7kK2qzZX5POkQQHsR/wKIA708m1gLO1rtn9qekKhfeQxLmyeaGMmTRkk6YsfOiDWVOBaY/nggQRxSJYw2Cto3Stahly5K8WnXohd9LCG0rtPmgAehyUKVnN3ZHeIVI5QPsY90w4F8OKIm7gn/c+o+PtZTpEAu42ih+LUMhgdNIqmF+12SocZ/iCdJQQwRktu4h7cnpF8sMOwlRjqQo9fEH3qpacYnfdipCuDtt4WyWBKH+4rHVA0M5WzitWGOROz2xgdOlfesSa59OPCHSMLYmTEu+L7gU92P2cFTdtswvM+61qtq4MIOHbxwT76Eiq9DCBrF1NV0Y+17RYluazEOS8KMrrlcRqV/qA0zKgKeUKTi94B+LtgfxWU9d37CQXk8wgQx1nQCsryXnjz/2GV25WeN/S+BlLagYOy4qjDJTwwdMk5ysPpR3Z3bPlrzw5Ji6Ohcw4FQGN8nu5g/vZ+pmGVuOEnJL9KcFqJoWRqmM5El3OEurY8nb+sRkjEXf5/vsECbxikHato45xrA304q3oFpWhWI2h3gMN6/+xkAGFyPkS5ZVJBkTCFBV8vV6sUX1kiey0HR2ikHtY2GevYxD5oyazWrtHcz7oLCMSoO4eQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199021)(2906002)(316002)(478600001)(52536014)(41300700001)(4326008)(8676002)(8936002)(19627235002)(54906003)(110136005)(5660300002)(66899021)(71200400001)(66556008)(66946007)(76116006)(64756008)(66476007)(66446008)(7696005)(53546011)(966005)(9686003)(6506007)(26005)(82960400001)(38100700002)(186003)(55016003)(122000001)(83380400001)(38070700005)(86362001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UohalLUfsS674Tp/qgvBtJ2FRubsdoapfyh6WzmFqi7dNb/9xOf9nWffdIiA?= =?us-ascii?Q?TMH0qwYmOKcGdA/exZ8+Cg7cEFSPuQYtOdHImoGpvBJZKGAh5mnYV/FZ6ko6?= =?us-ascii?Q?1V2xSQazpi9OFJg7/L+S/s08McBEYSzO9RIqGqTaAPHN7RIG/rzKVo126/1F?= =?us-ascii?Q?HNDS0zWrcMQHrURbyFWmk+f9zsAPqhiYbQ4HkWjX9ota2nniYBrxAqFEXZow?= =?us-ascii?Q?+5x7d/ALYN7PfNAqybQxuAVRrseQ3anOtsA0I300t84F0zR20Wmr7qhYiaug?= =?us-ascii?Q?u8ZDNGgNC6mHnkF7dQpg/a/MAqcaBoTVbw8LTAOLbzLC0TrBCAlY2+momDGG?= =?us-ascii?Q?JUNmq0vnzvvZ6d+TUpy2laOheL4NNUOLhUS27hnhx0gsOGH6XCv5a3RsOwkn?= =?us-ascii?Q?Qrl3vDTJEOFqs74AOhoZNyvNe8TZhI45TFIPCazDGMgDuBOZh6Bj1EgSgjXq?= =?us-ascii?Q?kt5Y2+AoDB6VV7PMzOtMAuSHaEqGQAaPfLmiKyjgz7dSE4El3v6zffGJo6ta?= =?us-ascii?Q?y09J/aWy4IEjhQ7kh5TGCp1p94zgB8Nb0xWtgEhcrI3yROXzq0cxL4Xaa3/J?= =?us-ascii?Q?pMSBR+qlUnFHLmGvy9CO2H4tXH+/OgjUP9ELVX0zayMXojNlPqsI/2gUDMdJ?= =?us-ascii?Q?uQUJWim4sup0wbmoEYMXRmJ6+SCb0DljOGrOMLF5qM0xLa39aMKyL918di9p?= =?us-ascii?Q?LRssDABzUH656v+/B/CfupM/mo8/rOqe8f6q5XVoZI9hq6lsdxnBKOPUwD8l?= =?us-ascii?Q?xTJXK+E3B0bEuCW2UMY28mxMBMxf5GgKJ3jRRlbgTYMoi+R5LMziAZWwnf4N?= =?us-ascii?Q?2ZwGBOF/7DLHuCpjTzE38Y8t5H8UYCn7Y1jbJFQ5iMCVMJ5qpgZQZkVgt983?= =?us-ascii?Q?xQIGhiRMnfCS3ma6b4Dn5mW+TAhJcMG7tEOqIYO+qaMeZ0FcxpdO8i5nvVku?= =?us-ascii?Q?eMHBpdEpj09BfVBLdHqS8Z3KkhofnwkORG/iG+QFYi615FObO+eVfei7L/BB?= =?us-ascii?Q?05Ka+UO5jVtECH0akahS5GUnEZP/c6oaCUF0numRhgvvx5987T4KGAYo7Mbj?= =?us-ascii?Q?5FCisQ0tze+RUSNveSYKi1bZD7XZoTrfEmahpZSJRCVvUw+QV5B7iTE+Db1E?= =?us-ascii?Q?MkQ6ZNVEhFN1t4Ta7ceDpAxTH4u89VZlXUHGLrnEjddhHDs/5jHYxVnKPvbo?= =?us-ascii?Q?eXq1NSWuZkwVeiIKESF5gGN0HIG6pZ6299HnlrN/KlqZ6fnqukZVfQSnBTXV?= =?us-ascii?Q?Alux6No32dsTZd7pWFO8N1OV6/iKzAko+Jv6/y/Rv/OlKkcoX0egDWG1z9H7?= =?us-ascii?Q?aENqmpvcRJk4ya7ht9e0STl1b0yIJbFO2QGOoCixuyRrQ6DQ6owLrOXorjnl?= =?us-ascii?Q?e9VesPDjMHlyx6U9vTxx3CZ56v5MPHNgrMPbIbAB50NSNKmv/jFeZHYr6QvM?= =?us-ascii?Q?Ekk+nhEP5B/W4WJpIlg7MeBN6A8Ibm3DNaDDpsQUIAQY6fTG6Qe25wvrnm4+?= =?us-ascii?Q?j6bT4pYC/0sdT4D0GgNJVEq5e44KdS8eAY1pOgGh+4e0EXGccfBgeahzUB4o?= =?us-ascii?Q?xal3+Zh8qR2TU7x+TEqrQFiXi+hFgRpQMWOAHBtT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 142966b9-b249-4895-91c9-08db58163e27 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 03:07:55.8322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CtC7lIxRPlmfSVIc/XQpPMzbEktmIrKUboJd444MNv+Maouuy977xiXdjyxvzvZDOqG/cqdN7RXvYeBUDHcpJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5357 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chang, Abner= via groups.io Sent: Thursday, May 11, 2023 8:27 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Abdul Lateef Attar ; Nickle Wang ; Tinh Nguyen Subject: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiFru:= IPMI FRU Driver From: Abner Chang IpmiFru is cloned from edk2-platforms/Features/Intel/OutOfBandManagement/ IpmiFeaturePkg/IpmiFru in order to consolidate edk2 system manageability support in one place. Uncustify is applied to C files and no functionalities are changed in this = patch. We will still keep the one under IpmiFeaturePkg/IpmiFru until the reference= to this instance are removed from platforms. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../Universal/IpmiFru/IpmiFru.inf | 34 ++++++++++ .../Universal/IpmiFru/IpmiFru.c | 67 +++++++++++++++++++ 2 files changed, 101 insertions(+) create mode 100644 Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf create mode 100644 Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.c diff --git a/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf b/Feat= ures/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf new file mode 100644 index 0000000000..ddef310309 --- /dev/null +++ b/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf @@ -0,0 +1,34 @@ +### @file +# Component description file for IPMI FRU. +# +# Copyright (c) 2018 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ### + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D IpmiFru + FILE_GUID =3D CD9B99D9-E86F-48CF-A8EB-20120AC22666 + MODULE_TYPE =3D DXE_DRIVER + PI_SPECIFICATION_VERSION =3D 0x0001000A + VERSION_STRING =3D 1.0 + ENTRY_POINT =3D InitializeFru + +[Sources] + IpmiFru.c + +[Packages] + ManageabilityPkg/ManageabilityPkg.dec + MdePkg/MdePkg.dec + +[LibraryClasses] + DebugLib + IpmiCommandLib + UefiBootServicesTableLib + UefiDriverEntryPoint + UefiLib + +[Depex] + TRUE diff --git a/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.c b/Featur= es/ManageabilityPkg/Universal/IpmiFru/IpmiFru.c new file mode 100644 index 0000000000..2b489410db --- /dev/null +++ b/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.c @@ -0,0 +1,67 @@ +/** @file + IPMI FRU Driver. + +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include #include =20 +#include #include + +/*++ + +Routine Description: + + Initialize SM Redirection Fru Layer + +Arguments: + + ImageHandle - ImageHandle of the loaded driver SystemTable - Pointer=20 + to the System Table + +Returns: + + EFI_STATUS + +--*/ +EFI_STATUS +EFIAPI +InitializeFru ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + EFI_STATUS Status; + IPMI_GET_DEVICE_ID_RESPONSE ControllerInfo; + IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST GetFruInventoryAreaInfoReques= t; + IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE =20 +GetFruInventoryAreaInfoResponse; + + // + // Get all the SDR Records from BMC and retrieve the Record ID from the= structure for future use. + // + Status =3D IpmiGetDeviceId (&ControllerInfo); if (EFI_ERROR (Status))= =20 + { + DEBUG ((DEBUG_ERROR, "!!! IpmiFru IpmiGetDeviceId Status=3D%x\n", Sta= tus)); + return Status; + } + + DEBUG ((DEBUG_ERROR, "!!! IpmiFru FruInventorySupport %x\n",=20 + ControllerInfo.DeviceSupport.Bits.FruInventorySupport)); + + if (ControllerInfo.DeviceSupport.Bits.FruInventorySupport) { + GetFruInventoryAreaInfoRequest.DeviceId =3D 0; + Status =3D IpmiGetFruInventoryAreaInf= o (&GetFruInventoryAreaInfoRequest, &GetFruInventoryAreaInfoResponse); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "!!! IpmiFru IpmiGetFruInventoryAreaInfo Statu= s=3D%x\n", Status)); + return Status; + } + + DEBUG ((DEBUG_ERROR, "!!! IpmiFru InventoryAreaSize=3D%x\n",=20 + GetFruInventoryAreaInfoResponse.InventoryAreaSize)); + } + + return EFI_SUCCESS; +} -- 2.37.1.windows.1