From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.2986.1672946743831338732 for ; Thu, 05 Jan 2023 11:25:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=msm0kvjZ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672946743; x=1704482743; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4Gkiu73r2nFnHnuPPGDqXke+TMwt/rr4hHUCziv4v2o=; b=msm0kvjZQsLw8jan8zGOODF62WPOoLgCm3Wwo0S8ddfS3i8GbUOVDaqd SAO4srL2NyzHa5SqkHGtICo5XVT6WYECECIJdr5MVVMKXuegz32WzMOG5 5yKvTLkUt3qXA9RPg2tg06qfqRHYHAtylRArSXjd0GQzGOFfPIlJV/jit GudheZrlvPkkIn4JKNiY7sO7bhEfxPsM4xiNaJBDepNHv/o5O3O+YnUbv V1pmyx/j9TwMchouboikMwlRatPMoxgXNFGygvVwqEWupf/l91zbGw3Y9 cfQx1aNg6QzHvYMRyDw6Qf9qub7Ypg+2b3yuFehEsBjkLofTPiO5VHG5Q w==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="305823351" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="305823351" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 11:25:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="657644621" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="657644621" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 05 Jan 2023 11:25:36 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 11:25:35 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 11:25:35 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 11:25:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK4V/4C2ZOiqKDTtMZlUlnxbcffQCmQKVgdmawhWFvpUkwxYPSR/XCgWW9TU2pfT3Fg8z1Kd1nP1pUJq+1hj3nX0C5oA+kZPUmxtH9WdyL6JJitnRuLYNiFK0AFzUrO9Diggk7EQDHWSYsOn7/yhSaSAiKQ0j2nT8ePupTVuRZUtuKE2DcmHAs6mnPPHOAexnExbluo3bXnTnYUfu6rtQc1jOHgVKubucUdzzneBDh8HQEdgT6QBazd5NF5zHOxJfDdVaehXMXWkCVOh+t2/V/23tWt4UVQQp8r3l41tQp/eq6CJJKinuW4Hh/TFt2T/+As9Bj8itwe8wAb1Op8+ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xX1FP08g+OnRldE9o9Jjt+F1iKwMHCDnNWZvUJpasjs=; b=e+lMpKF1vfcFkVFsHYTS/5fPGhVgisg71p8i/fjj8D5hFEGpWXuVbb47m+ayz9ZhQPXvUwL8jkWBFom1rfZyP81tCGetUHmMOvfE6jDFBcn3qb04pDtCrAiPBB4F5HH4UwOVPGz+/w7D4d8h3caxTCCg5npPszm4lGTKoIxcv7O092Q7n3XjKa1QRt1ZSHZiylzQVpfWTMosMoheztCieqr32Yb5eEZ6ect7pm+aecp8YPjkkw1xwV0/eUhb8ErVbK8eJrB94t7nGI2X96+nKaTP9aSGHd+/eTsQoG86XYcIlbwqRluXl7P5/45F3Gw5RjoCVnMTm/ItPGyPSATi8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by SA2PR11MB4843.namprd11.prod.outlook.com (2603:10b6:806:fb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 19:25:34 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::b190:fa87:aa79:58b9%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 19:25:34 +0000 From: "Isaac Oram" To: "Ni, Ray" , "Chang, Hunter" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "S, Ashraf Ali" Subject: Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Topic: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Index: AQHZIBFQQkLmbDEqd0O98ZYtpCQK566PaAiAgAANooCAAB1RAIAAom4w Date: Thu, 5 Jan 2023 19:25:33 +0000 Message-ID: References: <20230104074715.1782-1-hunter.chang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|SA2PR11MB4843:EE_ x-ms-office365-filtering-correlation-id: dfb52ddd-aab6-44ca-9f34-08daef529dc5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8t36zIFEWrN/wf9hGemLD7wIuVUVxMoxf0orbRzLXxFmHSCVTq/7dv7NLTbk5s8uhtrQ7D2/1FBS8YvPiS1Cee/MrLeICW8/gSAewwJ1WOXafogIDrMRkCCEBsZAT2i+bLdcLTbZo/Z646wdVzhs724t9oAn5/kv/J8qQwnhKWeldrUHusLQFHqxTjfjz6eMHxx0kkrOq5bBskZlXCWcvCJyRlWsg6lTPjC8grqAZSNT9pimHu9c9qZ8ubyENhoB/hBC7HtSmtAn05XmY9Ch0K5YvqGwyKmd1rCGpRgs88oyblfac0XYkRR87r02IpDtzgHSbioEpaHaRFAlQwzYvI4O+Gf8OQaD+EY7zR5AQi4/8EgHfTkaJ7UkVAvpHlF526YDFV5XnXfXAf9irr5eOlu78snj63SiGRdr0S0yeNF9JgUJojAQsaQFj5ZfR9YZeYacK0v72LJ1P290XC1e1CmCjeFnTyPkoV4ZlMR8K9DTvDDDGlpC2T2vqz8id79BhueqY3Jsfbjhcm/sujxWUpAfSSCt9DcqOhi0q1QOz0v5kRDQvrq/J+ec4970XzIyjSHiuoUHwPNmr4LQbe88S9z4EU0sqhgXZPpnzvYIQ5XsDN6n5G1pcH5x1M0PbPiObaFwYkgcNkUnNP2yvBUzTKdreYi5ESZ7FnNQCMQdjCx+F060Kq22w1grYmCy8mFasru4DQL7CZUThK2qdlsuvZ85u690QGSoKNYmgZxDjfU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(66446008)(5660300002)(8936002)(41300700001)(8676002)(4326008)(2906002)(66556008)(76116006)(66946007)(316002)(64756008)(110136005)(54906003)(71200400001)(66476007)(966005)(478600001)(52536014)(33656002)(55016003)(26005)(186003)(9686003)(7696005)(6506007)(107886003)(83380400001)(53546011)(38100700002)(82960400001)(122000001)(86362001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MdC7KsV1PYsTjrZMu8BQqRZgGrEmlG5qmZO+XONBrTPxrdxB54Tfg7MAze4Q?= =?us-ascii?Q?X/l4SCguGRs0OsZIUUGLMx9k0+V8x0/iMhOCpUWXFxrAqZvVNUnMRdSYGZ7J?= =?us-ascii?Q?WpGtVNJ38LOEwe3np2gq+ArTWZAuCHaYu7f+pwyaR5ddpjDXQRV2xjwE74An?= =?us-ascii?Q?zaTUVHJv0FytlRWn0/JweJrkUWROCzVZUWWR1SXZD66xO251bpy2dstFXrFL?= =?us-ascii?Q?74rVlHFs6t0/remNgSMMfq7pxt+isJmNl/cEMliMOhLKiu5HwpqlbAsiWgdI?= =?us-ascii?Q?XLSDQ91typDOVC4V/rCog+dLqc0zasojg4S2pRZ2carMdLyaWc1Rsh4fRB4P?= =?us-ascii?Q?4rJAuK5IKoBJUhQLa5SR3BJeoO1yXJdvrxC8PrEp+Eai0tYuWRRGwFaFzKma?= =?us-ascii?Q?sCm+XYAQskJP54tJxoMLOvVsn5jygvPZOB0oUZDMrH+LYDmPcErKxDAPXIMo?= =?us-ascii?Q?9KXXMnTL4mVgC+Hrazzt4hRE/16XsiLCGCeKFRkJ+2tmtz3DM5C2ViriEEMS?= =?us-ascii?Q?IcJ+pRLoTI72HLe0n6qs9PtPk7X2i59mcdXvh6a6QzQEUw8kvu2UdZnsvLJm?= =?us-ascii?Q?7yPGmYCIR54VQDk6WWNJ15kFairHBEH9RRyS/JGLYUjPhU34S7KodAZ9YOxp?= =?us-ascii?Q?Y2yXuXTs9OxVm3qL+PunyV0t3iglyEOEvBjVKwGM2vUuauSQl5FgrLRYDqJ0?= =?us-ascii?Q?QEzuczNR9ChfocvRrj3l0/1aMUyi/AG22eaqXUWuBS7lF5PYIJrg7PnHVwVi?= =?us-ascii?Q?mHmVKsYoQMRpL/wH7wXXK38438nYeO/pVAZxOhmY97JevVKno7vZOUWkXOC5?= =?us-ascii?Q?enRbGLSV8l0TsBFQY2g4790MF2EtPvXwsISUnnyNuuEMjrGDFB5V45YtCuIZ?= =?us-ascii?Q?4NCDiTDAoFQZGqpsNjIjymhc6NAAav56SzKw7NjbWP5rdyRz6YJdn0DPP3tO?= =?us-ascii?Q?2Ub673pvTNSKuBH+J4b9hCut2LpQY54pglqCSdizj3nAHdcoviY1SLAwuFGe?= =?us-ascii?Q?04UdIbPBzYX3sWIhzlGozlmF7hI0JFDY23qby5xP4wZPZgiVnIarZlxsV5CI?= =?us-ascii?Q?DzB47piJa/Ffo8EmtaO+n+GgHwHSj4JH3luXkVvW8UjrgcHbCuEI5Mus+Z0I?= =?us-ascii?Q?VsO1TaT/e8ILKBhJEmAz6XPL1+JHyU4nzvzUu4PgB5DhL8agA0Jht+mUOao9?= =?us-ascii?Q?dubJDYU0FHuJVi08I9CbFDSvOsR6kPduP0yTtY17LdGFRRqRB/If7sxUs8bS?= =?us-ascii?Q?Z104JRa7oKaaPZN8U4Q+lGA6h1ZOQ23DaBBE/1Bv47DQt6MOg1KpN2VZ/qbX?= =?us-ascii?Q?6jNbtRgO/TvWBWePBktQ8/jc88nJil/0fn26kcg3dJ0ZpeYuo+WZCq9yDXrn?= =?us-ascii?Q?MkaZqwk9YmuKtDetjakBC7uInkcl+oPALZ8FR/thOMduxDGmpznAgrTufn2V?= =?us-ascii?Q?DKSaRskbg9/Mfm3DaxHExUz/U1Bp3zX4TLTm8R6MPf+P730JaViCwMyrsFpu?= =?us-ascii?Q?kN18m01j6fjIXuTsQHAEDPcJiE5qasZ1e4CSj/wrInbOFJEormy+Jdzoy+dM?= =?us-ascii?Q?zS/qxN7vnC4S2aNLfrULY7nsK4BVZMKWrphYMKi1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfb52ddd-aab6-44ca-9f34-08daef529dc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 19:25:33.9365 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k+A57wfXOlSr6Dugxo6Y54+OexnyiTLKz4XDrr0yVEZMeNoiLvBErs70q+avfxQD/cDVBB4ogBxP47VqDoFF0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4843 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, I think it is ok because this file is "Intel common definitions for an OEM = defined SMBIOS table structure". We could say that the folder name is wron= g or the whole file is in the wrong place. But this addition seems consist= ent with the rest of the file contents. Regards, Isaac -----Original Message----- From: Ni, Ray =20 Sent: Thursday, January 5, 2023 1:39 AM To: Chang, Hunter ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in = FirmwareVersionInfo.h If it's not defined by any spec, it's probably not a good idea to put the d= efinition in an industry header file. > -----Original Message----- > From: Chang, Hunter > Sent: Thursday, January 5, 2023 3:54 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac=20 > W ; S, Ashraf Ali > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > definition in FirmwareVersionInfo.h >=20 > It is from Sipkg.dec > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD >=20 > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are=20 > available for system- and OEM-specific information >=20 > I think there is no spec define 0xDD. >=20 > -----Original Message----- > From: Ni, Ray > Sent: Thursday, January 5, 2023 3:05 PM > To: Chang, Hunter ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac=20 > W ; S, Ashraf Ali > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > definition in FirmwareVersionInfo.h >=20 > Which spec defines 0xDD? >=20 > > -----Original Message----- > > From: Chang, Hunter > > Sent: Wednesday, January 4, 2023 3:47 PM > > To: devel@edk2.groups.io > > Cc: Chang, Hunter ; Ni, Ray=20 > > ; Chaganty, Rangasai V=20 > > ; Oram, Isaac W=20 > > ; S, Ashraf Ali > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition=20 > > in FirmwareVersionInfo.h > > > > From: Hunter Chang > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4242 > > > > Define a macro for SmbiosFeaturePkg usage which named=20 > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in=20 > > IndustryStandard/FirmwareVersionInfo.h > > > > Signed-off-by: Hunter Chang > > > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Isaac Oram > > Cc: Ashraf Ali S > > --- > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi > > on > > Info.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > si > > onInfo.h > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > si > > onInfo.h > > index b30bc3f9e7..466cb8e7d2 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > si > > onInfo.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmwar > > +++ eV > > +++ ersionInfo.h > > @@ -18,6 +18,7 @@ > > #include > > > > > > > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version In= fo" > > > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD > > > > > > > > #pragma pack(1) > > > > > > > > -- > > 2.26.2.windows.1