public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oram, Isaac W" <isaac.w.oram@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Sinha, Ankit" <ankit.sinha@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying PCD category based on MinPlatformPkg
Date: Thu, 7 Jul 2022 23:51:48 +0000	[thread overview]
Message-ID: <SA1PR11MB5801F1B50B916AAC801112DED0839@SA1PR11MB5801.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220707173330.2066-4-ankit.sinha@intel.com>

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sinha, Ankit
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-devel] [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying PCD category based on MinPlatformPkg

From: ankit13s <ankit.sinha@intel.com>

PCDs need to be re-categorized based on the changes in MinPlatformPkg definition

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Ankit Sinha <ankit.sinha@intel.com>
---
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc | 8 ++++----  Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
index 6f6fb20d461c..050f9b6228ef 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.ds
+++ c
@@ -254,10 +254,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -372,6 +368,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
index bed0625df9ef..5940c40dfc9d 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.ds
+++ c
@@ -257,10 +257,6 @@
   gEfiCpuTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmCodeAccessCheckEnable |TRUE
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5
-
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiEnableSwSmi|0xA0
   gMinPlatformPkgTokenSpaceGuid.PcdAcpiDisableSwSmi|0xA1
 
@@ -375,6 +371,10 @@
 
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0000
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000004A5
+
 [PcdsDynamicExDefault.X64]
 
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
--
2.27.0.windows.1







  reply	other threads:[~2022-07-07 23:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 17:33 [edk2-platforms PATCH V1 0/6] Re-organizing ACPI FADT PCD categories Sinha, Ankit
2022-07-07 17:33 ` [edk2-platforms PATCH V1 1/6] Platform/Intel: Modifying PCD class for some ACPI related PCDs Sinha, Ankit
2022-07-07 23:51   ` Oram, Isaac W
2022-07-07 17:33 ` [edk2-platforms PATCH V1 2/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined Sinha, Ankit
2022-07-07 23:51   ` Oram, Isaac W
2022-07-07 17:33 ` [edk2-platforms PATCH V1 3/6] Platform/Intel: Modifying PCD category based on MinPlatformPkg Sinha, Ankit
2022-07-07 23:51   ` Oram, Isaac W [this message]
2022-07-07 17:33 ` [edk2-platforms PATCH V1 4/6] Platform/Intel: Updating " Sinha, Ankit
2022-07-07 23:51   ` Oram, Isaac W
2022-07-07 17:33 ` [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined Sinha, Ankit
2022-07-07 23:52   ` [edk2-devel] " Oram, Isaac W
2022-07-07 17:33 ` [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs Sinha, Ankit
2022-07-07 23:52   ` Oram, Isaac W
2022-07-12 16:18 ` [edk2-devel] [edk2-platforms PATCH V1 0/6] Re-organizing ACPI FADT PCD categories Oram, Isaac W
     [not found] ` <17012142FB8117E1.15323@groups.io>
2022-07-12 16:20   ` Oram, Isaac W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA1PR11MB5801F1B50B916AAC801112DED0839@SA1PR11MB5801.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox