From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.9298.1678230432964425992 for ; Tue, 07 Mar 2023 15:07:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nGYERKbk; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678230432; x=1709766432; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9YuQVXKxHylEZFv7ooPRBshod/IOI10PVwsOUTA6jkQ=; b=nGYERKbk+fKuJ/d++l79KWGDyGc5EYMaoVQ9xkZ0IrujroO3UnWf5dyo MwzeJ8HCQAOJpAZUoAAYt4Il2yRhNxEkyMUXysCYE9KDFbBYf/TJFqaY/ TsbPAB2sfUo+UAHL6/WZnXrGWzNNanF8eudzBf8LBDXjK+ccnXY77FdAt VDZ0Fq+NiRBzCewZGJvltiFu0+yOGXZaRaR1ZT/Qr5JoFxscvZfBm97aK DfuFKOYal1m5z3gGWi1DA/5FSfs0yaUveU4QCzMHCd1bnJSmmUATCC+bt N51cQN91pA1jQ9Oq3XBIWikLeAJTHNvrbC2sCdHX4IPCYwnh27EcJB/ht A==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="400825348" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="400825348" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 15:07:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="1006064004" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="1006064004" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 07 Mar 2023 15:07:11 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 7 Mar 2023 15:07:11 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 7 Mar 2023 15:07:11 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 7 Mar 2023 15:07:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zexd0vB5D+O9hxdJ/x9bV90Rxmwbe0cH702az6pU7jyTdipI+EKpvgkzICJot2iOkbX0dG3pKzXi0AglWr6HMcjt+WCbFwGjfNoYJ3xzXoYS+idKv3zLEzizrNMi4e6RJsi/awZQJK9cMiG3BEyTe+HtajUj+Hxp7SrsVFHuflWukWpu6TWRkv8eGwzEVYNXuLZi0ZFIS6Nn1z6sJTWrUIk4pPFspYwWM5zV9aWM/xx/9m+UPBexyVszQRLG74nVyG63AdbJy/5/JYhk1TCU3kHzoOkq3XEzxV1dvm49Ho4UvcF/u5m7YqtDomQ4f1J39QZXx/emeJAFfuM0TnRE2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sOwckkZIKLa02wmkkHB+y581VXbmkGZJtNro4cvY1oU=; b=aDYUekuHRsxVzKYJPJxFFHEr0U2aIwDYFzGrYW8tubVM+llR8k/+XxPDkzo9dT+9aGGBfpCYQN2lsYEaZkT6RoMGU6NIJoRaEqoyi7Yn667IqMWmvXslNH9xsmTCkzvInm+PxzGQzECCKhpG+8O6Nz8veAj8xPV/HlKzTQvUUKSmgF5WVZhNHKGJq+IzC0pvz9pSDYhUIPBECiyiTBuNp4YPvg4lZllFcD/nDWY9fZhv1qSQAgfHBltmyvgcGpdeSAeJz9rNMzwSdtxq0nUHMm6qmfMcu31LZz4E+wJH3ACtgigSu/Lbt79AMHzRRzNJlFNK+W4RZGIJyND+YoYiIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by BL3PR11MB6482.namprd11.prod.outlook.com (2603:10b6:208:3bd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.26; Tue, 7 Mar 2023 23:07:08 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::2319:e5ae:6470:462e]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::2319:e5ae:6470:462e%3]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 23:07:08 +0000 From: "Isaac Oram" To: "devel@edk2.groups.io" , "mike.maslenkin@gmail.com" CC: "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/3] IpmiFeaturePkg: refine GetSelfTest function Thread-Topic: [edk2-devel] [PATCH edk2-platforms 3/3] IpmiFeaturePkg: refine GetSelfTest function Thread-Index: AQHZSwONw9fR3zIoh06+bJXgvN4boK7v9x+w Date: Tue, 7 Mar 2023 23:07:07 +0000 Message-ID: References: <20230227232757.9312-1-mike.maslenkin@gmail.com> <20230227232757.9312-4-mike.maslenkin@gmail.com> In-Reply-To: <20230227232757.9312-4-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5801:EE_|BL3PR11MB6482:EE_ x-ms-office365-filtering-correlation-id: 4dbcd603-9a40-4eac-2ecc-08db1f60accf x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8bdEJGMVuwsyP3Z36std7XVq/qnmlMiV4Lr/Nvj9X0wTN3UgTnJmt/29arR2modpixiFzb2rrJMdoHIeMfZGc4pxs5fgg+qTu51VCFEJQf8yUJXLYbxEQq+rtiHa6VyWmv2rHrF1nZSeDhXjcdo75be6e875EJG1AAr5wZ5TGwaAOmDgZpZxsPVRkxt1BBhHTwhjmGm6T6/V4XS3SFzOpTH454sVTdyY6x4qdcQlUHDoPWiVQnoGkVaFl0e5AndpSqn9MuENCmAUVKsTEtF6Jm1oxIZVurTVk1K31MzXpIyOqdNvEjeaeKx1jl8QtWnFUfd0DdgD6Lroct8p+5sOnPADCPJKvxggqWgrtYeab1F2rB3jtIyiqXnHfyT5U8GLTMlGnx7qAw/TnP6+OEAtPmixn6So2wNZ+BDUP5BCTn5EaohIsqLCKsZTjTi3My3Qndm9k9RkTUrIO9rOLLdfIsFb/s1YI2IDEZli8YbSHfC/lf7KD8vn9JuMKRxsPRgZzYJzAay7ponZj/hB/Qhj+IKW09sU8TBrssE9Pmw8BIEcgv7nZlRRUD6DbspuuVNM7UJ7ObtX4/LoXVBcfQEZOZhUhE6rxhmmN887siKzpaJX42zdLvbSZ1cqnwcfZK9ky1FAlHXQUidwzsfOw5/EVsohCxmtF8rawSJlKtH0AgIsC+T650P34dWgmhVgiTeMvU3M2BE0NSFmCEsBJ2lvU2pi29nipkIKIV7Of8U/05Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(396003)(39860400002)(366004)(376002)(451199018)(8936002)(52536014)(66476007)(66446008)(41300700001)(66946007)(76116006)(2906002)(5660300002)(4326008)(66556008)(64756008)(8676002)(66899018)(54906003)(110136005)(316002)(478600001)(71200400001)(7696005)(26005)(966005)(6506007)(53546011)(186003)(55016003)(86362001)(82960400001)(83380400001)(38070700005)(33656002)(122000001)(38100700002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RabsM+siycRUPreGHCEoNRfWKNsL1GSHbUIemdyFQPaCOvotQ/PlXfLSOpOz?= =?us-ascii?Q?WCA/qT2RNW+xLTbwL2I7+lJEHgBhUOVyz5dGqDquf2Vo8hqvUwKcyEfRPuVH?= =?us-ascii?Q?AjqT0annt+UxFT+BI5//WxjifBRnnaqIhYo+4e1QpQ7ZKRW54Afh+aJQWzr1?= =?us-ascii?Q?9rPDD1qaofl9VSsIzd2w9Ry0/6Yu+mGsN+qNLvmopEQDu6XC0BmGYycXPI9D?= =?us-ascii?Q?Pj+VsAFLng8HQxZ2QF4WlqfPtFKhzL/yeQYbtK0ajIxuP+ZcoeN1gYFsIMul?= =?us-ascii?Q?OyOTG/Rk57wPLzoGk3qSQtBq48YxDjkT+3IdmesIeWyinS4qkt6Gd/b75T9E?= =?us-ascii?Q?FuYCwdHRYcsBRc8TcCXU4Ol8XZ/9bhPqVp0xubt+V63KgQ9rB+IgAwEmNBKE?= =?us-ascii?Q?Ml6JhCDnESEeidW2jsR8qE39IBQXnvrWJSH0ISlyBhhwYxwpzITkeZGQJf5H?= =?us-ascii?Q?2k0MCoQPhlcmxSRRrcGNVrVGyHdt6XZQXclpxtYfrtEVy7J6D7Tp3ST9KQ4b?= =?us-ascii?Q?QI3CNR1DYhMSpjQz8nTwQaHL7ERoW1kxEQHmDHpaYQtYWhD/NhUGTFuD7Tc3?= =?us-ascii?Q?+u6cEvvygw3cqgX4ZMBfMdu+ZWiNcCy2D2M0L0tlls3vn5X2tfc4dNuSYdta?= =?us-ascii?Q?Q2j1dkMyARCUIDjhYKWFlCSUXLE12r+6aP+EBQDMPKE0opDGEXdxhs71yd+R?= =?us-ascii?Q?z00yw+Iz7ukirTnlne+9cExZ2t+g03f+3f62U6yzlRwhKH8FA+m/pDidLmjE?= =?us-ascii?Q?HvkQLQl/q9Ktq/+q6O6UwNP8Kcrl/LnaszI0RVl2dWpMaszcWn5A+TEWo2SX?= =?us-ascii?Q?7C+MQawxU+O39MZyf6FMFp0HoGsKAQwxzom+oOyOfmEjO/Ir6zTGgyHQMm0r?= =?us-ascii?Q?wjO4H2cOsBxM+h2ABeofUymoTu3xmQxQElizb7KobroJSTd05TcpGNah7OFb?= =?us-ascii?Q?FPO9xh1UmzXVGMskARgTTG91sWAxA0K2dURRqo5snkNqpvpcKRaOAPpNxulT?= =?us-ascii?Q?yzN+eO4jTtBGpLZHWQ8zpii8/Pn7+/bjzOyYkkYxRnqf+5PhiVyxMDYlDKJM?= =?us-ascii?Q?iQQa79jtABWRxb7BCyyQIISW/+Yap20bDYNxr7WVfNHXMzh3RjbzNLdxLnVk?= =?us-ascii?Q?fabKRltyOgKFW30Eyi+hhd0QVHeJYEHDVhhisvT2Yi97asCuLN6UUVehj/2P?= =?us-ascii?Q?o5ZUls2OJTtd2l/tVenLKOEG2YEQJ0UIuVXd3YKD2bfSQtGTg/p2mHtBq99w?= =?us-ascii?Q?77aA5xy770TaNfNat+y59zHp+Qab4flyo/5bWLp4Fao+3MDag5KGyXGFYtou?= =?us-ascii?Q?f6wDBPLX/RYGI3f9a75Sa/QUCThdNAzaLEPmxbxKq+uONGMGSSHiSmw2Ji8n?= =?us-ascii?Q?a8szTROTPEforMh8SMfdQCk6AyLFZHR40PPImg1reXN8vkkHJd5QCvZauZVQ?= =?us-ascii?Q?gt7Lc6fVNLY1U/Z5Q+oi57RYzdabeNdJ25gIKcKUkD98A/2TxaCL4Uf3cDou?= =?us-ascii?Q?9PoVk5lTG693wwSHIBdgWa+c0R+m8TKCs9iy3eXVeY8tpfM2aKDPSZFB9AUi?= =?us-ascii?Q?2yvpnGjqzRqIjQSPXTHU8meg+DO+bC2PKm6e1g3S?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dbcd603-9a40-4eac-2ecc-08db1f60accf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2023 23:07:07.9169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2WrwrC0QZDZS+v+EisLM6GL/bx0fQYpIfCWaXRiGWXw4igxXQoFgwYlfSj889o5VrB2A12TGYzzlmkjw4QdhIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6482 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Coding convention does not allow Hungarian notation, https://edk2-docs.gitb= ook.io/edk-ii-c-coding-standards-specification/v/release-2.20/4_naming_conv= entions/43_identifiers#4.3.3-hungarian-prefixes Please change pSelfTestResult to SelfTestResult. Thanks, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Mike Maslenk= in Sent: Monday, February 27, 2023 3:28 PM To: devel@edk2.groups.io Cc: Mike Maslenkin ; Oram, Isaac W ; Desimone, Nathaniel L ; Gao, Li= ming Subject: [edk2-devel] [PATCH edk2-platforms 3/3] IpmiFeaturePkg: refine Get= SelfTest function Use predefined type while accessing IPMI command returned data instead of r= aw byte array. Signed-off-by: Mike Maslenkin --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 8a0c596a6434..1db47e28c54e 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -86,6 +86,8 @@ Returns: BOOLEAN bResultFlag =3D FALSE; UINT8 TempData[MAX_TEMP_DATA]= ; + IPMI_SELF_TEST_RESULT_RESPONSE *pSelfTestResult;+ // // Get the SE= LF TEST Results. //@@ -100,7 +102,8 @@ Returns: DataSize =3D sizeof (TempData); - TempData[1] =3D 0;+ pSelfTestResult= =3D (IPMI_SELF_TEST_RESULT_RESPONSE*)&TempData[0];+ pSelfTestResult->Comp= letionCode =3D 0; do { Status =3D IpmiSendCommand (@@ -114,7 +117,7 = @@ Returns: &DataSize ); if (Status =3D=3D EFI_SUCCE= SS) {- switch (TempData[1]) {+ switch (pSelfTestResult->Result) {= case IPMI_APP_SELFTEST_NO_ERROR: case IPMI_APP_SELFTEST_NO= T_IMPLEMENTED: case IPMI_APP_SELFTEST_ERROR:@@ -147,7 +150,7 @@ Ret= urns: IpmiInstance->BmcStatus =3D BMC_HARDFAIL; return Status; } else = {- DEBUG ((DEBUG_INFO, "[IPMI] BMC self-test result: %02X-%02X\n", TempD= ata[1], TempData[2]));+ DEBUG ((DEBUG_INFO, "[IPMI] BMC self-test result= : %02X-%02X\n", pSelfTestResult->Result, pSelfTestResult->Param)); // = // Copy the Self test results to Error Status. Data will be copied as l= ong as it // does not exceed the size of the ErrorStatus variable.@@ -1= 62,7 +165,7 @@ Returns: // Check the IPMI defined self test results. // Additional Cases a= re device specific test results. //- switch (TempData[1]) {+ swit= ch (pSelfTestResult->Result) { case IPMI_APP_SELFTEST_NO_ERROR: = case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: IpmiInstance->BmcStatus = =3D BMC_OK;@@ -174,7 +177,7 @@ Returns: // BootBlock Firmware corruption, and Operational Firmware Corrupt= ion. All // other errors are BMC soft failures. //- = if ((TempData[2] & (IPMI_APP_SELFTEST_FRU_CORRUPT | IPMI_APP_SELFTEST_FW_B= OOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) !=3D 0) {+ if ((pS= elfTestResult->Param & (IPMI_APP_SELFTEST_FRU_CORRUPT | IPMI_APP_SELFTEST_F= W_BOOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) !=3D 0) { Ip= miInstance->BmcStatus =3D BMC_HARDFAIL; } else { IpmiInst= ance->BmcStatus =3D BMC_SOFTFAIL;@@ -182,7 +185,7 @@ Returns: // // Check if SDR repository is empty and report it if it= is. //- if ((TempData[2] & IPMI_APP_SELFTEST_SDR_REPOSITORY= _EMPTY) !=3D 0) {+ if ((pSelfTestResult->Param & IPMI_APP_SELFTEST_S= DR_REPOSITORY_EMPTY) !=3D 0) { if (*ErrorCount < MAX_SOFT_COUNT) = { StatusCodeValue[*ErrorCount] =3D EFI_COMPUTING_UNIT_FIRMWARE_= PROCESSOR | CU_FP_EC_SDR_EMPTY; (*ErrorCount)++;--=20 2.35.3 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100527): https://edk2.groups.io/g/devel/message/100527 Mute This Topic: https://groups.io/mt/97279450/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] = -=3D-=3D-=3D-=3D-=3D-=3D