From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.673.1659572052606468966 for ; Wed, 03 Aug 2022 17:14:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PVH1Qu3s; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659572052; x=1691108052; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TCBvVjNormHrUqY1usM5SMxZ6YTaPPw1PN6joyq9HJQ=; b=PVH1Qu3s6UOYe3DsdtHpMdFmddlaS9wMi4OIaH2KyPZJsurOCffgdtbN yysq0Oisrscurof0iY5Ay+zq9fsIcnrcUVRNwXjSwLjE86Dtr9N/psgNw wGiOgc089mEr70cSmvR/Dyj9tuAKVhQs7v770QYoQ1845uuO2QU23GoI0 9tviKH+HcnToONFOYQzxVGw6Of8FLMhFI4XaNjgQjMgydJ+sRLKTEpfOA jxHI8WAhELC1OHxFMx3zcPvu1Oh/OcTXiwAmxo8GuFB5c3HL0/Y1w6p/F 0SmbasUWfygV/NEz8S8pRZZHIc/ggWsHOuExKI+wZ/RrmmdhePiawVWXP Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10428"; a="291022161" X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="291022161" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 17:14:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="692430081" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 03 Aug 2022 17:14:11 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 3 Aug 2022 17:14:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 3 Aug 2022 17:14:11 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 3 Aug 2022 17:14:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y8Ya8c357Sqw4LzTJNzpknz+qL2pxjDmCPuMDi/qyyU1iaZzxAn5RovS7OI6eCWM61FFuSRBlG6rF7ugsEPxphYesR6RfCikkNL365FvrGdSTRTqKCbklE/p3QeD07rmJuEJkWHfFEXOW78qRnYIkgkI1zl8VHNlWyMabVl7ur6Nhf9jwH3bomdJoNtsqwTEjjsvdfzcC6t3xRp5PsrMgb+8OYDDUCbWRlmYb4+VV1puPyxO3aT4zNRtH6gPozmgwzG3h/Y4sTQr5qWBn4voyUKWiLkDIypdbQyHurlsegRcJ9Hv8VgEhQ4FNE6W9TJwHzpp4BBDbx2wZlApG8h3Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+VZ3QqRjFl1Yd7tmWpjVY43TBKQ6BA8kT3OmO/im/8=; b=lXzMyllc7Jk5BmGLiJTOfM5bP5TbsutWsN/FBKUkw3nYJp5S2CZBzWfxmMnkroLJEsjCT7X5EKNqcaxaCtFmk9DScgd+qO8vlNtdh0ChlSn1yRpYrYBUjDI2+a/WfnXoCEOiRp7QQf+Yrlq0qLf7CrVfcmbU696AErgrwejBDLOtN72hHoEPQGoM9et5UjQmavwla5cd3BqJj6oo+urMNnowte6ZPY5ITK5VaxHirPXUotJxVFZx2UW5kFMAFMt89KXxd070tJoQCvIx+YIX6BGOM0m2TayoF/RXSVKL9cbRDeVWYi9ggCqODeMmOoU/Ju5C6ZyZ40wgStKH4t+sbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) by BN6PR11MB1618.namprd11.prod.outlook.com (2603:10b6:405:d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.14; Thu, 4 Aug 2022 00:14:03 +0000 Received: from SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe]) by SA1PR11MB5801.namprd11.prod.outlook.com ([fe80::203f:2686:96f2:f8fe%8]) with mapi id 15.20.5482.016; Thu, 4 Aug 2022 00:14:03 +0000 From: "Oram, Isaac W" To: "Sinha, Ankit" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Dong, Eric" Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: AcpiTables: Add additional thread mapping in MADT Thread-Topic: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: AcpiTables: Add additional thread mapping in MADT Thread-Index: AQHYoezr/A24Bb1N7U+RWx91JZ8jW62d3XDg Date: Thu, 4 Aug 2022 00:14:03 +0000 Message-ID: References: <20220727191253.488-1-ankit.sinha@intel.com> In-Reply-To: <20220727191253.488-1-ankit.sinha@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e65ded80-13fe-40af-4967-08da75ae3d30 x-ms-traffictypediagnostic: BN6PR11MB1618:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7vhFQGuDFfHKKv3ETi11q4FpIey+xOr2NcNLkdyP1mBzCrN99YaFmobrQgJHD3R40/AlX7GW9i5rC+qxdPVGMt8fkrcmMI8YodZc5fmLZtxEQ9cNNaMVOoLRuxJ7f4eNFU9vUxu4e7X+sveL+oGwsWd8bnhQsCgcjcSGMClFtpb3UJyPmL/S2uoyqw6XaXFPxpINK+h7uTB+othkmv9lSfAxaLDWV2jzpBaGNwsl+BsuuQQOS3fbTJ0jq1o8olecgbxqY5B080fRZaSeauBQ2z7zntljRLv16JseQNeh9JdDdHEJdMfmUC22ihQnSx5r0GK3KBOq3yjlZe3mRw3rYRJqNCd0w4cTLySnsa4mX7gztTbNLuDlr1CTPzeIm0IktMA9T2bX5skalcC4aIqCpit3hYkrVJNNzE1vtf4qgNtml/ICeTYOYX5YtXRom5o0y0JiyGk2Kmn4S3JGvOX2OzNUqh+XYtj46Z1TJmm/BDJdvT5yqFz/hNStTKU6QlakD9l/UGhuJ69+xQ7Sa2HAuDhiNsR4hzNNSQ5BbeEf8x3hWFgFzgmgwHtKdLdWxof6kT5mi+iSZ937TM9MAEDMrQooeZbr/GCjivEkpzKJvS9EyrQWSxD7IpBHeHmjY1tYYYa3XXuI95aw3z3DyD6rTyFjYOH2QJtn1MYSNDavvsnkSzF7h3/qhi2Go3U6joEiv8QKh4shrBv+pB0Qo3TOWdlPvCKAfvFki6ZEZPAW+X9X72Qq3xSN366fw5vp06fy/iKw3foFkNQyvQSskdKgAbMg162Pf+Cf2/eGH8rojldrTC5aj0IwjSbXZ7ThgnM0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5801.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(39860400002)(346002)(136003)(396003)(33656002)(2906002)(55016003)(8676002)(82960400001)(76116006)(66446008)(52536014)(5660300002)(38070700005)(107886003)(66556008)(66946007)(64756008)(86362001)(66476007)(4326008)(38100700002)(122000001)(71200400001)(9686003)(316002)(478600001)(26005)(83380400001)(41300700001)(8936002)(53546011)(6506007)(7696005)(54906003)(186003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0hCYi9l8zgvwjPBPx/JKZONQuMCueDvVDL6HR3Wcf2cLj7lBlf67z4uGTFl3?= =?us-ascii?Q?hcX+KjLHbgjToa8pn64Qb+xSAE8Iz3KingU44SP25OQi0mt8dR4cLliJZScK?= =?us-ascii?Q?Guc/U9DIOx9TCBmw+mdUypbBKNydWaBkXyqbguVZjTc3q7AvLwPra6MROb1t?= =?us-ascii?Q?2EipKW3jyATtRx98cSw1Eu8sRJauHaOhIamxqdpd9x1UpL5paZVb0gkcIiLe?= =?us-ascii?Q?kJmB4hBB73BBC04bOF137AJfL2/Q/UiZaEWO1mggeFE9tZePDg3snyEybXaL?= =?us-ascii?Q?fGBQDO1Jps5eeK58FDXDtSkmBRCHR+9hzC9R5rk+YoApkXOSeFq2kNUJ0p2E?= =?us-ascii?Q?gltmxz3XHrVjYrBqYhQOCdegTMzhoQkdBprqFlPJlkSlIwj0g+PzviZNjEHr?= =?us-ascii?Q?i12WEaN7Y3MHNVNsfVJOOg8cldjEvMTe4+hmKqLnp9cKBB7U4M8zoO+1qfR1?= =?us-ascii?Q?G/b/mdztENbt541TYlDVbMfhUk62mJY6p4+ydq+k4/XFlo8Xhlt0tg/W4g1P?= =?us-ascii?Q?93wVGl3wFUM46KHOG1pALX9w4QIu9ihFQoF6IwsaTuBYVWup2SoVRbLk+86W?= =?us-ascii?Q?hBQOxxE/qUI0yDFlj8W1JL1NoSr2zY1NVEXVp7MdNHALxMnR+Ir0baowrLoy?= =?us-ascii?Q?RVbxwjXOCRl/mzve+o+7bj9X/7B79NcPrxC+smhBQ5F3CwSVKiUn7guSwftQ?= =?us-ascii?Q?BkyMjbKBRmjfcAtM0V9MIEPSg0FI7lL6943agoF+URmEriKKsslQ69lV4WZC?= =?us-ascii?Q?XksCwyafNvhzGaFvA9uGlI5TLVrcLRJc07Dd4NyBmasqz8cwVpdY4YFzaABh?= =?us-ascii?Q?9+yaiJXFc5W2n/eI3dvzUcUI7+74Am2BFXJLFF7v2gxlSMmo6ixYdZyA381K?= =?us-ascii?Q?y0QdatZ9a1GsvwvlHszw2bw16OrZ0mtbZJGES733kSzOhuZprx7VhcpiIL8X?= =?us-ascii?Q?i1hgVJgIh/Dd5TS/f+Styuici37kCxqdGN129bfaVVzWnta/Rc8ZxwhTqoFG?= =?us-ascii?Q?hzXn5MS//Aki1dcBF67/F6uEznVRDdquNSjpm9F/SDMJbwg9KAfNKpxQf/FV?= =?us-ascii?Q?Q4ZW4+r3IIOTotBCDzePMiFHOcDOuotPHMABVyvNBdD2puKU4K89hdlzR3oq?= =?us-ascii?Q?o4h+RkCQcvUeOa2Ge4K3UHDaeEHIkI2nqGz6ILWDxZTo9XklhDm0tV/tgqZW?= =?us-ascii?Q?xgL8XHuEkF6nutzPfayIKXU4gQkjKy8WwXOj/y1wDrKpFqQCz/g1v+U+wVHZ?= =?us-ascii?Q?EnzuaKMWDn3kXb6elg+yvAZ2iV0EQ0r/zBZB87lUZxwrp97TS5znAfP8/G3k?= =?us-ascii?Q?43kq4786o+HZkBsW1spEjzlOGC86ZfHtKrqx+wZXZkTcEPtyqRy32EaaO409?= =?us-ascii?Q?LPrxd7VaoyUKOBtHKiwtw6R0Bq7YVwhqXkYc3hBofAlczz0MTumaxLbi/D+7?= =?us-ascii?Q?+4GVSjZm3cyoYhykDq5JOuNcSREcC8LgL0Xe92l8XCUwM2obasNFUFKkf9EG?= =?us-ascii?Q?jWv4Krrsbd1t3aSD3Ye8hC3AF2DfaAEaKVIqTaCcl6daIspkLXjo4v72Wa0K?= =?us-ascii?Q?vsT/0VvgX+WP0RcLK3KzsIdevCF5EiQk+yG33BRm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5801.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e65ded80-13fe-40af-4967-08da75ae3d30 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 00:14:03.7368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s1RW93xu2wp6eAPpqcaeXfwkx256RpEIg8paKtZhwhidBYmRpwCKUgXORuR3xeH80hbwKqUbFSUCmfZE8gd8IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1618 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Generally, convention for "Pkg-Module" is "Pkg/Module: " not "Pkg: Module: = ". Kind of a nit, but using : as separator will make parsing tools harder = to write. Convention for comments is "no newline between comment block and code block= " is that the comment applies to that block. A blank line indicates the co= mment applies to multiple code blocks. Please fix the comments to match the new code. Prior comments made sense; = first, middle, last. Second, third, and fourth threads "in the middle" mak= es less sense. I think explaining why we are grouping into the order we ar= e is perhaps important. There is nothing explaining why this ordering and = why third and fourth are being added when they appear to have been previous= ly ignored. That info may belong in the commit message if not appropriate = for the comments. Also note that your author name format settings need to be modified such th= at the author field in the log is: Ankit Sinha Regards, Isaac -----Original Message----- From: Sinha, Ankit =20 Sent: Wednesday, July 27, 2022 12:13 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W <= isaac.w.oram@intel.com>; Dong, Eric Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: AcpiTab= les: Add additional thread mapping in MADT Adding second, third and fourth thread mapping to MADT Cc: Nate DeSimone Cc: Isaac Oram Cc: Eric Dong Signed-off-by: Ankit Sinha --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 16 ++++++++= +++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index c7e87cbd7d9d..524f9914b0b1 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -261,7 +261,7 @@ SortCpuLocalApicInTable ( } =20 // - // 3. Sort and map the second threads to the middle of the CpuApicIdOrde= rTable + // 3. Sort and map the second, third and fourth threads to the middle=20 + of the CpuApicIdOrderTable // for (Index =3D 0; Index < mNumberOfCpus; Index++) { if ((TempCpuApicIdOrderTable[Index].Thread) =3D=3D 1) { //second threa= d @@ -270,6 +270,20 @@ SortCpuLocalApicInTable ( } } =20 + for (Index =3D 0; Index < mNumberOfCpus; Index++) { + if ((TempCpuApicIdOrderTable[Index].Thread) =3D=3D 2) { // third threa= d + CopyMem (&mCpuApicIdOrderTable[CurrProcessor], &TempCpuApicIdOrderTa= ble[Index], sizeof (EFI_CPU_ID_ORDER_MAP)); + CurrProcessor++; + } + } + + for (Index =3D 0; Index < mNumberOfCpus; Index++) { + if ((TempCpuApicIdOrderTable[Index].Thread) =3D=3D 3) { // fourth thre= ad + CopyMem (&mCpuApicIdOrderTable[CurrProcessor], &TempCpuApicIdOrderTa= ble[Index], sizeof (EFI_CPU_ID_ORDER_MAP)); + CurrProcessor++; + } + } + // // 4. Sort and map the not enabled threads to the bottom of the CpuApicI= dOrderTable // -- 2.27.0.windows.1