Re: [edk2-devel] [PATCH] Pkg-Module: Remove Non-ASCII Characters

["SteveX Li" <stevex.li@intel.com>]

Hi Ardb,

The environment is
Windows: Traditional Chinese WIN10
VS15: Visual Studio Professional 2015, Version 14.0.23107.178 Update 3 (have visual C++ tools selected during installation)
Python: Python 3.6.6
Nasm: 2.15.05
LLVM: 11.0.0.0

The error message is " error F000: TrimPreprocessedFile: Error while processing file".
The system could pass the building process after removing non-ascii characters.

This issue might be related with the certain Windows language specific compilers.


Best Regards,

SteveX Li

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Friday, October 14, 2022 4:43 PM
To: Li, SteveX <stevex.li@intel.com>
Cc: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH] Pkg-Module: Remove Non-ASCII Characters

On Fri, 14 Oct 2022 at 04:14, SteveX Li <stevex.li@intel.com> wrote:
>
> It would cause compiler error.
>

Which compiler and which error?

> Signed-off-by: SteveX Li <stevex.li@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> ---
>  EmbeddedPkg/GdbStub/GdbStubInternal.h    | 32 ++++++++++++------------
>  EmbeddedPkg/Include/Protocol/UsbDevice.h |  2 +-
>  2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/EmbeddedPkg/GdbStub/GdbStubInternal.h b/EmbeddedPkg/GdbStub/GdbStubInternal.h
> index 9c3929c812..5eaff61d83 100644
> --- a/EmbeddedPkg/GdbStub/GdbStubInternal.h
> +++ b/EmbeddedPkg/GdbStub/GdbStubInternal.h
> @@ -322,7 +322,7 @@ SendNotSupported (
>    VOID
>    );
>
> -/** ‘p n’
> +/** 'p n'
>   Reads the n-th register's value into an output buffer and sends it as a packet
>   @param     SystemContext       Register content at time of the exception
>   @param     InBuffer            This is the input buffer received from gdb server
> @@ -333,7 +333,7 @@ ReadNthRegister (
>    IN    CHAR8               *InBuffer
>    );
>
> -/** ‘g’
> +/** 'g'
>   Reads the general registers into an output buffer  and sends it as a packet
>   @param     SystemContext           Register content at time of the exception
>   **/
> @@ -343,7 +343,7 @@ ReadGeneralRegisters (
>    IN    EFI_SYSTEM_CONTEXT  SystemContext
>    );
>
> -/** ‘P n...=r...’
> +/** 'P n...=r...'
>   Writes the new value of n-th register received into the input buffer to the n-th register
>   @param     SystemContext       Register content at time of the exception
>   @param     InBuffer            This is the input buffer received from gdb server
> @@ -355,7 +355,7 @@ WriteNthRegister (
>    IN    CHAR8               *InBuffer
>    );
>
> -/** ‘G XX...’
> +/** 'G XX...'
>   Writes the new values received into the input buffer to the general registers
>   @param     SystemContext               Register content at time of the exception
>   @param     InBuffer                    Pointer to the input buffer received from gdb server
> @@ -368,7 +368,7 @@ WriteGeneralRegisters (
>    IN    CHAR8               *InBuffer
>    );
>
> -/** ‘m addr,length ’
> +/** 'm addr,length '
>   Find the Length of the area to read and the start address. Finally, pass them to
>   another function, TransferFromMemToOutBufAndSend, that will read from that memory space and
>   send it as a packet.
> @@ -381,7 +381,7 @@ ReadFromMemory (
>    IN  CHAR8  *PacketData
>    );
>
> -/** ‘M addr,length :XX...’
> +/** 'M addr,length :XX...'
>   Find the Length of the area in bytes to write and the start address. Finally, pass them to
>   another function, TransferFromInBufToMem, that will write to that memory space the info in
>   the input buffer.
> @@ -394,7 +394,7 @@ WriteToMemory (
>    IN CHAR8  *PacketData
>    );
>
> -/** ‘c [addr ]’
> +/** 'c [addr ]'
>   Continue. addr is Address to resume. If addr is omitted, resume at current
>   Address.
>
> @@ -409,7 +409,7 @@ ContinueAtAddress (
>    IN  CHAR8               *PacketData
>    );
>
> -/** ‘s [addr ]’
> +/** 's [addr ]'
>   Single step. addr is the Address at which to resume. If addr is omitted, resume
>   at same Address.
>
> @@ -444,10 +444,10 @@ RemoveSingleStep (
>    );
>
>  /**
> -  ‘Z1, [addr], [length]’
> -  ‘Z2, [addr], [length]’
> -  ‘Z3, [addr], [length]’
> -  ‘Z4, [addr], [length]’
> +  'Z1, [addr], [length]'
> +  'Z2, [addr], [length]'
> +  'Z3, [addr], [length]'
> +  'Z4, [addr], [length]'
>
>    Insert hardware breakpoint/watchpoint at address addr of size length
>
> @@ -463,10 +463,10 @@ InsertBreakPoint (
>    );
>
>  /**
> -  ‘z1, [addr], [length]’
> -  ‘z2, [addr], [length]’
> -  ‘z3, [addr], [length]’
> -  ‘z4, [addr], [length]’
> +  'z1, [addr], [length]'
> +  'z2, [addr], [length]'
> +  'z3, [addr], [length]'
> +  'z4, [addr], [length]'
>
>    Remove hardware breakpoint/watchpoint at address addr of size length
>
> diff --git a/EmbeddedPkg/Include/Protocol/UsbDevice.h b/EmbeddedPkg/Include/Protocol/UsbDevice.h
> index b299ee10a7..b07f459afa 100644
> --- a/EmbeddedPkg/Include/Protocol/UsbDevice.h
> +++ b/EmbeddedPkg/Include/Protocol/UsbDevice.h
> @@ -83,7 +83,7 @@ EFI_STATUS
>                                  first interface descriptor. If there are
>                                  additional interfaces, their interface
>                                  descriptor and endpoint descriptors follow the
> -                                first interface’s endpoint descriptors".
> +                                first interface's endpoint descriptors".
>
>                                  The size of each buffer is the TotalLength
>                                  member of the Configuration Descriptor.
> --
> 2.31.1.windows.1
>