From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.3283.1663898854611795335 for ; Thu, 22 Sep 2022 19:07:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XZ+sqjSB; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663898854; x=1695434854; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Iyak3dpydbkSA6v/ju3/qnzQabkpYfMtQLbi5D0TDDE=; b=XZ+sqjSBMWKbxR/uVcF8c68GCIFV8qcUjZQfb8cu27Ffd4/uXhcYCasg ZdaaXxBPuj6blGSn1kRskEYRIdQOobaAESnESn2PtxIwiIkwmIgP2FuKw KQ5L3HnF+rchhCNTihqU1lt82xftUDErPQ7+reqGBUvCNCDeKNxrFxvHE poi5s4LLKQ3OgrqYwPZLOTwqvx1Y+tvdhIIP4Fblwn0oIyKEQgWUJkUFr cb/i4/iGsN+ZjPOZK9NeHh0XgQ8NTepa2c8dK1iaBaFsL+6YPpqiQ2+oc X6cJmKcztj9jI85UV43sazTMoCBgNm40bzFla5rMuCn7CQ6BlbzrtKkh+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="299209150" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="299209150" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 19:07:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="865121644" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 22 Sep 2022 19:07:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 19:07:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 19:07:33 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 22 Sep 2022 19:07:33 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 22 Sep 2022 19:07:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Msx2oKVTDXBx3NOP1vzPx7fDirgLqtyjHoEy5sRLPSAWRLsq0sbsaweNIM9RVEqq3mRleNGhrIycu8AvVGdZlC6BpIWdmQWkRUHvMnckM0HKYF2yZaOG8OVwxqgTB9USv5OtrHX35nmwvuZOEKl0Cg4mSyCCrDqbSh4jJE65o9w0K+9tVMcNUXDvpXEu1PURiFxPVSpyWU7Bba0ORyNWQyfp1CKMhYSPLBVkac8Fp86Q1IgvvtsLzNgPQipGWvtxBQTLowo07MaGk1ctVOUsUvWfpgmZlUp6vUthmJKsPZNMWAhFjVUr4CzzQNdcsy9x2X1Ou0ZcA59+CL/nUbd68A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1REC18GbrHq4FkE3vb0fqyBDuXGjxvHkTin8NOANfFQ=; b=nx7c+36iTePA3MycOokOOdXeeHDhx08zWRs2H4bFX23MlSrxCr4enXKRHQ3GdTHu4b1Ref0WqB1FvKMOeueW7Xps0w8XWtna03P79gpGLV9B5x64neiesEyHNwc7YXilI4XpVfuu0JesUvZXk81PoOcNYpritKqloD7G9Qp8uRmfhPmwKLhuvi1EZa3iql2ELF3ND52JEYxJLUpG9FwFZ4kOuyBOrfWfBpMPUvN33VQlCnkEte3rni2l/KCR6tsvGO9nO69i3aqP1gGdq4mxIzjO527E/mXs5dzeQEGA/kr29PjVD1lZ8Hs+kU3aSJgxfqrVW3owKdKYvTP6qadt3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5873.namprd11.prod.outlook.com (2603:10b6:806:228::11) by CO1PR11MB5172.namprd11.prod.outlook.com (2603:10b6:303:6c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Fri, 23 Sep 2022 02:07:32 +0000 Received: from SA1PR11MB5873.namprd11.prod.outlook.com ([fe80::65ea:e82:b2ac:4209]) by SA1PR11MB5873.namprd11.prod.outlook.com ([fe80::65ea:e82:b2ac:4209%5]) with mapi id 15.20.5654.017; Fri, 23 Sep 2022 02:07:32 +0000 From: "Yao, Jiewen" To: "Gonzalez Del Cueto, Rodrigo" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Thread-Topic: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Thread-Index: AQHYzlYGnWJuJIFKb0m08vYz5ptt6K3sRUOw Date: Fri, 23 Sep 2022 02:07:31 +0000 Message-ID: References: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5873:EE_|CO1PR11MB5172:EE_ x-ms-office365-filtering-correlation-id: fbb0a5ff-f9b5-4947-9bdc-08da9d085fd7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Uu0n/LBsNC3W6M0AxOi+zxAVZO5LrHcKOtcou+VIZxlb4lEP3YWN4xvYxJNjiydVt5fcOprYYzKwc0O2BnECyKGVuBsDEVATdwQoJweENd0dbKmMvxCTDL0ptGqs0M4OOgneGNqJzqeC2Og3j84QiFjAmGsXC6xF29XFBJh5pD91TrZB2GtZqmO7UBFAJT8ffeCC0TVGhPdg6HkP+aUGl8C827PwwdT06VMjSzRTYt4TIOBJM5pTfJ0PywPYf0Wey0nYpmU+aabbO5iHYWoRnLtjzDEN2EwhHdo4LNwJIT+jkPc9+XsL1PPNMZ9UDjFPeci6maibTM31aPbcxBpodZqPPtCHz6ik1dA7rm4GEM2fYQLc3UjQvdEuPmv4ES3HAIi02ENPkfS9gpriaN9it6fJK9OmSb0dOMrnWIaFoDj8atwhjZc8QMEkfCAc+id8mSYFmXp+JIk09fLvg8LirW3kRm+UhPi+e37QeENEpyBUpXSIlyQfXxZjdEgD3k/2izvP+7uDUsisoqFErUMUi+4s4chtVwtYq52299ULQ28lWs3ZRGjEJ9Zhn1KiUMksYVudaSTwZPEXXLnxPZzZVhba2orClQE1lE14XZ8UWqyZgBOj8wjwJW0CHagwJGFabUlKpa5loXP7wSQihiP0Z6wUaCNnd9kGn9Ygl6q8ry+CPp52G7ENZeH87KCM1WgJaV8KQ9GTLasUOE1TzcqRgNlRcBiGkooEnPtW0YMOOSOFnsxuZX3XShnPC6Npc4HuhkR4J7kIospXR2Hi7nR7gcivhjwP70ygCHUL7CdGnY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5873.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199015)(71200400001)(19627235002)(26005)(478600001)(316002)(966005)(110136005)(66556008)(66946007)(76116006)(8676002)(41300700001)(4326008)(107886003)(5660300002)(52536014)(53546011)(7696005)(6506007)(9686003)(64756008)(66446008)(66476007)(8936002)(186003)(82960400001)(86362001)(38100700002)(38070700005)(2906002)(83380400001)(15650500001)(33656002)(122000001)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OAD/GunJBaoltYGzcOd2MwrAD+z6iu9vddSKpUlWk0esnovBLLQWCFGYEJOL?= =?us-ascii?Q?X38Dp97U6jYfDKZl233jNgoqThTehfYl7vbVob+6jLr7ahMjMq7+6Dvfafjf?= =?us-ascii?Q?aLJzhPBYeTPwKaxJltaLOwIvXgXg0ErUsfe9x1NA9LLQRUS1xslbo44NhkCL?= =?us-ascii?Q?asrmkPyqsFgsuQoyrw/RV4hfacm++WPcUtsptuSSDg/4yOckyJehiLFypObI?= =?us-ascii?Q?DgtFRuOVwG4RYm15XU6WmZm2+GD02PIupvz+rkfQyjA29n4Zy2RQLbviQYf6?= =?us-ascii?Q?FLGowznW4tMqoeXtbCWMI+vDxgqnjsVZ6QTxX5ZL7OmIP09pQSYp5y2Lr4kr?= =?us-ascii?Q?6sVL498ogHV66ordJlWL85D37B93Fn9RZh3+3YEUol8xftv+Var8CFdLCf11?= =?us-ascii?Q?BSmoGRtIZzsRHthUYxspRGAvdM+mySVGxauTU5I1X3mSGrbvchiv4FC1P7r6?= =?us-ascii?Q?ViIlQwQQMwRfASI+lFRdTi9uvREocldWPKX0sVVDWIUSvhclqTogLp3S6OOX?= =?us-ascii?Q?W9FvPEG52XKObWzgv6QfGDRg0gfV8N7zr0wFwQq9+Q97owPNi+2i404xMxsy?= =?us-ascii?Q?O4XXDTPSnFs1BwEu5R8Z5srIP5Q/rYx/+0F8pUcRqMJgjnk5psWvKwBH9ChF?= =?us-ascii?Q?imKwnq7h8K0hmmy1iPV9/k+nDE8RKy7ab5j8hJt0/s2FnoERJ04zWGbDR8y3?= =?us-ascii?Q?89uPzhwlSBQ989dqJpj45d0dZs/ukO79BjrMIxawWKMRLE6A83OjcxgEisfL?= =?us-ascii?Q?IEUSq+8pOgyX+LW8VGUntjrxRqv3VEYqAKGy9ICR9mCcK3J1eexeRdppMH6w?= =?us-ascii?Q?G786YhAPCd8Y6A73b42XLtENLGsIoaon1YXLjIsYqI17O9ZGt3nOsvsrSWN8?= =?us-ascii?Q?oR2izMuGRoa5WA1uvrKDJbp6o1UqWE/wZq9OOHGuGLXv139pbuaWosvUhGQ8?= =?us-ascii?Q?Dljg6PIDxS02zbA9bcyIS8O4BHR2/iB4HDmdInlwyY7x4a4yfnYc+bVCB1j5?= =?us-ascii?Q?5eiB62vu/Xh40RXfGfpFURoxUTPyEa8Ts1cso9UVkk6xmB8dBKr6ukGhqmFJ?= =?us-ascii?Q?L9l+BUYh82nDEjooqPQ5Uobsw6Ql6f+2F2IsAvLNd3BNMVqSPDM3+v7bQ7Y9?= =?us-ascii?Q?aWHiiVRq614aWlBu1UshNVKJ0BJ06Iss5OA+V+EwshXFw+kPwPHjBK5cQqZh?= =?us-ascii?Q?ow5LX0Wo5jxunbn6P1otc1YgPs9x+ZQte+/wfKiWnPtPeE9Wn4yA2okn5ef8?= =?us-ascii?Q?+ZNzmI3R3pHGhKu5pUXVd68Ph9nvwVBFjj29YWbP5p0NGrc0J7CsacRyQzEe?= =?us-ascii?Q?D44KGYPzxPuPMSSxz1SLo3urljq+uDLBfmmYgKrss+FSDwcGk9Rw2W0MxRgq?= =?us-ascii?Q?uIAD/PR8r1iTqwjAffZC4PKwumdMsBcAk5zhAOxmyk+DFIPzQ2FwaWmkUjOe?= =?us-ascii?Q?1vR9Z3p7EmwBUfRLSD4tG6YIHUvli0AVB/mu8s7nUMpYGbgqBg8o47dkdpk8?= =?us-ascii?Q?mcNj+UH/n4ptuKLlffqXQk3eqYuE54K3G3H0naY5guIHxsI13HWNDVqdYOZy?= =?us-ascii?Q?Ogo8GSxftYU06/ms0uXUvH5kFRhArpSKkFT6CcUj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5873.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbb0a5ff-f9b5-4947-9bdc-08da9d085fd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 02:07:31.9298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xXAH7E+25Jnr57mEgQnLNHtZVRq/qUatZ85Fg40CgHZF3t3KLRIDtQa+3C+pl2Ps3NCtGxVgxfzlTw/GBnIb8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5172 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Would you please describe: 1) What test you have done? Which TPM chips you have tested? 2) Which specific section/sentence you are following to remove the goIde? I= would like to double check spec.=20 Thank you Yao, Jiewen > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > Sent: Thursday, September 22, 2022 3:36 PM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Yao, Jiewen ; Wang, Jian J > Subject: [PATCH] SecurityPkg: Remove enforcement of final GoIdle > transition for CRB commands >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4077 >=20 > Following the design described in the TCG specification, > the driver implementation of the CRB protocol does not require > enforcing completing the transition to goIdle at the end of a command > sequence. >=20 > Signed-off-by: "Gonzalez Del Cueto, Rodrigo" > > Cc: Jiewen Yao > Cc: Jian J Wang > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 13 ------------- > 1 file changed, 13 deletions(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index 840265292a..1f9ac5ab5a 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -381,19 +381,6 @@ GoIdle_Exit: > // > MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, > PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE); >=20 > - // > - // Only enforce Idle state transition if execution fails when > CRBIdleBypass=3D=3D1 > - // Leave regular Idle delay at the beginning of next command execution > - // > - if (GetCachedIdleByPass () =3D=3D 1) { > - Status =3D PtpCrbWaitRegisterBits ( > - &CrbReg->CrbControlStatus, > - PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE, > - 0, > - PTP_TIMEOUT_C > - ); > - } > - > return Status; > } >=20 > -- > 2.25.1