From: "Ning Feng" <ning.feng@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lu, James" <james.lu@intel.com>
Cc: "Guo, Dong" <dong.guo@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Rhodes, Sean" <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Date: Tue, 10 Jan 2023 02:31:29 +0000 [thread overview]
Message-ID: <SA1PR11MB58765DB5703EB525F653ACB5E5FF9@SA1PR11MB5876.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL1PR11MB5478DF679D0CF4D138856ED5EFFE9@BL1PR11MB5478.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 5114 bytes --]
Hi, @Lu, James<mailto:james.lu@intel.com>
will you please check if the code change make sense then merge the pr?
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>
Thank you!
From: Guo, Gua <gua.guo@intel.com>
Sent: Monday, January 9, 2023 1:07 PM
To: Feng, Ning <ning.feng@intel.com>; devel@edk2.groups.io; Lu, James <james.lu@intel.com>
Cc: Guo, Dong <dong.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
@Lu, James<mailto:james.lu@intel.com>
I may need to get your help to add push label for the PR.
Thanks,
Gua
From: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Sent: Monday, January 9, 2023 1:04 PM
To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Dong <dong.guo@intel.com<mailto:dong.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Hi, @Guo, Gua<mailto:gua.guo@intel.com>,
Thanks for the review.
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>
Thanks,
Ning
From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Sent: Monday, January 9, 2023 9:58 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Cc: Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Dong <dong.guo@intel.com<mailto:dong.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
@Feng, Ning<mailto:ning.feng@intel.com>
Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls
And please also change commit message like below
“””
UefiPayloadPkg: Fix debug print error level hob not save correct
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264
Fix debug print error level hob not save correct DebugPrintErrorlevel
Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
“””
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
fix debug print error level hob not save correct debugprinterrorlevel
should cover the case:
Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b
BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
---
.../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
index 4f6b4ef1fb..10bdbe2bbc 100644
--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL
+++ evelLibHob.c
@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (
{ if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) { DebugPrintErrorLevel = (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);- if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+ if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) { gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel; } }--
2.25.1
[-- Attachment #2: Type: text/html, Size: 18717 bytes --]
prev parent reply other threads:[~2023-01-10 2:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 18:27 [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob Ning Feng
2023-01-09 1:43 ` [edk2-devel] " Ning Feng
2023-01-09 1:57 ` Guo, Gua
2023-01-09 5:03 ` Ning Feng
2023-01-09 5:07 ` Guo, Gua
2023-01-10 2:31 ` Ning Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB58765DB5703EB525F653ACB5E5FF9@SA1PR11MB5876.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox