Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

["Narinder Dhillon" <ndhillon@marvell.com>]

Sorry, that was my mistake.

> -----Original Message-----
> From: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> Sent: Tuesday, January 2, 2024 3:46 PM
> To: Narinder Dhillon <ndhillon@marvell.com>
> Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com;
> ardb+tianocore@kernel.org; mw@semihalf.com
> Subject: Re: [EXT] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix
> build
> 
> śr., 3 sty 2024 o 00:39 Marcin Wojtas <marcin.s.wojtas@gmail.com>
> napisał(a):
> >
> > Hi Narinder,
> >
> > wt., 2 sty 2024 o 21:57 Narinder Dhillon <ndhillon@marvell.com> napisał(a):
> > >
> > > Marcin,
> > > I don't see this folder in code, how is it generated ?
> >
> > It's simply exisitng there:
> > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc in edk2-platforms,
> > nothing is generated.
> >
> 
> If you meant the device tree itself, it's part of edk2-non-osi:
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_tianocore_edk2-2Dnon-
> 2Dosi_tree_master_Silicon_Marvell_Armada7k8k_DeviceTree&d=DwIFaQ&c
> =nKjWec2b6R0mOyPaz7xtfQ&r=1o2VA7xKsHvmQ4HFRY2JZggF-
> gGh1t4bxHFABsB1WTo&m=08gOJ2_xAynyvW3O-
> oNDWKoDc3FWWZiADHsHA1mnARRZOkvbYWJ4uGoI6qAZcinn&s=5fqFKjdJ3
> B1m_UCEsRzwqJ8rVqshTAD_ZyN0IlUHTFQ&e=
> 
> > Here's part of the patch, that introduced regression:
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_tianoc
> > ore_edk2-
> 2Dplatforms_commit_ec5de71d83f3a6327c90887456782d15565e6e36-2
> > 3diff-
> 2Dce7de187b6e203a8e22916145bdc2a35f7c922609105c4282932f02dee7bb8
> >
> 4fL34&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=1o2VA7xKsHvmQ4HFRY
> 2JZggF-gGh
> > 1t4bxHFABsB1WTo&m=08gOJ2_xAynyvW3O-
> oNDWKoDc3FWWZiADHsHA1mnARRZOkvbYWJ4
> > uGoI6qAZcinn&s=35ZI6uHnNjYbaOe39H4hr7Z0ljJLZl_ODejRzU9WBDk&e=
> >
> > Best regards,
> > Marcin
> >
> >
> > > Thanks
> > > Narinder
> > >
> > > > -----Original Message-----
> > > > From: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> > > > Sent: Sunday, December 31, 2023 3:07 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: quic_llindhol@quicinc.com; ardb+tianocore@kernel.org;
> > > > mw@semihalf.com; Narinder Dhillon <ndhillon@marvell.com>; Marcin
> > > > Wojtas <marcin.s.wojtas@gmail.com>
> > > > Subject: [EXT] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db:
> > > > Fix build
> > > >
> > > > External Email
> > > >
> > > > ------------------------------------------------------------------
> > > > ---- Commit ec5de71d83 ("Silicon/Marvell: Restructure package")
> > > > broke Armada80x0Db build by unintentional removal of device tree
> > > > component.
> > > > Restore it.
> > > >
> > > > Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> > > > ---
> > > >  Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > > > b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > > > index 22a0040265..501811a050 100644
> > > > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > > > @@ -31,6 +31,9 @@
> > > >   !include MdePkg/MdeLibs.dsc.inc +[Components.common]+
> > > > Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf+
> > > > [Components.AARCH64]
> > > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf --
> > > > 2.34.1
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113043): https://edk2.groups.io/g/devel/message/113043
Mute This Topic: https://groups.io/mt/103490025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-