Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

["Narinder Dhillon" <ndhillon@marvell.com>]

Hi Marcin,


> -----Original Message-----
> From: Marcin Wojtas <mw@semihalf.com>
> Sent: Friday, January 12, 2024 4:19 AM
> To: devel@edk2.groups.io; Narinder Dhillon <ndhillon@marvell.com>
> Cc: quic_llindhol@quicinc.com; marcin.s.wojtas@gmail.com; Szymon Balcerak
> <sbalcerak@marvell.com>
> Subject: [EXT] Re: [edk2-devel] [edk2-platforms PATCH v2 7/8]
> Silicon/Marvell: Driver to dump board configuration
> 
> External Email
> 
> ----------------------------------------------------------------------
> +marcin.s.wojtas@gmail.com
> 
> Hi Narinder,
> 
> 
> czw., 21 gru 2023 o 01:54 Narinder Dhillon <ndhillon@marvell.com>
> napisał(a):
> >
> > From: Narinder Dhillon <ndhillon@marvell.com>
> >
> > This patch adds an EDK2 shell command to dump board configuration
> > device tree.
> >
> > Signed-off-by: Narinder Dhillon <ndhillon@marvell.com>
> > ---
> >  .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c  | 361
> > ++++++++++++++++++  .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h  |
> 102 +++++
> >  .../Fdt/FdtPlatformDxe/FdtPlatformDxe.inf     |  60 +++
> >  .../Fdt/FdtPlatformDxe/FdtPlatformDxe.uni     | 106 +++++
> >  .../Drivers/Fdt/FdtPlatformDxe/README.txt     |  69 ++++
> >  .../Drivers/Fdt/FdtPlatformDxe/ShellDumpFdt.c | 283 ++++++++++++++
> 
> I think the FDT fixup part and the shell app should be split and the latter
> should be rather placed under Silicon/Marvell/Applications/ with a proper
> .uni file for displaying help instead of the README.txt and MODULE_TYPE =
> UEFI_APPLICATION in .inf file.
> 
> Is there anything Odyssey-specific in this driver? I was wondering about using
> it on Armada/Cn913x.
> 
> Thanks,
> Marcin

Yes, it is generic. It looks for a FDT HOB and saves the pointer to a variable.

Thanks,
Narinder


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113777): https://edk2.groups.io/g/devel/message/113777
Mute This Topic: https://groups.io/mt/103292517/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-