From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.69]) by mx.groups.io with SMTP id smtpd.web12.1408.1641869229978765388 for ; Mon, 10 Jan 2022 18:47:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=CRmsWvqr; spf=pass (domain: outlook.com, ip: 40.92.42.69, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqUtWRJTkIApPaJUUm6W7MLdhuo5Zc1rA+MkpmXPeKAmkvssBHVYFnhOUJEi5B+76Hkibe2mj7hGEvkoNWXg+T4d5jwL/mqQxEmx+aaRioOPdWDs6KNR/guAvvT8cZr2TvCtYTRdaIozKvFEuMvspWd3feUCdhsR6bvo5sKcq5qVxU0zDAK/0c7G12ZUin+CmCAIxFstQe2X2KRJYJkJO52AXdxdZjSweAe3xk2H+A14U+A3gXHUATh/R8fQNDZccT7MgJdmSraOerrsrvpAB+/1IbUGewPWoA2NCmaasizjy/VBUN5W1dAOXlmo4/ogHpKmbc7y04KqoOE7uQcw5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZI8ZQJthQn0UW1INWAjKBaWxn9BTe3PJpxGyM3tukU=; b=jUw4pQ2fWy2Hr7xb2trpUg8XykrBVP8j/9DEa85tcmUzPrRc57KIDzTtyNlu7M1UfF/kkI2Ge+abPQjlHgX7ymChkx6UJEaYkfuQkamypFCZP6XUidCjilmO70SwHYZdd7wpAn0+QegSKK6wjPAFLs/iRl+Kj0pvU2uuNfxd1ftEq2Tf4nHMpbzVh5MiPrIWVR94TzhXjUb1Uw0TdAmNvwENO2lU4BWZUikCGBbpP4mVvt1oyd9KkvM6VRYHFFvsltuK4TAzVj58P16pKdHVsFGANORRVfiyssz1NonQ3xGCJFjQFgIjRTl5mJ5Q+jln9UCG3tGs7+F5GEqB5hmU2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZI8ZQJthQn0UW1INWAjKBaWxn9BTe3PJpxGyM3tukU=; b=CRmsWvqrQ4KhTip8nZsOsDe5V4TrE26+KoNB4x09XOMq3b66D1oLljHbiHTKr5/paCN78A80Ef0lM08a5WdC6fHBUY9GmwtFz0GBC7adr6MarUtTASPEGT34xygmzGqrZobYVT2xfb8y5LdIZYWR5Vi7fJkMWR6kw2IMso77IhzdA9f9jS/Qvfu69tDQtWCCAlId+O2yAq4cMGyu7zflMVaYqAZIbp6pEF8xEXFIwBWId1nQ4rIfKch0DvJMdkuFRhRdz69ds+/ihvuhQuhljY86mmbey2zIqXay1T5s5o66ly9DuCQDXmpFn35Y5/y51oapNab5X5WYiQrP6kproA== Received: from SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) by SA0PR19MB4240.namprd19.prod.outlook.com (2603:10b6:806:8b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Tue, 11 Jan 2022 02:47:08 +0000 Received: from SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::b9fa:857:6dd3:78c6]) by SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::b9fa:857:6dd3:78c6%5]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 02:47:08 +0000 Message-ID: Date: Mon, 10 Jan 2022 18:47:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gTWRlTW9kdWxlUGtnXENvcmVEeGU6IEFsbG93IERYRSBEcml2ZXJzIHRvIHVzZSB1bnRlc3RlZCBtZW1vcnk=?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, stacy.howell@intel.com CC: 'Dandan Bi' References: <20220107193612.1350-1-stacy.howell@intel.com> <01ca01d8068e$e98aa590$bc9ff0b0$@byosoft.com.cn> From: "Sean" In-Reply-To: <01ca01d8068e$e98aa590$bc9ff0b0$@byosoft.com.cn> X-TMN: [7OntYi1uKUc4j1zbO+LOcg8nNaNNXTDR] X-ClientProxiedBy: MW3PR06CA0014.namprd06.prod.outlook.com (2603:10b6:303:2a::19) To SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <90c30cf6-885a-ca27-65a6-f467c2a34f11@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19ed6f22-be67-466d-f56b-08d9d4aca904 X-MS-TrafficTypeDiagnostic: SA0PR19MB4240:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vx1JBhal04UGjw8VfZXu/YfARQkaP9tykU4hYJDPB2ef++e1NF9guB6m+dCFf0YgZnIDDWDDEUfTDfLz5ZAmNATWNqUlc/+hL0xMTXukZLcjetBvjxqQfqFohME8crmETvmRDQpm5Z+g4xN6aqpja0H4CRVBTPewa6nks879v3qUSjwysrjdtCws0lXHeEVtsd1bJ8EuqcuKCgpUHZYBKUgRUNvujAGEXQQFnqc/X0945NIpKM4MqczlRh9WhCsmqzMg49jmtU581f6JilQVBHsmvGUfNHFlXIUej6yf0JeIdhy0zxV35/l0nM893+tLGH/oJC/CyAnOnSAtqLC8O8IZzCeMBlXJVlV/IH6Qy9twyx1T1pwvCVr5orCrS3RxGeL9Lcd70deUunqemKW9c1ScbabYG40wY7r9zPGKPFhTb9zhdmwCjhQnHUR/MiiEnerM1tll0SFeSgOy9PsrgwKMqfO5BHmN2sKluipyWnURhAuv03dRcCc5pMwuecH6XZKwAEb9zWt2smdCrWUK8CqaFXcrkXe+7Faw4TfU4L10NTlA9PAHfKkj/vk7QqvkAne6YA4yT/SJWTcn8vhUOZ9EjF95RRj8RAa6CPmYVzXCJ8zQ7uqTvChoJR2titT3zBl4XDNC5Z63mSLH8BSuPWedzH6oz2UViDizXFOHPfg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LMt2N3epM4nta8HG7mpIqVkj0zMof5nTmwDYYk0+xI+ZCeK3fLBYgDrwNs3bJ28cvEUO1YdUuzGcAVqH8Sgqyjztv8hL8W9OCIqIpTB4HV6Tuny9oTUVEe7s5Gv9jVqBOYw+nJIjQ2TCmQ387IELTM4IUwyjaA5O6Kb3ZZluvGaN6sfWhlug/aHb3qOEoiRKd0FuC2k4uej1mB2gzXFjr9GlGKoqqi17uYqr3J7FO1yD8Xv7NyaqA1/vFH91PX3LzvVJlrPN1uEPHM4cOrd0HeyNCoIwjQ5vSIs94EBuag8ZWhVXgeW/xd9vWqNVfDVWxi8WCmiTZ2166t6DFNmlwn0z5uJfUe+8zgns/+edWofVa9kohYyCFgw9hQPxUEO3QVhCINwDJfgSHRN9iCNruI4OXq6y5baIbRNfbmfUUlOQ3jK7oNlc5Oj7Hb6DY3E0OLoOgXRzQ7d+izWiDfltU/xlw8nNjyP/aj5fLYKODVdib1Rzi3D56p1SDS6Wo+OCniM3CZBmoPxWe788cPxkePquQgLbb8SvUVhLJr7rUKC7B3xx22Ds8GY28hNzwT+MBwonman24eRkWcLcp3ZLlz3VA7aML0kUI7ZZ4JN4EIC7nn/0f4XC0G/GdlD2ewMub0IRAR+w2PbxuwD/L+tLT9xcY+YusZOlYG0oFjiWNg3XveoUB5P96IpkJkunsY4lxOBIG6XMvIk6Y3FnIhzlydofzIBvq2QCWeamqYu/Q2n/nVNdkp9dknNjbQprsEuPkI+tGqmwhrLiHTfVI2r/qNWIdnQfYE84vLcgCAi0BLemB5rYwMMz2JlHR4rmWo8XRFFM+VlOHEbzn9FvVR0eXZmQv1/IXSBI96uSk3bPB+MMDyiYRLECXd7tx+Lsb+PkIQu10sCshYuIUd610wNQeKnXrdukviCFRv74rKAIiH+8x49pICHmQeuZwZewXrv2B/IhTOd9KdpVd3rvn8xZCw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19ed6f22-be67-466d-f56b-08d9d4aca904 X-MS-Exchange-CrossTenant-AuthSource: SA1PR19MB4911.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 02:47:08.8347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR19MB4240 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable if this is auto promotion is happening in the core then what is the=20 value of memory testing and tracking that state. Is memory testing=20 state a necessary feature of the Dxe Core? I think it makes more sense that if you platform wants to use a given=20 range your platform should either test it and/or mark it as tested. OR The dxe core should do away with the memory testing tracking. On most platforms i have seen in the past few years all memory is marked=20 as tested without doing any testing. The only value in the flag is keep=20 the initial memory allocations in a given low range (below 4gb). On 1/10/2022 5:59 PM, gaoliming wrote: > Stacy: > This fix covers the case with AllocateAddress allocation type. I agree > this fix. Reviewed-by: Liming Gao >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Stacy Howell >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B41=E6=9C=888=E6=97=A5 = 3:36 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Stacy Howell ; Dandan Bi >> ; Liming Gao >> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH] MdeModulePkg\CoreDxe: Allow DXE= Drivers to >> use untested memory >> >> REF: https://https://bugzilla.tianocore.org/show_bug.cgi?id=3D3795 >> CC: Dandan Bi >> CC: Liming Gao >> >> Updated CoreInternalAllocatePages() to call PromoteMemoryResource() and >> re-attempt the allocation if unable to convert the specified memory rang= e >> >> Signed-off-by: Stacy Howell >> --- >> MdeModulePkg/Core/Dxe/Mem/Page.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c >> b/MdeModulePkg/Core/Dxe/Mem/Page.c >> index 47d4c5d92e..cc0b90ac0d 100644 >> --- a/MdeModulePkg/Core/Dxe/Mem/Page.c >> +++ b/MdeModulePkg/Core/Dxe/Mem/Page.c >> @@ -1417,6 +1417,20 @@ CoreInternalAllocatePages ( >> Status =3D CoreConvertPages (Start, NumberOfPages, MemoryType); >> } >> >> + if (EFI_ERROR (Status)) { >> + // >> + // If requested memory region is unavailable it may be untested >> memory >> + // Attempt to promote memory resources, then re-attempt the >> allocation >> + // >> + if (PromoteMemoryResource ()) { >> + if (NeedGuard) { >> + Status =3D CoreConvertPagesWithGuard (Start, NumberOfPages, >> MemoryType); >> + } else { >> + Status =3D CoreConvertPages (Start, NumberOfPages, MemoryType); >> + } >> + } >> + } >> + >> Done: >> CoreReleaseMemoryLock (); >> >> -- >> 2.32.0.windows.2 >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20