public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt
Date: Thu, 8 Jul 2021 12:55:17 -0700	[thread overview]
Message-ID: <SA1PR19MB49113865B8A87BBB967E0C83C8199@SA1PR19MB4911.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20210708195047.1649-1-michael.d.kinney@intel.com>

Is Maintainers.txt a standard file used by standard tools or just a 
custom file for the GetMaintainer.py script?

There is a similar idea used by github (and maybe others) called 
CODEOWNERS.  See 
https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners

This allows github to auto assign reviewers to a PR.  Would it make 
sense to try to align?

Thanks
Sean



On 7/8/2021 12:50 PM, Michael D Kinney wrote:
> New in V2
> =========
> * Maintainers.txt updates
> * Remove content after email address from standard output
> * Fix --lookup compatibility with '\' path separators.
> 
> Update GetMaintainer.py to allow a GitHub ID after the email address
> for maintainers and reviewers and update Maitainers.txt with GitHub IDs.
> 
> The GitHub ID will be used to help autotate the PR reviewer assignments.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (3):
>    BaseTools/Scripts: Fix GetMaintainer.py line endings
>    BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines
>    Maintainers.txt: Add GitHub IDs
> 
>   BaseTools/Scripts/GetMaintainer.py | 382 +++++++++++++++--------------
>   Maintainers.txt                    | 282 +++++++++++----------
>   2 files changed, 331 insertions(+), 333 deletions(-)
> 

  parent reply	other threads:[~2021-07-08 19:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 19:50 [Patch V2 0/3] Add GitHub IDs to Maintainers.txt Michael D Kinney
2021-07-08 19:50 ` [Patch V2 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings Michael D Kinney
2021-07-09  1:08   ` Bob Feng
2021-07-08 19:50 ` [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines Michael D Kinney
2021-07-09  1:25   ` Bob Feng
2021-07-08 19:50 ` [Patch V2 3/3] Maintainers.txt: Add GitHub IDs Michael D Kinney
2021-07-09 12:23   ` Laszlo Ersek
2021-07-09 16:42     ` Michael D Kinney
2021-07-22  4:15   ` Andrew Fish
2021-08-03 10:49   ` Leif Lindholm
2021-07-08 19:55 ` Sean [this message]
2021-07-08 20:02   ` [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA1PR19MB49113865B8A87BBB967E0C83C8199@SA1PR19MB4911.namprd19.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox