From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.92.18.63]) by mx.groups.io with SMTP id smtpd.web10.425.1667260215700417391 for ; Mon, 31 Oct 2022 16:50:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=M1ZKRbjQ; spf=pass (domain: outlook.com, ip: 40.92.18.63, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSN41LQCSoHbifL2e7sen2VBMuAGs261zuRZrD5OzQF2S2vGJzW0uUq/QnOAAUo7FP1Z6jhpZp+SgBLLIWlnzis0nKCPnBNyj0XFiivuDnfDQ5F55H81Zy751X6l8cxhjO0DWn0pL8NQqZEO9Ie9/ADE636ztcE3ll2ATbIn6x2nWe8HMP1GlD1v4GXl4lwhyjyqQxhZEnY2Dr74ZB+QX5L4PfGRN4KwLqd6zAv7RTSCaXM8PmvvQI4PkEJriqvUZ6EVVH6WBJIaLclKI9IPYKn6ImFxajaKAbZuvNtYOLk+9JnuY2OH0SM25db2uzQwMxfelFDYTt/WGG31LrBnCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bm4df2Ft6AYSlu/X+r88zf/GTgQacjiAB5ctEvenMME=; b=NNMvEyCN2rVOgZPX2ExQTWJ+ufG5D9VUKUUsXRCgNh+0T74RcH8BqldPwiwVjo5nj5J2gedqy3WqGuiEgpcUl47DkYKBUxi1Lfr91eTQZPHRpTew5nc5/fbgj8QofyOqX7fGEDHzVuhztWUSHnnurob5akLbEaIQe41oOXwqHall4toY/VQo7cEJlE/wLeTACcbBVvhSgEGQBhZl3ILcBoYsRLfkUqmP+k7sOPyyw57BQb8pnZq37hQQagHp38HrqkEylqjfFeK88dZrEe1JJR3yuWLE86Ur7AYJujxi7n0vT9Zf+KVD/fcDtZeSq8MjO0VVAYETbxfidoEXybgv0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bm4df2Ft6AYSlu/X+r88zf/GTgQacjiAB5ctEvenMME=; b=M1ZKRbjQrCQ7jM6vZvSIAOP9ahodN1YcOn4Po3HEULkN2S9+jKmEMgfaiDhi2nZ+sNc9Q4460OXxIPXPnDviw/KTn3XG3YeYf8XWMJ2YEhvKZnRAc4yIhtf1+gYQwlVC1ttDsjIJpCeotFLYTg0hGppDkvnvHHcdcHAlzWdtevfVbzAWicmqdErT12S3v7zZ9DOWy87YVXZz3Mimt9Gdw0z00opX91Y0t7S8sPF7xQPTO7j3cRgq3WqTgwQfrKDWAE+E2rnuX7kH5ScmyN/VjySXPic2vrXOFYVgkPaFXArOXP/pjdckqEvxMsnLncud5t/x4RHwVb8vMuMi0RFdtA== Received: from SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) by BLAPR19MB4628.namprd19.prod.outlook.com (2603:10b6:208:295::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct 2022 23:50:14 +0000 Received: from SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::a076:c13c:c408:58c0]) by SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::a076:c13c:c408:58c0%6]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 23:50:14 +0000 Message-ID: Date: Mon, 31 Oct 2022 16:50:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Support FILE_GUID override in host based unit tests To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Michael Kubacki , Sean Brogan References: <20221028155947.1172-1-michael.d.kinney@intel.com> From: "Sean" In-Reply-To: <20221028155947.1172-1-michael.d.kinney@intel.com> X-TMN: [jo+Jew4NOXG5FKVsZgnfeY6Ftd+1dx63] X-ClientProxiedBy: MW4PR03CA0114.namprd03.prod.outlook.com (2603:10b6:303:b7::29) To SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <79ef13d3-9229-93ac-26a0-15ee0bef3453@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR19MB4911:EE_|BLAPR19MB4628:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f03d2a1-8ac0-4f64-318a-08dabb9aa750 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x57gkM7ZTnIBSE3qwqH8rnpZhKdkuPl3a0PIo7acoqSt29K+oRNhyQSI5+caHtiOvUrByE+Y6JlIgfspq/yDq25EasQiuLzQUXA6d4AHDFUOXsMBgwR61PD3Hv3Zra2Z2t87VmJlAtgZDBnwyGO3sGlits9iWyihizNFRIyARsT8FHoTZBBtlY9roQ/Vk9bOxF0/wB+Tdi2YYhSppY8An+avIRflrWEfsIgN6LrKEEQD45jddWir46warTGXucG2xjU5x9G4LgBCAz5GPbhSOsq+u2N1VMLjmsE0vFm2gHeMvCBlbF8Rn2gi1D+0fdUTgrQl/YUbAyISXBlMMN11TvU1l3S0qdhJ93ERx8PDeDy9Bd89p8C4N0jnSd2DcODB2MJRmtT9WWwy5ip2r7y/5NSAWnbhgPN2bRVa2BRBBbgthfIMQtGm/FPDNJp6KTk0O2BHYYsqkYqf4xmhrayVcS4TgQg4pWlrVnFrAZiqAmYFzxfJGQ5pmenXTWCywx1RhxZIKMpa1w3utmmh8X6K7L6/e5eJ7GvRV+s7oBO36z7doSA+RO+Mb9XHmoiWpKIxtMltgngaKXNLVbG4RdZDQwNJyeJkd6PzgFgNcZWmoIlHmJgU6M8WhNsOTOp6VJGOD9jmCK5vcjWDB5XQ79EVSmNOkRaetrBW6dzh7IASKThhhbO48NyowWVVs2SXCWBH X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWhPNFZQYTRHMGlGT0NKNFFhNWxUTFN5SVI2M29weUpkVUsvNjVmRUhlZXU1?= =?utf-8?B?TVZ5UVdUQXYvM0Zoak5JUXJGb0cyb2dCd2R5K1pqNG1aaGhHd1JwelVaV01K?= =?utf-8?B?ZkZnS2VUUktHQTlJNS9tTU8wUVJLeXJVNW5kYTJMZDhTSUh5ZER2d2l3Ti9I?= =?utf-8?B?NkJvM1NZR2VORklWQ1NoQWxFMDRUMWZOOFBETVRMcWkxMm1BRUNETUpQYlBu?= =?utf-8?B?dVNMU0pyOFYrdlVZSXRsRDZBT1BpTk5WS1dCMjFyZmpZWVo5bnp2ekZmdTBB?= =?utf-8?B?VFhMOUY0Lzd3TGI5QS91UlFGdnJiTURrZkkvd3VrZE5pR3NTTEg2dTEzN2tw?= =?utf-8?B?ZHY0UWI0dWdaQ2FZR0pnSHk1L1FiSVRoZEdMZ0dkWGdTSHFFNUhldWt1Mm9z?= =?utf-8?B?NUpFWmlXZFZ4ejNiajRLSUh6QmtKNDA2enR0NUtjWHV5ZkxFQU9CSFpCbTR0?= =?utf-8?B?RHhlRnFUTFhhMkpYWFZjUjJTSUw1c2I0WWVocjRIeHQ2R2JLdFgreUFKbFd1?= =?utf-8?B?WlR3NFJoU0VSTHhVb3JxTllHT25ZNWFxWHZsYVJEczVDSWNvd0M5ZUJjZGZE?= =?utf-8?B?YlIxMGFDdE5pekthK0xwMk9GWEdyalNrQm44VGlKNDJ5TVh4aVU0d0ZGb3Ns?= =?utf-8?B?VFVSTTcyOWlzMFZDVlIxdVh5Rnd0cDJ4Z3d5bTF4ellDMFpRUzAzdWtyeFpu?= =?utf-8?B?ZnlNQy80QTlPd3Z3VUhuOGdGaklESXlCVy9FUzRZTmtzNGFpb2tKK3o3MlEr?= =?utf-8?B?elFrVXFpcEwyNTV4VTIyczQ5cVFvWTRZVkd1eEZaQnR4YjhpS2V6VnVEU1hC?= =?utf-8?B?SHJWcHNnUVEvVkJHc3hsUkNaZGxsMlF1Yk5idldyOGxUMjFtY2p4R0k0Q2I4?= =?utf-8?B?TGJhdHNjZzBHZFNsai9idmcrbzdIdE5DakRSNElyVUlxTzhGd1dYN25Xc0s5?= =?utf-8?B?bDdEd016b3U1ZmJGNUswUEMzZ28wZFQ4RGtJMzVsT0FsU0dadmx3R1hlY2hX?= =?utf-8?B?UXVNa3NWVVdFQkdsNWJBNm8yL2ljTCt3aFFaZXFSVnFxYlBhbkdISGkvK0do?= =?utf-8?B?QmllN1hOTVNIYWdJdGc1ZzJFQnlDTTI5K05XRnBSbWFZQ2V3Z3JXY0NobHBG?= =?utf-8?B?SHJTZUExUDFlYnRuUmhHZFk4MXhmNEtScksyaVppbjVnMWdjMzAzL3laVDlM?= =?utf-8?B?b3AwbzRlWnV4a09OQ1ZnOTZXaWRGbUc1STdaTFEwM2lSWXh1dUZnRWh0L0c5?= =?utf-8?B?a0kyWm5VVFlpOVYzdzN5c2dBZGNkMlpnWFV5elp1YXg5a1JtRmt4cDJiT2pH?= =?utf-8?B?d3ErZkJ5cEVjTFhOT2lhUjR4bW15eXkyTUlxeHorcVlHUjVIM2lkTUs4NXpo?= =?utf-8?B?VFJWV0V5MFJlV1ZTcmwrNzg3Rm1BOVBNNTFJSHAwdk1sL1VEZ3liTmMrYS8r?= =?utf-8?B?U2lnQi93QmE4TVlrcFY4c1J3NGZ3OWg1cHQ0K2dmYng0d2t6d3ltRmExNEdJ?= =?utf-8?B?Y0pUNzEzcHpaZTJDRjhWTS9MUzZnMlFRNUNrSWZ2Qm05NGZZclFRTVpheGNl?= =?utf-8?B?TFNxbzN2ZlgydTJXd1NJZUxRNGJhWmVwckhDZW9obVRGUzVvbFduT2xTOWVl?= =?utf-8?B?YU9pRWs4UVlodXlVZFRyTDcweVJrbk5zc2xVN0U0WFZRU3N4TG5VWkU4R1Bt?= =?utf-8?B?dkduT1dleE5seDFZdlpWZVIzZ1VQeWFIUzBxNDdBeXNqd2FsTm1FZkRRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f03d2a1-8ac0-4f64-318a-08dabb9aa750 X-MS-Exchange-CrossTenant-AuthSource: SA1PR19MB4911.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 23:50:14.1503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR19MB4628 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Look good. Good find. reviewed-by: Sean Brogan On 10/28/2022 8:59 AM, Michael D Kinney wrote: > Always use the module name with FILE_GUID to generate the host-based > unit test executable image and symbol files. This allows the same > host-based unit test INF file to be used more than once in a single > DSC file with FILE_GUID override. This is valuable when there is a > requirement to run the same host-based unit test with different PCD > settings, library mappings, or build options. > > Cc: Michael Kubacki > Cc: Sean Brogan > Signed-off-by: Michael D Kinney > --- > UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > index 4dd8d4ac678a..f249813713a8 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > @@ -30,7 +30,7 @@ [BuildOptions.common.EDKII.HOST_APPLICATION] > # > # MSFT > # > - MSFT:*_*_*_DLINK_FLAGS == /out:"$(BIN_DIR)\$(BASE_NAME).exe" /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM:CONSOLE /DEBUG /STACK:0x40000,0x40000 /NODEFAULTLIB:libcmt.lib libcmtd.lib > + MSFT:*_*_*_DLINK_FLAGS == /out:"$(BIN_DIR)\$(MODULE_NAME_GUID).exe" /pdb:"$(BIN_DIR)\$(MODULE_NAME_GUID).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM:CONSOLE /DEBUG /STACK:0x40000,0x40000 /NODEFAULTLIB:libcmt.lib libcmtd.lib > MSFT:*_*_IA32_DLINK_FLAGS = /MACHINE:I386 > MSFT:*_*_X64_DLINK_FLAGS = /MACHINE:AMD64 > > @@ -47,8 +47,8 @@ [BuildOptions.common.EDKII.HOST_APPLICATION] > # > # GCC > # > - GCC:*_*_IA32_DLINK_FLAGS == -o $(BIN_DIR)/$(BASE_NAME) -m32 -no-pie > - GCC:*_*_X64_DLINK_FLAGS == -o $(BIN_DIR)/$(BASE_NAME) -m64 -no-pie > + GCC:*_*_IA32_DLINK_FLAGS == -o $(BIN_DIR)/$(MODULE_NAME_GUID) -m32 -no-pie > + GCC:*_*_X64_DLINK_FLAGS == -o $(BIN_DIR)/$(MODULE_NAME_GUID) -m64 -no-pie > GCC:*_*_*_DLINK2_FLAGS == -lgcov > > # > @@ -56,10 +56,10 @@ [BuildOptions.common.EDKII.HOST_APPLICATION] > # > XCODE:*_*_IA32_DLINK_PATH == gcc > XCODE:*_*_IA32_CC_FLAGS = -I$(WORKSPACE)/EmulatorPkg/Unix/Host/X11IncludeHack > - XCODE:*_*_IA32_DLINK_FLAGS == -arch i386 -o $(BIN_DIR)/Host -L/usr/X11R6/lib -lXext -lX11 -framework Carbon > + XCODE:*_*_IA32_DLINK_FLAGS == -arch i386 -o $(BIN_DIR)/$(MODULE_NAME_GUID) -L/usr/X11R6/lib -lXext -lX11 -framework Carbon > XCODE:*_*_IA32_ASM_FLAGS == -arch i386 -g > > XCODE:*_*_X64_DLINK_PATH == gcc > - XCODE:*_*_X64_DLINK_FLAGS == -o $(BIN_DIR)/Host -L/usr/X11R6/lib -lXext -lX11 -framework Carbon -Wl,-no_pie > + XCODE:*_*_X64_DLINK_FLAGS == -o $(BIN_DIR)/$(MODULE_NAME_GUID) -L/usr/X11R6/lib -lXext -lX11 -framework Carbon -Wl,-no_pie > XCODE:*_*_X64_ASM_FLAGS == -g > XCODE:*_*_X64_CC_FLAGS = -O0 -target x86_64-apple-darwin -I$(WORKSPACE)/EmulatorPkg/Unix/Host/X11IncludeHack "-DEFIAPI=__attribute__((ms_abi))"