From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C105D940273 for ; Tue, 7 Nov 2023 00:57:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=satpTdW7GvQTHNYMwtsNeZzjsXr+5gYPz04y3lqc4YA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699318634; v=1; b=jelw8XWkrMMdosRlzz7h9rxFBAdKR7HIaZvnQmUEDuYp8R/efGYJjS6/LCRSw/sUVJjx3LFu b/a94OTj01ySE9ZdbVwabk+hpGgiXBBcQDq4++kbaWNc1+obwip2e3jJdaZRlaJSBGP14Yk87M8 grk7rvD4qeSZOMVLCpk/YL9Y= X-Received: by 127.0.0.2 with SMTP id dcAmYY7687511xldxKuBYcXm; Mon, 06 Nov 2023 16:57:14 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.81]) by mx.groups.io with SMTP id smtpd.web10.353.1699318633897805517 for ; Mon, 06 Nov 2023 16:57:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kzfip3oV7MrtrMf7Ap5wjaQmdenp/1Ix7EKqy8PsTCP2ZWXmUif2Ng/5qyXiDBFBMxbYXYu4AvGepT2GVj1Q6upzkEkZpUNPPnDT5hL5YRszVbYHzRsrcd7uLQTG2rgUQVHi4xdx7sPIpP6qWjTaZ0c4Im14NWQlJW+l7QTz22rb02NJqS7D50XNZGkDFNHQkqdWe4F/B6H6AeKNc1WZTn9Us8XeYZRxD9RY32Gr4rA/wnli2fj/USidkT6F9StucM5Eex2tVwtR5Vja6qFODpr6gBIBtPEnYiF2TCzOmbxZtGdPHt5SfVe/r6mPWzXpDb8pfdj5uCgqW4q/1X//8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ttEUqq1ttWuXsHviES/RfjqLvSJUsjrVpDEXow/S8WI=; b=gOqmTgC8vbeukNbhdU73ppYnuWRSkKsPruIna1AMkmX/Z25ZjLSygnENRTr9LHuDXVxEbHHkWO8jQeqcLDOsx5RyZi0c9X4hmyvFLEiGVCcPbsfjNnIyyqt2RdKHzAF7QlXx+TqEMXcOZhmRURZMpAog9R1RyFu88qp7gnYCT+HA2DouvLjur+OqUvivwA9VESQXRx2fOpWAPjnV1icekXS/7Fvr3n7A39NVlAKQlazPygJVbKNnCw+0TXMo4PqL6DfcIlJYn3wZ4iaiDBX1AWLHYfT0nBZPkh012MrtQ33fPShAKB5wS6TlNAPmFaRQlP8+6jGVDJ+8+/8eRXPB/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Received: from SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) by MW4PR19MB7031.namprd19.prod.outlook.com (2603:10b6:303:228::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Tue, 7 Nov 2023 00:57:12 +0000 X-Received: from SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::d81b:3482:f2d3:813c]) by SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::d81b:3482:f2d3:813c%5]) with mapi id 15.20.6954.029; Tue, 7 Nov 2023 00:57:12 +0000 Message-ID: Date: Mon, 6 Nov 2023 16:57:11 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 6/8] .pytool/CISettings: Enable CodeQL audit mode To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Sean Brogan , Michael D Kinney , Liming Gao References: <20231102200313.1010-1-mikuback@linux.microsoft.com> <20231102200313.1010-7-mikuback@linux.microsoft.com> From: "Sean" In-Reply-To: <20231102200313.1010-7-mikuback@linux.microsoft.com> X-TMN: [Iq+R2L4dgp5rjOjNlRIkKoEabfmTP5LRjYUMJQQxjv3MTCkqTs8yor5xmv+2xTQQ] X-ClientProxiedBy: CYXPR02CA0010.namprd02.prod.outlook.com (2603:10b6:930:cf::21) To SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) X-Microsoft-Original-Message-ID: <7da50d94-bb09-4479-9491-09c8085bac79@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR19MB4911:EE_|MW4PR19MB7031:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f0a85f5-9788-4927-b43f-08dbdf2c7a0c X-Microsoft-Antispam-Message-Info: 42wZvnflJ4AYrFpx+4dPZ4HOya1lVHJlmdUbDkAf4tCx4QkmWqltN/ELHR5L6wBmdKFmnrU7usYFvf12guxBFFh19qf8SgMdPb9RbIESMuc5an+cj8Lq1m+kfPDtu5zKa/IJDOV5rtAEXhNYBsmiSCkMQlITo8sokm8H7R6tzl9vlZGKOhKcj5zJuCYYmS28wZBFXRcDirCqvKm3FoeHkqheqofJKhrOgjH+X78TocfQw66IUUvTulJ3zM/M4BwWzAjp3jJQK8/l2BAQAHcw97TViMX8rb6tiSk25tj7++y7dINRXaMsyrYOQFJoDWxO+l3c7vQeSaPKoozXRDzoi2/4Hmtwds9lO8DVab0lLWExPOHu8huo1+7XzrhVACWrLaN6waFXwig/uoyHYMDg0/iXTKriJyasLIQYE4vYkzeQ6pH8NLgGF5qcTu1XJrVIn9oxtKhjeCb57mLy0pffIrfxb90QGyyyYUBDi7nm+a15ZpwBOHDJwOOHqp7qmsonJgwtg/jbeeGrI55/9fmfD8lzdun5MvMCrV8wh4dSAvjy+lcfWdbzBeh3zQqKOglu X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ni9oZ0RjNEE4YmhRRENhblNwLzFHU2k0bEx2b3c3R3Brc0dNb2U0S2cwMXoy?= =?utf-8?B?OVpZM3FtSlZMaFZhZTUrRFo1Si8yeEdUd2tFUUlJaTVka0o4a2FiUVdVcTVw?= =?utf-8?B?cnRRaUYrRXBKaDA4Tmt3MmtyWXQyK2JWWTgwclZMRUs3Yk9Iak4wZWI2enda?= =?utf-8?B?L3o4eVFyVUFvUzN5WWVvZVBrcTJVZGJacXdqU0hoSWV1blFlb0sxR21VSlIv?= =?utf-8?B?enJORjlaZ0V5QmZmejdaQjFwemp3SmVUQ2J6RWJIRkx5ODBNU0JacEV5Z0lX?= =?utf-8?B?ZlZ3RjhyZFZWVWpha0dmZ1dHZFhwRml3RGdGdFRac1RXOXFGTzNuQUNkeDRZ?= =?utf-8?B?WU0rcy8wM0xjTDNVbUpIN0R5NEdJSGRTRDBISmc0Slcwb29JRlU0VGh1Q2ZJ?= =?utf-8?B?WmFzbTZTS0R1bkxKamlWR0kybHJ5WlVEVm0wMVg0RjdLQi9Eb09mSXJYWG9S?= =?utf-8?B?QkJZc1JMVnpRd3czS3RzcUs2QVAxdTZaUTA0bjhUMXk3NFNpSkpNR3BhcGl6?= =?utf-8?B?K1c1RUx4YmE0Mmx6clhwSzlPSGpVejdGTXVvcVRGdXprVnBOOXQ2WEMvUStJ?= =?utf-8?B?MHFvQ2NicThSVEYxaEYvRmM3aTZRR3FhaWNBd1c4MERmcFZmNmtXMXdwd0JW?= =?utf-8?B?bFYwSkhtS3BkUVZ0NXEvNDBzUmp3K2gwYnVwS3V6R1FUZWowRWR0N0ZRQzlE?= =?utf-8?B?VnlremI2eXAzdVFqWnFTL1J6TldlRzF3V1RRMlgvYzV4bmNCU1ZFc1pmNnRH?= =?utf-8?B?NWM2M2wwTmVSVFFQL0ZjMHNWQWRXNWQyMXBKQW13ZE9IdEp0eHZRNk1ZYnAz?= =?utf-8?B?Qm9NNVhqMFhnRGdWTnN6VzFpUU5GSnFHbmhaQW11N1k1QVBQSUVXRVMvbmxn?= =?utf-8?B?aW40bUR5bEhWbkRDc0FTbmxQVzN5ZlBJZS9HM1A0QVNXL1NpRFIyM1BlR0tx?= =?utf-8?B?L09VWGQ0UDNPYzRzQmRINGVaVEk5aWxvN29SL1Fmb2J3M2sxNDM4MjJKd3NB?= =?utf-8?B?QTRCajdFSDlaYkVabDhDdUZJTDRzUXY2UDhjektBV05ZTDNKdFFXSGJVZ2xl?= =?utf-8?B?YU52TDNqUmIrb0xzQUFVZU5qOWhtcUlPYmc2dDlINlNEcmwxb3UxZTZndVVU?= =?utf-8?B?TWNoY1hzQ0piRzcrNTJ5cFNBOWxWY2xxNnc0R3ZqOWYxM1IyVHF6OTF1ZGRT?= =?utf-8?B?UEpHR09NNmpCZU1WcHBOMkRQdTgvTG1CNXM0K0UxdUhncGh0R3JGYnJDTXVP?= =?utf-8?B?bVlSOTBMcXU0ZW1xN3dKQVBRaXlRVFhuRUo1cEY3S3FLR0V1U0pDOXVLVml5?= =?utf-8?B?blV1d2k2bTZ1N05LRm1sVzRHRWYxeTlLY01iM1FVczRwRC9OOFpzSndjWm52?= =?utf-8?B?TlY4N2lkbDdQVGNwdmJYN2tUeTB0OTRMRS9uY1pvTnRqK1dRWDBwc1dTV2N6?= =?utf-8?B?eHY0YW1VTGFpNWtoZkw1aGxJRzJ4OXFjbzhuZ1k3bUZZZHRhMHhySThSa294?= =?utf-8?B?dnFaeXFqaFdaZXlYT0x0S2RpZWFyYlNSb3lNQmd0NHgyZGY2RjJ3WXpMQmVF?= =?utf-8?B?NHE4dVZQSnlpSyt0c2ExV3c2R2M0WDVVeVRBYkIzNmxGRzVXTXlJOEVwb1Ez?= =?utf-8?B?aE5PL0hoMW5mNHJHVkhpMDNLTW9kWThTUkQwbXlnWGE1bjYyeUF4cGthUERO?= =?utf-8?B?VFhDNWVUNEJXa1Q5UzNTWmx1d2Y3OVdvQzI4TnowSys5elpzbWVCTUJ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f0a85f5-9788-4927-b43f-08dbdf2c7a0c X-MS-Exchange-CrossTenant-AuthSource: SA1PR19MB4911.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 00:57:12.5321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR19MB7031 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,spbrogan@outlook.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: N1OBOO9uSuyXIpRcrqMEpu4Qx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jelw8XWk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=outlook.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Sean Brogan On 11/2/2023 1:03 PM, Michael Kubacki wrote: > From: Michael Kubacki > > Since a large number of CodeQL queries are being enabled to identify > issues that the community can collectively resolve, audit mode needs to > be enabled to prevent the build from failing. > > In the future, this global audit mode can be disabled and individual > packages can enable/disable audit mode in their package CI YAML file > using the instructions in the CodeQL plugin readme. > > Cc: Sean Brogan > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Michael Kubacki > Acked-by: Michael D Kinney > --- > .pytool/CISettings.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py > index b8b8080439c1..ec3beb0dcf9d 100644 > --- a/.pytool/CISettings.py > +++ b/.pytool/CISettings.py > @@ -196,6 +196,12 @@ class Settings(CiBuildSettingsManager, UpdateSetting= sManager, SetupSettingsManag > =20 > try: > scopes +=3D codeql_helpers.get_scopes(self.codeql) > + > + if self.codeql: > + shell_environment.GetBuildVars().SetValue( > + "STUART_CODEQL_AUDIT_ONLY", > + "TRUE", > + "Set in CISettings.py") > except NameError: > pass > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110775): https://edk2.groups.io/g/devel/message/110775 Mute This Topic: https://groups.io/mt/102350796/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-