From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.92.23.11]) by mx.groups.io with SMTP id smtpd.web11.111591.1670094867320942810 for ; Sat, 03 Dec 2022 11:14:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=b2uVtyKC; spf=pass (domain: outlook.com, ip: 40.92.23.11, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEMi8ZGGYEBZtAT8RaWNMjT9Xmfop1Cdi+eYS5NR5bOIXR0IB2o1eVRVbvbITSF7OyqaCM9p8290DTcL5yZdYqTEN0K1Mq/jg/lZ7RCsnKcSLNJCxW+YKCMytb4pP1hS2kA41iQ7jgo16tI8rFbTnI1LdfnCYGTKXcuiMrhElPZ3LNoh6c4mA+pdzGKkoCGxGeCR8h2Qf6M94ZZfQZcRJcQh1nB9DjLXLYxn2dk5t1fkSw4wQJlumFdvi7PwRPm2SjFUtE/2ht4822XWvUn2/qGmvO1ut+v4BQHAq0XrikCN1h8Y18K9JN2snLy7FZT7fJtEErlbWSddCD8V1t8RmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FahSswSKaJxKOyw2CQqoP8cMIzKS2m3eCHkTBDCAVmg=; b=FwffynUvlvFiBPV0HEtSYR+dC9m+YtvDGjp1uiOnyZKpqJeGTEoEfPBXF32YhSsVxSk06GhsbfkNIRdD1t6rnJqINM436uGpwkYTCgJqcZg/+4+AtqhglhIC64A6a2YeM78zGK1zKUEKIBoXGvHwVNOglt7qbO+mHCAv8Z9SF+kr9rM9JuCkPEmCrVN1k7XXca+q5RiLa3abtgNnyr8l/ooyBwWY4mNSX588eI/lhHgu6KIy+IwfUadfLz0aUAV5jfN4NSKNz8ErxDqYSWpMt4lBabBgNUAiXYDtj6F/a1/2MpWbjQu28vXVDZ+yv9byedANRkNodp3uTX7gk3hohw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FahSswSKaJxKOyw2CQqoP8cMIzKS2m3eCHkTBDCAVmg=; b=b2uVtyKCnnCW1Zj0HB8snRI82KSX3+hW/LABDifYbY6RYBTGrxu83A3cbTmtSEHlxQXiOGArHoXyv+KzMpZx2VOcc5T5RoKHL4VKUbgxBA3ClIyY5/i+ISv0nifE8/soaEzLtmixeIuXGFBl0+wFgVjaRnPS95q/kWodSHm5G/xsxpOlsP/lfW8ah8UbD+11wKzoj/xHOp7NGkD+j27qxUPRV9yxlzIauERaPznH2MQDbxXbRuQ4q433U37HKCHP6xllLiqwsv+3EI/tY2fpDDWxg8YI7o3s5uYu3SHIWjb2f2sMesTznrIGBHb1qh6zw9cNjeYAUQr8cwkCGv0nBg== Received: from SA1PR19MB4911.namprd19.prod.outlook.com (2603:10b6:806:185::10) by DM6PR19MB3818.namprd19.prod.outlook.com (2603:10b6:5:229::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Sat, 3 Dec 2022 19:14:25 +0000 Received: from SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::bb64:5feb:9de7:a514]) by SA1PR19MB4911.namprd19.prod.outlook.com ([fe80::bb64:5feb:9de7:a514%4]) with mapi id 15.20.5880.010; Sat, 3 Dec 2022 19:14:25 +0000 From: "Sean" To: "devel@edk2.groups.io" , "jiewen.yao@intel.com" , Wenyi Xie , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" CC: "songdongkuang@huawei.com" , "yizihong@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib:time overflow Thread-Topic: [edk2-devel] [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib:time overflow Thread-Index: AQHZBhI0U1Kf+uAKykSuY/HI5qgPBa5cSR4AgAA7dp0= Date: Sat, 3 Dec 2022 19:14:25 +0000 Message-ID: References: <20221202055150.1476640-1-xiewenyi2@huawei.com> <20221202055150.1476640-2-xiewenyi2@huawei.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [S/ziHMockt6GZb8J5JewoLDLQCv5eJ4t] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR19MB4911:EE_|DM6PR19MB3818:EE_ x-ms-office365-filtering-correlation-id: 4080eb44-0355-4b31-2ff4-08dad56297c7 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WM4Fe3ICrSIxjUidkTOgjvIRZkg/6b8X1ZrZivwqVwVZ1aK0+l3KVlTr2rO5VrvsTbbJRsYHUmkVBjudkXWJY2KDNYM16zWWt7smDpohwj5LIeUIW5Cs+tsER5vT/+O9LR074ibEy91WL71gACNei1prXUxIwlJHlvr8+Vg9EGbf1LaT/nFKP17qzHY0vSJFFbGAFDYzQoj1zPa1QbTLkG5uG/3ELc/xMEPeTE1T59gZVInaNBbem4u85imBZGVzv5Fsmh0vqts05H3+7LwYqHDV9M7+MX7T50CeR7wa1n7w5XKdsumQQZ/eMMYa/p0c9gor8I/LaWLkcUX974caFYwixT+451bBlNtKPJ9SowHwA+bB1+x/6aE/I//oYB3jre3+cbDYakAsmhylRghZzwa/DFQlilWnEmo3wuiLq/RoElGRF2dzAwdbMQ72tyUitnXpuwEM/VHwiWNsEOU8WQO3SSGLfylFMpX4EVAdH/VBzqunCJxL2x6cfUemkHWiTDQKyfhuoRS9i+M9oSQBiGagMnERUmz12LGR6s6DxtEdvhWFhZgxCPiYkoS1OSEmdQwZqQ9+OtnEr47lTRI5OSQFe+PzfSmfYrsAqNe4y4Kp3stP2/HPV5Hu5HJ+BOFz8AEJK9+NAmlbAMSlizOCgZ8RBcRAz3LaYVFohT3Ag5aH68njeKq56kCkATT07zJG x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?+XBh7ma3bjcgB20v/Mx8i0D4PsAfL7euo7IBSbQFdHG/90Ih9wi5QltM?= =?Windows-1252?Q?lZoP/IPU+CRqENM894z+U93THnBa1ItBRG8CVhqJtR5c9EGzD5HzDCan?= =?Windows-1252?Q?z3R3B/2ZeXHI9YQARHGHUxAXAwqzX8G7FGnfYxKN25mAfFLiVXI5P0Ff?= =?Windows-1252?Q?w5KKJlXy/w0vnwKTSpy7AXfqhn+wrI1NqFQGtq54dmMQkE6s6D6/xuai?= =?Windows-1252?Q?rinoOX6NsJ/xhP6RAgushZAIOf9d6URDtYI6G+iQBtQebpZidwqFgPjp?= =?Windows-1252?Q?wx9ytAUNd/taE6SdBUfyZvJo63BpG7RLFjbkU2e73QxFFT4viNJ/azEQ?= =?Windows-1252?Q?UZmfoOYuN1J5L7bM5q34ke80UsWDQq1eim5+M1ezBjJ492JUR1OhAZKO?= =?Windows-1252?Q?i8qy6cbo2tINI7W9XrcDXTC7Zqui8XRvB+rv5HjcniCANRhFzvEMwSbo?= =?Windows-1252?Q?6CKeco63En/3PcdHRbNYrB8+iM4H0uDFdY9Mzju8DuBwFsVxnUV13rCN?= =?Windows-1252?Q?9M4H+NTx6DN6Ua2tkfr4nqUrVPQtD8ZrcUIDTWnlcR2MYBnp8AdEf7a/?= =?Windows-1252?Q?a+osEAYKv31H7LQAuhFmNkm3N05iFnor1xTYop0hDkdpNtvYkm0zhmVq?= =?Windows-1252?Q?Vy8COzwGzHxmFFX+YiodZZr0qFt2cVYJp98y1xGZHbECaqg61eEujf2T?= =?Windows-1252?Q?657eDisJBi1+CoFSx69rx2W9JywhEDsiQveyhMPu4iPhddpALTJtSfDY?= =?Windows-1252?Q?sS6BYfbFHM9GnkDILQRq7Pnop71shM1S0BX2cAEi5IT3dbRAagin4WIb?= =?Windows-1252?Q?cWuw0BvJLkvIgZ1bDRHw5f/IihKz2Zi6QMhASmy09hqKNUHZ61mMFCxa?= =?Windows-1252?Q?TpGA8yXiZm5zCMbEXRRqnM/qumU+VQHd+cS2pEuABkiZUckS0bTE0Ck4?= =?Windows-1252?Q?7V5trL1CUElQn6y0hb89QXoFygTFfpJyqRu/swgKgPGza8tz42W+y38H?= =?Windows-1252?Q?zDajQEKEeYUpRLPa0LB2sa4mxmdXfnnKj6/qTe7K8wcN4SSoCvnGAfuO?= =?Windows-1252?Q?qtLla4J5TEjGqdzazVnwoCKKpndD5UsefPyRU5BZE8wZl5YNaNVh4mMG?= =?Windows-1252?Q?YA2KdpvHHpavZlTwmtaAoSLoGEceWbib3xe8xNuXEiVcSbPS7Hmf/7cY?= =?Windows-1252?Q?Mr13IBF7ZT1BeoAJ8oIA//yw7EAO6Esu0vwYyshXwwi9DGlVYrtKt65+?= =?Windows-1252?Q?z+WJ+DjI2L2+RIobDS34b9grbkQu7J4tOUM/4qpOUR7frodNBAnMvzT8?= =?Windows-1252?Q?3jXge3p3iUUwXicCEn1zss1rIh2otq5HK2JNAbYjmJZpTLVKq22jND2L?= =?Windows-1252?Q?87SXcM4ABv0DIA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR19MB4911.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4080eb44-0355-4b31-2ff4-08dad56297c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2022 19:14:25.5802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB3818 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SA1PR19MB4911B0CF70BA5D328295A5B2C8169SA1PR19MB4911namp_" --_000_SA1PR19MB4911B0CF70BA5D328295A5B2C8169SA1PR19MB4911namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable We have a great unit test framework. Is there any reason we can=92t write o= r extend a unit test for bugs like this? Thanks Sean ________________________________ From: devel@edk2.groups.io on behalf of Yao, Jiewen = Sent: Saturday, December 3, 2022 7:19:26 AM To: Wenyi Xie ; devel@edk2.groups.io ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Cc: songdongkuang@huawei.com ; yizihong@huawei.co= m Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib:time o= verflow Merged https://github.com/tianocore/edk2/pull/3710 > -----Original Message----- > From: Wenyi Xie > Sent: Friday, December 2, 2022 1:52 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com; > yizihong@huawei.com > Subject: [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib:time overflow > > From: Zihong Yi > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4167 > > In CrtLibSupport.h, time_t is defined as INT32, and its maximum value > is 2147483647. That is, the corresponding maximum timestamp is > 2038-01-19 11:14:07. Therefore, overflow occurs when the test time > exceeds 2038-01-19 11:14:07. So change the type of time_t to INT64 and > also change the type of variables in function gmtime which calculated > with time_t. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Zihong Yi > --- > CryptoPkg/Library/Include/CrtLibSupport.h | 2 +- > CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c | 51 > ++++++++++++++------ > 2 files changed, 38 insertions(+), 15 deletions(-) > > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index 5072c343da57..94b0e6b6014f 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -109,7 +109,7 @@ typedef UINTN off_t; > typedef UINTN u_int; > typedef INTN ptrdiff_t; > typedef INTN ssize_t; > -typedef INT32 time_t; > +typedef INT64 time_t; > typedef UINT8 __uint8_t; > typedef UINT8 sa_family_t; > typedef UINT8 u_char; > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c > b/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c > index bf8a5325817f..2dfc6fe6c593 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c > @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > // -- Time Management Routines -- > // > > -#define IsLeap(y) (((y) % 4) =3D=3D 0 && (((y) % 100) !=3D 0 || ((y) % = 400) =3D=3D 0)) > #define SECSPERMIN (60) > #define SECSPERHOUR (60 * 60) > #define SECSPERDAY (24 * SECSPERHOUR) > @@ -60,6 +59,26 @@ UINTN CumulativeDays[2][14] =3D { > } > }; > > +/* Check the year is leap or not. */ > +// BOOLEAN IsLeap( > +// INTN timer > +// ) > +BOOLEAN > +IsLeap ( > + time_t timer > + ) > +{ > + INT64 Remainder1; > + INT64 Remainder2; > + INT64 Remainder3; > + > + DivS64x64Remainder (timer, 4, &Remainder1); > + DivS64x64Remainder (timer, 100, &Remainder2); > + DivS64x64Remainder (timer, 400, &Remainder3); > + > + return (Remainder1 =3D=3D 0 && (Remainder2 !=3D 0 || Remainder3 =3D=3D= 0)); > +} > + > /* Get the system time as seconds elapsed since midnight, January 1, 197= 0. > */ > // INTN time( > // INTN *timer > @@ -117,12 +136,13 @@ gmtime ( > ) > { > struct tm *GmTime; > - UINT16 DayNo; > - UINT32 DayRemainder; > + UINT64 DayNo; > + UINT64 DayRemainder; > time_t Year; > time_t YearNo; > - UINT16 TotalDays; > - UINT16 MonthNo; > + UINT32 TotalDays; > + UINT32 MonthNo; > + INT64 Remainder; > > if (timer =3D=3D NULL) { > return NULL; > @@ -135,18 +155,21 @@ gmtime ( > > ZeroMem ((VOID *)GmTime, (UINTN)sizeof (struct tm)); > > - DayNo =3D (UINT16)(*timer / SECSPERDAY); > - DayRemainder =3D (UINT32)(*timer % SECSPERDAY); > + DayNo =3D (UINT64)DivS64x64Remainder (*timer, SECSPERDAY, > &Remainder); > + DayRemainder =3D (UINT64)Remainder; > > - GmTime->tm_sec =3D (int)(DayRemainder % SECSPERMIN); > - GmTime->tm_min =3D (int)((DayRemainder % SECSPERHOUR) / > SECSPERMIN); > - GmTime->tm_hour =3D (int)(DayRemainder / SECSPERHOUR); > - GmTime->tm_wday =3D (int)((DayNo + 4) % 7); > + DivS64x64Remainder (DayRemainder, SECSPERMIN, &Remainder); > + GmTime->tm_sec =3D (int)Remainder; > + DivS64x64Remainder (DayRemainder, SECSPERHOUR, &Remainder); > + GmTime->tm_min =3D (int)DivS64x64Remainder (Remainder, SECSPERMIN, > NULL); > + GmTime->tm_hour =3D (int)DivS64x64Remainder (DayRemainder, > SECSPERHOUR, NULL); > + DivS64x64Remainder ((DayNo + 4), 7, &Remainder); > + GmTime->tm_wday =3D (int)Remainder; > > for (Year =3D 1970, YearNo =3D 0; DayNo > 0; Year++) { > - TotalDays =3D (UINT16)(IsLeap (Year) ? 366 : 365); > + TotalDays =3D (UINT32)(IsLeap (Year) ? 366 : 365); > if (DayNo >=3D TotalDays) { > - DayNo =3D (UINT16)(DayNo - TotalDays); > + DayNo =3D (UINT64)(DayNo - TotalDays); > YearNo++; > } else { > break; > @@ -158,7 +181,7 @@ gmtime ( > > for (MonthNo =3D 12; MonthNo > 1; MonthNo--) { > if (DayNo >=3D CumulativeDays[IsLeap (Year)][MonthNo]) { > - DayNo =3D (UINT16)(DayNo - (UINT16)(CumulativeDays[IsLeap > (Year)][MonthNo])); > + DayNo =3D (UINT64)(DayNo - (UINT32)(CumulativeDays[IsLeap > (Year)][MonthNo])); > break; > } > } > -- > 2.20.1.windows.1 --_000_SA1PR19MB4911B0CF70BA5D328295A5B2C8169SA1PR19MB4911namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
We have a great unit test framework. Is there any reason w= e can=92t write or extend a unit test for bugs like this? 

Thanks
Sean
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Yao, Jiewen <jiewen.yao@intel.= com>
Sent: Saturday, December 3, 2022 7:19:26 AM
To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io <= ;devel@edk2.groups.io>; Wang, Jian J <jian.j.wang@intel.com>; Lu, = Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.= com>
Cc: songdongkuang@huawei.com <songdongkuang@huawei.com>; yizih= ong@huawei.com <yizihong@huawei.com>
Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib= :time overflow
 
Merged https://github.com/tianocore/edk2/pull/3710

> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Friday, December 2, 2022 1:52 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wa= ng, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com&= gt;; Jiang,
> Guomin <guomin.jiang@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com;
> yizihong@huawei.com
> Subject: [PATCH EDK2 v2 1/1] CryptoPkg/BaseCryptLib:time overflow
>
> From: Zihong Yi <yizihong@huawei.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4167
>
> In CrtLibSupport.h, time_t is defined as INT32, and its maximum value<= br> > is 2147483647. That is, the corresponding maximum timestamp is
> 2038-01-19 11:14:07. Therefore, overflow occurs when the test time
> exceeds 2038-01-19 11:14:07. So change the type of time_t to INT64 and=
> also change the type of variables in function gmtime which calculated<= br> > with time_t.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Zihong Yi <yizihong@huawei.com>
> ---
>  CryptoPkg/Library/Include/CrtLibSupport.h    = ;         |  2 +-
>  CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c | 51
> ++++++++++++++------
>  2 files changed, 38 insertions(+), 15 deletions(-)
>
> diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h
> b/CryptoPkg/Library/Include/CrtLibSupport.h
> index 5072c343da57..94b0e6b6014f 100644
> --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> @@ -109,7 +109,7 @@ typedef UINTN   off_t;
>  typedef UINTN   u_int;
>  typedef INTN    ptrdiff_t;
>  typedef INTN    ssize_t;
> -typedef INT32   time_t;
> +typedef INT64   time_t;
>  typedef UINT8   __uint8_t;
>  typedef UINT8   sa_family_t;
>  typedef UINT8   u_char;
> diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c
> b/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c
> index bf8a5325817f..2dfc6fe6c593 100644
> --- a/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c
> +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c
> @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  // -- Time Management Routines --
>  //
>
> -#define IsLeap(y)  (((y) % 4) =3D=3D 0 && (((y) % 100) != =3D 0 || ((y) % 400) =3D=3D 0))
>  #define SECSPERMIN   (60)
>  #define SECSPERHOUR  (60 * 60)
>  #define SECSPERDAY   (24 * SECSPERHOUR)
> @@ -60,6 +59,26 @@ UINTN  CumulativeDays[2][14] =3D {
>    }
>  };
>
> +/* Check the year is leap or not. */
> +// BOOLEAN IsLeap(
> +//  INTN timer
> +//  )
> +BOOLEAN
> +IsLeap (
> +  time_t  timer
> +  )
> +{
> +  INT64  Remainder1;
> +  INT64  Remainder2;
> +  INT64  Remainder3;
> +
> +  DivS64x64Remainder (timer, 4, &Remainder1);
> +  DivS64x64Remainder (timer, 100, &Remainder2);
> +  DivS64x64Remainder (timer, 400, &Remainder3);
> +
> +  return (Remainder1 =3D=3D 0 && (Remainder2 !=3D 0 || R= emainder3 =3D=3D 0));
> +}
> +
>  /* Get the system time as seconds elapsed since midnight, Januar= y 1, 1970.
> */
>  // INTN time(
>  //  INTN *timer
> @@ -117,12 +136,13 @@ gmtime (
>    )
>  {
>    struct tm  *GmTime;
> -  UINT16     DayNo;
> -  UINT32     DayRemainder;
> +  UINT64     DayNo;
> +  UINT64     DayRemainder;
>    time_t     Year;
>    time_t     YearNo;
> -  UINT16     TotalDays;
> -  UINT16     MonthNo;
> +  UINT32     TotalDays;
> +  UINT32     MonthNo;
> +  INT64      Remainder;
>
>    if (timer =3D=3D NULL) {
>      return NULL;
> @@ -135,18 +155,21 @@ gmtime (
>
>    ZeroMem ((VOID *)GmTime, (UINTN)sizeof (struct tm));=
>
> -  DayNo        =3D (UINT16)(*= timer / SECSPERDAY);
> -  DayRemainder =3D (UINT32)(*timer % SECSPERDAY);
> +  DayNo        =3D (UINT64)Di= vS64x64Remainder (*timer, SECSPERDAY,
> &Remainder);
> +  DayRemainder =3D (UINT64)Remainder;
>
> -  GmTime->tm_sec  =3D (int)(DayRemainder % SECSPERMIN);<= br> > -  GmTime->tm_min  =3D (int)((DayRemainder % SECSPERHOUR)= /
> SECSPERMIN);
> -  GmTime->tm_hour =3D (int)(DayRemainder / SECSPERHOUR);
> -  GmTime->tm_wday =3D (int)((DayNo + 4) % 7);
> +  DivS64x64Remainder (DayRemainder, SECSPERMIN, &Remainder);=
> +  GmTime->tm_sec =3D (int)Remainder;
> +  DivS64x64Remainder (DayRemainder, SECSPERHOUR, &Remainder)= ;
> +  GmTime->tm_min  =3D (int)DivS64x64Remainder (Remainder= , SECSPERMIN,
> NULL);
> +  GmTime->tm_hour =3D (int)DivS64x64Remainder (DayRemainder,<= br> > SECSPERHOUR, NULL);
> +  DivS64x64Remainder ((DayNo + 4), 7, &Remainder);
> +  GmTime->tm_wday =3D (int)Remainder;
>
>    for (Year =3D 1970, YearNo =3D 0; DayNo > 0; Year= ++) {
> -    TotalDays =3D (UINT16)(IsLeap (Year) ? 366 : 365);=
> +    TotalDays =3D (UINT32)(IsLeap (Year) ? 366 : 365);=
>      if (DayNo >=3D TotalDays) {
> -      DayNo =3D (UINT16)(DayNo - TotalDays);=
> +      DayNo =3D (UINT64)(DayNo - TotalDays);=
>        YearNo++;
>      } else {
>        break;
> @@ -158,7 +181,7 @@ gmtime (
>
>    for (MonthNo =3D 12; MonthNo > 1; MonthNo--) { >      if (DayNo >=3D CumulativeDays[IsLeap = (Year)][MonthNo]) {
> -      DayNo =3D (UINT16)(DayNo - (UINT16)(Cu= mulativeDays[IsLeap
> (Year)][MonthNo]));
> +      DayNo =3D (UINT64)(DayNo - (UINT32)(Cu= mulativeDays[IsLeap
> (Year)][MonthNo]));
>        break;
>      }
>    }
> --
> 2.20.1.windows.1






--_000_SA1PR19MB4911B0CF70BA5D328295A5B2C8169SA1PR19MB4911namp_--