[PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

[PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

[Rebecca Cran]

Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

This should be merged at the same time as the edk2 patch that supports
passing CC and CXX to make when building BaseTools.

Rebecca Cran (1):
  Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

 edk2basetools/Workspace/DscBuildData.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH edk2-basetools 1/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

[Rebecca Cran]

In order to support building BaseTools using non-default compilers, a
change is being made in the edk2 BaseTools directory to remove the
'BUILD_' prefix to CC, CXX, CFLAGS etc. so developers can for example
run 'make CC=clang CXX=clang++' to build using clang.

Update DscBuildData.py to generate Makefiles with CFLAGS instead of
BUILD_CFLAGS.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 edk2basetools/Workspace/DscBuildData.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edk2basetools/Workspace/DscBuildData.py b/edk2basetools/Workspace/DscBuildData.py
index ff5662f35702..38a5283389f9 100644
--- a/edk2basetools/Workspace/DscBuildData.py
+++ b/edk2basetools/Workspace/DscBuildData.py
@@ -89,7 +89,7 @@ def _IsFieldValueAnArray (Value):
 '''
 
 WindowsCFLAGS = 'CFLAGS = $(CFLAGS) /wd4200 /wd4034 /wd4101 '
-LinuxCFLAGS = 'BUILD_CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable '
+LinuxCFLAGS = 'CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable '
 PcdMakefileEnd = '''
 !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.common
 !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.app
-- 
2.34.1

Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

[Michael D Kinney]

Rebecca,

In order to avoid issues with the order or timing or merges, could
CFLAGS be added in one set of patches and then later remove BUILD_CLAGS
in a second set of patches?

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Thursday, March 30, 2023 1:05 PM
> To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris
> Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>;
> Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
> 
> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
> 
> This should be merged at the same time as the edk2 patch that supports
> passing CC and CXX to make when building BaseTools.
> 
> Rebecca Cran (1):
>   Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
> 
>  edk2basetools/Workspace/DscBuildData.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --
> 2.34.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

[Rebecca Cran]

Good idea. I'll send out a v2 patch with that change.


On 3/30/23 2:09 PM, Kinney, Michael D wrote:
> Rebecca,
>
> In order to avoid issues with the order or timing or merges, could
> CFLAGS be added in one set of patches and then later remove BUILD_CLAGS
> in a second set of patches?
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
>> Sent: Thursday, March 30, 2023 1:05 PM
>> To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris
>> Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>;
>> Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>> This should be merged at the same time as the edk2 patch that supports
>> passing CC and CXX to make when building BaseTools.
>>
>> Rebecca Cran (1):
>>    Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change
>>
>>   edk2basetools/Workspace/DscBuildData.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --
>> 2.34.1
>>
>>
>>
>> 
>>