From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Oram, Isaac W" <isaac.w.oram@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"KARPAGAVINAYAGAM, MANICKAVASAKAM" <manickavasakamk@ami.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
Date: Thu, 5 Aug 2021 19:59:23 +0000 [thread overview]
Message-ID: <SA2PR11MB49383675738B48D9FDC7F28ED2F29@SA2PR11MB4938.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210805182739.16310-1-nathaniel.l.desimone@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
> Sent: Thursday, August 5, 2021 11:28 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; KARPAGAVINAYAGAM, MANICKAVASAKAM
> <manickavasakamk@ami.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
>
> Building the IpmiFeaturePkg standalone
> (not as part of a platform build) currently
> fails because the IpmiPlatformHookLib was added
> but the reference to the NULL implementation of
> that LibraryClass was miseed.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> index 05a7d4f0af..a6eccb428b 100644
> --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> @@ -48,6 +48,7 @@
> # IPMI Feature Package
> #####################################
> IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
> + IpmiPlatformHookLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
>
> [LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
> #######################################
> --
> 2.27.0.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2021-08-05 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 18:27 [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build Nate DeSimone
2021-08-05 19:59 ` Michael D Kinney [this message]
[not found] <16987C6E76A1D518.16257@groups.io>
2021-08-05 20:23 ` [edk2-devel] " Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR11MB49383675738B48D9FDC7F28ED2F29@SA2PR11MB4938.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox