* [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
@ 2021-08-05 18:27 Nate DeSimone
2021-08-05 19:59 ` [edk2-devel] " Michael D Kinney
0 siblings, 1 reply; 3+ messages in thread
From: Nate DeSimone @ 2021-08-05 18:27 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Liming Gao, Manickavasakam Karpagavinayagam
Building the IpmiFeaturePkg standalone
(not as part of a platform build) currently
fails because the IpmiPlatformHookLib was added
but the reference to the NULL implementation of
that LibraryClass was miseed.
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index 05a7d4f0af..a6eccb428b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
@@ -48,6 +48,7 @@
# IPMI Feature Package
#####################################
IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
+ IpmiPlatformHookLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
#######################################
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
2021-08-05 18:27 [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build Nate DeSimone
@ 2021-08-05 19:59 ` Michael D Kinney
0 siblings, 0 replies; 3+ messages in thread
From: Michael D Kinney @ 2021-08-05 19:59 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Nathaniel L, Kinney, Michael D
Cc: Oram, Isaac W, Liming Gao, KARPAGAVINAYAGAM, MANICKAVASAKAM
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
> Sent: Thursday, August 5, 2021 11:28 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; KARPAGAVINAYAGAM, MANICKAVASAKAM
> <manickavasakamk@ami.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
>
> Building the IpmiFeaturePkg standalone
> (not as part of a platform build) currently
> fails because the IpmiPlatformHookLib was added
> but the reference to the NULL implementation of
> that LibraryClass was miseed.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> index 05a7d4f0af..a6eccb428b 100644
> --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> @@ -48,6 +48,7 @@
> # IPMI Feature Package
> #####################################
> IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
> + IpmiPlatformHookLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
>
> [LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
> #######################################
> --
> 2.27.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
[not found] <16987C6E76A1D518.16257@groups.io>
@ 2021-08-05 20:23 ` Nate DeSimone
0 siblings, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-08-05 20:23 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Nathaniel L
Cc: Oram, Isaac W, Liming Gao, KARPAGAVINAYAGAM, MANICKAVASAKAM
Pushed: https://github.com/tianocore/edk2-platforms/commit/d6794cc
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, August 5, 2021 11:28 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build
Building the IpmiFeaturePkg standalone
(not as part of a platform build) currently fails because the IpmiPlatformHookLib was added but the reference to the NULL implementation of that LibraryClass was miseed.
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index 05a7d4f0af..a6eccb428b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat
+++ ure.dsc
@@ -48,6 +48,7 @@
# IPMI Feature Package
#####################################
IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
+
+ IpmiPlatformHookLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPla
+ tformHookLibNull/IpmiPlatformHookLibNull.inf
[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
#######################################
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-05 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-05 18:27 [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build Nate DeSimone
2021-08-05 19:59 ` [edk2-devel] " Michael D Kinney
[not found] <16987C6E76A1D518.16257@groups.io>
2021-08-05 20:23 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox