From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1441C941EF3 for ; Mon, 22 Jan 2024 23:25:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QINtIEMnTJQjohWM5ofnXZ1PJdADVUwHlxAR+3b78j8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705965954; v=1; b=juBoPvHByn1Asy2mepZiGRkzY0VFAoLgBDaoGfLpEE81XuGn/LncNTup6eG06OCd6Ocla0MY X5QRGly9gsRJDnz9to+INLK2Fz01spdp4/+tu6cujGFA1XtwEKpYmjAGovOnmNIU842LJxp1XGn 6FDFCYFFMf+Qp75ZzXA2pAzM= X-Received: by 127.0.0.2 with SMTP id R2j2YY7687511xvqcTJbqMoo; Mon, 22 Jan 2024 15:25:54 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.8401.1705965953797559040 for ; Mon, 22 Jan 2024 15:25:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="8724491" X-IronPort-AV: E=Sophos;i="6.05,212,1701158400"; d="scan'208";a="8724491" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2024 15:25:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="909095116" X-IronPort-AV: E=Sophos;i="6.05,212,1701158400"; d="scan'208";a="909095116" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jan 2024 15:25:39 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Jan 2024 15:25:17 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 22 Jan 2024 15:25:17 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Jan 2024 15:25:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4p+GQ6lbxSR+qKSQWMUKRxdBfsOys47K5E9JCRjFEzGcotuwStBUKgSRb15dLLjM2EPsVs9hcFcHsEJod/kQ+fNfD32tFy98cIxYGT/sESJImt3rRlTp7wKPBsmIsDojwrAsK1Ub0mx71brGQJXbXzjYe5XfQUwOeeTRf7qd82rWGhOAo+xtU0ae1c8M4XEtN6qC8H4saTozqQk+tK8EaXePy5AkGqCrGKADnmbm1jc3reQamTObriXSfipXpP/gT6JFsV/jvlyxHjQtzkvFewKpujmqCIlPoEPZishdoG0YHkFPbnauSZHhOHMV+u9FCW8wQeUe5nhcCyPzAUtlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ZsgGoM2/BW9tlS6wEcIIOZxoRB94UESo+hO9oQsfpo=; b=hLZNbqf64uxJuAfWIcGolB3thPkqe6jyV/D3gv/hKYYSr3wNHENenRGUMu8f7rssn83VBtYStWnzmBSsnHOpNG9ywMUaVZygByvYabQzKUW8fUGmiTcaMMPjosYJQWAXZiHHTX9hGDMVIo9meFwUYwrg0868zeUCkUSDUmeffBmv6u4Ua6XymeDVpt7dYrJA4524h3V+7FItB1kPWsapLMFYM5bEmC380ssoUVOtavKFf58PIPRJff5AY6ig3K+ugjiZdHGSzeuoH7rkpXTLFYDTPRDHiMbJaibEJM8UNSvK9hv7GbHxsiXWtRYTdWhdrgFnjoGHVgxuzZ4eEkxfdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com (2603:10b6:806:fb::14) by BL1PR11MB5221.namprd11.prod.outlook.com (2603:10b6:208:310::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Mon, 22 Jan 2024 23:25:06 +0000 X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::af34:7981:454b:39eb]) by SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::af34:7981:454b:39eb%4]) with mapi id 15.20.7202.034; Mon, 22 Jan 2024 23:25:06 +0000 From: "Michael D Kinney" To: Joey Vagedes , "devel@edk2.groups.io" CC: Liming Gao , Sean Brogan , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat Thread-Topic: [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat Thread-Index: AQHaTYm8hOmQViZJFUm70PazdkEDEbDmeUww Date: Mon, 22 Jan 2024 23:25:06 +0000 Message-ID: References: <20240122232108.134-1-joey.vagedes@gmail.com> <20240122232108.134-2-joey.vagedes@gmail.com> In-Reply-To: <20240122232108.134-2-joey.vagedes@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB4938:EE_|BL1PR11MB5221:EE_ x-ms-office365-filtering-correlation-id: 3f68d18a-3c14-41fd-4f41-08dc1ba15e1b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: jkco99IvUaPDGCzYxcx4TcJBuwGJuOPWervU3mGAHEZnBqQoSN+6ugfgPwjK77mLHzpjay/Fc2selQ0IntAUkW4NVMh3xIpAzVuxyKlYLgt7+plE6Ne1rUNxJ3k8UrNjDY4Cvlq3ofFR5Ce0bW06MlSewNGeP+te76LHwkcBqFBqyKgNdFnQTB2CPu8NzxH+O5p6xcZzj0gQsGcvcGIEWmLAAh2K5nySJHiO9Nc5hV6gc+LGE94nIO98H+2A3cm9G2xhTsWI5eC0XSls2aoeMDtM/3R+1TVZm00EP4E/3mVIjJs5mW8+rNjbCiichCoQm1+5qsC94rls2rsgn/azZXlO48Rv5ntW5NgQTLnhb/F562egTwWnNpKC5ysiDZiYI6D3ofJZQjUmCcEGWDF5zT7tyCsA6I9Pj/ogk3DczMTlHg2dCpzPRe/FQPO3OPOSraHKEzxsl/jfya43O3D/MKv1Xg9p0cyIXnPI6tuEQkAhznkj5JnER1uBBtSWRl6zlCqr8TahhYvH2YiSUd7eQ731ckfVI/trs8WDiXX4gZyjTBNZoKUhfvbMK2u2xLEANR+xVU8Crv5fNn3C0rGKMHhl5nVArMr9vKBXdJOV4qA0Ojw7O+CX1J2xBhuZZxLR x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qhZjtZOzLotJ4Hv0X86atsLkNiMwHCURk8XiWnTBE6tq/klNYj2urrNphvTq?= =?us-ascii?Q?YGDNbA60/RRsxSAejpg9Fm57NUq5zNgGiUm1giQmGPs1oEYxCdqP9Ru0l6Cr?= =?us-ascii?Q?NQYNx19BfjOrqROQozbx7QHwtMLLk4IYEWEkX4E0BXAWdhhg6nsjlprapnVc?= =?us-ascii?Q?07P9oDaDemj9bKhLNILz1ATrnI+vEKQg1gMvkfNVX99s22DITRU4ZXYw1YB4?= =?us-ascii?Q?KfsApvdIhEwDl2Oy1qcjFBmsLqZwB/dNTHi35y9g6fA3ucaIKvAkJzJyv+i6?= =?us-ascii?Q?3FtxygGG8kwAeXjfXgHISApn4KxWVFmd2uSqGJ/n0OX02revJJ2i4cXJht21?= =?us-ascii?Q?Og6GaL4XqPbAmjaYDAqgzF15ykSgxkCMEMKAjsWDn9rDdC0VFftXXG74+NSS?= =?us-ascii?Q?1XUgq03GQZt2KsYrtjkoLRhGlpjNEEqJ4yeAjUxm9gUWM0kePDak+iKsdfXH?= =?us-ascii?Q?Lc/S7Xoq/WduvGmaN6pRibFXxUP7UEPykPQOGcA+N2iEaehGeE33A0xBWbLY?= =?us-ascii?Q?ofVe6Vb8aqSXWJcafz2EZifFxxVIH4ZmEeOYvex91PNQM0D6D8ZwBheXiOf5?= =?us-ascii?Q?um/giNxvT2qiS+SxxahL8Q2Lrw7ghsfwcPcyO2GLWAjTjZtlQWnD2IhgXpBG?= =?us-ascii?Q?oeAmdLQPl9p9UBpsLh0YkqIG6EFRNZkRhwButJmpP6YYdGT3AHs+5WKkWH8S?= =?us-ascii?Q?UnQlfLtqJlEweIXi61munm4jQBRzYCmC2Js6k6o8ROs8luoiy8AoEw2V7LoF?= =?us-ascii?Q?oYMSfbFJdqHs9vCsCbPzI80E2Hy3amSLkGrmQETXdQfhqnXtg8Z/ZbdKmkKb?= =?us-ascii?Q?THguAAHv2YFOX3DwNjI/xsHWm0g5rDqWyzCybdIn8o/sX4gxSRiurRWCWCwv?= =?us-ascii?Q?rfCfhaqPLHAXdYviGoOJnJFuHbE1gQ/gA3LazrXt6G6F9O9pepTGCxgWEkDa?= =?us-ascii?Q?81qJ6PzZGEG64td9Prra+H8qJ5k8Q7mvccNbo2SNDlSnFzzZY0RbBu+gSO7k?= =?us-ascii?Q?xZsS2Wngok4F7sk1Ql7JwINpVfqVMrzx3FLDpfHLb+O2OdjnpRiKh9J+w/M0?= =?us-ascii?Q?Cpc1ex7XKbS88ID+ft5fi6dVtrr/KDEPUbhp76FTXRK7rn7eSENhnXUmeBWd?= =?us-ascii?Q?Ldg+6L0pE0kSkjjlzKZ7cWc74sQRfT9w/qiLtFN8aV7C0NFbXsKCDxqdHEUG?= =?us-ascii?Q?N6ELVQqt9a4axE6Y9mqII0BlWC2XdnlB3u+gC4LqkiSzKIxO3G595EYKFWBM?= =?us-ascii?Q?BHS8VevUsNnGOSAgQE93gEqAo2Z4PG8MdM1H4XIY4yXgQ3DP6qqRHq9CqbUy?= =?us-ascii?Q?0YwOHtk/eya3k4uMKY85UIh5jmGxaMSJlYWS7teJHdubuSe/crMb9AX3Vwi6?= =?us-ascii?Q?Abrtpfn1CbgNmGGN7HS+yvKWe9JZOZg6QjpN3Vt5Fcfhu6qbLyFgSV61erLF?= =?us-ascii?Q?RQMKpW0Qh33X/06k73qfFyO/dNjHA18JiGWVjFo0yynGy+9UJFVfJjspuGsI?= =?us-ascii?Q?L0JM+sWzHex2eyD9UVfuKkFQTWt7gIaZIGxXVNb8v4Ed4Gmxm8kbO2Ek6P69?= =?us-ascii?Q?HflN5uxIO7HA0XJTispb7sP5sfYhOOGy4oRSQaLJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4938.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f68d18a-3c14-41fd-4f41-08dc1ba15e1b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2024 23:25:06.1976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ByibAawe0lRzOHJgDMP7dokMBveiRZnUEAN5JO/ic8n4Pc7rYmEx3LtCH7Jx/aL8YXEhq9RmDH6M7ZSYvwPstQuL0W56o0tq4nuwi4iGN2c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5221 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: huyalr8ZeezCNRsJNSKtvfvqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=juBoPvHB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: Joey Vagedes > Sent: Monday, January 22, 2024 3:21 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Kinney, Michael D > ; Sean Brogan > Subject: [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat > instead of os.stat >=20 > The UncrustifyCheck plugin passes os.stat.S_IWRITE to os.chmod, when > attempting to change file permissions. os.stat.S_IWRITE does not exist > as os.stat is a function. The correct value is stat.S_IWRITE. >=20 > Signed-off-by: Joey Vagedes > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Sean Brogan > --- > .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > index 9aeef5a5a3..73dc03c0dc 100644 > --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > @@ -12,6 +12,7 @@ import logging > import os >=20 > import pathlib >=20 > import shutil >=20 > +import stat >=20 > import timeit >=20 > from edk2toolext.environment import version_aggregator >=20 > from edk2toolext.environment.plugin_manager import PluginManager >=20 > @@ -628,7 +629,7 @@ class UncrustifyCheck(ICiBuildPlugin): > """ >=20 > Private function to attempt to change permissions on > file/folder being deleted. >=20 > """ >=20 > - os.chmod(path, os.stat.S_IWRITE) >=20 > + os.chmod(path, stat.S_IWRITE) >=20 > func(path) >=20 >=20 >=20 > for _ in range(3): # retry up to 3 times >=20 > -- > 2.40.1.vfs.0.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114154): https://edk2.groups.io/g/devel/message/114154 Mute This Topic: https://groups.io/mt/103898982/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-