Re: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Wednesday, April 26, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Kubacki <mikuback@linux.microsoft.com>
> Subject: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> If code coverage exist failure, CI/CD need to catch it
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  .../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py    | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git
> a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> index a384b55629..d993de9412 100644
> --- a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> +++
> b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> @@ -130,9 +130,13 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin):
> 
> 
>              if thebuilder.env.GetValue("CODE_COVERAGE") != "FALSE":
> 
>                  if thebuilder.env.GetValue("TOOL_CHAIN_TAG") == "GCC5":
> 
> -                    self.gen_code_coverage_gcc(thebuilder)
> 
> +                    ret = self.gen_code_coverage_gcc(thebuilder)
> 
> +                    if ret != 0:
> 
> +                        failure_count += 1
> 
>                  elif thebuilder.env.GetValue("TOOL_CHAIN_TAG").startswith ("VS"):
> 
> -                    self.gen_code_coverage_msvc(thebuilder)
> 
> +                    ret = self.gen_code_coverage_msvc(thebuilder)
> 
> +                    if ret != 0:
> 
> +                        failure_count += 1
> 
>                  else:
> 
>                      logging.info("Skipping code coverage. Currently, support GCC and
> MSVC compiler.")
> 
> 
> 
> --
> 2.39.2.windows.1