From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9696.1682556652452921788 for ; Wed, 26 Apr 2023 17:50:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=A+m+lr4I; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682556652; x=1714092652; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LTjt1mTVnElVkb7sHA7vsGFmz5L1aUAhNTMawtICNcA=; b=A+m+lr4I8vexvWexuCai7H7EnaQ7cZPd8fBNLLPTbErw6umFJS9bQvEX gBfZ7tXrulHNiN8/o9SWTc1zwV/f3Mi1T/IBH7liRXpVYVaGBpM8odZyC Vl65VnHwrr8zM3JmLQLepPDaVNuT7b7FnJmMLNe8mwLZmn6sm7spStR/q kXfzsCroHOlo9ZyEyQN7NLd6SiTJpQP9qKdQ7Sq3FLBIU1vxnNMp8PERB tegNGY1Nw1IhH2LwpEoCYm/hXkS7K5MnBskq703jGODhqaEBcb/S6llTC qO+l4UNV0Y9las41unm0kj4B6Zy25W2qiftNyOLsyWVO1P9nE2dsA00I7 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="327601668" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="327601668" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 17:50:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="644462611" X-IronPort-AV: E=Sophos;i="5.99,229,1677571200"; d="scan'208";a="644462611" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 26 Apr 2023 17:50:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 17:50:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 17:50:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 26 Apr 2023 17:50:43 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 26 Apr 2023 17:50:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8GCFXI1GAK5Ikvkz+PozOr2ik38WesYDNVg2hJ6xEqtXzrVS7PfywLkGF9Mb3gSq7I11L/aIQfs1d2v+6yzH37Ygla9ipw/qzWYQi7nZg04UYeMy4qaET7JXlrPDaOdtdHDFzpIKiQTm9elyR4LEoWbAU4ArrhNTAvIzfGBSyhCoOoXd32tLxMMzIlfGoc0Gkej8Q89cwzxOljtU7uVtsY4DnB7CHoGFgTM2RXixMGCttnq69MPIi6UMWmNXUuilfCycFKjhMevq5RIwwoG0AjiXnGyuSL0o3CtvUoQHwkzBPc/q6V9RSVp1qV8Dr+D/spcj6uFxq0WrZmdXPhmMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtfcgSr11PpnTfM1qDvqJnqWc7VuV/vaM0KcoNRgnwc=; b=Tp7+0jh9lA9ODGwB/+WpP4wXIG5wCIEHZ4khYZZrjam3V0qqp49LG/U+5DnMv17s6eMSMiTGPHHPXiRV5SxSwirKSuprh1mTYWK6JvY+Iw/igoOLWIE/dw1nRWFCaJ4/4HTtiiYfuwFzQb+xR6MqMPSa2yFR35UCA4u3zZSDaFgP2dtw6GrEBRaIkJRbyZAdr+AYqnEz3NEfUIPENGK0mMQcn9fxqSiISQ0dCtekx7ip8cqFbQyKILm3est8ZdoIIkGqasKyDqXa3qvPkbFVRZ1h8mDZZgNYN2I6d3Go4h3Xx0we80uOW5RJCdvy329/VcB3wm9uShlyIX7+f03KgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB4938.namprd11.prod.outlook.com (2603:10b6:806:fb::14) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.34; Thu, 27 Apr 2023 00:50:40 +0000 Received: from SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::9ad:892d:ae85:59bc]) by SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::9ad:892d:ae85:59bc%5]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 00:50:40 +0000 From: "Michael D Kinney" To: "Guo, Gua" , "devel@edk2.groups.io" CC: Sean Brogan , Michael Kubacki , "Kinney, Michael D" Subject: Re: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Thread-Topic: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Thread-Index: AQHZeKALwp2RqZGjRUeO+HSYbxrGR68+Uxyg Date: Thu, 27 Apr 2023 00:50:40 +0000 Message-ID: References: <20230427003416.315-1-gua.guo@intel.com> In-Reply-To: <20230427003416.315-1-gua.guo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB4938:EE_|PH0PR11MB5176:EE_ x-ms-office365-filtering-correlation-id: a0ed9f38-4e3d-4ef6-d457-08db46b96c3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z9qM05d9gyWxAt47NTj8Sm+55NANPfxfkTZSj6xEhujLIqWDJZscm0V5cSfqqxJTt7Ri0jLKPrS26JI6hrifEDBH/2IPDrSwPUt27f92ZSAtJY70TwoZd0Goxi7fRbLLUqco7JumltxZVNSKIQQ3cbThZ2r69ufaruZw+ej2hSjx5xqBfwJfgXpen4nG/unm8MMm2izmjjPe77gAUtpRnskRcMD7v8egOzNaAlSwGU/tcJ73/o8zRtnjgMb6EgWUGu5bcZH16BXkpKarsKCZDf1iz6crao6HX5yBoiGIXQfXPAq3gPF+0tx5RZ/AlzlzBbf1eySIE+oYAsqnvorg1jHIthAHIHeredDZmvDcVKcftps+yEsOJidcesEBcu846Q/OJhDcT5dIrK2oOojwAVKesbQAIDCXySFTrAUN/zh45Gq/tshcqqIis3C3Bmtkb00+cSyia38wi7Q9jBrWhvLJPeXFkE4/qsbZ6CatQ4u3KD2yFP6rB8eGGRbdrSeVKM+3dqIwDu/76YmEx3uxAugpwoNmSPds5zMkaJZY5AtOeIwrzm88kG2BYHzNloM/kxUKQNMcceEnQumsO9+KrmTIU2YTj3oCLTEM8y9afYdjmjelp3X240lu0bgD5cJq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR11MB4938.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199021)(6506007)(186003)(26005)(9686003)(55016003)(316002)(53546011)(8936002)(41300700001)(83380400001)(110136005)(66476007)(76116006)(66556008)(66946007)(7696005)(4326008)(2906002)(54906003)(64756008)(107886003)(38100700002)(71200400001)(82960400001)(122000001)(478600001)(66446008)(33656002)(8676002)(86362001)(38070700005)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?go9hAGH55bkQEXTKMdh0eNTqticgP5pZ88d0S/3Un+UUf4jhIq/mqWlyXlZC?= =?us-ascii?Q?orh0Rh078KU/tcN6B0OOtm39x54HEaWv81hPuaMMK9r9mTQpUxGP4hkJUITs?= =?us-ascii?Q?vYbSl8n7ZcOaBJbHDsSOnOk9ULImLKOe1oUd4JocG0vO58iPXbz7C0TigfNM?= =?us-ascii?Q?i6hnwrC3oV4TwNrUeJ7BEA+WiCCkyYWcg6qlBU2/7cJrrUWElacsNEz2B29i?= =?us-ascii?Q?4YgwbIPAz3nuz4WepWqqcgVYWlmI1gu1JwsZlB0FrLOhtEdqcik+OFtBH4Tr?= =?us-ascii?Q?OBM+KsbgPLEBJxRnw72VLVbs/wzdpbxF5E5nSzFv+5tUorlkira01FI5lK2y?= =?us-ascii?Q?pE8D+W9HCqtoq0Agu1kIrZ1U6cNR+OG5Z8JPAqqssCSnJ5rjmaHaVXhsn97E?= =?us-ascii?Q?Tyi+GWcoYYJmTTPr5utzhhiL86hPLprJ9lXa9DkuOsVRiv8Fh5pUt/yDCvXA?= =?us-ascii?Q?clyahkq/M2eg/jMLt5Nq3RKr1snX0dw5VcaPQrcaQFTIcw04ePrJxkJiKYT+?= =?us-ascii?Q?TAWolBJ01ONDcPZzlUUquIYzTrCSqGjXSWGTJ9tqEo+qW9AGAigCdJQi8eFU?= =?us-ascii?Q?UM6Y2CcEHtdS6ImEP1lwpU6Edf/8bdZ5AUcYoaZe98TvGVXPf7eVCGBBIjb/?= =?us-ascii?Q?ERodrzNCm81VLI/3NxHuJPDgKkj6lL7vc5b9O5UIHDcdPfmEIGn14fZmpjGH?= =?us-ascii?Q?owP8N6n2M3WTqcqifsAZJmcgToSsWgWpdy6e8vATb2+XvocgmtrGcL4TPl/f?= =?us-ascii?Q?/a6NvYmdKAQQJz+0pEULuI0TytPopk88ZLecYEehwNtwFAFs4vRRw67RIweW?= =?us-ascii?Q?+Trq0JOukIG9kMmXQOJ3aXwwVlFF9xgmHpLTVQEpTZuthKFwHthBO1SItJoS?= =?us-ascii?Q?CGx2ybGj9w4hQ1iEyJ3aSq3lKYKP2AyY5bNkANoHuOazf4YDT4Y4z63AycbU?= =?us-ascii?Q?+aTCqe3otPPskljiaM/1Kpao0rs9sx29ScSZWpeEfh8lonQ+f6F4EIdpTZt6?= =?us-ascii?Q?q1fYOAz6KgDrZzw/ouBPA/AsaJmjCXD+0SZJnmR+PRkTq3EMLwW78gQpFfQS?= =?us-ascii?Q?HKWsaajsG/zJYF+i/ewaw0zSUlsdZyhVXo97hbQRjU1sIPtyK6UHPKBeNuee?= =?us-ascii?Q?4qoT1dxcfRL2tIuzUC+StYp5nkLrQnHFdqrqZTtTZxqqt5j5o7op4ye6n3VF?= =?us-ascii?Q?LCJWDSoYaqNR3PYb4OcMqwx5euNEVfgzzFpLkGvbjq1EiqfL9M88M3i2RS+M?= =?us-ascii?Q?r43csJ0y5Wo2qd7Dg6ze4H2TxDl1WEZpkq9uW7engT/sD22j0DbUGFg+D/5R?= =?us-ascii?Q?abEuBi3astpEADc9jPls1f9HEG45vnu1HMSD4kIlYQQEsk3EqyR5eR7AqzB9?= =?us-ascii?Q?fXw0Syp8D++Yj8fqnStOdW0vB1VNZqvoC1dldur4vCLaA4fkTd44jc0mlMqI?= =?us-ascii?Q?EylfOsjr9UjbpxMZGPx1AkCSuSEC+ZQzmmd4jt+bhqPQiisMcAbQ+ZsbC4W2?= =?us-ascii?Q?5TKSotw0PbIDxHaCg5JFUSwAcTgJ3CPXDkO4p+7AHJIC287gkYoFuRwXJQU6?= =?us-ascii?Q?XcoDgw6pbM4MKoSXzWcTdvMFDdJrCOgC6P34FhxrnnmF81roaHLDpSjEjbTP?= =?us-ascii?Q?5w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4938.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0ed9f38-4e3d-4ef6-d457-08db46b96c3b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 00:50:40.1387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uXVwnsg/VmiXTo1Hu1AM+gt3z+wuqS/ZCC/W2kRUWBufmzkiEFQf3IE8TwogNuadKehPbT2fIYCzyTSw6qEQ9VN1EQudq0U2BpcN37UOOlw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 Return-Path: michael.d.kinney@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney > -----Original Message----- > From: Guo, Gua > Sent: Wednesday, April 26, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki > Subject: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage f= ailure >=20 > From: Gua Guo >=20 > If code coverage exist failure, CI/CD need to catch it >=20 > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Michael Kubacki > Signed-off-by: Gua Guo > --- > .../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git > a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > index a384b55629..d993de9412 100644 > --- a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > +++ > b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > @@ -130,9 +130,13 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin): >=20 >=20 > if thebuilder.env.GetValue("CODE_COVERAGE") !=3D "FALSE": >=20 > if thebuilder.env.GetValue("TOOL_CHAIN_TAG") =3D=3D "GCC= 5": >=20 > - self.gen_code_coverage_gcc(thebuilder) >=20 > + ret =3D self.gen_code_coverage_gcc(thebuilder) >=20 > + if ret !=3D 0: >=20 > + failure_count +=3D 1 >=20 > elif thebuilder.env.GetValue("TOOL_CHAIN_TAG").startswit= h ("VS"): >=20 > - self.gen_code_coverage_msvc(thebuilder) >=20 > + ret =3D self.gen_code_coverage_msvc(thebuilder) >=20 > + if ret !=3D 0: >=20 > + failure_count +=3D 1 >=20 > else: >=20 > logging.info("Skipping code coverage. Currently, sup= port GCC and > MSVC compiler.") >=20 >=20 >=20 > -- > 2.39.2.windows.1