From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 072D9AC18AC for ; Tue, 22 Aug 2023 17:46:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GHnYLmo6ZzUeIsSjFdCUn4i5SfahFxfxUm0YCS4hkWM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692726377; v=1; b=fGknzoy9uXXvmI85Qe1U3ObeoAnahMgCKDTAwd50rz+wKCH3HsRBOaoerihYVFP7gAdXGwX1 Q6BUIW5JkiZj0nVKstaPM9gN3vRbMleoa/TAo9fZzZ5Xl1C+ZBINJDdeGXYfSwVUJzCzjYo4BOa LyM3OwsfwVoJeVFhYZOlpa1o= X-Received: by 127.0.0.2 with SMTP id pYLyYY7687511x2ilBsty64k; Tue, 22 Aug 2023 10:46:17 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.2750.1692726376880757015 for ; Tue, 22 Aug 2023 10:46:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="437885227" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="437885227" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 10:46:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="686137495" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="686137495" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 22 Aug 2023 10:46:16 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 22 Aug 2023 10:46:15 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 22 Aug 2023 10:46:15 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 22 Aug 2023 10:46:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lupsjCThgfTCXIu+IKuut1jZelIrGq/AQoQOABrMp2w0D1wo8UGoBEznkjxcJEgOaCIOLdqwO82pgZfVXhuqzLha6R921a2ZZWTLcwUgVQaJstb7y6NeF9/oNelkExZS3K6Jii1bpv/j7L6kiO1wsQzf+2Kl0QsdYmzoR3l1trGWU/Tdra2C9fPepWRiiiRa80v7SSO4EpN+RoJkUdAzFc+V1ptn1T+QWizv+nvcdjQ0oHR0LZOrpJh7CClGX+G+e780JgOTXRmMMWraIaPvgxtWrba01xzRVGYoyM0G2JTB8d7ArxEgBr0vBcLWTQcDCHDKc8ddxmWSCxas3cf5DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpHVc+9yK/e1o60ypFzRS1lgDeoVm2AjnU2/6AQQDUM=; b=cUg64fApX8d7hhdWiyj+JaBNcu6nzK/yrX59Yy0uI0tZdiKj91UzlsSLIo70zEOP0SQEmbDADL3K/sK6+a+NFe8XK2KtWBsCvvBYeuGh3tktCRXQ8IXN/2sauV5hG765EmlagEam5wrM2N88SoscnIw+/Aa01bW1BbTz1Zh/N0W1wdBHIV5IEk+o+CXRr5o3HMqyDRf14C2NeBiOqrKdmRr1zV4iSFtDm+YsDtaZKNYPLI8T5KuUXdg0EvmL4tzEdfqwkG72t05gEE+mze3uCsZ1Z3dEgrJU7BrGg5eNAeEV78gTgUwo+anKXs998tjSQWQ8o6J1ZYuFMi4iN5nLHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com (2603:10b6:806:fb::14) by SJ0PR11MB4815.namprd11.prod.outlook.com (2603:10b6:a03:2dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Tue, 22 Aug 2023 17:46:02 +0000 X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::155e:93a6:3634:6e79]) by SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::155e:93a6:3634:6e79%2]) with mapi id 15.20.6699.022; Tue, 22 Aug 2023 17:46:02 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kloper, Dimitry" , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in rename() Thread-Topic: [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in rename() Thread-Index: AQHZ1Kfby87y3Q9+LECim/W9q6tscq/2l5Dg Date: Tue, 22 Aug 2023 17:46:02 +0000 Message-ID: References: <20230822032154.2009-1-n.jayaprakash@intel.com> <20230822032154.2009-2-n.jayaprakash@intel.com> In-Reply-To: <20230822032154.2009-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB4938:EE_|SJ0PR11MB4815:EE_ x-ms-office365-filtering-correlation-id: 0d559544-5c0b-4809-a338-08dba337a713 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Ck1jtNHazbjBZBS3tZkq9dN5Nfsk2W0uF43bGcPGdes0HQJR22CD2cRMpynz118dF+ZHNRfBsK8xGDcTmC4mKZrOWGAMRg8w/QmktQk2hu+lGdNgKnEzX2eZyspXthwbgIqC6dRpxTOJ4E3DBCHWXauTSCCfukeoPG7tV3w4VFvVOD3Cv3a929FGNSd9YZLOazMzJ8aBnkgk2s/YqaE2eZuA9eXBAU8AEznnLO/4qfRq82dGu4FWu43cHnYrIhDRTho4JtH63vS4LOB6lTSE8Ojaj4UOwjNFaLbvkfczaoke7TeRh9wQhubRY9caURz+ZrDoEp2GXaSAv3D02Swip64QR0Ah3fbNEo+9fH2nePSwFTJ7ANHkj4lySYuU0qKVG/vmm12SM0EN1m3U/WcW9vHWSTk3riXnZBBjItHN3tJ+g7onMnVTiqlx3pkajNoS8GoJ87lnr4B9XF12OGYq+pm8AJiigUrjaMxGL9d/GhBmSGGIk1z/TH1TGe4NXdeTXksMXuIkGwjyQT2dCY5hWfy1qwUoDNk6kpr5ubhSfe8eOVgLDVUpInhS1hy7msO7Xt4KtM/dGJThpTJxa0hNUuNysrhGRXW1St3Bb6VF2EQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UsvMdf5n/3DCFhu1L+xEYDgzb4p0A5hRYnrql9zGAY4GZmawGSj0NHRvoD0U?= =?us-ascii?Q?Qf7ai04Q2qHES6KO7INd4gz/Gq01csL2mNPRiYA7n4PQWpYXQoRzJ9vpQeHU?= =?us-ascii?Q?FTJ6teJUQZpbHAspZkbb0aHv8CetcsmVfLsjs6VK3A0EEmYOm5QKuRewEP+f?= =?us-ascii?Q?fKWdqU9OJTRxz38Tfjurqg8sER+nlmpJ11z8DNLwSYL63MW2td4ump8nIlSg?= =?us-ascii?Q?jreWpe5ENkbZCtG/LpdlR6sLPkNg8ZEDEfE/nSVVRoOjiQSNQQrNsfMEbkUz?= =?us-ascii?Q?oucXA1ntD6/R2+Qnm5aDHGOnBZeAJhEnPjsNydh0JFF/9kqikcmYy8AneEzg?= =?us-ascii?Q?ByZXYo2OiVFPSj5mBYH3x4b6nWyOh69B5SoA9jlWXToNHqzPkj7Iawbmg8Dr?= =?us-ascii?Q?DiHwaYew53rXQ9/MGZo5wartTdUEL21yiQK0+ZLAU5vwK+SD9sXL4MGqVxdP?= =?us-ascii?Q?+3kGtv7us2S2583r4ONDe/HjosOolOsGcRYUKuE9iN27H47brOaxsYxlsEHl?= =?us-ascii?Q?uYphNZd+f2XWwWVYhAid9xRuQQ0TAWHRsx1/Sqx7K10lbe+Wbhz/2ZR+EjUY?= =?us-ascii?Q?mJ8VIQEpF6LyH3WGp4pj5xz/FtZwsyxrt7zbV62r2Egi2DAOT0D79csE7C5D?= =?us-ascii?Q?D6AyZpPZMcHwhiyyA0Ae6JjsNxh4Z95+k8zKnOkJmWr/x2h0vmenfY8omQ0H?= =?us-ascii?Q?i5TwiNfm1yrJzDxUe0Hpfg6v4rt/OI0wy//EZykFe2vGlDloCEJF9lPbyqDH?= =?us-ascii?Q?72Qu1J1+j+K9T45C7g6dnQGL4aEmPV/wm6kb0fq2o+olH963AklVqwI3lwH5?= =?us-ascii?Q?/vymoq99ss9jpJhngmD8BtLuYoOThokyB4lz7kPxibGhHFvk5A1kxVUDPg6c?= =?us-ascii?Q?tDYT92hViLzBDjmSAYTQOfG03g+kQrGDGXiLqoKbwJVeEnEAmyKcqr0iarKX?= =?us-ascii?Q?oxX7JdJmOzIhENDJ5a5cw0kuknyCLp/SxgHBOexg98KLjjSWID0P4npfxzoO?= =?us-ascii?Q?3gz/VfTeVjGPOFXMrPIYjgcupsqyolLk71lJhBlgTrSS8prv7KZYU1IjBZro?= =?us-ascii?Q?xa5PEPdp2D5SdQQtya2X9g18rdZCSv7pLUezQ81gazMEpFrLV47dVu3qyw6K?= =?us-ascii?Q?PmCZrc77cmIs85lKk4OBB/hV04EkOlvxfPku4wstzDLvMLcZJBf1dCPVmZpo?= =?us-ascii?Q?Z6TVY+5G9Dz0rXZmFtY5K9cR57WCw7VtrXPjLsvR6ToWMBAXHFTS3WfBqqXG?= =?us-ascii?Q?gcT/+hRcTWxnINMegWX6ftS9iDF6QDNwCt+hCYVfLYQNLwKbf2ug54VPVBZ2?= =?us-ascii?Q?rUjq5/cRvb5zI+8B+a0PMKr4JI4TNgZssNVSrGIUtGUbMLNpECAl4eH0FZF+?= =?us-ascii?Q?cIkSpEWW0LPn7ArDLrX9PiMuyCIJf/t1rSJNWx+bSVhXa4nvmKEHuO16Kxbv?= =?us-ascii?Q?i9cFw61XbW6fKhzo0/PSbxw1vFv6m+aSFy7lXmdhuSKIrVrk3lO7j2Hwc3oJ?= =?us-ascii?Q?TEnQNAYdTYCJLy3ye+OED0Gt+UZhP060mTxhnlZhvHSsGNO9/RA9eXz7Ir+/?= =?us-ascii?Q?IforTosHFHbmzJugXRaBY2f8awoJfJYguoiMIMPJgr3eTTrobeWDVipVeGwB?= =?us-ascii?Q?dQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4938.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d559544-5c0b-4809-a338-08dba337a713 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2023 17:46:02.4323 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o2Knrb/QzxjdZtpNBUa0qBlqyCcxDhp8tUi3zRJY28p97zM6GJWwc5L2s15z26QC+FM2WPGgX3sv2zP2Gpu4JEk34svZyAt0NzMHaldbe4A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4815 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3991UcD7TgVK0n8EbElmGFIVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fGknzoy9; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: Jayaprakash, N > Sent: Monday, August 21, 2023 8:22 PM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D ; > Kloper, Dimitry > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in > rename() >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4529 >=20 > rename() call leads to a function that makes open() for source file > to be renamed. The resulting file descriptor is never closed. > If you have to rename a couple of files this will quickly exhaust > the descriptor table. > The fix is trivial - just close the fd before returning from the > function. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Kloper Dimitry > --- > StdLib/LibC/Uefi/Devices/UefiShell/daShell.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/StdLib/LibC/Uefi/Devices/UefiShell/daShell.c > b/StdLib/LibC/Uefi/Devices/UefiShell/daShell.c > index 861765e..06fcc3b 100644 > --- a/StdLib/LibC/Uefi/Devices/UefiShell/daShell.c > +++ b/StdLib/LibC/Uefi/Devices/UefiShell/daShell.c > @@ -670,6 +670,7 @@ da_ShellRename( > free(NewFileInfo); > if(Status =3D=3D EFI_SUCCESS) { > // File has been successfully renamed. We are DONE! > + close(OldFd); > return 0; > } > errno =3D EFI2errno( Status ); > @@ -688,6 +689,7 @@ da_ShellRename( > else { > errno =3D ENOMEM; > } > + close(OldFd); > } > return -1; > } > -- > 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107955): https://edk2.groups.io/g/devel/message/107955 Mute This Topic: https://groups.io/mt/100888179/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-