From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 040DBAC0BDA for ; Tue, 31 Oct 2023 03:37:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=p0ERbuTW+LGiiZuzPTsFXX8J7cb3wDGZNCk+lSnJvEE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698723467; v=1; b=ffaflpniZgnzGj/vHztJzX5Z2yo4xrzhMR1rhZSyFZbOe5m0mSQ1FxpLZvrTtbg4zWbvJ7cS YWNR+6I8jrgsfKUrPgvEyvLWvWO2OVMVXWJIHDCRshNbhf0KQOsCQCtaAt1eCbohqYBMSHR6tOW d56v+YzUx07161FYK62yuNiI= X-Received: by 127.0.0.2 with SMTP id xUVzYY7687511xQ92YupwNUf; Mon, 30 Oct 2023 20:37:47 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web11.179399.1698723466891720667 for ; Mon, 30 Oct 2023 20:37:47 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="9737300" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="9737300" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 20:37:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="851121329" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="851121329" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Oct 2023 20:37:46 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 30 Oct 2023 20:37:46 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 30 Oct 2023 20:37:46 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 30 Oct 2023 20:37:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDymeWBHVOo4DcHK/TYLiR66e5RWTK74tY08sCTBOlCCIIg/KrX/OdT+VRRKWeXWFnzeG5ebP2zSe3Vx5N4AYzI0yd8AqtKM2YDkXjlX3bRzCGGLlHYxsVdW0uMZXix3mWa5UNgthtvh61ddiBXdeUmFpGYee39IfRQmO3z1uQFYliN9/H6y3DVIxYpddjW6tQA35If98/4dSxQWE3CXb9VDPOSOOVLMlEYW8xyLlo0TeUKg0TBF/bY2PVITunmbaV3gMrjkOs1K3t+OefI35rzfIgIKRv7bx0IXPUnmfjy6HDDyQbgog8LGVwZ8b6zDIIaLe4y+BOjuJObUDlJd5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vxmFTwixbjjivPjYAALuKUn+xKWfLMV3NEPP/fF8RFY=; b=EAfPqL1/IRc/O3M8jpRjG5S4V2kD214gZFLBtOrOA6TdgIrjzA7n/bVKQAm1LryVKHvMvAae0h1mf/5ZeXaEfUSRTOvcZNedw8QPDOgqOS+teCK3vu9BNe5LQ6CYwGGvMrkessvdJJ4t3+BTNu0GLs/s4uRMF9ByXBiIb+pWyexVYP3Hu0zjK/9WbybIgswzU/nt40Z38dsrg4kj0YKPGd10RNF0P6zQP2OFmTyPO7n3W/gMdrizH0T2Sh8Rhbxmtq7fIZhcBxR7dqjzhcpyBEXKClfh5xOc4Uhce+VsxPzhpQMiL9D9BHbk15VjVAOekXludlgr7mpFwlXD7wpHjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com (2603:10b6:806:fb::14) by PH7PR11MB7122.namprd11.prod.outlook.com (2603:10b6:510:20d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.24; Tue, 31 Oct 2023 03:37:43 +0000 X-Received: from SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::9347:a2e9:54ac:45]) by SA2PR11MB4938.namprd11.prod.outlook.com ([fe80::9347:a2e9:54ac:45%7]) with mapi id 15.20.6933.028; Tue, 31 Oct 2023 03:37:43 +0000 From: "Michael D Kinney" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Sean Brogan , Laszlo Ersek , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check Thread-Topic: [PATCH v1 1/1] .github/workflows: Add Stale Check Thread-Index: AQHaC5tp27PaQRlRSk66nc3nzsDYJLBjP+IQ Date: Tue, 31 Oct 2023 03:37:43 +0000 Message-ID: References: <20231031014120.917-1-mikuback@linux.microsoft.com> In-Reply-To: <20231031014120.917-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB4938:EE_|PH7PR11MB7122:EE_ x-ms-office365-filtering-correlation-id: 54e8c96f-a019-457f-63a3-08dbd9c2bdfa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: zspvL5VIFBT4LvRKWABrVtqfEPEBXO886nGQNSRcWP26XmdqNZEnMbqw3zUHzbZtyZBFF9aOQK2ZgdwB4BE/AXhwrz9nxwqNjwkPmP2S/6ZHNoJ2hwRlp3yNA2FyUaTdWBNZQ5UNDv+P/sccyCOrlJEGS2uMUwJSabZ42Jmhjd8aK+n1NV7NqKLUvXEM7l72IoljIp+tcsZ27aeZOKJK0Ucj3Y+j3nevSYkwc8lpy6Tr6axEPdKVZM1tLfdJzg/5s0RpnXln9Hbj65WsOJckLHVr4sD69YIz6kMcauCgL1RX3Y5AyBkQ93d1uWd5Yuo//HrQ8Qn0wdMJ1m9VMUWcea6fY9gpdBg74exNjeEdShhnb15MdzjCqQPElhwmd6maEfsrSw71oTr48Mk4huhBQn8xOj23hbW4gLy3yfMTl5+YKhzlHOM2acMY+SKqtKrC9Isr1AcNdOkI3g8S0UiSRpBmFcrIPkUpj/18Qr9c5D2Rbx5csyFG8Pp6WLb6kHo1vZWHLRtnnAgvp273cE9iyOaqDX1b4Yj9WHMKmmg5nicQXDZXXkL3V596ToyfmE6AJncgXIEY90pBRpWHp3TvN30BtivX7EKb7V9qrmzQjjPEZhH8Hho9K9qkS31DxxDEzLzBnYKb6fXq6vZCbDzkww== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ryk+REr4VxjarMFI2ph+px+E7/D1j5hdlDhWwV1nm2YpmKsosseUmJMFUnfY?= =?us-ascii?Q?5TsU/6f5D48R4PbftLKejfuGVy4+K9e8CBdZ/7+T/c0UKCp4VrgJQQl+ECvJ?= =?us-ascii?Q?w8wCaTlWd3kofgR9RP8Us3hI4yFHHh3dFJYTDZogbx4A2nyupsnyQUP/8F3P?= =?us-ascii?Q?2cH4l6EO1l1QPsoH7x7tRccZckkmfMPZ/8/b9N2T367LvrlQ7LfLe/B0ijLw?= =?us-ascii?Q?AsFcuuLfVHC6T4YGxDBFJNwFFNRTVfnA6f7OenyC8eRos6DV7HPjWC1oo2Xa?= =?us-ascii?Q?glVKPyrXtTAXKpiVbMYODPy20AmBcfM6onfx/fJ3AMGnFvM08Y3QuH3KODmx?= =?us-ascii?Q?NPORpLmKs2nx1ks5oNMy6C3d/MdaU5XsjCFwX2TekLPP2lRNtLBE4Gyam0W5?= =?us-ascii?Q?NpXUNcHAWvUcovIWwacUqkav3OSesC5feuer7JHM6eWCmnrRLvyg8Gj/0u+z?= =?us-ascii?Q?qw4wlcnPXId6jBM00vdzEMiUYxOc9ELr5BHsmSjJNe3Rn39IoSWMSMRP1kA9?= =?us-ascii?Q?h7o54VpHyZ78/gWbyo8x/JLUde7/4Sl44kuLbtA7zYHs5WDeZuZPiTrs5h6C?= =?us-ascii?Q?cEpgpyXKxnFzftCXA6a7Rkk72hwaCeUsFnTXSMaN6mFw8HoBSdcBUeH3rTM3?= =?us-ascii?Q?jQu26PMUhy0LPXdMxuE1ybZXQoXRYCgqSzyot/v0vfXSP0iOqgg2FTvd8PGv?= =?us-ascii?Q?u2ZD++KeB9OyAioX8fIFFIL/wWkS9V0Slq59iMJX9mh5jursSYkd9MV8esWv?= =?us-ascii?Q?0hIX9m6qMBYLMzskQEc41h6kDW9CMiijLaZzXvdtc+6Zlx9qWOW1RE/2SDtN?= =?us-ascii?Q?w308qxAr/zkDbxKhCa0IZ8fDU52egdoyP3gWqOrOb/i3eCPGYQcWEnlw4RcB?= =?us-ascii?Q?Sa+CwB+tFGK4kwQIPrUkeUMQ/7xEg/vAFTMN6LTsHXjV4ntD3iAxnud7h0jR?= =?us-ascii?Q?iObpwAtY8m3Oeou6i+hhRz6FfxRvkkN8/I4ba/tzWS6gOywN/ny6z8dhwFp/?= =?us-ascii?Q?lH+N+6/ZUaN/+MP6eSb+Kw9h5btwGUeASZ/C+Fumj0bMZBMvsqjZaoibb4lD?= =?us-ascii?Q?mRnu58ZErDZb5mUL7SPyiKA1QcwuVdNxWKVVvPCc/nDg9B/sk8VCK4I7jrIC?= =?us-ascii?Q?hvEynWHnz5A+tb7/BsdI3Wi6AsqwB3NeMB96dZiSCacfJ0iAhn8kPPHjuxn8?= =?us-ascii?Q?Wg+v2P9mdPD72f25pm3gDu7aOq+wcTP/0sBbc+/SRTs/0+vVCQ04ugV64MZW?= =?us-ascii?Q?y9ApRTT74xU2sExL5plGqEygdQBRiJZ+d0h2tyDolbkDnygfRiBn7Gyp7L7J?= =?us-ascii?Q?yBUQCET2cgkXXpD/usGPJGH+p4Fjsidu9BV7I8tMjknOM1efFdGw/9zye0jd?= =?us-ascii?Q?GyZb85poxG1lUDZwAXFYxWaIUmwHPujG6gGjl+KnDufmLwxtB4ugkcnBsO1j?= =?us-ascii?Q?e2FOm27l696q5ltvCAu7CIVwU3rcw9kEuVVJvRFplYHjneuJiQ29yPt2u4Il?= =?us-ascii?Q?dRBZIXtVBipohrGQqwa8PnFSgPTmgKdflR3e0kZ4Z/cvDsLcNnyLEIZ6bseq?= =?us-ascii?Q?wfOG5pfnQakrSDwHii+VgsUvIcrvxxlO3gN0+dI8hHwhPVvL/ywYKjAYc4ch?= =?us-ascii?Q?4w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4938.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54e8c96f-a019-457f-63a3-08dbd9c2bdfa X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2023 03:37:43.6665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jysv7xPAkIp8eEvEwOjJm1ztZn/zxd3AgSrZqRZ+2kz5+rcn53fK2E3M5t+5dueASBi4NOInNrIWKafjWTbtczx0sm1Dj5h/o+pGaqmDvBU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7122 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eGspb3mfGqF4VfTsI3EwW0d1x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ffaflpni; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Monday, October 30, 2023 6:41 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Michael Kubacki > ; Kinney, Michael D > ; Laszlo Ersek > Subject: [PATCH v1 1/1] .github/workflows: Add Stale Check >=20 > From: Michael Kubacki >=20 > Adds a GitHub workflow that uses the actions/stale GitHub action to > automatically leave notifications on and close PRs that have had no > activity for a long time. >=20 > Note: Modifications to a PR reset the staleness counter. This > includes pushing to the PR, adding a label to the PR, > commenting on the PR, etc. >=20 > If a PR has been marked "stale", simply leaving a comment will > reset the counter. >=20 > Configuration choices: >=20 > 1. Do not attempt to close edk2 GitHub issues. > 2. Mark edk2 PRs as stale if no activity in the last 60 days. Close > PRs marked stale if no further activity in 7 days. > 3. Do not exempt PRs with a "push" label. > 4. Run the check once daily. Allow manual runs from those that have > permission to run GitHub workflows. > 5. Add the label "stale" to the PR when it enters the stale state. >=20 > Rationale: >=20 > 1. We do not use issues often enough. The limited usage of GitHub > issues in Tianocore org GitHub projects are in another repo not > impacted by this workflow and expected to track long term tasks. > 2. This is the default value. In non-edk2 projects, I've seen these > times work fairly well to identify PRs that have fallen stale. > 3. Adding a "push" label resets the stale timer. If a PR has had a > "push" label for 60+ days and has not been fixed for submission, > then it is has very likely been abandoned. > 4. This is sufficient to update PRs on the day granularity the > configuration settings are applied against. > 5. The label makes it easy to filter stale PRs in the PR list and > write automation around PRs that are stale. It's also an obvious > visual identifier that a PR needs attention in the PR list. >=20 > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Laszlo Ersek > Signed-off-by: Michael Kubacki > --- >=20 > Notes: > I tested this workflow on my edk2 fork: >=20 > https://github.com/makubacki/edk2/actions/runs/6700887619 >=20 > Here's an example of a PR it did not mark stale there: >=20 > https://github.com/makubacki/edk2/pull/136 >=20 > Here's an example of a PR it did mark stale there: >=20 > https://github.com/makubacki/edk2/pull/4 >=20 > .github/workflows/stale.yml | 44 ++++++++++++++++++++ > 1 file changed, 44 insertions(+) >=20 > diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml > new file mode 100644 > index 000000000000..b9160b548ab3 > --- /dev/null > +++ b/.github/workflows/stale.yml > @@ -0,0 +1,44 @@ > +# This workflow warns and then closes issues and PRs that have had no > activity > +# for a specified amount of time. > +# > +# For more information, see: > +# https://github.com/actions/stale > +# > +# Copyright (c) Microsoft Corporation. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +name: Stale Check > + > +on: > + schedule: > + # At 23:35 on every day-of-week from Sunday through Saturday > + # https://crontab.guru/#35_23_*_*_0-6 > + - cron: '35 23 * * 0-6' > + workflow_dispatch: > + > +jobs: > + stale: > + name: Stale > + runs-on: ubuntu-latest > + permissions: > + issues: write > + pull-requests: write > + > + steps: > + - name: Check for Stale Items > + uses: actions/stale@v8 > + with: > + days-before-issue-close: -1 > + days-before-issue-stale: -1 > + days-before-pr-stale: 60 > + days-before-pr-close: 7 > + stale-pr-message: > > + This PR has been automatically marked as stale because it > has not had > + activity in 60 days. It will be closed if no further > activity occurs within > + 7 days. Thank you for your contributions. > + close-pr-message: > > + This pull request has been automatically been closed > because it did not have any > + activity in 60 days and no follow up within 7 days after > being marked stale. > + Thank you for your contributions. > + stale-pr-label: stale > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110360): https://edk2.groups.io/g/devel/message/110360 Mute This Topic: https://groups.io/mt/102289677/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-