From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.1786.1652855440482576301 for ; Tue, 17 May 2022 23:30:40 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZaQL41Wv; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: robert.kowalewski@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652855440; x=1684391440; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=nQBr9LNOC+/njCmx+vd7/Pu3IW7FjTuo/dNvMemJNNU=; b=ZaQL41Wvoqjkisqt3T+tlLG5lDIo6VluCWXQezWSCiGmAXQG6MdBEnBH 7DrfEoQbNTl3nsqFXBA/bmreLZ+QdKvjVUjfQNS1QbLnbI/+oC49LzBQ/ f3vH0C41l8Ws1IspIqjnMAdbN736XpwNsMxQQfPUCnWABQpOrD9EFqq/L Y9WUoiurk5gYUx4nyK7ZrYxpx5i3cUJ52fW+AXv+8hL2iQhZipaD+Uv3q dupFrhcn5z+BpBJf2349UsIo2HUTKHrSSZjVD9IKXdGMdcfRxKbYVWNC8 H8KCJbVCYeNeQlHtN2b/Y//RP5zL8yNpxHi0CTSdJOpgn1GVNgEyj1knr g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="253553661" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="253553661" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 23:30:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="700448072" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 17 May 2022 23:30:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 23:30:34 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 23:30:34 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 23:30:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 23:30:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddZi+Ao+indXnZ67rzI74lZ4nrmMEyRSBK5W+8rRqak2o8n+TbX7BEuelY6QCrTJb/5wvPtDzS2vBhAeLTQJ2gN8RANxukUPP4Id09zxXA8OOX5AlX1X2EC1bJyqv+rPrYLuEBTF4oySM1pE8ds0mr8SiJpIxP9IlVsIAZJZe2tgEITQwf8AkVcYW1QGYpbV44iCFFdESzZlkOkd8dzEDbHXHnMhj/nXaAoADz7j5wvFItXQwgJJTXTWMUtHKapa1Wnmgw3QRZlGEKOwSFNWuA8BHsznC89OjotcIPJO30jGQ3xBahWjAHY0Cca5gVp2YKCKYcx7EZKTu1BuFr4fFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYIRmeJH8ygDYx6X4n9GyXPjGFHR8JMncqkPXYO7AtI=; b=oSVytYaspeSpquqOMvYOKpBl+X/sMSGXSVQj03zSwNh9Yvu6pACf1QohlKIuTOnfKQrLRDx5xKKPa1jtDLFPscQec5utvmMiuWCtys6OsxKqcPKgYaIhVFHO548AseqGvWNK7Q3SqBr2XxCfSK+JXIjDq7VtgcmLoDd3OFGIZNBCY8RuyVSQj9P+b+JRD8hqI1nslFe2SVpmOKXxegPE8NRprFJSxGFMcWXr2N/3ca3R2B+fA+U1G9YUqQguoAfsZ+doaeGsf+u5YrJpkCF3y6N2zc29b6oH1TqTE2JcPt06BlNeQ0VUkvdV70hEaBlCH1SVCQRNOVX/iq5BPAGPrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB4954.namprd11.prod.outlook.com (2603:10b6:806:11b::17) by MWHPR11MB1278.namprd11.prod.outlook.com (2603:10b6:300:1d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 06:30:31 +0000 Received: from SA2PR11MB4954.namprd11.prod.outlook.com ([fe80::f06b:7d39:940e:4e93]) by SA2PR11MB4954.namprd11.prod.outlook.com ([fe80::f06b:7d39:940e:4e93%9]) with mapi id 15.20.5250.018; Wed, 18 May 2022 06:30:31 +0000 From: "Kowalewski, Robert" To: "Sheng, W" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Huang, Jenny" Subject: Re: [PATCH] IntelSiliconPkg/VTd: Add PCD for VTd Abort DMA Mode Support Thread-Topic: [PATCH] IntelSiliconPkg/VTd: Add PCD for VTd Abort DMA Mode Support Thread-Index: AQHYZRX8tsmJqvzbSkirs9bVbmqEe60kN1YQ Date: Wed, 18 May 2022 06:30:31 +0000 Message-ID: References: <20220511090313.1598-1-w.sheng@intel.com> In-Reply-To: <20220511090313.1598-1-w.sheng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d40bf25-c4fd-430a-7a9d-08da3897e846 x-ms-traffictypediagnostic: MWHPR11MB1278:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0htJvb4i9sanZg/pE1QiJlWcyt4l9fSi8dPwuro7sEhsMBsAIblLnJA1HoYak+694nAEJ6YXJdBzbRg9SqPj6swF8HfnnsSX23aH6ylg2QEWApq5nEU4TMUSNmYC7acCEojx3l/NYsWWBrq4ytnhBQmo4nbE51N03gGQZ+zdnavlg8CNYuZ56SX9vBMIc/GnmMaTLQi0fSlqv9uR42v+Vw0U8mqe1AQelV/iHdE3JwFNj+hWU0wVYiy7SppXAMGdJeEZawQlqNAMI3gwn/aCYpRWA9zPKPQYycuRlDg7hQRV67daGiR5BENMGLilMeERuIjp7y2tu1UVdX+veapcM7tplsg62V1VYXPaZjL+SwRpPDXnYRtY+DTWJe877tyf8FfCek/zRupueNxgdq/eulgiolzYwW7rSquwnylz2UfYTZOV4XlZKcJ3O5tcnFEGf7niNRZqPN0rMDEjOYLXlH1AzeDp6vLZvJw+E7tIH5YKRv3fceiFeZGSMcyO5Uldieuiw8f7peNFUABYN/Nd66N5yA6l8/PyMVGaxYeE1yARUZJ5FcwMxAWShQRNV52VDpacXUvJ0KJvn3kODbfLIy4so1RqTSIHbRY0TGZAEevPkfGsTHzTOTRBICmvcAH2XVZAYc9Q4wzl/GEyGSM4xLd0ZFuaRpZ8nOST0DZVKJbnMWcCmgVYbbggrSE7c6fqVzdjnrxUyx97qvfPqh7r/w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR11MB4954.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(76116006)(86362001)(186003)(7696005)(82960400001)(66476007)(66446008)(8676002)(64756008)(66556008)(4326008)(316002)(83380400001)(122000001)(33656002)(38070700005)(52536014)(8936002)(66946007)(71200400001)(53546011)(110136005)(55016003)(508600001)(38100700002)(54906003)(6506007)(5660300002)(9686003)(26005)(2906002)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0dzv98re4U4A0gcjBzsrLD1NgPR93NkSZWDilz0WJlBMqLiCL9QhxW6dk1Df?= =?us-ascii?Q?5LownzYN2ZybYnF305ht5pIo8c8yTvuU1QRhgtR+i1AxvFUugIMPkluGLoVA?= =?us-ascii?Q?fl4n0wkj0fqV58BBMyWv1tsYZ/+9bQjOtHLl2lvDzwM4bdmcUkpzU7ilYCCi?= =?us-ascii?Q?4xROBxyXztMRJ+0podxky8U+ZFjGgoLCkEy0cHASUVoBcq55WNpvgq3RzTir?= =?us-ascii?Q?+etQIjAotVFDHBQ2Wc3K6AtoiN6LxZKjFCsJLaXkkXAeHFNy1/bTKJgOglyV?= =?us-ascii?Q?Xnjc5JHT2FA5Q7nUfP4f0jasBp0ZfSNFVIh4y2mMwbUDCPZYeV1B8JgvG3ab?= =?us-ascii?Q?KTGj+KcKYb8O/AWJBLlTFrZGhCVA3pNOG7dHUYqrrS9DXbQuASaUomfJNKLG?= =?us-ascii?Q?MLLpUGHAEVKQiGU6r1sWeD/8ZkS3Alh1mp2GiRmYXqcN4xx9+Xbp7lIa2OFG?= =?us-ascii?Q?bF1nEt9IAGx3tFUKoGRNNJeyY9/tesausOF7LhnJfDxd3dosVmZQA2WDWjzP?= =?us-ascii?Q?gRybUtAiHWhtuMs7s62tlyG0/Kbas4NOC1G1JRjd+ubq9GhH8Sz/U09OSeVU?= =?us-ascii?Q?PkAD9N8Abuse2pEUWx1/hB6csBFNTrAHnw1nUWEmLQfino31/np0zQf8Cs0m?= =?us-ascii?Q?qusOs2so+KOQmFKrH13WICQxieyTSU8ZWjhGBLY8QKSCeKmJEDFamw7i9Hql?= =?us-ascii?Q?U/hOic8uMADSOFXcCuudnrPmhWxel9NVGzqPnrLiMToJ2tpGDUUWEoPndqOa?= =?us-ascii?Q?SKteOQM2nuz7yGBl2lMw5i+bgRLEFyIrfYZGoObGzdRB9n06VdGnBx4GBojJ?= =?us-ascii?Q?7bv776rkMQdMUol9cLn0anrjn5/ClSyQ0CzeoJebKMp8bMTEnPNODtbOM0ME?= =?us-ascii?Q?pDZl7nS089qqS8q8T+jRztENV+E0slyKMSjYqpzdfwiNEib8qXeRBDkj5uid?= =?us-ascii?Q?pLtP5Cx/pAvpkKtkagb0sd51QWzGCv3MTLwsp9GB9oOs7zqsjX8bj/ZDBAyZ?= =?us-ascii?Q?EN+t/mfm98fXkM7kGjXVYx+XSOeW53kYCjxgvZ5QH0uQaFBpiFDeoURalBS7?= =?us-ascii?Q?aH9u9U1IvJEi0kRk7J87NV56zSMG6A+etJK60Dhbq7OEKjYYn2vtdB6B0p8v?= =?us-ascii?Q?rjDssH3hi9YX6m6yVGksY0ZJBiFs8R646PMPZXTZ1GEjSMhHjsWGQoyZ4JVU?= =?us-ascii?Q?FIR2vuC65PbuBB+ZWqejX+P8lyogb/SI17U+a1JuvOjsS5Io7DX73Hku+Cx8?= =?us-ascii?Q?x5ZAkvPN4YQ7qNWu0cY14xTtTUuz2yXqvIZBGBQ4BrZdr+VRCN4LknTnXWBv?= =?us-ascii?Q?IqMwIyi6Ez9Ak2rtO7mvbS0KQoEw+CirhAcSBJYygWpj1vGBa+KGOgahrjAi?= =?us-ascii?Q?VXOO4yo5Y3BF868OZqgGrT+4kCA7rPyZeoznCpy7ICr8yvzW/gCIlGkfPHON?= =?us-ascii?Q?aHKxBEM6g52+aamLPuaBEP95Jcv83zbwXMFoV2uXCgANcLk/MFygrjVxCu/u?= =?us-ascii?Q?ff0EntQi4pLIyx1FqDCW8bwEaFCZRP4r+fH4L0fu9DdGNHO+3Xy7NTUzCZPs?= =?us-ascii?Q?0S2+eO92xhK2k6BQxgCKIEVTGeS11OweLqo7X1Z1L0ZJvXuvkNEuOWHP6swD?= =?us-ascii?Q?jbmw4sb8k9HIJ/buM+w+Dl5mEhX/XtqzD0CQpZQcmyWYw/8kPtOHYVmbZdPE?= =?us-ascii?Q?8qnR6KlPPxHaDZ2ZLdYR7xU26gsTHotUNDaGFObTdme8/GmwgrNo8Xb0zrCp?= =?us-ascii?Q?2Xl9xlPT6mSuGcrAz6hsT1b7jv4s2sU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4954.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d40bf25-c4fd-430a-7a9d-08da3897e846 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 06:30:31.4185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6E6tBMJHhbl1YVBa/v/IgBCcmxB/neqQTvIifYAUQL2OM97sWGkKhl/umfkN4NiaQZNWzF2fOy9RzQf2X5LKDbRZfESGoNLN0h0gbiJNK+c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1278 Return-Path: robert.kowalewski@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Robert Kowalewski -----Original Message----- From: Sheng, W = Sent: Wednesday, May 11, 2022 11:03 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH] IntelSiliconPkg/VTd: Add PCD for VTd Abort DMA Mode Support PcdVTdSupportAbortDmaMode is used to enable/disable VTd Abort DMA Mode. Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c | 7 +++++-- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.inf | 3 ++- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c index b4c44d87..18c22316 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c @@ -1,6 +1,6 @@ /** @file = - Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.
+ Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.
= SPDX-License-Identifier: BSD-2-Clause-Patent = @@ -570,10 +570,12 @@ EnableVTdTranslationProtectionBlockDma ( = DEBUG ((DEBUG_INFO, "EnableVTdTranslationProtectionBlockDma - 0x%08x\n",= VtdUnitBaseAddress)); = + DEBUG ((DEBUG_INFO, "PcdVTdSupportAbortDmaMode : %d\n", FeaturePcdGet (P= cdVTdSupportAbortDmaMode))); + ECapReg.Uint64 =3D MmioRead64 (VtdUnitBaseAddress + R_ECAP_REG); DEBUG ((DEBUG_INFO, "ECapReg : 0%016lx\n", ECapReg.Uint64)); = - if (ECapReg.Bits.ADMS =3D=3D 1) { + if ((ECapReg.Bits.ADMS =3D=3D 1) && FeaturePcdGet (PcdVTdSupportAbortDma= Mode)) { // // Use Abort DMA Mode // @@ -594,6 +596,7 @@ EnableVTdTranslationProtectionBlockDma ( ASSERT (FALSE); return EFI_DEVICE_ERROR; } + DEBUG ((DEBUG_INFO, "Block All DMA by TE.\n")); Status =3D EnableDmarPreMem (VtdUnitBaseAddress, (UINT64) (*RootEntryT= able)); } = diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmarPei.inf b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei= /IntelVTdDmarPei.inf index b97ff900..473665e9 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= rPei.inf +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= rPei.inf @@ -4,7 +4,7 @@ # This driver initializes VTd engine based upon EDKII_VTD_INFO_PPI # and provide DMA protection in PEI. # -# Copyright (c) 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2022, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -55,6 +55,7 @@ gIntelSiliconPkgTokenSpaceGuid.PcdVTdPolicyPropertyMask ## CONSUMES gIntelSiliconPkgTokenSpaceGuid.PcdVTdPeiDmaBufferSize ## CONSUMES gIntelSiliconPkgTokenSpaceGuid.PcdVTdPeiDmaBufferSizeS3 ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdVTdSupportAbortDmaMode ## CONSUMES = [Depex] gEfiPeiMasterBootModePpiGuid AND diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index e5b785ae..92d7fa3b 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -172,3 +172,9 @@ # @Prompt The VTd PEI DMA buffer size for S3. gIntelSiliconPkgTokenSpaceGuid.PcdVTdPeiDmaBufferSizeS3|0x00200000|UINT3= 2|0x00000004 = + ## Indicates if VTd Abort DMA Mode is supported.

+ # TRUE - Support VTd abort DMA mode. + # FALSE - Not support VTd abort DMA mode. + # @Prompt VTd abort DMA mode support. + gIntelSiliconPkgTokenSpaceGuid.PcdVTdSupportAbortDmaMode|TRUE|BOOLEAN|0x= 0000000C + -- = 2.26.2.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.