From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.6696.1644908794506564332 for ; Mon, 14 Feb 2022 23:06:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FB4N8t2m; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: robert.kowalewski@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644908794; x=1676444794; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=FFZ0XT8ZDW/EsjK2SNQWRoRkjGRMHaaMmBSuLzx8PDM=; b=FB4N8t2mQYc9qek5Mc2ovBAY3kCqwn8mdadPAdk2mR99ynWt+8paFm+I iPMLTfON13v33rbPXik8vS2FYVQLftvqZX4ErmhSWo3NKpFZTJ4624gEy apwzeYaZOuJOytHOUUWebCtAkYhfjxdmBuZOEQ+CgCegPJL43eCK6bh0g I6I8hsjdAG/iGu6TQf/7gHd2BF/WojAHCCIg9UMumPWR+McEs6e3ii637 2RJ/AxlW08DF7enJRKD7BhLnffQ0sk5W5aYCJoCQaZS2G0Qx2OohjYAEa KjHcd6chDOqLJul1QQyyYzgHFNznaEMh/WCy8IZhCHg3gZN1ML5NhwNq7 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230902753" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="230902753" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 23:06:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="635666057" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 14 Feb 2022 23:06:30 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 23:06:30 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 23:06:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 23:06:29 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 23:06:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNhU5v0yWoF1wsJeQS6qyswWA277o1Zj3tZrMKeS2r8LpbGwXFssWP9WRZHGSts1w3BEjC1wG6DSV89NKT67g+Vsf98JiVs6SM37Fwc3uAenYBZd+xEv9tlMA5KOWHPeortpxurq2ZlIx49JI81Zkvl00Cw3gq864EPbYt5rAnOQF8lA1ur6/e8V7bFUoC0KHt5kakIIYogGfQLFVTFO1ST9W0KxUVrkvs3OtFcX47O3Km040qWL5TdZwXtqrstGPP8Aw3EaFKS0w8guFd2o/KYvk9aJIGrQeoOszDX08kCWofyHYhjmJnJP/z47teGDoCRcMtgT8CHXPzpw3EhMwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UyBJbpWqPWpXjBtVDHFEvkjnXJzFwVFVRiu/bxAkogI=; b=Vu9SmgmeL3YJg8sPjjRlwMm0qPVjiUWquVUMjo4049hyvDU2xzuPkIGKQOyJmOFM0LfviojHuN7jRBmdu94U/VQntZ45aN2tsCNsYTUOxC/E1YV2AzE8ia9mEZeoptdKEZ6+fDkZjBtr6oYx07hLS2ITtkQ/+Z//oBEBG9wgIywGVCEGcdYnjoGFkxbCJOAukulj33/1TULf93ChT6ywOtwtxEhF0IEI7B4ujql/vQrdzth3P3+OBi4LFW3Hs/CIcV52ngogn53dAr/BQmgapjYLJpWZ+N4+EKARsqVQIkb8Tr6MIglqdH4Z/DuToa8lCdrc1SD89Tc5BfyljCQWWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from SA2PR11MB4954.namprd11.prod.outlook.com (2603:10b6:806:11b::17) by DM5PR11MB1292.namprd11.prod.outlook.com (2603:10b6:3:7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Tue, 15 Feb 2022 07:06:28 +0000 Received: from SA2PR11MB4954.namprd11.prod.outlook.com ([fe80::5c4e:86d6:621d:f717]) by SA2PR11MB4954.namprd11.prod.outlook.com ([fe80::5c4e:86d6:621d:f717%5]) with mapi id 15.20.4975.014; Tue, 15 Feb 2022 07:06:28 +0000 From: "Kowalewski, Robert" To: "Sheng, W" , "Kuo, Ted" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Huang, Jenny" Subject: Re: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit Thread-Topic: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit Thread-Index: AQHYIjfoYMhJXw1WRUed41cm3hvug6yULi+AgAACEYA= Date: Tue, 15 Feb 2022 07:06:27 +0000 Message-ID: References: <7c1d6d087fb0667e191b4f282e0dae3fa728350d.1644907566.git.ted.kuo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67670ed2-3253-4b4a-3d22-08d9f051afb4 x-ms-traffictypediagnostic: DM5PR11MB1292:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:644; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5lXgxXt7xzMJ8nJo4yNvdGNrpnjfSRWq12zvlfflgdqAqgu5WLhpWgaRMllmklg2xysuICmS+mDNWhPwPi6BCEGdiYYMJ7+ptI8en1O3WCRqZ7/V5Mo8exRwooadhiWezuDc6BNt2/N1r60R+rbM3hoN0drCKQx0f7N/xYkC6PTBeoXKDsAH43CDyXW3VF056YR9AK84MH52Ma9SCoGyYW/ExhUn+3fSUjaVPGexI+F8Rmqx1xqoQY6hEf6FyaabxxQ75ufBMHC9bCCtWlQ4ZhB1abDXQeGy77tZsT3Hfx031k1tEcaTf0k43JufTFgMeNkqDDb8Ho6Q7ClR8VleXMEMi4n0ARIZ+ocCFXvq4dPr7gyxv1xdaMxhUYIx8CrWDCOmx5tmAlCApfWjxEurKXDgDCKzRg43p7ZiqTBTLrJmLAnYsWkVLIZJdGZD9Llpi6mpNH94v5dCU4kJ7RPe3i8N6J17MJyg8qYVprn4+cU3iVOIbacarVJ/yYYCEfc+8tZPa0LnbVsgzKeUeewZPePrg6JL2wvyo7Ucv/hVJkgS4Etj5nfqmEwjIxP56IPRUGcu0i8nShZ9Ml70IHL9p8HVhU3W+TLtUPzCUzabuyB7lxez4Ana9ZJxh7fAaIAsPrXLGdNU/lKl+oMgeveEdza7Sj2xnPMZ4MU+57hWYK9e2frNJ1gwzbGx+qaQwGKDyytmdI18QyoU22oZttM/8zNK91E8FBG7FsROun7ad5qq4iuGfnRypTyHQSHWZUfOiaz4p9UmWhOHclAbkz6el0r8bt7ulMcRY4cMSSfIrE8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR11MB4954.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(107886003)(33656002)(5660300002)(52536014)(76116006)(66946007)(66556008)(66476007)(9686003)(66446008)(64756008)(38070700005)(4326008)(8676002)(6506007)(71200400001)(38100700002)(55016003)(8936002)(83380400001)(53546011)(110136005)(186003)(82960400001)(26005)(316002)(86362001)(54906003)(7696005)(2906002)(122000001)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?dTR1SEpJY0h2RWJhMlVIRjhUdUd0amoxeUZxQ0lmZXdTTWxOVi9JVGsz?= =?iso-2022-jp?B?WHJFL0hpMG5LaGMxUlVIaGowbWUzeU1vb1kzMlg5cFpXUVpUWWNlK3o2?= =?iso-2022-jp?B?cHYwa0k5UzdGNkJnQ2hqTUZjbmJQRlJOV3lldkkyZUVhSlBJLytHdTk2?= =?iso-2022-jp?B?dkVSQ052ZE5VQXQ5K3puK0M3N1VENzh3SGg1MDJPbVpsdjhwTGorckFj?= =?iso-2022-jp?B?S2wwTWlMdTAzcEFSZUpZRDdWSDgzbGltamRMU3Y5MEVWRk51NHpJWGdn?= =?iso-2022-jp?B?dlplTmdBYWVuVlZMVmlYSlZnaWE2V0NzN3JjYmJFNlkyWHNQenh6SkFa?= =?iso-2022-jp?B?b3Q0c1J3U2lBWklNSTlVR2M5TWRYa3gyVVlVN0Q1TEdVckFpMFhGZlRp?= =?iso-2022-jp?B?MHpCZWxVR1ZIRDQ1YlpZQ2ZwcWxXd2s5RC9BaHV0Ync0ZzNRdThKTGRI?= =?iso-2022-jp?B?d0YyNlVTMGhsRXAzNU5vSi9jVVJWYUhSSllWNmlIZVlLaHF5S090dEQz?= =?iso-2022-jp?B?SXp2ZTdBRjNDSit1dm9TeFJIWWVENDc4b1pPNlRsQjJtamdUbHdLMHVB?= =?iso-2022-jp?B?S25pV0xTNnVwWUxnVEVveDdsM1hsTUMxVEMzNUZ0NXcxbnRzZ1QvSURH?= =?iso-2022-jp?B?T2tVY2lnOVBtZVRNQ0NUN28xWXBNaHd6OHI1bUhCNzlMc1pCVk5zanoy?= =?iso-2022-jp?B?Qmg3T2J4cG1IYTYvSTZGaHRqdWVQNW01c2hocnVhL0Y4NE02MHRqN1BQ?= =?iso-2022-jp?B?cm9XaXRpS21DUUszY21nWUg2eXNNL0hDVmZPSWZpRGY4UUNkY1lpUmV0?= =?iso-2022-jp?B?dWFtYksxbk43TTJ2bUhEM2tvdzZHcTExcVAyQnltckQvMW8valc4aFFZ?= =?iso-2022-jp?B?NUFyWWtxcjBDLy9MSTFiVXc5RVQrQlhWMWlUMmQzdWgzNGJoNXRRZ25G?= =?iso-2022-jp?B?QnhSck9wcGc5VlBTUnA2NGZpKzhmdUdiYXZ4VnZRMjFoQlYvUmZzNUN3?= =?iso-2022-jp?B?NVR3NlBUbGNSMnBtSUJibEdCS3d1ejBxR2pSRW5GTUxDRFN3ZHkraWE5?= =?iso-2022-jp?B?cW02MGtjUU82Unk1blVsVFZxazZTSWZINDg1cmxyR284S3dVblRqRms0?= =?iso-2022-jp?B?eGdyWDNaV3pLMlREZ0gvNW5CNXRiS0RuS1NuSHUzS2ZWUnV4bTUvVkc0?= =?iso-2022-jp?B?TjNJNDJRaURteENCcmpUeXRGZ1d3UktHYmV0V2czRXR0L3FKWnUzbkI0?= =?iso-2022-jp?B?amd0Zk9nNHMvU1k1dVRnMEZ1bFVwVWJwc29tcmprT0NFbW84UmV2MFp2?= =?iso-2022-jp?B?Y0oxQ1Q0Ti83SDlBbUVDQnBJbCsySnNhTjViWDc1VXAvOUhHdGlHcmQr?= =?iso-2022-jp?B?UG9ETU1DSUVqM1BFR0M3RnVPMzhtZDBEeGtyYVl1WWkwNEphbkM3cE9C?= =?iso-2022-jp?B?aURaVGFlb1hYZlh0ZGtoNmVleGtFSmt3N3FEeDAycUlLY0FCRVQ1SS9t?= =?iso-2022-jp?B?VXdWN3pJYmEyY0tUWjdaZmRlODJJZDdsWFFSdnR0VEVONEVpczc1SEx6?= =?iso-2022-jp?B?NU9Iekp5VDFFVFBRS0JVNFhkMWYwM2dhODIvWE1PVGR5STFDL2d0WGtw?= =?iso-2022-jp?B?bFFnSGlzVmVhQzZhTVltb0xwTHYwWWRSM0VsR0M0aStlMnh4cGxrRmxX?= =?iso-2022-jp?B?dHJiQUxYTldnUmtoQTBwdEFEcGd6Sm9Dbys4UTBRQkNvNkErZTVIKzNQ?= =?iso-2022-jp?B?WFErcHo5TXVxN1dCWDJjdktCYjFpUXg1ZSt3TDRHcUpFYkp0citFQ3JD?= =?iso-2022-jp?B?NUFJQWVNUVZON0g3VXlXT01FaklMTWNJWGJyNXc5RlJSSGd1SDA0eXlP?= =?iso-2022-jp?B?YnFVU083TnRHWWFYa3hGZHJYRTU3NXBseklwNlRrUmdaQ1FETmhSRWNw?= =?iso-2022-jp?B?cEFvNHlsUkNvYWp2TENNVEtnZWZFME82MytoUDhDcEs1NlMzeWdlc1JB?= =?iso-2022-jp?B?Q09sbTY0cG9zT0NVVktXYlo2T2xkZ1g5bFk5UWhPMGtKRmNvdVFGaGZv?= =?iso-2022-jp?B?bTF2OXBuTlB2bk9LQXRNWHRkbTlDMGV6QU1RYXpELzVoYVRldDNTUUpm?= =?iso-2022-jp?B?TFdEQXFSdUVrOGh1TnI3SXJnMVVFWkRTT1c3RmpIL2xmckhnUlk5Ujd1?= =?iso-2022-jp?B?d1hGRkFkYyt5NjBMd2dxLzhVWFE2cE16ek9QOEhuL0hDUG1xUGdwYWxk?= =?iso-2022-jp?B?YXZUMzJkbVVwbWNrYXAzU2dzMUJtL0VaWklTNGh3OWlFLzZXcStncWdz?= =?iso-2022-jp?B?bTZBMjByYjFqUmsxektkMlErY2hmNm1TRjlnNTV5MGptT2ZROU03TFRw?= =?iso-2022-jp?B?MU9WV2R5YmtSbSs2bGJFU0QzYVV4a3hreU5Pb0tmMTJkVGdaSjJQNG1z?= =?iso-2022-jp?B?TlhQRVhRPT0=?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4954.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67670ed2-3253-4b4a-3d22-08d9f051afb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 07:06:27.9228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8eUX0goqDgyS90LIXnRGXkYz74ica53YLyKFuV4CBJcvEI4obYHo7r2t5XVRysJ/bvCnipsVkgJTLYf9xCtm7K1qeMSy0BWhULLGjSD94II= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1292 Return-Path: robert.kowalewski@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Robert Kowalewski -----Original Message----- From: Sheng, W = Sent: Tuesday, February 15, 2022 7:58 AM To: Kuo, Ted ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: RE: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei= in 64bit The change is good to me. Reviewed-by: Sheng Wei > -----Original Message----- > From: Kuo, Ted > Sent: 2022=1B$BG/=1B(B2=1B$B7n=1B(B15=1B$BF|=1B(B 14:47 > To: devel@edk2.groups.io > Cc: Sheng, W ; Ni, Ray ; = > Chaganty, Rangasai V ; Huang, Jenny = > ; Kowalewski, Robert = > > Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to support = > IntelVTdDmarPei in 64bit > = > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3836 > Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from > UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit. > = > Cc: Sheng Wei > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Jenny Huang > Cc: Robert Kowalewski > Signed-off-by: Ted Kuo > --- > .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c | 4 > ++-- > .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h | 2 > +- > 2 files changed, 3 insertions(+), 3 deletions(-) > = > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.c > b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.c > index f97d627eca..2844f366bb 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.c > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelV > +++ Td > +++ DmarPei.c > @@ -434,7 +434,7 @@ GetVTdInfoHob ( > VOID > ProcessDhrdPreMemory ( > IN OUT VOID *Context, > - IN UINT32 VTdIndex, > + IN UINTN VTdIndex, > IN EFI_ACPI_DMAR_DRHD_HEADER *DmarDrhd > ) > { > @@ -454,7 +454,7 @@ ProcessDhrdPreMemory ( VOID ProcessDrhdPostMemory = > ( > IN OUT VOID *Context, > - IN UINT32 VTdIndex, > + IN UINTN VTdIndex, > IN EFI_ACPI_DMAR_DRHD_HEADER *DmarDrhd > ) > { > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.h > b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.h > index 351a7810d8..7bed0a5363 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm > ar > Pei.h > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelV > +++ Td > +++ DmarPei.h > @@ -49,7 +49,7 @@ typedef > VOID > (*PROCESS_DRHD_CALLBACK_FUNC) ( > IN OUT VOID *Context, > - IN UINT32 VTdIndex, > + IN UINTN VTdIndex, > IN EFI_ACPI_DMAR_DRHD_HEADER *DmarDrhd > ); > = > -- > 2.16.2.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.