Re: [edk2-devel] [PATCH V2 1/9] UefiCpuPkg: Add CcExitLib

["Min Xu" <min.m.xu@intel.com>]

On November 4, 2022 10:35 PM, Tom Lendacky wrote:
> On 11/3/22 18:19, Min Xu via groups.io wrote:
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
> >
> > +
> > +/**
> > +  Handle a #VC exception.
> > +
> > +  Performs the necessary processing to handle a #VC exception.
> > +
> > +  The base library function returns an error equal to VC_EXCEPTION,
> > + to be propagated to the standard exception handling stack.
> > +
> > +  @param[in, out]  ExceptionType  Pointer to an EFI_EXCEPTION_TYPE to
> be set
> > +                                  as value to use on error.
> > +  @param[in, out]  SystemContext  Pointer to EFI_SYSTEM_CONTEXT
> > +
> > +  @retval  EFI_SUCCESS            Exception handled
> > +  @retval  EFI_UNSUPPORTED        #VC not supported, (new) exception
> value to
> > +                                  propagate provided
> > +  @retval  EFI_PROTOCOL_ERROR     #VC handling failed, (new) exception
> value to
> > +                                  propagate provided
> > +
> > +**/
> > +EFI_STATUS
> > +EFIAPI
> > +CcExitHandleVc (
> 
> Sorry I didn't pick up on this before, but any reason this isn't
> CcExitLibHandleVc() to match the other APIs or have the other APIs just be
> CcExit (since the "Lib" part seems a bit excessive)?
> 
> (Same for CcExitHandleVe below)
> 
Ah it is my fault. It will should be the same as other APIs. They will be updated in the next version.

Thanks
Min