From: "Min Xu" <min.m.xu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 5/9] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV
Date: Sun, 12 Jun 2022 09:21:55 +0000 [thread overview]
Message-ID: <SA2SPR01MB0002929A083991CBB1D084B8C5A89@SA2SPR01MB0002.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220610132210.54deaotdn32pidui@sirius.home.kraxel.org>
On June 10, 2022 9:22 PM, Gerd Hoffmann wrote:
> On Mon, May 16, 2022 at 03:42:19PM +0800, Min Xu wrote:
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> >
> > TdHobList and Configuration FV are external data provided by Host VMM.
> > These are not trusted in Td guest. So they should be validated ,
> > measured and extended to Td RTMR registers. In the meantime 2
> > EFI_CC_EVENT_HOB are created. These 2 GUIDed HOBs carry the hash
> value
> > of TdHobList and Configuration FV. In DXE phase EFI_CC_EVENT can be
> > created based on these
> > 2 GUIDed HOBs.
>
> This breaks booting the IntelTdx build without tdx:
>
> ASSERT
> /home/kraxel/projects/edk2/SecurityPkg/Library/HashLibTdx/HashLibTdx.c(
> 189): TdIsEnabled ()
>
Thanks for reminder. I will submit a fix right now.
Thanks
Min
next prev parent reply other threads:[~2022-06-12 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 7:42 [PATCH V4 0/9] Enable RTMR based measurement and measure boot for Td guest Min Xu
2022-05-16 7:42 ` [PATCH V4 1/9] Security: Add HashLibTdx Min Xu
2022-05-16 7:42 ` [PATCH V4 2/9] CryptoPkg: Add SecCryptLib Min Xu
2022-05-16 7:42 ` [PATCH V4 3/9] SecurityPkg: Add definition of EFI_CC_EVENT_HOB_GUID Min Xu
2022-05-16 16:28 ` [edk2-devel] " Sami Mujawar
2022-05-16 7:42 ` [PATCH V4 4/9] OvmfPkg: Introduce SecMeasurementLib Min Xu
2022-05-16 7:42 ` [PATCH V4 5/9] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV Min Xu
2022-06-10 13:22 ` Gerd Hoffmann
2022-06-12 9:21 ` Min Xu [this message]
2022-05-16 7:42 ` [PATCH V4 6/9] OvmfPkg: Add PCDs for LAML/LASA field in CC EVENTLOG ACPI table Min Xu
2022-05-16 7:42 ` [PATCH V4 7/9] MdePkg: Define CC Measure EventLog ACPI Table Min Xu
2022-05-16 16:29 ` [edk2-devel] " Sami Mujawar
2022-05-16 7:42 ` [PATCH V4 8/9] OvmfPkg/IntelTdx: Add TdTcg2Dxe Min Xu
2022-05-16 7:42 ` [PATCH V4 9/9] OvmfPkg/IntelTdx: Enable RTMR based measurement and measure boot Min Xu
2022-06-03 11:53 ` [edk2-devel] [PATCH V4 0/9] Enable RTMR based measurement and measure boot for Td guest Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2SPR01MB0002929A083991CBB1D084B8C5A89@SA2SPR01MB0002.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox