From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (NAM02-CY1-obe.outbound.protection.outlook.com [40.107.76.53]) by mx.groups.io with SMTP id smtpd.web10.1750.1608056327853801345 for ; Tue, 15 Dec 2020 10:18:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=j9b9gFva; spf=pass (domain: vmware.com, ip: 40.107.76.53, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZD7vK5Pdo3XbwlFB6v0lqIxkry7kgEA5xhXtY9DID8ElyYCR/IEkINlgYwpq35eYD99EGUVDCkWikO3MP319bzHsIkQG/61VFFZ4ZsqykfIJE83cUtxJgeKwJ4KQcrM2jDLbcahUP3WW75fZ/yod1IbaUIy2ZcmfR85NurfrB3oJgZjOd3goj2rkMQtsLSx1852bfhIKSTgiEf4gqfxGaZy50PtNEYet1sKsXRH+Fryg6Sl0dw4oUgzTwU9PpD1OYFTye//2SUHKqr3PuO83F+xrVQYKQZaNF6A39nT+TX/6nri9mmF0kjDHCl6oP0yIrUSnooDCXwJNxszP2JTreA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89ttnWFVbxEdqy+C4czc+RODTQtAKzGf7yyD49u8SSQ=; b=nCiDCqtvJwp4CkqN60TlHq8i1mUDzz58ZkGIjyBS+Xk0VqIWwA7ZsALIQ+jhYUA/o+aVUTNUOwuyzAlAqyn/u5//1v5QFmf+IBNDK1qMan1Ng/DTMNb29QHiidaQ6QlkJDBHkNVa/SHI0IvyHQR/rNIvljl0eA2+oef35/ifyC2LtyWGVwnE0+2WuKQoGMrTdLRqyb++vUEL8wPfCoZCloLAVjb38rRRX11chVodzbFdtSU2t1J9EBvzSMyMguB77JX/cFtGMJ9JPwvnvGT6jGuSgbwgsGCicmYQ/3Xh/aQCc8Du3WPz4WTljZPkRpPwOj8kQYLEJN3mTb6yPBiwOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89ttnWFVbxEdqy+C4czc+RODTQtAKzGf7yyD49u8SSQ=; b=j9b9gFvam3NO1p+rE+bDH/szp+WvBVY/sCPMHa3zgtFP6N8nkU2bbnPDSLvbt0SF2u2D9huO9N/oVRdjCIpJBx2EKZ9z/Njbl+p94xq+lmGCdekMFzy8sjzxSfZ+6+BuCCwLceLYcd4963qiyoJEky0gY7YLqg8bqv/EjC5ZhZY= Received: from SJ0PR05MB7580.namprd05.prod.outlook.com (2603:10b6:a03:2e0::24) by SJ0PR05MB7754.namprd05.prod.outlook.com (2603:10b6:a03:2ea::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.13; Tue, 15 Dec 2020 18:18:44 +0000 Received: from SJ0PR05MB7580.namprd05.prod.outlook.com ([fe80::ad1c:9900:1bea:47cf]) by SJ0PR05MB7580.namprd05.prod.outlook.com ([fe80::ad1c:9900:1bea:47cf%6]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 18:18:44 +0000 From: "Andrei Warkentin" To: "devel@edk2.groups.io" , "jeremy.linton@arm.com" CC: "ard.biesheuvel@arm.com" , "leif@nuviainc.com" , "pete@akeo.ie" , "andrey.warkentin@gmail.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [edk2-devel] [PATCH 5/7] Platform/RaspberryPi/Arasan: Select the correct base frequency Thread-Topic: [edk2-devel] [PATCH 5/7] Platform/RaspberryPi/Arasan: Select the correct base frequency Thread-Index: AQHW0nA2RB7c/TAzeE+4+bIbd9+l8qn4eIn3 Date: Tue, 15 Dec 2020 18:18:44 +0000 Message-ID: References: <20201214232350.1192387-1-jeremy.linton@arm.com>,<20201214232350.1192387-6-jeremy.linton@arm.com> In-Reply-To: <20201214232350.1192387-6-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dace5e9f-fcc5-4e2a-8bd0-08d8a125dbc5 x-ms-traffictypediagnostic: SJ0PR05MB7754: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T0OjjraPWZJBs6GPy1YAxIDpGRu0mYuYsT+ZC85osDvqcYJW41s24vNCKKBZReMvsqKQz92amXjpi1q82z/ptHmqK17bOaaogRnb5prkKurrSOz0dNCMg10f8/uk8TDTYVR8b6PSMr1cvLNdhNwzSb6WRgyzjAnbPspBvVpi3pDCYFfEVffjoLzFYPTfbAQQ7TBEE+Ju3egl0ccbpo8uKICUmWGMxY/fi95VrigRuBBB+cktwFwJYvl/FE3vUpsIJTLnyyrf+XwKYC6OjOOv4YMs6/lbdoljDyYFDvxFBpgQ6cCgKv++FkNtsER1t5mH/fXXMkU+eID0IhjqaFQusqE63TbJ4Wd14nq57ntsoLK85U9boDUSE3jPpP8tcUEA0sJy7P73MtAwOHb0mfpVu8hHQMyPMOxZqJZJEeqVFLl8DQFTVK0gf3zfEJZLa9xi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR05MB7580.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(83380400001)(64756008)(66946007)(66446008)(316002)(33656002)(66476007)(76116006)(166002)(66556008)(45080400002)(91956017)(6506007)(186003)(5660300002)(54906003)(53546011)(26005)(19627405001)(4326008)(7696005)(478600001)(86362001)(966005)(71200400001)(2906002)(8936002)(55016002)(110136005)(8676002)(9686003)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?L8bxDe/wBI3Iq/0Oeqf9nq1qrDrzHJVpaHtDpBfoSgVI9TTU4N/J5aGpRQZB?= =?us-ascii?Q?2c2620l2+olHe6onzwyMBpgMie0j6TqckJzKha3bEZyjRQOdGRNbpRwC7csM?= =?us-ascii?Q?P75z4qbC5onJymQNZA3mz0ZGpacVRGoYxFDY0du6lVnU2dFSWF9cIIyvhhzi?= =?us-ascii?Q?vX9d6BvSp0WRttBya2LNczcxra45AESNN1e+UGM5VpByaoopTaxA8gK5C4UF?= =?us-ascii?Q?aiI1Q1EYHeULx0gfg6X6t2L6rVRroXk0ov1ThSXP65hboP+xd0qLRJFLG4vB?= =?us-ascii?Q?214p10WPGnDx9NN+sqqbDYmR7p8IZXHRDj/cMebbenvj9exghM90tSlwZklg?= =?us-ascii?Q?Qcy7uVK5JF/KGNQ8ehMsopTCc4stppDrmMhDbN52JhAujAnDXWPIZlxxoEh8?= =?us-ascii?Q?vj3Z9vEjcK2pMAm2A6cOqE5xohVOkDPuPezEiDVuzL+rh74m4YpCFslx/VVC?= =?us-ascii?Q?2Pf3BD+LYvowKmBYU/0FQo9fqHwHJrA9Inx6OW1PEh3WEq8eojZ5XS/OaUMd?= =?us-ascii?Q?8KgpDrUqgECW27Oneo8SoUwPuKJuNCnhev5PGkVcVOjyMMmbPjBgy0JwR5Ov?= =?us-ascii?Q?S9Xr34+7yXKQnUxCwJNnTOWfufgVMMM0r1BXK429Lyce5t/P3W65uLllT9Y6?= =?us-ascii?Q?pTi6pag+Sh75H46u4UDp1tx2hVYT+fTvkadY2NW16AGaF45AMqzg/lMH18YS?= =?us-ascii?Q?Vb1DbdrNcfqRZ14uXfj3idatvHQyWNoGXFj1RBMaQ9hdFI3nf8uBbhfkuIy1?= =?us-ascii?Q?CK0M3dTla5zWKIA0EsS9ISrLE3xx9nhqy94c2teFiIzaUsfvOCk/jxu7k6Iy?= =?us-ascii?Q?cJ7wxln8o/DuNxclLCzVm+uW/2umU8Xl3NZgi2S1qWP1cVh1ThnRTlfio/gu?= =?us-ascii?Q?q6uylOrP8bSPotRa9Rq4tKwjyRIZPv0airC2dGLBN0WpevNnrZoNPnTyQcy4?= =?us-ascii?Q?TtZKmu0iHDdq465/Em1l3c9xxoDsfx/ccTDAyCIKhko=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR05MB7580.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dace5e9f-fcc5-4e2a-8bd0-08d8a125dbc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 18:18:44.5246 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b6GbFwZlqikZY2njMHvGAAVTWSOHO8tge02IQDDJZD/vfniOkImd9tZ9HJE7Y6iteElBFiJ7oT1wobQjf8MmCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB7754 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SJ0PR05MB7580286815971D149E870C90B9C60SJ0PR05MB7580namp_" --_000_SJ0PR05MB7580286815971D149E870C90B9C60SJ0PR05MB7580namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable LGTM Reviewed-by: Andrei Warkentin ________________________________ From: devel@edk2.groups.io on behalf of Jeremy Linto= n via groups.io Sent: Monday, December 14, 2020 5:23 PM To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com ; leif@nuviainc.com ; pete@akeo.ie ; andrey.warkentin@gmail.com ; samer.el-haj-mahmoud@arm.com ; Jeremy Linton Subject: [edk2-devel] [PATCH 5/7] Platform/RaspberryPi/Arasan: Select the c= orrect base frequency The firmware reports the emmc2 frequency with a slightly different mailbox command, lets select the correct one based on which controller we are binding to. Signed-off-by: Jeremy Linton --- .../RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 10 ++++++= +--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe= .c b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c index a7b538a91a..b0f03cefc9 100644 --- a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c +++ b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c @@ -250,7 +250,11 @@ CalculateClockFrequencyDivisor ( UINT32 Divisor; UINT32 BaseFrequency =3D 0; - Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK_RATE_EMMC, &BaseFre= quency); + if (PcdGet32 (PcdSdIsArasan)) { + Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK_RATE_EMMC, &BaseF= requency); + } else { + Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK_RATE_EMMC2, &Base= Frequency); + } if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Couldn't get RPI_MBOX_CLOCK_RATE_EMMC\n")); return Status; @@ -472,8 +476,8 @@ MMCNotifyState ( switch (State) { case MmcHwInitializationState: { - EFI_STATUS Status; - UINT32 Divisor; + + DEBUG ((DEBUG_MMCHOST_SD, "ArasanMMCHost: current divisor %x\n", Mmi= oRead32(MMCHS_SYSCTL))); Status =3D SoftReset (SRA); if (EFI_ERROR (Status)) { -- 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68817): https://nam04.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F68817&data= =3D04%7C01%7Cawarkentin%40vmware.com%7C3e52cf5f8620415a603f08d8a0875747%7Cb= 39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637435850451597004%7CUnknown%7CTW= FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3= D%7C1000&sdata=3DYxlrM8qbYHtMl1ULi3pTnHnJyyepSmSxsSc3hPnqdY8%3D&res= erved=3D0 Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F78964894%2F4387333&data=3D04%7C01%7Cawarkent= in%40vmware.com%7C3e52cf5f8620415a603f08d8a0875747%7Cb39138ca3cee4b4aa4d6cd= 83d9dd62f0%7C0%7C0%7C637435850451597004%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= MFG8KdTLIf%2FzzP5taWbyHf94q%2FMd3CR%2B9l76FhBLlqg%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D04%7C01%7Cawarkentin%40= vmware.com%7C3e52cf5f8620415a603f08d8a0875747%7Cb39138ca3cee4b4aa4d6cd83d9d= d62f0%7C0%7C0%7C637435850451597004%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D18%2F= 5sdBQAPKGtwJDGPqwqWmLpLQeWDVGm1PQmZp%2B%2BUM%3D&reserved=3D0 [awarkenti= n@vmware.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_SJ0PR05MB7580286815971D149E870C90B9C60SJ0PR05MB7580namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
LGTM

Reviewed-by: Andrei Warkentin <= awarkentin@vmware.com>

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Jeremy Linton via groups.io <j= eremy.linton=3Darm.com@groups.io>
Sent: Monday, December 14, 2020 5:23 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuvi= ainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; andr= ey.warkentin@gmail.com <andrey.warkentin@gmail.com>; samer.el-haj-mah= moud@arm.com <samer.el-haj-mahmoud@arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [edk2-devel] [PATCH 5/7] Platform/RaspberryPi/Arasan: Selec= t the correct base frequency
 
The firmware reports the emmc2 frequency with a sl= ightly
different mailbox command, lets select the correct one
based on which controller we are binding to.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 .../RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c &nbs= p;  | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe= .c b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
index a7b538a91a..b0f03cefc9 100644
--- a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
+++ b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
@@ -250,7 +250,11 @@ CalculateClockFrequencyDivisor (
   UINT32 Divisor;

   UINT32 BaseFrequency =3D 0;

 

-  Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK_RATE_EMMC, = &BaseFrequency);

+  if (PcdGet32 (PcdSdIsArasan)) {

+    Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK= _RATE_EMMC, &BaseFrequency);

+  } else {

+    Status =3D mFwProtocol->GetClockRate (RPI_MBOX_CLOCK= _RATE_EMMC2, &BaseFrequency);

+  }

   if (EFI_ERROR (Status)) {

     DEBUG ((DEBUG_ERROR, "Couldn't get RPI_MBOX_C= LOCK_RATE_EMMC\n"));

     return Status;

@@ -472,8 +476,8 @@ MMCNotifyState (
   switch (State) {

   case MmcHwInitializationState:

     {

-      EFI_STATUS Status;

-      UINT32 Divisor;

+

+      DEBUG ((DEBUG_MMCHOST_SD, "ArasanMMCHo= st: current divisor %x\n", MmioRead32(MMCHS_SYSCTL)));

 

       Status =3D SoftReset (SRA);

       if (EFI_ERROR (Status)) {

--
2.13.7



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68817): https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F68817&amp;data=3D04%7C01%7Cawarkentin%4= 0vmware.com%7C3e52cf5f8620415a603f08d8a0875747%7Cb39138ca3cee4b4aa4d6cd83d9= dd62f0%7C0%7C0%7C637435850451597004%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA= wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D= YxlrM8qbYHtMl1ULi3pTnHnJyyepSmSxsSc3hPnqdY8%3D&amp;reserved=3D0
Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroups.= io%2Fmt%2F78964894%2F4387333&amp;data=3D04%7C01%7Cawarkentin%40vmware.c= om%7C3e52cf5f8620415a603f08d8a0875747%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C= 0%7C0%7C637435850451597004%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ= IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DMFG8KdTLI= f%2FzzP5taWbyHf94q%2FMd3CR%2B9l76FhBLlqg%3D&amp;reserved=3D0
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Funsub&amp;data=3D04%7C01%7Cawarkentin%40vmware.co= m%7C3e52cf5f8620415a603f08d8a0875747%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0= %7C0%7C637435850451597004%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI= joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D18%2F5sdBQ= APKGtwJDGPqwqWmLpLQeWDVGm1PQmZp%2B%2BUM%3D&amp;reserved=3D0 [awarkentin@vmware.com]
-=3D-=3D-=3D-=3D-=3D-=3D


--_000_SJ0PR05MB7580286815971D149E870C90B9C60SJ0PR05MB7580namp_--