From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.80]) by mx.groups.io with SMTP id smtpd.web08.1868.1608056477031328793 for ; Tue, 15 Dec 2020 10:21:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=jk8qIa+V; spf=pass (domain: vmware.com, ip: 40.107.220.80, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdzHzGQ3PFGWvh+2mXlqglNC+ZlyFjK+vNd1w6RtzIXZ/O0WJuuBgYFRMxgE/W3LRI/Kpe5Q5QrZ7mOQ8BZU8MHI2/xLFAh2u5XK4rrj0VWMWddxKnykBWpJfLHPIPMTQ2FJ1XRN2atz6tJXrsScPcCPDeWyO6q2MYDQOFqhz598N6eRFfUk2UUT67P5kT551aiyMYAuRkaJxluFZ0hgWiNiztY4CqNhxBvNFUAu2M8UONI7O5/T4+tN0Urp1LEXbk5LFRgo0XNkhHceblKXxyK2nA9CPnKe9+Wiz0c2MjbRx5vBy0RQgawJbw/H4aqpB72z7CwMKtQcjkytgqCqmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbCT/PwUJDZwUj8IF99s3E39O9tNbBdXYeIvcH0eCX8=; b=oC4ofRTf6QN2t0dT/8ZQIfuYfBcJdsePE9cjbblmtwtZPLFa69daTZyM/G/cJ+8+glLciza6Q7QeO3N/EWW0+BxCAFGqQa3NticlJXh663gW/PrkIPNDIKdp4m0ktyt2LLnW8stpAlzRWaIuFN8fshaaLlLWvlWdgYxGDjee4kD7MxBgiwJ6XA/wuuL/cULZP/YWbJU30FSRzMJOIGT3UAP7LVZlkNQKE0WtE7k4QHzqrt9ktaQVWKiRuslFWOBijnuE3J14CY1p2IMAW7C9TiBh/Wlv9d+4KTwhjERQXKiw0+UZbiEOgEjyhjhx17ZXYLsCcz8asF6i6CwqFFIrxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbCT/PwUJDZwUj8IF99s3E39O9tNbBdXYeIvcH0eCX8=; b=jk8qIa+VbY4dvjBKBAv30I+ANTZpru+hhQIHHAncRlRTsCVkDrWiTcuSm2hwFNyyDnSGybOQSRcbO/eIEaccuBIzfFfNTHOxH3PYTMl2jWF8n5cBe42Aoe3H85+b+3MAEPmTmNSAD/vuaE9Y1bU9HDwj1KYHfb4ts6x5EI4VgGE= Received: from SJ0PR05MB7580.namprd05.prod.outlook.com (2603:10b6:a03:2e0::24) by BYAPR05MB3989.namprd05.prod.outlook.com (2603:10b6:a02:86::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.9; Tue, 15 Dec 2020 18:21:15 +0000 Received: from SJ0PR05MB7580.namprd05.prod.outlook.com ([fe80::ad1c:9900:1bea:47cf]) by SJ0PR05MB7580.namprd05.prod.outlook.com ([fe80::ad1c:9900:1bea:47cf%6]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 18:21:15 +0000 From: "Andrei Warkentin" To: "devel@edk2.groups.io" , "jeremy.linton@arm.com" CC: "ard.biesheuvel@arm.com" , "leif@nuviainc.com" , "pete@akeo.ie" , "andrey.warkentin@gmail.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Power up sd, and tweak GPIOs Thread-Topic: [edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Power up sd, and tweak GPIOs Thread-Index: AQHW0nA3OVktWtvhvkq64OC7GiP+W6n4ePK9 Date: Tue, 15 Dec 2020 18:21:15 +0000 Message-ID: References: <20201214232350.1192387-1-jeremy.linton@arm.com>,<20201214232350.1192387-7-jeremy.linton@arm.com> In-Reply-To: <20201214232350.1192387-7-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=vmware.com; x-originating-ip: [98.214.99.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b246b625-a90d-4d39-87cf-08d8a1263595 x-ms-traffictypediagnostic: BYAPR05MB3989: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GVdKGzUva4PtD9GlYa9GLXQCd10Vh1CL7T7iVr+kLlmFxGBPdBa/S19+9T5zPczFkrKge9i0hRETknzWFyV8qJ7Ir39wXCZ52Q7DZnPUxXMPZ4KAecw7+LzWQRbUzpJuMzS5YFdN55khJA3WbY0WrdooMbw2YKNnPZJ2vsrRY/w5hS0J5ae28cwZXNXLboGaF5TY/aLnQYcUwnT+BFqRGapOhZzPavAX+aYE5E6vfkzt9a6VqYaQD54y9NfdyUWawPSLNkNse8PhG6U5EQP/1D/gFrUrfNHtPCtD+NG4YyO0dX47cUTMvEVJ3MifZXlaDBO2VTAjOwhU2pE4zEBzYmWroTwHz5lq1C+h2CEDqbG/3Z1JLhFLrDOuKHO2Rse1qO/OxFEY+xObxfClJrmIZSvbT22WHR1xiIcXgOQC06OrhKkYxozPONw6S/M4aeeJ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR05MB7580.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(110136005)(76116006)(166002)(7696005)(966005)(71200400001)(52536014)(66946007)(83380400001)(316002)(8936002)(186003)(33656002)(91956017)(2906002)(4326008)(66446008)(64756008)(9686003)(26005)(66556008)(54906003)(19627405001)(66476007)(86362001)(55016002)(53546011)(5660300002)(8676002)(45080400002)(6506007)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WsIhXpjjexGhSkcg2ldLSzRJIuDAAMECXmxaSR97YXD5TgybAEqBY4L5JROM?= =?us-ascii?Q?n5rDGDBZLp9h5DdovhZgPqGzMj+EMrLV3Rpztx3Rs3rBMDqzF83AOc2xpS9U?= =?us-ascii?Q?VkK5ReTY1Kb7sYllrGiRyLpTr5mIlDudFP2TQyEyGrLGUzqzwdg1MfVQl8Mc?= =?us-ascii?Q?g0JGZs17wi4K/F346mvAwrv1Im5wVgjvfBMmKXlMNiSfCpVsrkFl9Y5IArR5?= =?us-ascii?Q?NCu8KECieiqFGSlYnzdJ4u2vY5ZZbMgpSlzRjJGDFrT5JJ827nsQJ5bxM1y4?= =?us-ascii?Q?mctkxlvSMZHgs56tJ/R0Bu/zW/47s/C+rkM8W5vdfvhtgqgCwKw123498t3a?= =?us-ascii?Q?A6iUZowY4C8d60OyaPn0/660FmN9HL19SHwkDBU4Cutujnvhp2qenr3ewoiI?= =?us-ascii?Q?XHNYSeuEBXqI5sJwNxvXz7Y43FOgDTkLmfapM89xpQzezrRNFt53cOrEGOMj?= =?us-ascii?Q?djhp0fpf0yQymGT9LPyXqhd4Z04JlTHFGumJos+F2fl18t2YzVVDXp0+5KCU?= =?us-ascii?Q?IZPbCp017eImBR/6erLXLjZBIAEeAVCpnUy2vEa/CZgRRS+45ex1XiuqR/wR?= =?us-ascii?Q?JQ9tfEguPUrmx2u8tR/z2nbN/Ig3PDe2RF3Ub2h6N7OcQb0N4b4AboA6j86c?= =?us-ascii?Q?ahs9zxCPwb5EGP1KE8IrkeNA2ILTSwUK5fnaM2eQjedKirjm4Cw+DZTNor32?= =?us-ascii?Q?vjgrb104ZOaGjkGz7mpsSACT0MCUqrfKl6Ktl29jUeFyTc0kpGFwOJNXNN/8?= =?us-ascii?Q?aKliQnpXnz0E1zdTgXX/O8WTCYh0kGBRfaHPj/oy1NHZZLuTZnOQld4Ydc3c?= =?us-ascii?Q?sAh1/Ycq/p16/KVjnfq8jdJQDXTItU9KRyYnda1v+hdJ+uRwHMsZGtAZl2Ez?= =?us-ascii?Q?msgYsOVQlAPROSe8KuhjSRv40TGWtaUTDppO/Ib356+fGWN8F9/CBVzPIyiv?= =?us-ascii?Q?9mfyVgFeBfsUB/CdLs5heICmMmqVExBdIr8gxT9d0iw=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR05MB7580.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b246b625-a90d-4d39-87cf-08d8a1263595 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 18:21:15.2119 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P66D6rlFoY9BfcQQlnzIfhq6PFyq5gJCBm2XmPl/SYDjKJxbXBlVxkUXFPARYmnQjONsxfKqGvqL3lF8/c3lWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB3989 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SJ0PR05MB7580D391B986A33D021FDFA4B9C60SJ0PR05MB7580namp_" --_000_SJ0PR05MB7580D391B986A33D021FDFA4B9C60SJ0PR05MB7580namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Could we rework some of these magic constants? Esp the SetPowerState ones. Do we need both EMMC and EMMC2 clocks enabled all the time? A ________________________________ From: devel@edk2.groups.io on behalf of Jeremy Linto= n via groups.io Sent: Monday, December 14, 2020 5:23 PM To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com ; leif@nuviainc.com ; pete@akeo.ie ; andrey.warkentin@gmail.com ; samer.el-haj-mahmoud@arm.com ; Jeremy Linton Subject: [edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Power up sd, and tw= eak GPIOs It seems we should be powering up the sd cards, and possibly the clocks as well to assure they are setup properly before we attempt to access the controller. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 28f57438c5..8829740938 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -552,6 +552,15 @@ ApplyVariables ( GpioPinFuncSet (37, GPIO_FSEL_ALT3); GpioPinFuncSet (38, GPIO_FSEL_ALT3); GpioPinFuncSet (39, GPIO_FSEL_ALT3); + + /* + * power and clock everything by default + */ + Status =3D mFwProtocol->SetPowerState (0, 1, 1); //SD on + Status =3D mFwProtocol->SetGpioConfig (RPI_EXP_GPIO_SD_VOLT, + RPI_EXP_GPIO_DIR_OUT, 1); //3.3= v + Status =3D mFwProtocol->SetClockState (RPI_MBOX_CLOCK_RATE_EMMC2, 1)= ; + Status =3D mFwProtocol->SetClockState (RPI_MBOX_CLOCK_RATE_EMMC, 1); } } else { DEBUG ((DEBUG_ERROR, "Model Family %d not supported...\n", mModelFamil= y)); -- 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68818): https://nam04.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F68818&data= =3D04%7C01%7Cawarkentin%40vmware.com%7C09a7a2483d704affef4e08d8a0875810%7Cb= 39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637435850454110853%7CUnknown%7CTW= FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3= D%7C1000&sdata=3DMYuBr4R6LYw8l3pWORpmGzLTyvljJCffHUODVQk%2BjxQ%3D&r= eserved=3D0 Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F78964895%2F4387333&data=3D04%7C01%7Cawarkent= in%40vmware.com%7C09a7a2483d704affef4e08d8a0875810%7Cb39138ca3cee4b4aa4d6cd= 83d9dd62f0%7C0%7C0%7C637435850454110853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= MRu43d1ZNnFvGE3K9JJCXIUXvE2bZ6xWUzWtVxkNf7E%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D04%7C01%7Cawarkentin%40= vmware.com%7C09a7a2483d704affef4e08d8a0875810%7Cb39138ca3cee4b4aa4d6cd83d9d= d62f0%7C0%7C0%7C637435850454110853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D5g23e= v8pYF4L%2B2rNNABCccLjr1VMPZ1nfbV%2BfUlwqmU%3D&reserved=3D0 [awarkentin@= vmware.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_SJ0PR05MB7580D391B986A33D021FDFA4B9C60SJ0PR05MB7580namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Could we rework some of these magi= c constants? Esp the SetPowerState ones.

Do we need both EMMC and EMMC2 clo= cks enabled all the time?

A
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Jeremy Linton via groups.io <j= eremy.linton=3Darm.com@groups.io>
Sent: Monday, December 14, 2020 5:23 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuvi= ainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; andr= ey.warkentin@gmail.com <andrey.warkentin@gmail.com>; samer.el-haj-mah= moud@arm.com <samer.el-haj-mahmoud@arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Power up sd,= and tweak GPIOs
 
It seems we should be powering up the sd cards, an= d possibly
the clocks as well to assure they are setup properly before
we attempt to access the controller.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
index 28f57438c5..8829740938 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
@@ -552,6 +552,15 @@ ApplyVariables (
       GpioPinFuncSet (37, GPIO_FSEL_ALT3);
       GpioPinFuncSet (38, GPIO_FSEL_ALT3);
       GpioPinFuncSet (39, GPIO_FSEL_ALT3);
+

+      /*

+       * power and clock everything by defau= lt

+       */

+      Status =3D mFwProtocol->SetPowerState (0= , 1, 1); //SD on

+      Status =3D mFwProtocol->SetGpioConfig (R= PI_EXP_GPIO_SD_VOLT,

+            &n= bsp;            = ;            &n= bsp;     RPI_EXP_GPIO_DIR_OUT, 1); //3.3v

+      Status =3D mFwProtocol->SetClockState (R= PI_MBOX_CLOCK_RATE_EMMC2, 1);

+      Status =3D mFwProtocol->SetClockState (R= PI_MBOX_CLOCK_RATE_EMMC, 1);

     }

   } else {

     DEBUG ((DEBUG_ERROR, "Model Family %d not sup= ported...\n", mModelFamily));

--
2.13.7



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68818): https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F68818&amp;data=3D04%7C01%7Cawarkentin%4= 0vmware.com%7C09a7a2483d704affef4e08d8a0875810%7Cb39138ca3cee4b4aa4d6cd83d9= dd62f0%7C0%7C0%7C637435850454110853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA= wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D= MYuBr4R6LYw8l3pWORpmGzLTyvljJCffHUODVQk%2BjxQ%3D&amp;reserved=3D0 Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroups.= io%2Fmt%2F78964895%2F4387333&amp;data=3D04%7C01%7Cawarkentin%40vmware.c= om%7C09a7a2483d704affef4e08d8a0875810%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C= 0%7C0%7C637435850454110853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ= IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DMRu43d1ZN= nFvGE3K9JJCXIUXvE2bZ6xWUzWtVxkNf7E%3D&amp;reserved=3D0
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Funsub&amp;data=3D04%7C01%7Cawarkentin%40vmware.co= m%7C09a7a2483d704affef4e08d8a0875810%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0= %7C0%7C637435850454110853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI= joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D5g23ev8pYF= 4L%2B2rNNABCccLjr1VMPZ1nfbV%2BfUlwqmU%3D&amp;reserved=3D0 [awarkentin@vmware.com]
-=3D-=3D-=3D-=3D-=3D-=3D


--_000_SJ0PR05MB7580D391B986A33D021FDFA4B9C60SJ0PR05MB7580namp_--