Hi Sami Mujawar,

Thanks for catching that.

I will add them.

Thanks,

Dandan

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami Mujawar
Sent: Wednesday, March 31, 2021 12:48 AM
To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access

Hi Dandan,

On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote:

+ Flag = FilterBeforeMmIoRead (FilterWidth8, Address, &Value);
+ if (Flag {

There is a missing closing bracket here and at other places in MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please?

+ Value = *(volatile UINT8*)Address;
+ }

Regards,

Sami Mujawar