From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.5836.1621388785789843564 for ; Tue, 18 May 2021 18:46:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZTfbh7Bd; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dandan.bi@intel.com) IronPort-SDR: WQRy96iiP1I1Xg9JoovhDY62Ap01DJMqRIgcjeThKSe/z4Q+mOht/lo9LTdWPtGS++t3JO0YeK nDTl6NWznHeg== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="264782542" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="264782542" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 18:46:24 -0700 IronPort-SDR: VYBKpE+szGcqYxluvDBN7kl+TkiK3mNwO3Ri/kyckqgGQC/8ESYQOOM7IsxR5RbPR1qZOjOVlG UgOM/oR4BriA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="394198888" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 18 May 2021 18:46:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 18 May 2021 18:46:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 18 May 2021 18:46:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 18 May 2021 18:46:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 18 May 2021 18:46:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DrEOMeQUZOVV5nEHgs3Dai1dIXgZQT6sZ6j6IFBh2Jq+OmhLdCcgt6dHkh+UCSUBwl/FTlcYCDWq0Ua7UNbPfjuLyhjiDLDm/XiY7qhwkg/9CFD0feMZsMF63i38OjzMb6o4MPjFpoQQsvt1uDf+6YYuxetGSPtcrl1e6yE7LGSIXCWyEnY8Ej1UAkmDX9mVrGvb5YZaDie2fhrKHYHxQrcfmqr94hnJgFFjL8z3wj/f8gr2ihXo9xteFm+Z3ouakTyfJKiSiRuwzCWu0nBcwNmMatN5ktI0QtwFBWGsY+yFExNazRix8M4HBHqlwYxI8xYy1RBSBvrL9indZediFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vl6oJi6gfIQ5qXahxJfk3MHamzsl+JNb31k3AZctj80=; b=eZWwfwDFElAI8vKU+Z/y5okVnHAVwzdlk6X937hP4APNz/3M+Gpa6TzHePxpOWUiLHiiJ6TURBe4DpDxwtWU8Qnos22574QzLuaR/ZUzS9jrabcNcsJOYKMRPfcv0/zq8+407O9IJ4KmKjxqel1FQs3xYmcAO9NmauIM7LAvRdXsMHneD9Qzp2HmA7NLPCk5k0F26L1DwTr1di3ME1b2AEsRLYV63Ko8/GZ+5p2n2qv7sFB81UMwxosuDN3DvWonjmS9h2+/Gbm8lxaqKtzNdWdD8Gs1hb8KKLMNdiV3hiVVZKefeqat0c+0AC5LiD2uVIlalWVOKowQnRhoU2kPTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vl6oJi6gfIQ5qXahxJfk3MHamzsl+JNb31k3AZctj80=; b=ZTfbh7Bdff/ZlUz7cyXnCn/PSup1dvvab63tfG0CF5IyRcgaWJt/lsISuPrm1bX8nPwWGgGVU36YD5RnCNbJxazaptur8RNI6MfWiAYJMcNSXwyEDi6Cy3jaEArIJJy+ZzB4DjKkbA6JDIazD3sHu9I8QPKM+AteimDmqJEAEiE= Received: from SJ0PR11MB4862.namprd11.prod.outlook.com (2603:10b6:a03:2de::16) by BYAPR11MB3253.namprd11.prod.outlook.com (2603:10b6:a03:77::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Wed, 19 May 2021 01:46:18 +0000 Received: from SJ0PR11MB4862.namprd11.prod.outlook.com ([fe80::e0b4:32d9:d431:f642]) by SJ0PR11MB4862.namprd11.prod.outlook.com ([fe80::e0b4:32d9:d431:f642%4]) with mapi id 15.20.4129.032; Wed, 19 May 2021 01:46:18 +0000 From: "Dandan Bi" To: "devel@edk2.groups.io" , "xiewenyi2@huawei.com" , "Wang, Jian J" , "Wu, Hao A" , "Dong, Eric" CC: "songdongkuang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code Thread-Topic: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code Thread-Index: AQHXS7Zb+daGtt0s3UCU2ikUzD7wSKrqCfMw Date: Wed, 19 May 2021 01:46:18 +0000 Message-ID: References: <1621322219-109579-1-git-send-email-xiewenyi2@huawei.com> <1621322219-109579-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1621322219-109579-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dee0ac03-ab40-48ab-2851-08d91a67e59a x-ms-traffictypediagnostic: BYAPR11MB3253: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:370; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gWMHbXfw3ylPSvPTY/vcR7Bwex+EAL/ZdLP/c4XU3fuN7TtN7T2x7utRqDfmWWaJqn1CCwFOWlfK+VTlS5QrzyFCufbhcKgEDi3YpBjAEPRUavxNJcfz3yHRA1Pq5DQF7/4X4Ymklg16cu/ICfsc3PX1SEvWL8DcjB8zko1EJY3nMqkCV8iILDL7psnYAE7gTCOOQPq0IqhoFY6e1TnzaipTAIljkrlMNIiWV2sgqAk923WAuiQg0NaAdYM5I5TZcCANCeG2dCkGS9QRZoDnsEn0q1erP520XJX4+yR8sGcCIb6VuFcrYG/9xeGwrhN5Ne5SLUXnb8Qf50zaYHrxZj/XJwtuLB3TvUexiBbQn2vinN9I/92TCTZTWyZwqRI9Z/TpbEv+k2VKPt/UW/YWaetfHusWjGezFkGISbHqQNkYDpAB1awu9PVcs5mSfIqIT8jgiMKtZiQMcyWFWTSBDD0uvL9ycGYf/JT14YKw+b+xqUCwEbKmpj+P8GW+BzeECfXBwl39XxEGRcVmdBs0sdYO6vuuKooTcX10kxNBt4IxWoWCURyEkyHGfJBgCUJ7an092XsUJndAtKegwdMyhkMG8OannRvC5BUlMkpyFgy3U2dvPOkIYqpSjz52bSMAIXvQvQAzuPO/Q1cO5VBpFRqUtoZRXI0qAeO8O1sLMmvimzF9ilB29Ue+iL0mjcUli36jwuK232PvR8drWCL5ywyk6YE/VhFqfR7+sOBxXWI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4862.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(39860400002)(396003)(136003)(478600001)(2906002)(76116006)(122000001)(38100700002)(83380400001)(64756008)(66476007)(53546011)(55016002)(5660300002)(8676002)(6636002)(110136005)(86362001)(7696005)(4326008)(9686003)(66946007)(316002)(71200400001)(33656002)(66446008)(52536014)(66556008)(186003)(966005)(26005)(6506007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kORDW45+dv6Mq4NeZsd06+jn7aCWeEyrbKU6nKdoCdfW8ag4qox/+/EMMxCR?= =?us-ascii?Q?3bTSeJ/+DptUrjaUJglSTrQCrAdNSVWhS5bs5gttRSJLAB34w780aHX5Y4yh?= =?us-ascii?Q?rapSbHOvc3nH+ITU3X+WBi626WhcxUAtkwdE6x7yoeiDsxuijLGkmq2gX4/c?= =?us-ascii?Q?EJ0M6bnVxgg0JWKMOVatbY9J5Z6xT65c+UzAQpcULLkAfOzKqyqoNQenVYxo?= =?us-ascii?Q?9qC6aIcikmeFbP4qGS0k1FNvKpDzLb4Udojj/4FxqCzR80lhO391DhyQ6uL5?= =?us-ascii?Q?5MYSM7HT1jE66flimWlL4UJoaVmeu+qqTq3WH02l0nf5sJ13MFmi0Q475O65?= =?us-ascii?Q?k8UZtkfjQon0RObOlFhAC6B+x/9SRuGI494i2ruCYHJEmYohydPMLwMRQurH?= =?us-ascii?Q?4ML11RwFBxKhxi5ocTs248JuChLEIhRMdwtnK3nHVS1+UGtN/8b5hO/0Rrl1?= =?us-ascii?Q?3VfgvlxAa4xKiIjjmETwFIQQppJ7RxeUJQ3+HwZGMDLa+SUF9im8hTCtFfX1?= =?us-ascii?Q?8nBVlrY4Idl7Myz/pPxTY8CuB2DzVgoy45eQCAIkxnKLtIKihe4ZhlizB/u1?= =?us-ascii?Q?TKoog+50JLK2rUUErBURPqL1sgvXhTHGG8tLr5E+0ecT/poq/d4KTOYyH++o?= =?us-ascii?Q?1gJQBScpY6DYlDcE6KLvU39ILBP71i9SGGYyYMQTXK/BtRzyymbDFzj1HJa3?= =?us-ascii?Q?08nWzl/xnrqVsTj7XFHK4zyRlzd0SPiSEaBNVNqSNqDsDSUrWkO0jLWNK2NX?= =?us-ascii?Q?lu18UB1z50lzCDojCW8vh1c92qlOyqy4AQPN7bLqJE3/m7mOd6vHqCMQxg5R?= =?us-ascii?Q?06iwXYGe1IzuGnkULUKMnccu6bHmWdlStnU9lm8a/78PSoDSSoKwx5U892Qa?= =?us-ascii?Q?sg0RkRfEj50hP3eB9PFBzWFYpkYa2Zr3zQmYOaRaMYUX9yBp46Y4jG5mawn3?= =?us-ascii?Q?KQEZ4DzcW4tMXolwhf+HrNHfkRIwtRtib6pVX5RsR1e/uvxXeJ6n85FVWdWD?= =?us-ascii?Q?f7pHEfwl0VakgPETXuTAVlyncsMnwXsFYHL9Rrx67GCVtGzwjsc4SYBFyvr9?= =?us-ascii?Q?wy697rdBYKJurLWOJR4FU4O1+o4T+whr4x/nq1k7VsGCalYNvkbH61Lsbh1F?= =?us-ascii?Q?a6TLT03QE2ztE7T7d7yYaUuWWT0j1Y6kZ+ARpYMCkqC+SulSXJdrylPs5IvZ?= =?us-ascii?Q?kiGrtrYOY2XHWvKUrT5eBBnKnGY5twPZqVFtYj17QS4P307aAr8Su47JNeR5?= =?us-ascii?Q?zLPp9EWFf26bUCUka977JHsrYwmVh6NEkzXaGc84xPjbaDqzOH28s0pdwr2R?= =?us-ascii?Q?Iv4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4862.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dee0ac03-ab40-48ab-2851-08d91a67e59a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 01:46:18.4480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u3XBBoE3vqR0PT/yWfRoFspfP3KL0ubexLuLjtPu7Zj/VGpzEdQrJZEXYgkkpP7i0de8JQVlSn4qGJRH03HWUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3253 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > wenyi,xie via groups.io > Sent: Tuesday, May 18, 2021 3:17 PM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao = A > ; Bi, Dandan ; Dong, Eric > > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: > remove dead code >=20 > Outer condition is 'BlockData->Name=3D=3DNULL' and inner condition is > 'BlockData->Name!=3DNULL', Opposite 'if' > condition leads to a dead code block. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Eric Dong > Signed-off-by: Wenyi Xie > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > index d492b769d51c..17a914208c6d 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > @@ -2871,9 +2871,6 @@ ParseIfrData ( > // > if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset + Bloc= kData- > >Width) > VarStorageData->Size)) { > Status =3D EFI_INVALID_PARAMETER; > - if (BlockData->Name !=3D NULL) { > - FreePool (BlockData->Name); > - } > FreePool (BlockData); > goto Done; > } > -- > 2.20.1.windows.1 >=20 >=20 >=20 >=20 >=20