[PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe: remove dead code

[PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe: remove dead code

[wenyi,xie]

Main Changes :
Remove dead code.

Wenyi Xie (1):
  MdeModulePkg/HiiDatabaseDxe: remove dead code

 MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.20.1.windows.1

[PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code

[wenyi,xie]

Outer condition is 'BlockData->Name==NULL' and inner
condition is 'BlockData->Name!=NULL', Opposite 'if'
condition leads to a dead code block.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
index d492b769d51c..17a914208c6d 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
@@ -2871,9 +2871,6 @@ ParseIfrData (
         //
         if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData->Width) > VarStorageData->Size)) {
           Status = EFI_INVALID_PARAMETER;
-          if (BlockData->Name != NULL) {
-            FreePool (BlockData->Name);
-          }
           FreePool (BlockData);
           goto Done;
         }
-- 
2.20.1.windows.1

回复: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 wenyi,xie via
> groups.io
> 发送时间: 2021年5月18日 15:17
> 收件人: devel@edk2.groups.io; jian.j.wang@intel.com; hao.a.wu@intel.com;
> dandan.bi@intel.com; eric.dong@intel.com
> 抄送: songdongkuang@huawei.com; xiewenyi2@huawei.com
> 主题: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:
> remove dead code
> 
> Outer condition is 'BlockData->Name==NULL' and inner
> condition is 'BlockData->Name!=NULL', Opposite 'if'
> condition leads to a dead code block.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
>          //
>          if ((BlockData->Name == NULL) && ((BlockData->Offset +
> BlockData->Width) > VarStorageData->Size)) {
>            Status = EFI_INVALID_PARAMETER;
> -          if (BlockData->Name != NULL) {
> -            FreePool (BlockData->Name);
> -          }
>            FreePool (BlockData);
>            goto Done;
>          }
> --
> 2.20.1.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe: remove dead code

[Dandan Bi]

Reviewed-by: Dandan Bi <dandan.bi@intel.com>


Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> wenyi,xie via groups.io
> Sent: Tuesday, May 18, 2021 3:17 PM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:
> remove dead code
> 
> Outer condition is 'BlockData->Name==NULL' and inner condition is
> 'BlockData->Name!=NULL', Opposite 'if'
> condition leads to a dead code block.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
>          //
>          if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData-
> >Width) > VarStorageData->Size)) {
>            Status = EFI_INVALID_PARAMETER;
> -          if (BlockData->Name != NULL) {
> -            FreePool (BlockData->Name);
> -          }
>            FreePool (BlockData);
>            goto Done;
>          }
> --
> 2.20.1.windows.1
> 
> 
> 
> 
>