From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.34658.1628848552138053673 for ; Fri, 13 Aug 2021 02:55:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kx8yUt8i; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="301121596" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="301121596" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 02:55:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="485879594" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 13 Aug 2021 02:55:51 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 02:55:51 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 02:55:50 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 02:55:50 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 02:55:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNs+YpFXSPAOXiRgTPPZWNA/dgH71H+iSySLi6Qv3W+4u8c5IVTuZUt3Kb5sf/JP1Bk9JKs29wZ6iTV8Nh0oN09CdynvKfn/aVtEk1SmydbNWnJq6OzukQEwpCU8xa7bzh84ihz0P86e+dQOBOJ4cPOGYhU5jAz0IoddvpicyrG5pf1/oXuDBW6mvfHsxATrdSL4ixWgt94FVjqlkffA3fPLupk9dH6j2ozx1HNoCJBGIn3acKj46RULweTWVRIS0MKxxxNeW0C8uE47MEEjDjAk6874pWa9+57w40SZ8SQDpsslXd30VcqDg5tcY+mC+t7cQpWBZQCIeh/3BWNoLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=96VzhUr4J/eFXO0KPRpqPXWMEDWegfN8Iwfn6VYvjF4=; b=lQhkbFsUjuCm2QhjRN/cmyKLnGfpIQbo5/YzEmVss3Vq94sYkMdImiyC7gMTKDQ5HxQuePBKGr5Ch7seCTleyA6wI7d1JJerv8QuH9d1Agi04scdAyh4efUeb2HiHCrZFRskZ9CR4ymTInYls8K7PlVKdiNhUs5cm0GqwS8ScTTT63jNxahMdyPAU/Biw5+4SNmvnJq5QdbS9G7vSO5cCkS9jPw8o7y//sQZ02GPgmaiTOAUX0p0B4ZQluCQ/Pb1HLi/J9KYmDhzydeVb9q3YpplAa2mI8B+9Fja/od9K/UsaPpm8UYxAklN3xfOxlDMts+paelX3/Y9kvjvJLxIoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=96VzhUr4J/eFXO0KPRpqPXWMEDWegfN8Iwfn6VYvjF4=; b=kx8yUt8iUD/7Jpd9dhnrDYj5cnx2jhCqdOIqnu1naG99/hJ3AXBi+bT81BGEu75J44P4Nz/smK5mnXCp5KPeWoJOPKkDJgbdNGWsBpX/jP4/uJwGSx2RI8eucLn2LDkzFKKis/h7qM4tmGQGLq0hKZ23tWA5bplLKP5AN8zfrDM= Received: from SJ0PR11MB4894.namprd11.prod.outlook.com (2603:10b6:a03:2d4::5) by BYAPR11MB3701.namprd11.prod.outlook.com (2603:10b6:a03:fc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Fri, 13 Aug 2021 09:55:49 +0000 Received: from SJ0PR11MB4894.namprd11.prod.outlook.com ([fe80::d514:1b69:230:264c]) by SJ0PR11MB4894.namprd11.prod.outlook.com ([fe80::d514:1b69:230:264c%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 09:55:49 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "gary.lin@hpe.com" Subject: Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure Thread-Topic: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure Thread-Index: AQHXkApYEUEr+Zmap0mlkFAmBbJOIatxMQUg Date: Fri, 13 Aug 2021 09:55:48 +0000 Message-ID: References: <20210813061305.17519-1-gary.lin@hpe.com> In-Reply-To: <20210813061305.17519-1-gary.lin@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eafbb927-e695-4d4a-a449-08d95e40874a x-ms-traffictypediagnostic: BYAPR11MB3701: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +YG4mlJ21Eygpf/Sq63U1WPcAI6BnBsFyjvSrE24QWcVMBgSFrF+9cTn0Qg8n0WG+kzPhyModdC+FvnVb44/woS7/0Z45JIhOPC+wemmOQaKynLOIpty9QTIicYojUxJiom6bNoVhtU7jHuBpw47W13opg5oqvMmuw1Mfkpix34zQCtXRt7pU5rLCj64o8v5aznw5Uqzz0PMVuZLlv8oQwUxp+K1Fl/PZPs+fKaT9H2V/X2BUO8Gn6iKlrba7zYx4rn55FHiTVUF9KMcRtJtQvD7rzZjhy/SHtp4dCjELc5S7AK6SPMGgUgeoccAxXe72TMq0OBMwU5HIpLeKsLDUcB7emMwL5MqWhhLHxx2xayMrp6rIzMHXSxERjn/clusKtQmF21i6IH7icjO8umBTJRV1jaKcoIn3bhC+/WiO4UZiDpS0vtiReHthOwmP4b5dFIpmKYuCwblIai4Uyp2NAEABLIDGYApzx6kImsZw+UpVEULAOje3np4jg/13ebGqDz9qjlB3F4BGIs4AOXTqtEpFMiZJGwKufGPhtVY76csH9k7xCvjdG4v3V6vZU9PVE5VJRuKjr7Y6hlpSpXgCvk2ACKU4uxoxovNOyI/6mwEsM8R2ThIGhEOsFMtVPwVb/trwFsuPCKdfQOiyR2QeWEftR7yqfhFxYXNBngCgd0rvQg+3CHy9uLVPW7DY6CB1EcuF/qisJQYAjDeR3feaAGPJruRoiVvTV8tS32wK3VFq2Wc74H1ADhTtVO8kMVOxXjK+upAwYFoDXAfkrTHNUjMlsRafW3TAyNh9P5kn3pAp1g9DLWHfFAUby1iekUG7h/HV66TaJ6X5CgLG8QUCg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4894.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(366004)(136003)(376002)(66946007)(52536014)(86362001)(53546011)(478600001)(9686003)(66446008)(2906002)(33656002)(66556008)(66476007)(6506007)(64756008)(38070700005)(83380400001)(966005)(8676002)(38100700002)(110136005)(26005)(7696005)(76116006)(19627235002)(8936002)(316002)(186003)(122000001)(55016002)(71200400001)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1D1Y8TAy/+cxQMANNuZ0//01h8i8uuBnC1d0gBBu9+chMMYL5evCpzJQQGYZ?= =?us-ascii?Q?mOMZjlnYfmK4f6OnnfwbIIdq0FPeEMuYqdFDZh2T9CfPvt8RxJHWgFtk2K4/?= =?us-ascii?Q?mPaHzr6igtx7UI2+eQrpyXpdo6JWtvMXMOErjwahofWiTGXuiZK6hXS9BBPV?= =?us-ascii?Q?25HpvTGW3sPNe1eHrmZo4JVJUM5Ukz7HwOelD256bxcKx0SKtAJIqQWzddGr?= =?us-ascii?Q?24oaOBvjz4zAbqUX3XlIO64+c9H+rZjtIJZeOYIyY7DaZXI/CEzD6Sjr9S4K?= =?us-ascii?Q?WO2i2g8xA3LKKnslJBW65B6EN0P/ftolj8D0VpR8UtpmjdfStXuB/VejjAf7?= =?us-ascii?Q?vNpbhTR4D8bZ6uyy8NdbGUuqPdSwWmYf0xPRJkfQRUAJBU0ZTaowXp8XYfv8?= =?us-ascii?Q?thHt7wSuxOjw0svTY/VixgBfIy0qVZt88V07Mj5+j0BlUA6JwM6QjNbekZZT?= =?us-ascii?Q?Dex4kKPgKPLN9lwksNoN4AIDewbTVIMBnfWoUmQQvhcY/troNQaGNPYn7ENp?= =?us-ascii?Q?4ThW5/liBRDJeZYUCMfFMsoLcVMUm15/wYVZMOWwhoqRKFGn7/n+7aVeL6q3?= =?us-ascii?Q?oSrD5tBgxsHZix2Hy5vJykx0OKdzpti+DW8MElWqSBjyUamyRzwtY8DcL35x?= =?us-ascii?Q?go9YeISqBti/JD9tnz7YyRrdlyE55DAcJ6DRwO+Ta4tUgUDh+m+TaRGOSjc7?= =?us-ascii?Q?Pz9lQ+UCelMwbtmLkfCd2oD2TDH3BzbplKcnNTT8PLAje6WuUjWEPNwoLuvA?= =?us-ascii?Q?pjXSvp8lrO8jkxPbtcHFjHvtOH6NNw+gRaIGlQU0CQ+cTf82mB1U2AIlmZDX?= =?us-ascii?Q?/XsyGFX0K/rW3U6sB2fz+z9ZsUAt1wb3mXRN6N7hKUSmcYF8GZTOKgckOxiB?= =?us-ascii?Q?OGQbFKfnCm1DlYiwEHknfDwS8yboKBh93E7ht6qWqLjo0hnyK3UUtt/5Yyj0?= =?us-ascii?Q?VtcWehJoTATczEF5A2Dks9GXlX0Da+u8/SGGT749KfVvDAAigOX00WFnSI+U?= =?us-ascii?Q?AiCJWNPnQnetg4M4SycNaT0aJgGo4gXV4pcnfTrT/7UvOzuFonqvc6i4rdM4?= =?us-ascii?Q?KBFDBSinOdckKvz0S6VPDi9IXrrs1xeitaYujv0DUBDY/02OsX6rDqgdmCwx?= =?us-ascii?Q?SZnR37Vi1Vo/86KN41BV6SmSYfsnR3nsQy48k3beV98vQVpNWmth67HhUdMK?= =?us-ascii?Q?zFPPc6vbZi1GzaaROIXvs9uhKKAQLFl0QXXnIW+OAcQhm8ODnaWPVOTOffXR?= =?us-ascii?Q?3X50TiP1dCvDy5kqL6fTBDPR2oh2P5c252/fN2NIlagq6dDUnGDkK8bwkDRz?= =?us-ascii?Q?Ede6BTUtaQbfT9PktoDQanSS?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4894.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eafbb927-e695-4d4a-a449-08d95e40874a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2021 09:55:48.9244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NdEo6TEMaM6Ius9JtqEBc0TsA64XRYFsV/mWxknNJhlpFVHqfd2Exn/z3kfI/AH9gP8k0Xdkjzlu5MBmsRdkEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3701 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Gary Several comment: 1) According to our process, we need a Bugzilla. Would you please file it? 2) I do not understand how HVM direct kernel boot is related to S3 enabling= . It seems 1/3/4/5 are for S3, while 2 is for missing driver. Should we split them to 2 patch set? 3) Does the S3 issue only happen in direct kernel boot? Or is it a generic = issue. 4) Have you validated non direct kernel boot to ensure it still works? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lin, Gary > (HPS OE-Linux) > Sent: Friday, August 13, 2021 2:13 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot > failure >=20 > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. Besides, QemuKernelLoaderFsDxe wasn't included > in OvmfXen, so the firmware couldn't fetch kernel/initrd from fw_cfg. >=20 > This patch series initializes PcdAcpiS3Enable and adds > QemuKernelLoaderFsDxe into OvmfXen. Besides, QemuFwCfgS3Enabled() is > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > potential inconsistency. >=20 > v2: > - Amend the description and address "HVM Direct Kernel Boot" > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > - Remove unused QemuFwCfgLib > - Update my email address >=20 > Gary Lin (5): > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > support > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support >=20 > OvmfPkg/OvmfXen.dsc | 1 + > OvmfPkg/OvmfXen.fdf | 1 + > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > .../PlatformBootManagerLib.inf | 1 + > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > 10 files changed, 24 insertions(+), 9 deletions(-) >=20 > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20