public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] Define FIT 4 record
@ 2021-09-29  2:15 Holland, Michael
  2021-10-08 23:33 ` Chaganty, Rangasai V
  0 siblings, 1 reply; 2+ messages in thread
From: Holland, Michael @ 2021-09-29  2:15 UTC (permalink / raw)
  To: devel@edk2.groups.io; +Cc: Chaganty, Rangasai V, Ni, Ray


[-- Attachment #1.1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #1.2: Type: text/html, Size: 1451 bytes --]

[-- Attachment #2: 0001-IntelSiliconPkg-FirmwareInterfaceTable-Define-FIT-4-.patch --]
[-- Type: application/octet-stream, Size: 1270 bytes --]

From 068b2fc40fc0798a9cbe14884099d5e09bb83a56 Mon Sep 17 00:00:00 2001
From: Michael Holland <michael.holland@intel.com>
Date: Tue, 28 Sep 2021 21:05:58 -0500
Subject: [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record

Define FIT 4 record

Change-Id: I171f10194f4abab492932d9101f3c53db8f22c65
Signed-off-by: Michael Holland <michael.holland@intel.com>
---
 Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
index 3a8dd24d..f65779eb 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h
@@ -17,6 +17,7 @@
 #define FIT_TYPE_00_HEADER                  0x00
 #define FIT_TYPE_01_MICROCODE               0x01
 #define FIT_TYPE_02_STARTUP_ACM             0x02
+#define FIT_TYPE_04_PROT_BOOT_POLICY        0x04
 #define FIT_TYPE_07_BIOS_STARTUP_MODULE     0x07
 #define FIT_TYPE_08_TPM_POLICY              0x08
 #define FIT_TYPE_09_BIOS_POLICY             0x09
-- 
2.22.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Define FIT 4 record
  2021-09-29  2:15 [PATCH] Define FIT 4 record Holland, Michael
@ 2021-10-08 23:33 ` Chaganty, Rangasai V
  0 siblings, 0 replies; 2+ messages in thread
From: Chaganty, Rangasai V @ 2021-10-08 23:33 UTC (permalink / raw)
  To: Holland, Michael, devel@edk2.groups.io; +Cc: Ni, Ray

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

HI Michael,
The actual changes are fine.
A couple of comments on the patch format.

  *   It's good to include the repository and package name, in the subject line

[Repo Name: [Optional] Patch Version# #/total #] PackageName: <One line summary of the change>

  *   Commit message is missing the BugZilla reference.
  *   CC maintainers as part of the patch mail.
You can get more details on these guidelines here<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process>.

Regards,
Sai

From: Holland, Michael <michael.holland@intel.com>
Sent: Tuesday, September 28, 2021 7:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: [PATCH] Define FIT 4 record



[-- Attachment #2: Type: text/html, Size: 5547 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-08 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-29  2:15 [PATCH] Define FIT 4 record Holland, Michael
2021-10-08 23:33 ` Chaganty, Rangasai V

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox