From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2E1C5AC0967 for ; Fri, 24 Nov 2023 03:02:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XwV3WuzG0Qlk6pBCLogGVst/IKjRS1xSMhTLJ/DbFtU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700794945; v=1; b=b4Ryh4LPwHkdztTt7f0rbwrgYYVr9TyTY46noIlUedyc4GklnBCXy/Dau2dNAr9LtKo7Xc/d 5RXqQ3FE2TMBJUM7PnzQUCDH98Pv15N+cu63STXkbueuEHftmgyqfeV13Vm8t5F7saGoNdlN60t YK5d0h1vzq/bZ4hr42NjrrOg= X-Received: by 127.0.0.2 with SMTP id OimUYY7687511xWLkmFDtyKn; Thu, 23 Nov 2023 19:02:25 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.128591.1700794945375153273 for ; Thu, 23 Nov 2023 19:02:25 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="389512013" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="389512013" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 19:02:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="760824139" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="760824139" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Nov 2023 19:02:19 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 19:02:18 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 23 Nov 2023 19:02:18 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 23 Nov 2023 19:02:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aa8o/x9kekUfbRS9WwD0hAsfoQIn7jz5lvF7NAFTIC1nW9Yv30/nHlgVk1Vr/u9wta7U7zN1xbey7uz8QTxJ0ic8TFyp9I04On+8CxSnwrdgOGLKnU7LWlxLaI1cGT6zmaogY+JPf2HIdMxSdCL+U1SRu0qfdSdJ5iFOqfgvQxiR2UhB0YhRs/IrbKx20lIpqfzUaKzzkR9E40hT4ouT5UK/SpKh7OnqQAlzgD4NhGKk71T0ksGOUqlgS1wp9aHY+9n1JlwwTMnLunl+NLspA/FyCFDBvKvkiMHNIFwSanW4IyKkFwRCgV+6h+RiUeJwrQch/FoOiT4YiFRBkA4a7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7UWmbuKaXiyCVjPIOzY+2WXNKknbr+z/+Nxuyp/jOMU=; b=bGK6zpx2fYdddr7qvFzbF/vN2uky1QiMFttgB8qZSPyvEGXrgA8ARTLHZdm/Dh0KY+EBqWCalJ2mp+lu/edyjW01LIgAi6PKMk4knpxESqPvFmHI2gOn2hmBqMsA3Gv2NMXD7gAPimJ6DMz8peI9Z+3iIXGQIGMz5SVChUyVg85/irBqdm4gRVr4pEYJHMQUDQNxQdFHIDUqrnEUYPRgW7ZRGT/odBwm/3xpwFIxrsHTVfAEk907gPG+Kl5uJQz3btheX1jbkyxqcD0LcvjxrQMxlCVJjON2IMhod8hWkklj/brXeDzNQTD3VfCrEt7s4n3VcerUNoicTknZ3JavNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SJ0PR11MB5037.namprd11.prod.outlook.com (2603:10b6:a03:2ac::21) by LV3PR11MB8481.namprd11.prod.outlook.com (2603:10b6:408:1b7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Fri, 24 Nov 2023 03:02:17 +0000 X-Received: from SJ0PR11MB5037.namprd11.prod.outlook.com ([fe80::ec24:9b2b:7dab:8a2b]) by SJ0PR11MB5037.namprd11.prod.outlook.com ([fe80::ec24:9b2b:7dab:8a2b%7]) with mapi id 15.20.7025.020; Fri, 24 Nov 2023 03:02:16 +0000 From: "Yuanhao Xie" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky , "Laszlo Ersek" Subject: Re: [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function. Thread-Topic: [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function. Thread-Index: AQHaHQppIZ4Vnb4Y7EOyycNs9jRWdbCHHVeAgAGtJwA= Date: Fri, 24 Nov 2023 03:02:16 +0000 Message-ID: References: <20231122060834.3467-1-yuanhao.xie@intel.com> <20231122060834.3467-4-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5037:EE_|LV3PR11MB8481:EE_ x-ms-office365-filtering-correlation-id: 65404670-fbbb-4473-6226-08dbec99c43e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kxl9KJDVQgovsoEtfdjJ6pxgk/LTCpzehKaqKa0xlsAJq47t552YBeGoEl/Ei4AxLycwZ4Jw9AjqNqBuzXmOkmgQawdhz0d3kzmt7u1I3vAhspJIUaOAVbi3iFP0EqASir4trUDbFcVWQkDQ8tN6SZZtbya/dHXUcIefSDkiaLWax5XlXdOsJrbDfpqRIEWdeggeN4WleNyxAyyR3d9kYiZPgJ19Em0Jc6tlh6Epfvy+3zlAa2og/b2L28Je+Pxqhe655V1AYehLgmazHijB7Y/IlPyfcn0Td3dcHGanWwOKTkY6ZH/CYsklHUDlOpY7EoxlhJjGvp93Z8fb8QQ8oLQdG9MqCl/fPgzcVU7cNDlhqmTWcV4fAKWypPxo0EkX75JSJEiXKxDLpCYAgXIptFOxE2icrsH/pK0sW8O9ctgDa7CEZIr6VwGRDqjYtKSxx/SXFfRro76XMzaNwyB9JfhwzGSwGw9EpV/WgkURKjqD/bzTC253nlToYL5guykaNaTu9Nt7OP9PffVGiTAz5cfwPljZ9KUU3PQfrC2XIX/CRU/kBTH7wSRftIDS3diTcF17QGwH8+vZmxZI1k5nwF1jpmu03YfkpZ8R03XB3g6waQC89uZFjwYrM2PCGEy5 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6uXxD0kW4KsolU0Op8p6N72nXfJuoKIMNL4GpoBo61vjZ0+Mp/LXhcY6r/nf?= =?us-ascii?Q?mboOeY18OCQZMbEcSDYWrjY56z2qRbqUenVPakc0DQ/sOqJHt7dZGUZRISxj?= =?us-ascii?Q?VVZc3HJffLPnxssSDjgSEgieQSCBY8A0BNu+lfj7RWuITtWIpGEoCsCYXTjo?= =?us-ascii?Q?npr07dvPiV2amxqEL2LwvciaEyc4k7MBzQtjtvHuddhLDrI1KyOZRyEfqLAt?= =?us-ascii?Q?p9oKAl5ZBJJ6bZg+fZi6hJqykq5TCwRlrr/Bv2CTD9uPUmMuruWsKmD5A6Ka?= =?us-ascii?Q?mME3W7kz5hgU3yHTggfBdCvfPjtzdhKZ0FWW+mO+cpV3TZ02YA/u/NJ1I5t/?= =?us-ascii?Q?f9RXGyHVAEYtIlV1LBrXXZXQehg8Grkqk/n2NlMO6LrPeWKA8K4XyA7UvqI3?= =?us-ascii?Q?fO7Mw2HHOWhhmfepcY/uLOfExE8w4FRF1BHHl1DuDt6WUDtvQnBrhsa1ioWm?= =?us-ascii?Q?MenRb/GChm8JJTaLRBN/s64hVWefl2k1yESnP9NnryUGa7Nmvr29DqDF7vpP?= =?us-ascii?Q?8gSjpTBSL2FArABesf3hhY5i21fw3PrSz0+audGA1WcxBM7Gw/llfKfdRXkg?= =?us-ascii?Q?tbkGKmsEZgnE7DGfH39i6TCO/oTvrZvjfg8GwbCCKdFb+plgUIoSj5pzXjAs?= =?us-ascii?Q?L6tQt9K3EISHQ7LHK4+n/kdrIKLYpP2oIWPMoR+n4bBKOiPDrWE4eJJ8hj50?= =?us-ascii?Q?/OXplTp+c2NHzxvMlFOGZ/bOvqMdoT+xsAjiHVYvUVTeujMR1ecXcZJw4crj?= =?us-ascii?Q?4/r8DLLW7vRIV9+YB2z5voDHL8eMhAOxrSPlE1dFgIUqqnG57D9eRLURWRGM?= =?us-ascii?Q?c+ZB4sHjQNyQDov7qQzkrvJL3oKO+/pubngil8LrqZP8TBhJ1HIdc4mrDOId?= =?us-ascii?Q?EnNQIAa9mv6PhxXnU+W10giSp2zmXe+CFa/4t2U4oxtP0oXyKsosoDFAIQQt?= =?us-ascii?Q?NHnKz3OR7u0Jhx8saUY1wP/aiy6x71QBAR9fcF5YkY9X1RHaGhte9hkaKIPP?= =?us-ascii?Q?aK3LhL61wEnG9bRqj19taaT3TK2DSAlbw2HE6RyJirShZr/ZDDb49yhgZTvJ?= =?us-ascii?Q?QtPL1zFZpfC4UKAo8kf+fr4KkQ46vT+Z78iEQJ+Ez2EbYe63+kthIrgPqhv+?= =?us-ascii?Q?J8RmmUOPA+QLgFcQQeXZQs69SmuRZ2cuBLLZlEnyrgqespKNP4JssRsyjtPp?= =?us-ascii?Q?5FDiCKK2KQxHQU2AGU9Iy6gbFvGkKuN4YvwL/ZqpJTfZsE+uSTJo5DR5/pB3?= =?us-ascii?Q?8SxGTe/oNQbDoqjLfRE5MLMuFMj1oN8w0XJCdl3M52fA9GlbZ+J9tRcrjDMH?= =?us-ascii?Q?UM0BgHPU4sZcz1TBfURQypbyFJXUhBd31VM3LYBus8QRDIKG0LDlHa90eY3F?= =?us-ascii?Q?UNeQ39NCbmOySEgGaH/wqYBpTLAhu1y0U81+MTPXZlmBtPUWzxHbCwaS+Cs4?= =?us-ascii?Q?5gMI/8l5TqxuiYLo2wsbS2THNFek3ZHGEUhCzyf++xuAilQ+VVfCb8gQGna2?= =?us-ascii?Q?b+W9Do6zw2J5kOCLR0zo9AleR8uyWKI9fFeFz/zbS9h1xbyl3JdLn0HZ9ES8?= =?us-ascii?Q?4DpC3fxIzchxzacsdDrLHEHxmyi+aM+IDU3sL20P?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5037.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65404670-fbbb-4473-6226-08dbec99c43e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2023 03:02:16.9315 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1VwWBbHn7RYO3KdvjzUcECjNVDukRlZLBphx7XEOfsxjDS6E5jiXJeA3AWj86J9XWEntJUbD3P2XmmXUycJxIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8481 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sbglkzQfiqdAb54RbvGUET3xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=b4Ryh4LP; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, In v4, DEBUG_CODE_BEGIN/END() from DumpMicrocodeRevision() is removed, and = calling is updated as: DEBUG_CODE ( DumpMicrocodeRevision (); ); Thanks a lot for the feedback! Regards, Yunahao -----Original Message----- From: Ni, Ray =20 Sent: Thursday, November 23, 2023 9:24 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Tom Lendacky ; Laszlo Ersek Subject: RE: [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Re= vision as function. > VOID > -ShadowMicrocodeUpdatePatch ( > - IN OUT CPU_MP_DATA *CpuMpData > +DumpMicrocodeRevision ( > + IN CPU_MP_DATA *CpuMpData > ) > { > - EFI_STATUS Status; > + UINT32 ThreadId; > + UINT32 ExpectedMicrocodeRevision; > + CPU_INFO_IN_HOB *CpuInfoInHob; > + UINTN Index; When DEBUG_CODE is disabled, above local variable declarations will cause b= uild failure as the compiler only sees the local variable declarations but = cannot see any code that references them. So, can you remove DEBUG_CODE_BEGIN/END() from DumpMicrocodeRevision()? Instead, you call it using following way: DEBUG_CODE ( DumpMicrocodeRevision (); ); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111691): https://edk2.groups.io/g/devel/message/111691 Mute This Topic: https://groups.io/mt/102744601/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-